Commit graph

15916 commits

Author SHA1 Message Date
Martin
d30492a222 tech(clean): better naming 2022-08-23 13:28:10 +02:00
Martin
45e0c15eb0 feat(PurgeManagerAdministrateurSessionsJob): also purge instructeur assign_tos 2022-08-23 13:28:10 +02:00
Martin
dc524cf615 fix(spec): broken spec due to TDD and refacto on former code 2022-08-23 13:28:10 +02:00
Martin
711b2ee2e4 feat(ExportComponent): only render it when connected instructeur/administrateur is not from manager 2022-08-23 13:28:10 +02:00
Martin
25c0e91d87 feat(Administrateurs::GroupeInstructeur): ensure admin from super admin can not add an instructeur 2022-08-23 13:28:10 +02:00
Martin
d1544bc4ae feat(Administrateurs::ProcedureAdministrateurs): ensure admin from super admin can not add administrateur 2022-08-23 13:28:10 +02:00
Martin
d1297bc1f5 tech(rubocopify): ... just clean up ... 2022-08-23 13:28:10 +02:00
Martin
5e8210b8f8 feat(Administrateur::ExportsController#*): prevent SuperAdmin to ask/download export 2022-08-23 13:28:10 +02:00
Martin
bfd0f3379f feat(Instructeur::ArchivesController#*): prevent SuperAdmin to index/download archives 2022-08-23 13:28:10 +02:00
Martin
c2e0994e11 feat(Administrateur::ArchivesController#*): prevent SuperAdmin to index/download archives 2022-08-23 13:28:10 +02:00
Martin
ef67958324 feat(manager): add #add_administrateur_with_confirmation and #confirm_add_administrateur so SuperAdmin requires another SuperAdmin approval to add an administrator to a procedure. Add #add_administrateur_and_instructeur for SuperAdmin willing to be administrateur/instructeur for 24 2022-08-23 13:28:10 +02:00
Martin
f0a4cbb61e feat(assign_tos): add manager column to assign_tos table. Same idea as administrateur_procedures.manager which flag a link between procedure/administrateur coming from a SuperAdmin [target: able to avoid SuperAdmin sec issues] 2022-08-23 13:28:10 +02:00
mfo
33000466a5
Merge pull request #7687 from mfo/US/fix-conditionnal-in-section
fix(conditional): within section (dark blue bg) ; use white text
2022-08-23 09:55:03 +02:00
Martin
4c302c9c0e fix(i18n.conditionnal): add missing operators Logic::NotEq key 2022-08-23 09:27:46 +02:00
Martin
ed20951f14 fix(conditional): within section (dark blue bg) ; use white text 2022-08-23 09:23:42 +02:00
mfo
73b417e6b2
Merge pull request #7684 from mfo/US/remove-unused-column
fix(migration): following e764aade13 …we still need to remove those columns otherwise destroying a procedure fails due to index on types_de_champ.revision_id
2022-08-22 16:40:25 +02:00
Martin
b9e7bdc01e fix(migration): following e764aade13 ; we still need to remove those columns otherwise destroying a procedure fails due to index on types_de_champ.revision_id 2022-08-22 16:00:56 +02:00
LeSim
15e623fd3d
Merge pull request #7674 from betagouv/fix_pj_template
fix(editeur_de_champ): permet d'ajouter à nouveau un template au pjs
2022-08-11 16:08:00 +02:00
simon lehericey
adf194cc08 fix(editeur_de_champ): can join an pj template 2022-08-11 15:01:48 +02:00
simon lehericey
6b5f38ce74 spec 2022-08-11 14:03:04 +02:00
Kara Diaby
4bddb4dde9
Merge pull request #7672 from betagouv/feat/7668
Manager : permet au super admin de se retirer d'une démarche
2022-08-11 12:30:46 +02:00
Kara Diaby
58f2f6bd9d Manager : permet au super admin de se retirer d'une démarche 2022-08-11 10:58:58 +02:00
LeSim
354248c88a
Merge pull request #7670 from betagouv/add_is_not_eq
feat(conditional): ajoute l'operateur "n'est pas égal" s'appliquant à un choix parmis une liste
2022-08-10 12:05:10 +02:00
simon lehericey
650c36e3e2 feat(conditional): add not eq operator 2022-08-10 11:59:09 +02:00
LeSim
3eb440b9da
Merge pull request #7669 from betagouv/fix_hidden_required_in_conditionnel
fix(conditionnel): corrige les champs obligatoires mais cachés
2022-08-09 14:43:12 +02:00
simon lehericey
00d0813292 ensure the mandatory star hint is always displayed 2022-08-09 10:29:41 +02:00
simon lehericey
898badb579 a champ is mandatory when visible with a mandatory tdc 2022-08-09 10:25:47 +02:00
simon lehericey
ec40836589 spec 2022-08-08 18:02:28 +02:00
simon lehericey
0b90c81c3a wrap existing spec in specific context 2022-08-08 18:02:28 +02:00
krichtof
f77a6cfc14
Merge pull request #7666 from betagouv/7665-pdf-for-close-demarche
Can get dossier vide if procedure is closed
2022-08-07 18:43:23 +02:00
Christophe Robillard
e087582f57 Can get dossier vide if procedure is closed 2022-08-05 16:00:08 +02:00
Paul Chavard
29e3b3f831
Merge pull request #7653 from tchak/feat-other-with-condition
feat(champ): can condition on other option
2022-08-04 16:35:44 +02:00
Paul Chavard
a24885c2ee feat(champ): can condition on other option 2022-08-04 15:28:54 +02:00
Paul Chavard
a53688ce23
Merge pull request #7662 from tchak/fix-mandatory-conditions
fix(conditional): mandatory champs inside hidden repetition should not be validated
2022-08-04 15:27:21 +02:00
Paul Chavard
bbca7344e5 fix(conditional): mandatory champs inside hidden repetition should not be validated 2022-08-04 14:48:40 +02:00
Paul Chavard
8e8d8d4f55
Merge pull request #7660 from tchak/use-new-factory
refactor(spec): use new procedure.types_de_champ factory
2022-08-04 14:41:31 +02:00
Paul Chavard
65e96002b1 refactor(spec): raise if old style factory is used 2022-08-04 12:10:32 +02:00
Paul Chavard
2d7803cd48 refactor(spec): use new procedure.types_de_champ factory 2022-08-04 12:10:32 +02:00
Paul Chavard
5e890cdb36 fix(factory): fix options handling on drop_down_list 2022-08-04 11:37:56 +02:00
Paul Chavard
21637da8ab
Merge pull request #7659 from betagouv/fix-random-tests
Fix random tests errors
2022-08-04 10:01:22 +02:00
Colin Darie
adced0f33a fix(revision): fix stable siblings order when there are multiple identical position
Ça arrive parfois dans les tests, et potentiellement en prod :
après avoir créé un nouveau `revision_type_de_champ`,
on se retrouve très momentanément avec 2
RTDC ayant le même position en attendant le renumérotation peu près.

https://github.com/betagouv/demarches-simplifiees.fr/blob/main/app/models/procedure_revision.rb#L55

Ceci conduisait à une renumérotation erronnée quand la db renvoyait
le nouveau RTDC créé *avant* les précédents.
2022-08-03 18:29:48 +02:00
Colin Darie
1601a18c34
test(combobox): increase wait time because component may be slow to render
Fix erreur type 'Unable to find css "li[role=\"option\"]'

Ce problème peut-être reproduit en local, en diminuant le wait à 0.001 ;
avec une plus grande valuer il disparaît.
2022-08-03 16:15:40 +02:00
Colin Darie
9ebcbbbd67
test(brouillon_spec): fix random errors due to db champs not yet updated 2022-08-03 16:15:40 +02:00
Colin Darie
e8b088c2c5
test(brouillon_spec): remove unecessary manual sleep, improve "brouillon" feedback testing 2022-08-03 16:15:39 +02:00
Colin Darie
81a9258c8a
test(brouillon_spec): use capybara wait matchers 2022-08-03 16:15:39 +02:00
Colin Darie
983815bfe8
test(brouillon_spec): fix frequent dossier_link error by using an existing dossier 2022-08-03 16:15:39 +02:00
Colin Darie
9e9b429100
test: fix frequent too many open files with webmock & capybara 2022-08-03 16:15:39 +02:00
Colin Darie
3ce699eef3
chore(bundle): updata capybara 3.35.3 => 3.37.1 + capybara-screenshot 2022-08-03 16:15:38 +02:00
Paul Chavard
18a2419b96
Merge pull request #7658 from tchak/update-dependencies
chore(npm): update dependencies
2022-08-03 14:49:04 +02:00
Paul Chavard
7024c4c551 chore(npm): update dependencies 2022-08-03 14:31:42 +02:00