Commit graph

17182 commits

Author SHA1 Message Date
Pierre de La Morinerie
71e1b6c973 models: delete AdministrateursProcedure when destroying Administrateur
By default, `has_and_belongs_to_many` properly deletes the record in
the join table.

However, as the association is declared manually with a
`has_many / through`, it doesn't delete the joined record automatically.

As we also lack a foreign-key contraint on the join table, that means
a dangling record remains in the join table.

To fix this, let's declare it a proper `has_and_belongs_to_many`
association, which will let the join record be deleted automatically
on destroy.
2022-03-01 16:58:04 +01:00
Paul Chavard
9bd1d128d4
Merge pull request #6987 from tchak/fix-map-spec
fix(carto): show map UI before loading map styles
2022-03-01 11:13:32 +00:00
Paul Chavard
2a42690388 fix(carto): show map UI before loading map styles 2022-03-01 11:08:07 +00:00
Pierre de La Morinerie
022fb04e2b
Merge pull request #6993 from betagouv/dependabot/bundler/nokogiri-1.13.3 2022-03-01 11:33:14 +01:00
simon lehericey
30a7fb25a7 update nokogiri 2022-03-01 10:01:33 +01:00
mfo
8aa8c4a9de
Merge pull request #6991 from betagouv/main
2022-02-28-01
2022-02-28 15:21:34 +01:00
mfo
b7da406fe4
Merge pull request #6990 from betagouv/US/fix-avis
fix(avis_controller#*): missing ACL
2022-02-28 15:12:53 +01:00
mfo
4346775169
Merge branch 'main' into US/fix-avis 2022-02-28 15:08:25 +01:00
Martin
48612028f4 fix(avis_controller#*): missing ACL 2022-02-28 14:24:41 +01:00
mfo
43f8bbfb11
Merge pull request #6913 from betagouv/US/redirect-after-dossier-submitted
Possibilité de rediriger l'usager vers un site externe après dépôt de son dossier
2022-02-25 14:05:27 +01:00
Martin
b808b4db00 fix(relation): avoid double association between procedure/procedure_revision/dossier_submitted_message 2022-02-25 14:01:18 +01:00
Martin
35b9487897 feat(data.integrity): add foreign key to prevent orphan data 2022-02-25 14:01:18 +01:00
Martin
567d01478e fix(brakeman): prune absolete and ad a new one [surprise] 2022-02-25 14:01:18 +01:00
Martin
85a588541b feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap
wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook

refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers

refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook.

feat(wip): current progress
2022-02-25 14:01:18 +01:00
LeSim
7c45589ae6
Merge pull request #6986 from betagouv/fc-agent-2
Relooking agent connect v2
2022-02-25 10:42:48 +01:00
simon lehericey
83d2e44cd7 do not show connect button on agentconnect page 2022-02-24 12:23:12 +01:00
simon lehericey
0d74a6e45e compact display to show agentconnect to small screen 2022-02-24 12:23:12 +01:00
simon lehericey
28005db9aa do not show left column on small screen 2022-02-24 12:23:12 +01:00
simon lehericey
7883b08a5e apply new style to agent connect 2022-02-24 12:23:12 +01:00
Paul Chavard
a92c4c39b3
Merge pull request #6959 from tchak/chore-pin-node
[RFC] chore(node): use volta
2022-02-24 09:54:33 +01:00
Paul Chavard
c3fa55b9f4 chore(node): add yarn clean to help with webpacker caching issues 2022-02-24 08:48:27 +00:00
Paul Chavard
9bd0373aaa chore(node): add .node-version file 2022-02-24 08:48:27 +00:00
Paul Chavard
ffcff87103
Merge pull request #6985 from tchak/fix-eslint
Javascript : correction des avertissements ESLint
2022-02-24 09:48:01 +01:00
Paul Chavard
8ee6bdfac0 chore(eslint): make @typescript-eslint/no-explicit-any an error 2022-02-23 15:28:52 +01:00
Paul Chavard
7c8e97f084 chore(eslint): ignore type of global react-query queryFn 2022-02-23 15:28:51 +01:00
Paul Chavard
cd2273ba54 chore(eslint): ignore any types in maplibre styles 2022-02-23 15:28:51 +01:00
Paul Chavard
67bfeb261a chore(eslint): fix gon types 2022-02-23 15:28:51 +01:00
Paul Chavard
12ddaa0533 chore(eslint): disable types because we use mapbox plugin with maplibre 2022-02-23 15:28:51 +01:00
Paul Chavard
96e9024694 chore(eslint): disable types on complicated event handlers 2022-02-23 15:28:51 +01:00
Paul Chavard
4e218ba562 chore(eslint): fix react-query cancelable promise type 2022-02-23 15:28:51 +01:00
Paul Chavard
a914950982 chore(eslint): fix getJSON reponse type 2022-02-23 15:28:51 +01:00
Paul Chavard
beafa21796 chore(eslint): fix isNumeric types 2022-02-23 15:28:51 +01:00
Paul Chavard
95b9e47993 chore(eslint): fix flash message root element query 2022-02-23 15:28:51 +01:00
Paul Chavard
68e89af775 chore(eslint): make react-hooks/exhaustive-deps rule as an error 2022-02-23 15:28:51 +01:00
Pierre de La Morinerie
c6425cd1a6
Merge pull request #6984 from betagouv/fix-api-entreprise-error
Affichage d'un message clair en cas d'erreur `APIEntreprise::API::Error::ServiceUnavailable`
2022-02-23 14:58:02 +01:00
Pierre de La Morinerie
a2028e115b controllers: fix crash on APIEntreprise::API::Error::TimedOut
In that case we want to display the nicely formatted error message to the
user, instead of a "Error 500" page.
2022-02-23 11:36:25 +01:00
Pierre de La Morinerie
56c2e57aee controllers: fix crash on APIEntreprise::API::Error::ServiceUnavailable
In that case we want to display the nicely formatted error message to the
user, instead of a "Error 500" page.
2022-02-23 11:31:41 +01:00
Pierre de La Morinerie
70fe0b2fd4
Merge pull request #6983 from betagouv/csp-in-tests
Blocage des connexions vers des services externes pendant les tests
2022-02-23 09:03:18 +01:00
Pierre de La Morinerie
3481d27cba config: block browser external connections during system tests
During system tests, we don't want the headless browser to load
external resources:

- It is faster (we don't wait for external resources to be loaded)
- It avoids leaking our test setup to external service

Fixes #6982
2022-02-22 17:24:25 +01:00
Pierre de La Morinerie
6d5f44d489 config: translate the CSP comments from french to english 2022-02-22 17:17:55 +01:00
Pierre de La Morinerie
a5c1800b67
Merge pull request #6979 from betagouv/restore-older-after-party-tasks
Restauration des anciennes tâches after_party supprimée du code
2022-02-22 16:35:29 +01:00
Pierre de La Morinerie
30d7cf634a tasks: restore older after_party tasks
Turns out deleting the tasks after 6 months only may not be enough for instances deploying
only once a year, for instance.

This reverts commit 77b65f3aa0.
2022-02-22 15:39:16 +01:00
Pierre de La Morinerie
e79ea23bf2
Merge pull request #6975 from betagouv/remove-hardcoded-gem-version
Dépendances : suppression des mentions de commits spécifiques pour les gems
2022-02-22 11:37:05 +01:00
Pierre de La Morinerie
4cde3623be gems: remove hardcoded git URL for mina
It is not needed anymore.
2022-02-22 09:27:57 +01:00
Pierre de La Morinerie
e6ad411aae gems: remove hardcoded version for zipline
The fix was eventually released.
2022-02-22 09:27:57 +01:00
Pierre de La Morinerie
d29e02d6c5
Merge pull request #6978 from betagouv/update_to_rails_6_1_4_6
Mise à jour de Rails vers la version 6.1.4.6
2022-02-22 09:23:46 +01:00
simon lehericey
6930ddb433 bump rails 2022-02-22 09:19:08 +01:00
Pierre de La Morinerie
8e5e325ccc
Merge pull request #6816 from kreushed/france-connect-update
Intégration des maquettes AgentConnect
2022-02-22 08:35:44 +01:00
kreushed
1c5b1c0030 Mise a jour du volet gauche de la page session new 2022-02-21 18:21:38 +01:00
kreushed
167cb100b6 Mise a jour du volet droit de la page session new 2022-02-21 18:21:38 +01:00