Commit graph

1973 commits

Author SHA1 Message Date
Christophe Robillard
20d0585e31 rend plus actionnable message d'erreur 2023-07-19 18:16:04 +02:00
Eric Leroy-Terquem
e8e9857dda style(reaffectation): apply dsfr to buttons 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
0e58e10b82 refactor(DossierAssignment): move create_assignment to assign_to_groupe_instructeur 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
96d17d03ec feat(DossierAssignment): create assignments when admin reaffect all dossiers 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
082db0ed02 feat(DossierAssignment): create Assignment when admin reaffect dossiers 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
f619fdfb19 feat(DossierAssignment): add reaffectations to presonnes impliquees view 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
ac2043e920 feat(DossierAssignment): create assignment when manual assignment by instructeur 2023-07-18 16:54:00 +02:00
Martin
ce9dbed663 amelioration(NotificationMailer): sort la creation des commentaire sur la messagerie du mailer [trop de prob possible sinon: au retry on dupliquait les commenaitres, si le mail foirait, on commentait pas etc...] 2023-07-11 15:11:40 +02:00
Colin Darie
6ce8428ac6
feat(sva): instructeur can flag a dossier as incomplete 2023-07-11 10:01:48 +02:00
Colin Darie
30df476791
fix(sva): ensure "en construction" + "en instruction" notifications when submitting at submission
Pour le moment on conserve les 2 emails car l'email en construction
contient des informations spécifiques :
- l'attestation de dépôt
- potentiellement un contenu spécifique car il provient d'un template

Même remarque pour les démarches déclaratives.
2023-07-11 10:01:47 +02:00
Colin Darie
afe373c6b4
feat(sva): transition to en_instruction when (re-)submitting a dossier 2023-07-11 10:01:46 +02:00
Eric Leroy-Terquem
f959450477
Merge pull request #9244 from demarches-simplifiees/refactor-routing-update
Tech : mise à jour du routage sans callback
2023-07-04 09:39:00 +00:00
Eric Leroy-Terquem
0c3426228f feat(routing): to_configure include invalid_rule and non_unic_rule 2023-07-04 10:04:35 +02:00
Eric Leroy-Terquem
7598b0a513 remove previous routing sytem code 2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
a2c636d784 fix(tests): create groupe instructeurs with factory 2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
d6fea4ed95 refactor(routing): toggle routing when custom routing 2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
520050933e refactor(routing): toggle routing when simple routing 2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
97949fc168 fix(typo) adresse électronique 2023-06-28 10:24:37 +02:00
Eric Leroy-Terquem
3f55c71bc8
Merge pull request #8658 from E-L-T/notify-instructeur-when-added-or-removed-from-api
feat(API): notify instructeurs when added or removed from procedure
2023-06-26 09:37:15 +00:00
Paul Chavard
e509ff1717 fix(dossier): do not send notifcations to deleted users 2023-06-21 09:52:38 +01:00
Eric Leroy-Terquem
18054fe346 feat(routing): add view for dossier a reaffecter 2023-06-15 14:34:02 +02:00
Eric Leroy-Terquem
e7e702a574 feat(routing): add reaffecter_un_dossier 2023-06-15 14:34:01 +02:00
Paul Chavard
c1afc985e4 fix(prefill): allow private annotations prefill 2023-06-15 10:07:25 +01:00
Paul Chavard
10524643fb fix(hack): fix and test hack for procedures using groupe instructeur api 2023-06-14 19:24:58 +01:00
Colin Darie
f675d2d1a7
Merge pull request #9196 from colinux/fix-admin-publication-errors
ETQ admin je veux voir les erreurs lorsque la (re-)publication échoue
2023-06-14 09:56:46 +00:00
Paul Chavard
b3aeb46c1b fix(prefill): it should be possible to prefill a dossier on a test procedure 2023-06-14 09:14:12 +01:00
Colin Darie
889940af2a fix(administrateur): renders errors when publication fails 2023-06-13 19:11:59 +02:00
Eric Leroy-Terquem
0164b5f008 fix tests after typos corrections 2023-06-12 15:13:25 +02:00
simon lehericey
44859b8217 fix(user dossiers index): do not crash with a deleted dossier and a discarded procedure 2023-06-12 13:57:28 +02:00
Paul Chavard
c4432b1b47 perf(carto): use json schema to validate geojson instead of rgeo 2023-06-06 15:43:56 +02:00
Colin Darie
52c8553576
fix(dossier_correction): don't allow to save with a missing (invalid) commentaire 2023-06-02 16:18:33 +02:00
Colin Darie
734d88d80d
fix(pending-correction): wording alignement 2023-06-02 16:16:14 +02:00
Colin Darie
a32014d4fd
feat(correction): user can mark dossier en_construction as resolved 2023-06-02 16:16:14 +02:00
Colin Darie
8839ac7f76
fix(instructeur): pending_correction flag does not make messagerie unseen 2023-06-02 16:16:14 +02:00
Colin Darie
5ab44fc7a9
chore: rename dossier_resolution => dossier_correction 2023-06-02 16:16:14 +02:00
Colin Darie
9565267170
feat(dossier): notify user by email about pending corrections 2023-06-02 16:16:13 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections" 2023-06-02 16:16:12 +02:00
mfo
c2f2b4ef2a
Merge pull request #9106 from mfo/api-entreprise.etablissement_adapter
API Entreprise: migration "Etablissement"
2023-06-01 11:45:47 +00:00
mfo
1a6dc10548
Merge pull request #9102 from demarches-simplifiees/8472-migrate-rna
API Entreprise: migration RNA (associations)
2023-06-01 11:37:57 +00:00
Martin
c90175f121 tech(api-entreprise.etablissement): passage du endpoint ETABLISSEMENT_RESOURCE_NAME en v3 2023-06-01 09:06:36 +02:00
Martin
0d3deb01be tech(rna_controller#show): corrige les specs et recupère uniquement les informations utilisé par l'app 2023-05-31 16:11:12 +02:00
Eric Leroy-Terquem
50abf496fd add warning in gi pages in rule does not match tdc 2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
6e88c49470 remove old logic test 2023-05-31 11:38:16 +02:00
simon lehericey
97aac5d588 update tests for rules based routing 2023-05-31 11:38:16 +02:00
simon lehericey
142ac9173d add groupes_search_component 2023-05-31 11:38:16 +02:00
Christophe Robillard
ba281d53cf migrate entreprise adapter to v3 2023-05-26 13:37:20 +02:00
Paul Chavard
c06a4113b3 fix(graphql): gracefully handle change state errors 2023-05-24 12:04:04 +02:00
Paul Chavard
bca08c8e6c feat(graphql): expose user connection type 2023-05-23 18:18:21 +02:00
Martin
0213ad018a bug(expert/avis#index): ETQ expert, je veux retrouver mes avis donnés sur des dossiers traités 2023-05-23 09:34:30 +02:00
Martin
af19bbe8f5 correctif(users/dossiers/brouillon#submit): ETQ usager, je souhaite que chaque lien pointant vers une erreur de champ m'oriente sur le champ 2023-05-20 08:27:55 +02:00
Paul Chavard
a2e98f9065
Merge pull request #9051 from demarches-simplifiees/fix-bug-procedure-clone-validations
[fix] Vider les champs invalides pour permettre de cloner une procedure
2023-05-17 07:44:39 +00:00
Lisa Durand
7e39e8113b feedback PR Colin 2023-05-16 17:54:37 +02:00
Lisa Durand
f2cf3188d7 empty invalid fields to allow clone procedure 2023-05-16 10:59:17 +02:00
Colin Darie
493e8dc9de
Merge pull request #9036 from colinux/fix-fork-ui
ETQ Usager: correctifs pour les modifications en construction
2023-05-15 11:38:01 +00:00
Colin Darie
059dabb5ac fix(fork): don't fail when user submit twice en_construction (from 2 tabs) 2023-05-15 13:08:42 +02:00
simon lehericey
35866cf860 fix graphql_stored_queries_spec 2023-05-11 16:56:56 +02:00
Colin Darie
b626714610
fix(dossier): submit en_construction render views in error with dossier origin 2023-05-09 18:49:53 +02:00
Paul Chavard
08a2a2c9aa
feat(dossier): fork dossier when editing en construction 2023-05-09 17:16:47 +02:00
mfo
2374ced5d2
Merge pull request #8987 from mfo/US/link-to-errored-champs
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-09 07:06:36 +00:00
Colin Darie
ae88c1de6b
fix(devise): default config for devise and turbo stream as navigational format 2023-05-03 11:35:32 +02:00
Colin Darie
61ebb27e86
fix(redirect): allow other hosts when required 2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux
7e0fbcf672
fix: ensure procedure used in remove_instructeur spec has routing_enabled set to true 2023-05-03 11:35:29 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Paul Chavard
99abdf45e7 fix(api-entreprise): use new status endpoint 2023-04-27 22:39:44 +02:00
Paul Chavard
cb752d1857 fix(dossier): do not bypass depositaire check on modifier path 2023-04-27 09:52:10 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Martin
6a2d2ae0a7 bug(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question 2023-04-26 07:46:21 +02:00
Lisa Durand
26ff82dbe4 Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier 2023-04-25 13:01:40 +02:00
Martin
6739bfc665 bug(instructeurs.annotations): ETQ instructeurs, lorsque je saisie une autre valeur dans un champ de type choix simple, celle ci n'est pas sauvegardé 2023-04-21 09:35:16 +02:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
418d3b55d0 feat(stats): give access to stats on closed procedures 2023-04-19 18:31:58 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem
aecd7559d2 feat(groupe instructeur): cannot disable default groupe instructeur 2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab feat(groupe instructeur): cannot delete defaut_groupe_instructeur 2023-04-19 13:52:42 +02:00
simon lehericey
b38470368b feat(routing): can change defaut groupe 2023-04-19 13:52:41 +02:00
Colin Darie
999f06075b
chore(rubocop): fix Rails/ResponseParsedBody 2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops 2023-04-19 12:55:13 +02:00
Paul Chavard
05cfb4055d fix(dossier): improuve dossier state display 2023-04-19 12:27:16 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
Paul Chavard
ae1ec87397 feat(graphql): add code to timeout errors 2023-04-18 15:22:11 +02:00
Paul Chavard
f70532a844 feat(graphql): global not found error handling 2023-04-18 15:22:11 +02:00
Paul Chavard
fbae6d941d feat(graphql): add error codes to graphql errors 2023-04-18 15:22:11 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
Paul Chavard
bf6cc25063 feat(graphql): expose pendingDeletedDossiers on groupe instructeur 2023-04-17 18:43:00 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
5abb6a8f12 chore(spec): remove memory store cache from tests 2023-04-13 13:10:23 +02:00
simon lehericey
c02319aa56 feat(routing): reset value if target as changed 2023-04-13 10:28:53 +02:00
simon lehericey
8b832396a3 feat(routing): server side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa feat(routing): server side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00
krichtof
78938b5a07 filter demarches by siret service 2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94 add alert on user dashboard to edit last editable dossier 2023-04-11 15:50:17 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
a2f7d1df72 fix(graphql): pendingDeletedSince should not crash 2023-04-06 15:07:48 +02:00
Paul Chavard
a5733002ed feat(graphql): improuve logs 2023-04-05 13:56:26 +02:00
Paul Chavard
52c8b0b297 feat(dossier): use turbo to select linked dossier 2023-04-05 11:40:03 +02:00
Paul Chavard
dee0952b2a fix(graphql): demandeur personne morale can be in degraded mode 2023-04-05 11:20:18 +02:00
Paul Chavard
a778e1083b fix(graphql): return better errors when dossiers cannot change state 2023-04-04 17:24:30 +02:00
Paul Chavard
2a48228552 fix(dossier): improuve commune champ rendering in pdf 2023-04-04 16:01:16 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
Paul Chavard
0864666d0a fix(dossier): an invited user can remove (leave) a dossier 2023-04-03 20:10:44 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
simon lehericey
b93e3776c4 feat(routing): add controller 2023-03-30 10:51:20 +02:00
mfo
60d41029de
Merge pull request #8817 from mfo/US/fix-expert-export
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-29 12:00:14 +00:00
Martin
c6e9674de2 correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis 2023-03-28 17:16:34 +02:00
Martin
4f9c45c489 bug(export.pdf): ETQ expert, lorsque j'exporte un dossier, celui ci devrait contenir les avis non confidentiels ainsi que mes avis 2023-03-28 16:55:12 +02:00
Kara Diaby
4a13c64b38 tests 2023-03-27 14:14:18 +02:00
Lisa Durand
d079f3ac98
Merge pull request #8770 from demarches-simplifiees/ask-question-in-avis-ux-part
[UX] améliorer UX de la demande d'avis
2023-03-24 10:50:33 +00:00
Paul Chavard
275150d727 feat(graphql): expose pendingDeletedDossiers
fix #8785
2023-03-22 19:40:43 +01:00
Lisa Durand
4a2982dc37 fix tests and linter 2023-03-22 09:30:26 +01:00
Colin Darie
954652fcf5
fix(champ): may fix pg deadlocks: autosave already saves value at the same time 2023-03-20 14:32:14 +01:00
Lisa Durand
ee2f795dec pr feedbacks - add validation for yes/no answer - improve locales use 2023-03-16 11:32:05 +01:00
Lisa Durand
eddd7a2192 add flash alert if email field empty 2023-03-16 11:32:05 +01:00
Lisa Durand
01afa998b6 add specs 2023-03-16 11:32:05 +01:00
Paul Chavard
8ee13f1719 feat(api_token): add allowed_procedure_ids and write_access 2023-03-15 19:09:49 +01:00
Paul Chavard
cbaa77fca7 feat(annotations): activate autosave 2023-03-14 15:22:13 +01:00
Lisa Durand
6ba47b731b refacto destroy action and add spec for unauthorized user 2023-03-09 14:58:47 +01:00
Lisa Durand
3d5bf40c0f allow transfer sender to revoke a transfer 2023-03-09 14:57:59 +01:00
Eric Leroy-Terquem
72b6dacfbd fix(API): remove notification to group when instructeurs removed 2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
a150aa33ef feat(GroupeInstructeurSupprimerInstructeurs): add notification for removed instructeurs via API 2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
ac0d7a67a1 feat(GroupeInstructeurAjouterInstructeurs): add notification for added instructeurs via API 2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
b2f3a7af4c feat(GroupeInstructeurSupprimerInstructeurs): enable emailing for unrouted procedures 2023-03-08 11:59:55 +01:00
Eric Leroy-Terquem
9e0753a710 fix(groupe instructeur mailer): do not notify if no added instructeurs 2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem
f317f28ff5 test(groupe instructeurs): use right data (a routed procedure has at
least two active groups)
2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
e1906febcc feat(groupe instructeur): can enable routing from import 2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
9f0f5b0dc5 feat(groupe instructeur): allow import of many groups when procedure is not routed yet 2023-03-08 10:48:02 +01:00
Kara Diaby
4ea7bb2f1c tests 2023-03-03 11:50:47 +01:00
Damien Le Thiec
687c05e6d1
Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue
Dossier prefill get without stored queries
2023-03-02 14:01:04 +00:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
2023-03-02 13:28:23 +00:00
Damien Le Thiec
8a7cb3f1fe
Merge branch 'main' into fix/stored_query_issue 2023-03-01 10:22:40 +01:00
Damien Le Thiec
01f142183e Add and correct tests 2023-03-01 10:21:22 +01:00
Paul Chavard
d8ee4cb360 fix(test): dossiers_controller_spec 2023-02-28 17:28:17 +01:00
Paul Chavard
294a5135ce feat(public/api): add dossier state api 2023-02-28 16:35:25 +01:00
Colin Darie
7e13d58db2
Merge pull request #8703 from govpf/feature/fix-dossier-controller-spec
Fix dossier controller spec
2023-02-28 12:11:30 +00:00
krichtof
dee499d386
Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones
liste toutes les démarches, même celles non associées à des zones
2023-02-28 10:58:07 +00:00
Paul Chavard
7076d6d99e fix(turbo): rerender only top part of the header 2023-02-27 16:06:11 +01:00
sebastiencarceles
39545671f3 refacto: better error management 2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2 don't clean the rna champ value
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.

Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Lisa Durand
636e6aa6cb fix broken tabs with turbostream 2023-02-27 14:30:10 +01:00
sebastiencarceles
becf4da70a fix raison social fetch 2023-02-27 13:54:35 +01:00
sebastiencarceles
30eef3e128 review: detailled error message 2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542 don't clean the siret champ value
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
Prefill repeatable
2023-02-27 09:58:53 +00:00
Christian Lautier
704dbf94db Fix dossier controller spec 2023-02-25 08:32:21 -10:00
Lisa Durand
6487e2c27e implement turbostream back for state change in dossier view 2023-02-24 17:54:53 +01:00
Christophe Robillard
1d6c2fd7eb display procedures without zones 2023-02-24 17:27:28 +01:00
Eric Leroy-Terquem
4ea1d7d33b feat(groupe instructeurs import): notify added instructeurs 2023-02-23 10:56:55 +01:00
Eric Leroy-Terquem
a6e01d98ea feat(instructeurs import): notify added instructeurs 2023-02-23 10:56:55 +01:00
Damien Le Thiec
731cd56594 Merge branch 'main' into feature/prefill_repetible 2023-02-22 19:49:06 +01:00
Damien Le Thiec
fbe4fe251a Fix format prefill repetition 2023-02-22 19:32:25 +01:00
Lisa Durand
fddcce8b7b fix specs 2023-02-22 18:17:06 +01:00