Commit graph

1644 commits

Author SHA1 Message Date
gregoirenovel
75ee41b7fa [Fix #2494] Improve deletion warning text 2018-08-31 15:41:51 +02:00
Frederic Merizen
559d080ca6 [#1946] Show data retention time in footer 2018-08-30 18:03:01 +02:00
Paul Chavard
4866f9724a Add support controller send_form tests 2018-08-30 15:16:35 +01:00
Paul Chavard
8e88f2c27f Cleanup support controller tests 2018-08-30 15:12:50 +01:00
Paul Chavard
ea5248dde1 Flatten tags list, cast to array and remove blank elements 2018-08-30 15:12:50 +01:00
Frederic Merizen
37c45f0d29 [#2486] Always order champs
to help activerecord cache the champs collection
2018-08-30 14:13:32 +02:00
gregoirenovel
e60aa0c37b Use scopes when possible 2018-08-30 13:16:14 +02:00
gregoirenovel
3662b82039 accompagnateur → instructeur 2018-08-29 23:09:08 +02:00
Frederic Merizen
580c6145d0 Migrate nutriscore dossiers from old procedure to new procedure 2018-08-29 19:40:02 +02:00
gregoirenovel
4b071ecf06 Use enum to the fullest with Dossier.states 2018-08-29 17:31:08 +02:00
gregoirenovel
ee25bba38c Use enum to the fullest with Service.type_organismes 2018-08-29 17:31:08 +02:00
gregoirenovel
2d3b553e4d Use enum to the fullest with TypeDeChamp.type_champs 2018-08-29 17:31:08 +02:00
gregoirenovel
16a719922b Use enum to the fullest with User.loged_in_with_france_connects 2018-08-29 17:31:08 +02:00
gregoirenovel
606b56033a Use enum to the fullest with VirusScan.statuses 2018-08-29 17:31:08 +02:00
Paul Chavard
509613afe6 Use contact_link helper instead of mailto 2018-08-29 16:08:01 +01:00
gregoirenovel
0ac160c824 Remove the now useless stats API 2018-08-29 14:54:49 +02:00
Paul Chavard
bad107ffae Add contact form 2018-08-29 10:44:12 +01:00
Paul Chavard
6453b53a41 Add helpscout API adapter 2018-08-29 10:43:00 +01:00
gregoirenovel
6b1ab9b552 Remove a now useless facade 2018-08-28 15:38:39 +02:00
gregoirenovel
cccad7dbdf Remove a now useless method 2018-08-28 15:19:54 +02:00
gregoirenovel
19789b6848 Remove the stats part of the procedure info page for admins
- the numbers are wrong (:termine state does not
  exist)
- the chart does not work
2018-08-28 15:19:31 +02:00
gregoirenovel
9f3650b12f Remove 2 months old call for suggestions 2018-08-28 10:11:09 +02:00
gregoirenovel
d6748bde20 Update a factory so that it uses rating instead of mark 2018-08-27 17:12:01 +02:00
gregoirenovel
3d7b239f2b Improve the feedback form question 2018-08-27 14:16:20 +02:00
Paul Chavard
9abb3c7a5a [ENV] Pipedrive key config 2018-08-23 15:55:32 +02:00
Mathieu Magnin
db8e750f1a [ENV] Configure Api Entreprise token 2018-08-23 15:55:32 +02:00
Frederic Merizen
cef0eafb1a [#2179] Tolerate spurious spaces around search terms 2018-08-23 11:57:06 +02:00
Frederic Merizen
7643459a55 [#2179] Reuse search spec for search service 2018-08-23 11:57:06 +02:00
Frederic Merizen
3b2919a326 [#2179] Use new updated value for search terms
Rather than old in-database value
2018-08-23 10:34:25 +02:00
Paul Chavard
097b06e314 Fix test dossier page 2018-08-14 16:47:31 +02:00
Paul Chavard
b57c22cafe Refactor publish dialog 2018-08-14 16:39:11 +02:00
Pierre de La Morinerie
af95e56b50 dossier: add a page with the form 2018-08-14 15:25:27 +02:00
Pierre de La Morinerie
86539413ee gestionnaire: move dossier partials to a shared location 2018-08-14 15:06:44 +02:00
Pierre de La Morinerie
c286e5fa41 specs: improve dossier details tests 2018-08-14 15:06:44 +02:00
Pierre de La Morinerie
242f9d0af7 specs: fix order-dependant tests in spec/models/gestionnaire_spec.rb
Test run that would fail randomly before:

```
bin/rspec --seed 10002 spec/models/dossier_spec.rb spec/models/gestionnaire_spec.rb
```
2018-08-14 11:48:54 +02:00
Paul Chavard
7237ff80cc Drop procedure dossiers when updating brouillon 2018-08-14 11:21:05 +02:00
Paul Chavard
9de3e6e74b Make info extraction method more safe 2018-08-13 18:32:00 +02:00
Paul Chavard
a6a4790a35 Replace logstasher with lograge 2018-08-13 12:44:00 +02:00
Pierre de La Morinerie
1b7950058d dossier: add details résumé 2018-08-13 11:32:27 +02:00
Pierre de La Morinerie
18d13d76d8 dossier: add details header 2018-08-13 11:32:27 +02:00
simon lehericey
b33f11115c [fix #2358] Checkbox: serialize in attestation by oui or no 2018-08-10 16:25:34 +02:00
lucien mollard
9ecc5f7928 add a user satisfaction form' 2018-08-09 11:41:26 +02:00
Pierre de La Morinerie
5e01be0f15 mailer: add direct link to dossier in creation email
Fix #2341
2018-08-08 15:24:17 +02:00
simon lehericey
9c023095da [fix #2359] Fix link in avis mail for gestionnaire 2018-08-08 13:19:54 +02:00
Pierre de La Morinerie
77eb89cb0f dossier: add a stub page for the new dossier details 2018-08-08 11:49:15 +02:00
Pierre de La Morinerie
0ac28da207 dossier: make Dossiers#show a stub redirecting to the correct location 2018-08-08 11:49:15 +02:00
Paul Chavard
8b79c32a55 Do not rely on javascript for form submits without direct upload 2018-08-07 16:58:49 +02:00
Paul Chavard
a0979b1d57 Fix logstasher custom fields 2018-08-07 16:26:44 +02:00
Pierre de La Morinerie
93ba063612 specs: improve reliability of procedure creation features
The 'etape_suivante' button is sometimes not activated, and it could
be because the event handler on the checkbox sometimes doesn't run.
2018-08-07 14:28:52 +02:00
Pierre de La Morinerie
cc15b0bb28 specs: make checkbox click cleaner 2018-08-07 14:28:52 +02:00
Pierre de La Morinerie
9ec5befa09 specs: increase Capybara default timeout
Because CircleCI machines are slow, and tests sometimes timeout.
2018-08-07 14:28:52 +02:00
Paul Chavard
c91abe73c5 Remove old user dossier form 2018-08-07 14:13:27 +02:00
Pierre de La Morinerie
c8409ecb89 dossier: remove route hack for show 2018-08-07 12:15:38 +02:00
Paul Chavard
46e75ac8ef Only notify on dossier supression if dossier is en_construction 2018-08-02 17:07:24 +02:00
Pierre de La Morinerie
1ca2ca9121 invite: support remote forms
This allows to keep the draft content when inviting a new user.
2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
1cac0b80af invite: add button for invite someone to collaborate on a draft 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
9541e781bb invite: rename 'email' to 'invite_email' 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
a386a0ffb2 specs: add spec for DossierController#forbid_invite_submission! 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
bdd05937e2 specs: refactor invites_controller_spec.rb 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
2a3ce61dd9 specs: move list_dossiers from user to new_user 2018-08-01 17:41:11 +02:00
Pierre de La Morinerie
dee4acd802 dossier_facade: remplace followers by an equivalent implementation 2018-08-01 17:41:11 +02:00
Pierre de La Morinerie
8d9b65e556 specs: wait for ajax requests completion where required 2018-08-01 11:01:46 +02:00
Pierre de La Morinerie
270384f8dd specs: remove redundant line 2018-08-01 11:01:26 +02:00
Pierre de La Morinerie
8af86fb110 specs: move config line where it makes more sense 2018-08-01 11:00:17 +02:00
Pierre de La Morinerie
45d9de0995 spec: remove useless comment 2018-08-01 10:59:54 +02:00
Paul Chavard
e358e72867 Do not display gestionnaire emails in the messaging interface
fix #2302
2018-07-31 15:27:36 +02:00
Pierre de La Morinerie
56e3a56bad specs: fix application_job_spec 2018-07-30 11:03:16 +02:00
Pierre de La Morinerie
1eb110ac7c specs: fix random seed being always the same when using Spring 2018-07-30 11:03:16 +02:00
Frederic Merizen
0e639030f9 [#2179] Generate denormalized search terms value for Dossier 2018-07-27 11:11:52 +02:00
Mathieu Magnin
84937e3d43 Fix Sentry error 2755 2018-07-26 17:38:19 +02:00
Paul Chavard
bf7c023380 Add webpacker and use it for new_design 2018-07-25 15:14:06 +02:00
gregoirenovel
abbd4e3c69 [Fix #2277] Do not crash when creating a service with invalid data 2018-07-25 14:22:44 +02:00
Pierre de La Morinerie
13182ad291 dossier: send deletion email also to the following gestionnaires 2018-07-25 13:49:55 +02:00
Pierre de La Morinerie
6daa31d410 spec: add tests for Dossier#delete_and_keep_track 2018-07-25 13:49:55 +02:00
Pierre de La Morinerie
0f1811dd4e dossier: add an button to delete a brouillon 2018-07-24 18:31:10 +02:00
gregoirenovel
eb95fce194 [Fix #2272] Add a SIRET field to the Service form 2018-07-19 15:43:13 +02:00
gregoirenovel
ed436bfe77 [Fix #2260] Add a search field in the usager UI 2018-07-17 17:26:42 +02:00
gregoirenovel
4d41381155 Move the attestation route inside the member block 2018-07-17 17:26:42 +02:00
Pierre de La Morinerie
40aae2e20b mailers: mention the procedure when notifying about dossier deletion 2018-07-16 15:49:34 +02:00
Pierre de La Morinerie
d6624aeca7 mailers: add tests for dossier_mailer 2018-07-16 15:38:03 +02:00
simon lehericey
0e8a1f1678 [fix #2241] GestionnaireDossierController: allow linked drop down value in update 2018-07-12 14:11:42 +02:00
Pierre de La Morinerie
0282994990 form: move the procedure notice link to a button 2018-07-11 17:13:18 +02:00
Pierre de La Morinerie
defee1d2d5 tests: refactor modifier.html.haml_spec.rb to use "subject" 2018-07-11 17:12:35 +02:00
Pierre de La Morinerie
f5d3adba5e dossiers: remove unused dossiers list code
This code is unused since the user dossiers list uses the new UI.
2018-07-04 12:23:49 +02:00
Pierre de La Morinerie
33c743ab77 helper: simplify DossierHelper.url_for_dossier
The argument is never an Invite
2018-07-04 11:43:39 +02:00
Pierre de La Morinerie
394019b70c specs: save a screenshot of failing integration tests 2018-07-04 09:43:22 +02:00
Pierre de La Morinerie
b0a9e49549 procedures: group new_from_existing list by organization
As procedures are not grouped by Service (which are unique to an
administrator) but by organization, this allows procedures with the same
organization name to be displayed together.
2018-07-03 23:43:42 +02:00
Pierre de La Morinerie
56987e5147 procedures: add tests for new_from_existing 2018-07-03 23:43:41 +02:00
Pierre de La Morinerie
d1301762d4 pipedrive: fix deals when no deals are returned 2018-07-02 17:07:24 +02:00
Pierre de La Morinerie
b4b533f0c5 dossiers: change all links to use the new user dossiers list 2018-07-02 13:58:58 +02:00
Pierre de La Morinerie
148dc164f7 dossiers: generate the correct link to see the dossier details 2018-07-02 13:58:58 +02:00
Pierre de La Morinerie
f2ee88b278 dossiers: put last updated dossiers first 2018-07-02 13:58:58 +02:00
Pierre de La Morinerie
d70f01a6b2 form: cleanup dossier feature spec 2018-07-02 12:30:27 +02:00
Mathieu Magnin
e694e7f9b9 [Fix #2145] When procedure is archived, usager should see a message explaining dossier submission is closed 2018-07-02 11:10:34 +02:00
Mathieu Magnin
9afbd16bbf [Fix #2145] When procedure is archived, usager should not be able to submit a dossier 2018-07-02 11:10:33 +02:00
Frederic Merizen
b003fe9221 [Fix #2176] Allow setting page size in API 2018-06-29 17:34:35 +02:00
Frederic Merizen
b326cb9c3e [#1421] Handle mandatory fields 2018-06-28 20:06:32 +02:00
Frederic Merizen
e794515c8e [#1421] Format linked dropdown menus in spreadsheet export 2018-06-28 20:06:32 +02:00
Frederic Merizen
04892f6c55 [#1421] Format value for display 2018-06-28 20:06:32 +02:00
Paul Chavard
d0a6957862 Remove old cerfa code 2018-06-28 15:16:20 +02:00
Pierre de La Morinerie
0cebf60c46 [#1421] replace master/slave by primary/secondary 2018-06-27 17:02:46 +02:00
Frederic Merizen
dad3bc092b [#1421] linked dropdwon user view 2018-06-27 17:02:46 +02:00
Frederic Merizen
7b1e8c2110 [#1421] Extract values for both drop down lists 2018-06-27 17:02:46 +02:00
Frederic Merizen
2214fc6b86 [#1421] Extract contents of both drop down lists 2018-06-27 17:02:46 +02:00
Pierre de La Morinerie
d77530b6a6 dossiers: move link back to the old ui 2018-06-27 11:37:06 +02:00
Pierre de La Morinerie
9f70e72d83 dossiers: add a button to start a new demarche 2018-06-26 18:13:52 +02:00
Pierre de La Morinerie
8c36c8d26f dossiers: add an empty state 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
06de1d6cee dossiers: link individual dossiers to the old UI 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
f242c73974 dossiers: make link in the header point to the new UI 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
b9c8a1ffbe dossiers: simpler display when there are not invited dossiers 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
663c39ea11 specs: improve speed of dossiers specs (12s -> 6s) 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
51e256e122 header: fix link to the contact email 2018-06-25 11:26:45 +02:00
Frederic Merizen
15e8d8af05 [#1421] Add linked dropown fields 2018-06-21 16:19:20 +02:00
Mathieu Magnin
4f93354107
Merge branch 'dev' into fix-rake-specs 2018-06-21 11:44:02 +02:00
simon lehericey
c3610fc96e [fix #2067] Resend confirmation mail if the user is not confirmed 2018-06-20 13:30:32 +02:00
Pierre de La Morinerie
9f502c536b spec: only load tasks once
When a task is loaded several times, a single call of `task.invoke`
will run the task several times too.

This made `add_annotion_privee_to_procedure_spec` fail when it wasn't
the first task being tested.
2018-06-20 11:35:20 +02:00
Pierre de La Morinerie
c4057a0807 dossier: display user infos on edit page 2018-06-19 16:27:53 +02:00
Pierre de La Morinerie
60475d0165 factories: add parenthesis around method arguments 2018-06-19 16:01:35 +02:00
Frederic Merizen
0239f936d7 [#1421] Move departements to DepartementChamp 2018-06-19 15:20:01 +02:00
Frederic Merizen
5b59bce0b6 [#1421] Move regions to RegionChamp 2018-06-19 15:20:01 +02:00
Frederic Merizen
521aec6af9 [#1568] Remove old previsualisation code 2018-06-19 12:42:46 +02:00
Frederic Merizen
fd10310cbf [Fix #1568] Use new procedure preview 2018-06-19 12:42:46 +02:00
Mathieu Magnin
e05fb2d0ae Allow dossier deletion if instruction has not started 2018-06-19 10:05:00 +02:00
Pierre de La Morinerie
790704ef58 tasks: silence output of tasks during tests
Currently, when running specs, the output of rake tasks is spamming
the tests results.

This PR configures Rake so that it runs in quiet mode during specs. This
disables the internal messages of rake during tests.

However our own `puts` also need to be conditionned to the verbosity of
rake. Using a simple `rake_puts` helper allows the info messages to be
displayed when running the rake task manually, but not during tests.

Before:

```
$ bin/rspec spec/lib/rake
Randomized with seed 6544
1 Mails::ClosedMail to clean
cleaning Mails::ClosedMail #1
1 Mails::InitiatedMail to clean
cleaning Mails::InitiatedMail #1
1 Mails::ReceivedMail to clean
cleaning Mails::ReceivedMail #1
1 Mails::RefusedMail to clean
cleaning Mails::RefusedMail #1
1 Mails::WithoutContinuationMail to clean
cleaning Mails::WithoutContinuationMail #1
.....Champ 0/1
.Champ 0/1
.
```

After:

```
$ bin/rspec spec/lib/rake

Randomized with seed 6544
.......
```
2018-06-13 11:05:15 +02:00
Mathieu Magnin
cd4615b10d When a new PJ is uploaded enqueue a anti virus scan job 2018-06-12 15:12:39 +02:00
Frederic Merizen
3ba0dd1620 [#2071] Fix test now that mails are multipart 2018-06-10 11:53:51 +02:00
simon lehericey
e11392981d [fix #2072] DossierController: check the user can update the dossier 2018-06-08 16:24:29 +02:00
gregoirenovel
24e37842ee Fix a typo 2018-06-08 15:14:22 +02:00
gregoirenovel
b88cea3c18 Change a deliver into a deliver_later 2018-06-07 15:14:26 +02:00
Frederic Merizen
65e9025d5d Add at least minimal test for AdministrationMailer 2018-06-06 16:08:18 +02:00
Frederic Merizen
695f5b2705 Fix class methods on BizDev module
and add missing tests
2018-06-06 16:07:29 +02:00
gregoirenovel
41e8350cbe [Fix #1735] Sign the admin account creation email 2018-06-01 20:48:50 +02:00
Frederic Merizen
52bb40ab20 [#1946] Show retention times in procedure administration summary 2018-06-01 17:35:04 +02:00
gregoirenovel
b82ed65568 [Fix #885] Convert .text.erb to .html.haml 2018-06-01 17:14:48 +02:00
Frederic Merizen
346687bd33 [#1946] Once durees de conservation have been set, forbid unsetting them 2018-06-01 16:46:39 +02:00
Frederic Merizen
42765efb91 [#1946] Add validation to durees conservation 2018-06-01 16:46:39 +02:00
Frederic Merizen
648483ac76 [#1946] Allow admins to edit data retention time 2018-06-01 16:46:39 +02:00
Frederic Merizen
5325830d62 [#1946] Extract test helper method 2018-06-01 16:46:39 +02:00
gregoirenovel
4f2509861b Improve the wording of the avis email 2018-06-01 15:42:56 +02:00
Frederic Merizen
c39a58749f Remove duplicate translations
There is a default translation for `blank` already
2018-06-01 15:21:25 +02:00
gregoirenovel
b364b8bfb3 Improve many subjects 2018-06-01 11:35:40 +02:00
simon lehericey
c72421fb9e Procedure: Once deliberation or cadre_juridique have been set, forbid unsetting them 2018-06-01 11:12:53 +02:00
simon lehericey
1f0e46a4ff Procedure: required juridique stuff only if needed 2018-06-01 11:12:53 +02:00
gregoirenovel
185f08f63e Add constants for email addresses 2018-06-01 00:00:11 +02:00
simon lehericey
18ad227df5 [fix #1897] Procedure: can delete a deliberation 2018-05-31 16:56:28 +02:00
simon lehericey
0e690c90cc Procedure: clone the deliberation 2018-05-31 16:56:28 +02:00
simon lehericey
fa14db1cbf Procedure: add deliberation 2018-05-31 16:56:28 +02:00
simon lehericey
a96889310b Procedure: add legal reference 2018-05-31 16:55:31 +02:00
gregoirenovel
0329b1db68 Use User#owns_or_invite? instead of Dossier#owner_or_invite? 2018-05-31 14:39:43 +02:00
gregoirenovel
4e9565a5df Adds User#owns? 2018-05-31 14:39:43 +02:00