DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
20324 commits 250 branches 1166 tags 78 MiB
Commit graph

148 commits

Author SHA1 Message Date
simon lehericey
3f0fd506bd fix(system spec): increase timeout for log out 2022-09-29 17:31:38 +02:00
Martin
96cdae0dd5 feat(DSFR.header): switch to DSFR header 2022-09-06 10:09:12 +02:00
Colin Darie
1601a18c34
test(combobox): increase wait time because component may be slow to render 
Fix erreur type 'Unable to find css "li[role=\"option\"]'

Ce problème peut-être reproduit en local, en diminuant le wait à 0.001 ;
avec une plus grande valuer il disparaît.
 2022-08-03 16:15:40 +02:00
Colin Darie
9e9b429100
test: fix frequent too many open files with webmock & capybara 2022-08-03 16:15:39 +02:00
François Vantomme
2032eb8144
Test (Capybara): add no-sandbox option to headless chrome driver 
Activating this option fix the 'DevToolsActivePort file doesn't exist'
error.

https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t
 2022-02-04 17:34:10 +01:00
Paul Chavard
7e81b257b1 test(system): simplify select menu selector 2022-01-13 17:49:16 +01:00
Paul Chavard
cb66348916 a11y(select): cleanup select helpers in specs 2022-01-05 12:33:40 +01:00
Paul Chavard
968384952a a11y(capybara): enable use of aria-label in spec 2022-01-05 12:33:40 +01:00
Pierre de La Morinerie
8b3d31980a specs: use Instructeur.bypass_email_login_token in the tests 2021-12-02 08:51:52 +01:00
Martin
b6adf5fc72 feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states 
fix(spec): broken due to last refactoring

spec(dossier.extend_conservation): add system spec

lint(ruby): still not yet ready for auto lint in IDE...
 2021-11-23 05:50:25 +01:00
Paul Chavard
ba0211ba52 feat(champ): ask for departement before asking for commune 2021-11-04 11:55:25 +01:00
Pierre de La Morinerie
9fd38cae5e specs: migrate from features to system specs 
System specs have been available since Rails 5.1, and are better
integrated with the Rails framework.

- Rename `spec/features` to `spec/system`
- Rename `feature do` to `describe do`
- Configure Capybara for system specs

Steps mostly taken from https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6
 2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
df9fa258ae specs: remove database_cleaner 
This is not needed for integration tests since Rails 5.1.

See https://www.nicholasjacques.io/blog/you-probably-dont-need-databasecleaner/
 2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
b1eee27dd7 specs: remove outdated workaround for silencing puma logs 2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
7b6420d427 specs: set i18n cookie before running browser specs 
Otherwise the browser specs use the dault browser language, which may
be English depending on the system language.
 2021-10-19 16:41:36 +02:00
simon lehericey
cd7bafaa0d clean log_out spec helper 2021-10-12 14:27:20 +02:00
simon lehericey
ecc26897e2 add end to end spec 2021-10-12 14:27:20 +02:00
Pierre de La Morinerie
407f46b7de gems: remove smart_listing 
It was only used in the old design, which we recently removed
completely.
 2021-09-09 09:58:41 -05:00
Pierre de La Morinerie
80f9d4adc0 devise: use password_strength component in SuperAdmin::PasswordsController 2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
e1909ed29f brouillon: redirect to sign-in when disconnected 
There are two cases where the draft auto-save might fail because the
user is no longer authenticated:

- The user signed-out in another tab,
- The brower quit and re-opened, so the Session cookie expired.

In both cases, the auto-save will never succeed until the user
authenticates again, so displaying a "Retry" button is cruel.

Moreover, in plus of all auto-save requests failing with a small error,
the actual hard failure only occurs after filling all the form and
trying to submit it. Then the user is redirected to the sign-in page –
but all their changes are lost.

Instead, we now redirect to the sign-in page on the first 401 error
during the auto-save, let the user sign-in, and then redirect back to
the form.
 2021-07-22 11:58:02 +02:00
Pierre de La Morinerie
684af77e35 jobs: extract an RetryOnTranscientErrors concern 2021-04-29 14:08:12 +02:00
Paul Chavard
85b907807a Improuve ComboMultipleDropdownList style 2021-04-28 12:54:45 +02:00
Pierre de La Morinerie
be58d82016 specs: clear jobs queue before each test 
This avoids `perform_enqueued_jobs` to execute jobs from the previous
tests.
 2021-03-16 11:49:14 +01:00
Pierre de La Morinerie
f9401cfbad spec: better split spec_helper and rails_helper 
This fixes the

> DEPRECATION WARNING: Initialization autoloaded the constants ActionText::ContentHelper and ActionText::TagHelper.

error appearing when running specs.

It also gets us closer from a newly-generated rails config.
 2021-03-04 22:59:39 +01:00
Pierre de La Morinerie
98be7e2076 Fix new Rubocop warnings 2021-02-16 16:31:30 +00:00
Christophe Robillard
b8097e782a rend accessible la selection multiple usager 
en remplaçant select2 par ComboMultipleDropdownList
 2021-02-16 16:47:14 +01:00
Pierre de La Morinerie
0d94eacf32 spec: fix Ruby 2.7 arguments passing 2021-02-09 09:20:46 +01:00
Paul Chavard
36668403b6 cleanup feature helper 2020-09-02 11:26:26 +02:00
clemkeirua
c91e231347 spec: replace reference to ds in password 2020-07-23 16:20:16 +02:00
clemkeirua
d31b4b6848 ajout d'un test sur le telechargement de zips 2020-07-21 15:45:57 +02:00
Pierre de La Morinerie
7a27e78452 specs: remove unused wait-for-ajax helper 
This helper is:
- no longer used;
- buggy (not all requests increment it);
- discouraged (we should instead match an UI change that signals the end
of an ajax request).

Good riddance.
 2020-03-31 12:54:49 +02:00
Pierre de La Morinerie
4cb747fdb6 specs: always require rails_helper 
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
 2020-03-31 12:48:32 +02:00
Pierre de La Morinerie
6664965961 mailers: add procedure context to the confirmation link 
This allows to redirect the user to the procedure they signed up for
even when the browser session is not available (like if they changed
of browser).

Fix #4738
 2020-02-25 11:45:36 +00:00
Pierre de La Morinerie
e746d90016 mailers: add a link to the procedure when the account already exists 2020-02-12 13:24:52 +00:00
Pierre de La Morinerie
a328e8d94a features: refactor the editor specs 
- Add an `add_champ` helper
- Stop relying on a default champ being created
- Wait for all champs to be created by watching the "Add champ" button 

This should fix the flakiness of these tests.

Refs #4417
 2019-11-27 11:58:46 +01:00
Pierre de La Morinerie
d0cd875e91 features: add a leave_browser_open helper 2019-11-27 11:58:45 +01:00
Pierre de La Morinerie
0ef4a5253c features: move feature matchers to their own file 
This allows to have the same syntax than native Capybara matchers.
 2019-11-27 11:58:45 +01:00
Pierre de La Morinerie
a56dc0f653 specs: re-order method in feature helpers 2019-10-21 11:45:03 +02:00
Pierre de La Morinerie
d94a5cee8e spec: during js specs, cleanup database using deletion 
This attempts to solve the database deadlock on cleanup by fiddling
with the settings.

Ref #4293
 2019-09-10 16:40:02 +02:00
Paul Chavard
65e227c44b Migrate to flipper 2019-09-10 16:10:14 +02:00
simon lehericey
7fbedb78fb Add feature spec about managing passwords (with the courtesy of kemenaran) 2019-08-14 17:27:10 +02:00
Paul Chavard
0969b1f85f Enable email_login_token for all gestionnaires 2019-08-14 12:53:51 +01:00
simon lehericey
3fde2a6f70 Rename gestionnaire in code to instructeur 2019-08-12 13:47:01 +02:00
maatinito
8d3e3baabc #3928 administrator new & edit pwd pages 2019-08-01 17:12:14 +02:00
Paul Chavard
6d312e1716 spec: refactor wait_for_ajax to work with out new ajax utils 
`wait_for_ajax` is not used anymore, but it may be in the future.
 2019-06-04 16:30:36 +02:00
Pierre de La Morinerie
c2fcc6057e spec: add a wait_until helper 2019-06-04 16:30:36 +02:00
Paul Chavard
e870ba186f spec: add a pause helper 2019-06-04 16:16:53 +02:00
Paul Chavard
5da5f75c5f [Types de Champ Editeur] Save on change and only edited model 2019-02-07 17:05:55 +01:00
Pierre de La Morinerie
ae763d93f3 sign_up: display procedure context if available 2019-01-17 11:07:09 +01:00
gregoirenovel
03eb47016c Fix a gestionnaire sign in bug 2018-12-26 18:14:04 +01:00
simon lehericey
5690599289 Session: send a mail to confirm gestionnaire login 2018-11-13 10:41:45 +01:00
Pierre de La Morinerie
b0541fba79 users: sign-in after confirming an account within a short time 2018-11-06 18:24:34 +01:00
Pierre de La Morinerie
0fb9c123c9 invite: mutualize feature helper for signing in 2018-11-06 17:26:20 +01:00
gregoirenovel
baf69acbcb [Fix #2833] Move /support files to /fixtures 2018-10-16 10:47:41 +02:00
gregoirenovel
dc28e79ab4 Group API Entreprise mock responses in a folder 2018-10-15 23:31:23 +02:00
gregoirenovel
7ae5e8ce52 Group API Adresse mock responses in a folder 2018-10-15 23:31:23 +02:00
gregoirenovel
bfa2d5748d Properly name a support files folder 2018-10-15 23:31:23 +02:00
gregoirenovel
6eeba14885 Enable Style/WordArray 2018-10-03 12:03:21 +02:00
gregoirenovel
0c9628c180 Fix some files according the the .editorconfig rules 2018-09-20 16:23:09 +02:00
Pierre de La Morinerie
45d9de0995 spec: remove useless comment 2018-08-01 10:59:54 +02:00
Guillaume RISCHARD
06c34c4920 Optimisation des images 2018-03-06 16:14:59 +01:00
gregoirenovel
a2f4e8b283 factory_girl is now factory_bot 2018-01-23 17:15:42 +01:00
gregoirenovel
b138dcd876 Enable the Layout/SpaceInsideHashLiteralBraces cop 2018-01-18 10:53:35 +01:00
gregoirenovel
f605cd35ac Enable the Layout/SpaceAfterColon cop 2018-01-18 10:53:34 +01:00
Simon Lehericey
fe9ac727de [fix #872] apientrepise: use v2 endpoints 2017-12-01 11:26:40 +01:00
gregoirenovel
f1907f4d0e Enable the Layout/EmptyLinesAroundBlockBody cop 2017-06-13 10:35:23 +02:00
gregoirenovel
f496f1adab Enable the Layout/EmptyLines cop 2017-06-13 10:35:20 +02:00
gregoirenovel
d5e7bbd80d Files should end with a new line 2017-04-04 16:59:38 +02:00
gregoirenovel
15802b18ea Files should not start with a new line 2017-04-04 16:59:38 +02:00
Xavier J
0aedeba125 Add QuartierPrioritaire test 2016-12-16 10:15:29 +01:00
Xavier J
be62dea0e0 Fix major .DEPRECATION WARNING for spec/controllers/users/*.rb 2016-11-15 05:54:27 +01:00
Xavier J
a5a95abf06 Fix test for all Model 2016-11-14 18:36:09 +01:00
Xavier J
bd3df8de22 Fix Devise Helper Controller 2016-11-14 17:50:06 +01:00
Xavier J
d7eee773da Migrate API Entreprise INSEE V1 to V2 2016-06-13 10:13:37 +02:00
Xavier J
23ab25396f Add type champs "Address" plug at the BAN 2016-06-09 12:08:18 +02:00
Guillaume Lazzara
833d7790c2 Add support for remote OVH cloud storage 2016-05-13 16:08:51 +02:00
Xavier J
b15c2bbb2b New feature : User, Guest and Gestionnaire can be upload a document with theirs comments 2016-04-20 16:51:57 +02:00
Xavier J
68bb4935e7 Fix bug enterprise's date_creation 2016-01-28 11:29:44 +01:00
Xavier J
e0d980e804 Delete on Factory Dossier :with_user 2016-01-18 17:18:04 +01:00
Xavier J
d48c600476 Add lib API SGMAP Cartography Cadastre 
Adapt lib API SGMAP Cartography Quartier Prioritaire at the new API architecture
 2016-01-12 17:24:42 +01:00
Xavier J
704e491cd0 Add lib RNA connect to apientreprise 2015-12-11 10:36:16 +01:00
Xavier J
edc4f7dcd9 add spec support files for sgmap api carto 2015-11-23 18:42:51 +01:00
Tanguy PATTE
d6e4a76bf9 Merge branch 'develop' into refactor_type_de_xxx 
Conflicts:
	db/schema.rb
 2015-11-20 17:16:45 +01:00
Tanguy PATTE
afd0b72ae8 add support file to wait for ajax request for capybara tests 2015-11-17 11:22:29 +01:00
Xavier J
dd8bafab49 Add on information entreprise : 
- SIRET Siège social
	- Code naf
	- Code effectif
	- Numéro TVA intracommunautaire
	- Exercices
 2015-11-16 11:23:29 +01:00
Xavier J
8db705ec94 Revu de code OK 2015-11-02 16:36:52 +01:00
Xavier J
c6ed98b978 protect page with check the owner's dossier 2015-10-09 17:33:33 +02:00
Tanguy PATTE
3bd9308483 remove blank lines 2015-09-22 10:16:06 +02:00
Tanguy PATTE
44173a17fb add login for gestionnaire 2015-09-22 10:15:12 +02:00
Xavier J
b3383bec9f - Correction des tests suite à la modification du schéma de la base de données. 2015-09-21 17:59:03 +02:00
Tanguy PATTE
327412fba3 fix datepicker and test it 2015-08-24 11:42:06 +02:00
Tanguy PATTE
d557cee249 style check 2015-08-20 17:30:17 +02:00
Tanguy PATTE
c78a4f655b rename ref_formulaire into formulaire 2015-08-14 14:05:09 +02:00
Tanguy PATTE
a807ba5ae9 rename ref piece jointe into type piece jointe 2015-08-14 12:06:26 +02:00
Tanguy PATTE
3c57643f76 add database cleaner 
add factory girl
fix tests
rename dossier_pdf into piece_jointe
rename ref_piece_jointe into content
 2015-08-13 15:56:58 +02:00
Xavier J
5dc8ae822f Affichage des pièces jointes disponibles dans la console admin 2015-08-12 10:09:52 +02:00
Xavier J
03b8a58d74 Ajout des supports pour tests pièces jointes PDF 2015-08-11 15:09:16 +02:00
Xavier J
b5b83e939a First Commit 2015-08-10 11:05:06 +02:00