Commit graph

1926 commits

Author SHA1 Message Date
Martin
1a424beb6f fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken 2024-02-16 14:00:18 +01:00
Martin
0fbbe4d97c bug(tags): libelle with double dash, double dash also known as tag delimiter 2024-02-16 14:00:18 +01:00
Martin
56ed901703 tech(clean): remove dead code 2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c refactor(export/archives): holds user profile asking for the archive or export 2024-02-16 11:23:38 +01:00
Martin
8488e74bbb review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06 feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert 2024-02-15 16:41:00 +01:00
Martin
05193e1d1e feat(User.validation): validates email when env var is present 2024-02-15 16:41:00 +01:00
Martin
25f92a7760 feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
Colin Darie
a650114671
test: fix flaky match_array test 2024-02-15 11:00:53 +01:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Paul Chavard
93635b3516 refactor(logic): compute sub champ values 2024-02-13 11:57:31 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf 2024-02-12 17:20:07 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address 2024-02-12 15:08:05 +01:00
Paul Chavard
23592087ae refactor(instructeur): use precomputed timestamps 2024-02-08 18:36:04 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
seb-by-ouidou
c2c54083e8
feat: display tree structure of a group 2024-02-05 09:30:24 +01:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle 2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9 feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread 2024-02-02 12:52:36 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section 2024-02-01 18:55:52 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2 2024-02-01 18:55:50 +01:00
seb-by-ouidou
f3cba9331d fix: improvement after review 2024-01-29 18:23:39 +01:00
seb-by-ouidou
6cd8b6d2df feat: for gestionnaire highlight card and commentaires if any unread 2024-01-29 18:23:39 +01:00
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
mfo
77ca3dd28a
Merge pull request #9922 from mfo/US/nplus_one_in_summary
perf(TypeDeChampEditor): faster
2024-01-29 10:58:05 +00:00
Martin
01752bc2e8 perf(ProcedureRevisionPreloader): preload revision quickly 2024-01-26 14:47:44 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
simon lehericey
d909e2c8ea add various expiring scopes to APIToken 2024-01-26 10:15:37 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
simon lehericey
49f0caba7e fix(spec): flaky test 2024-01-25 11:17:44 +01:00
simon lehericey
6e5678d1c2 feature(api): add forbidden_network? to api_token 2024-01-25 10:51:58 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
fa07c21ec3 fix(champs.epci): epci names change over time. remap when it occurs 2024-01-04 07:17:15 +01:00
Eric Leroy-Terquem
547a4d95b7 chore(logic): commune and epci champs are always compute with compute_value_json 2023-12-22 10:57:53 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Eric Leroy-Terquem
4c82f2c9d7 fix(champ value): fix compute_value_json on departement champ 2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57 feature(api): store any ip used 2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails 2023-12-15 14:05:11 +01:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
e40d1107ac chore(conditional): add not_in_departement and not_in_region operators 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
c9676020b4 chore(conditional): add in_departement and in_region operators 2023-12-14 17:48:13 +01:00
Kara Diaby
303230dd1d Add new testss 2023-12-12 22:35:11 +00:00
Colin Darie
7c38cbcab3
test: fix random failing test 2023-12-12 15:05:48 +01:00
Colin Darie
c0771ad903
fix(dossier): passe en instruction with auto-archive even with pending correction 2023-12-12 15:05:46 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction
Closes #9731
2023-12-12 15:05:44 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Martin
f26a4bc041 amelioration(delai.traitement): revoie l'affichage du delais d'instruction
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-07 09:19:52 +01:00
Martin
474fde3380 amelioration(procedure.usual_traitement_time_for_recent_dossiers): divise en 3 groupe l'estimation de la duree de traitement 2023-12-07 09:19:52 +01:00
seb-by-ouidou
e34307b50c fix: fixes after review 2023-12-06 14:47:39 +01:00
seb-by-ouidou
564c3c04fa feat: US4.3.8 administrateur management 2023-12-06 14:47:39 +01:00
Christophe Robillard
961c7c5be4 fix format for motivation in notification mail 2023-12-05 18:50:50 +01:00
mfo
d90c55c29e
Merge pull request #9762 from tchak/fix-email-template
fix(email_template): less magic - less bugs !
2023-12-05 09:56:53 +00:00
mfo
dbfbaf4cea
Merge pull request #9757 from mfo/US/fix-extends-duree-conservation-dossier
correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change
2023-12-04 09:18:45 +00:00
Colin Darie
42ea9ed2f3 perf(preloader): fix N+1 on non mandatory repetition blocks
We have to tell repetition.champs association has been loaded
even when it's empty.
2023-11-30 14:10:33 +01:00
Paul Chavard
3de0367ed9 fix(email_template): less magic - less bugs ! 2023-11-29 20:36:44 +00:00
Martin
57d7b385ec correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change 2023-11-28 16:59:41 +01:00
Colin Darie
64400b512c
Merge pull request #9677 from govpf/feature-ouidou/clone_procedure_with_feature_flags
ETQ admin, les procédures clonées conservent les features flags
2023-11-28 08:21:02 +00:00
Paul Chavard
bfc809f96f feat(champs): expose more tags and api fields on rnf, address and commune 2023-11-27 15:33:05 +00:00
seb-by-ouidou
c4ca381bed feat: enable features on cloned procedure 2023-11-27 12:00:27 +01:00
Colin Darie
3b9285a00b
perf(procedure): description view caching 2023-11-27 11:29:20 +01:00
Colin Darie
5d747ba0c2
fix(procedure): list piece justificative in repetitions 2023-11-27 11:08:39 +01:00
mfo
78f9a2aa1e
Merge pull request #9737 from demarches-simplifiees/9670-export-rnf
En tant qu'instructeur, je peux exporter les données RNF des dossiers
2023-11-23 08:19:00 +00:00
Eric Leroy-Terquem
d92155a96a
Merge pull request #9714 from demarches-simplifiees/add-not-include-operator
ETQ admin je peux conditionner / router à partir d'un champ de type choix multiple avec l'opérateur "Ne contient pas"
2023-11-22 16:29:24 +00:00
Eric Leroy-Terquem
a54d55486c chore(routing): update routing_rule validation 2023-11-22 13:01:44 +01:00
Christophe Robillard
daa4c28af7 add data from rnf field to export 2023-11-22 12:20:05 +01:00
Paul Chavard
4842fc4d94 feat(tags): all tags should have ids 2023-11-21 13:55:25 +01:00
Colin Darie
f972d36f2f test: fix when using timestamps not yet limited by postgresql precision
Sur des colonnes dont le schema ne connait pas le niveau de précision
(créées avant rails 7), rails créé un timestamp avec la précision système
(par exemple 9 décimales sur linux) alors que pg va l'arrondir
a posteriori à 6.

Ce n'est généralement pas un problème en production,
mais se révèle dans les tests typiquement avec des objets crées
par des factories: si un test dépend de ces timestamps,
il faut récupérer la valeur limitée par pg (d'où le reload),
plutôt que celle directement issue de Time.now à la création de l'objet.

Une alternative aurait été de créer une migration pour ces colonnes pour
forcer la précision à 6 et que le schema en aurait pris connaissance:
rails limiterait la précision de lui même dès la création de l'objet.
2023-11-20 11:22:28 +01:00
Martin
520863d814 amelioration(user.expiration): ajoute une raison specifique a la suppression d'un dossier : user_expired 2023-11-17 11:33:14 +01:00
Martin
66cf41b6d2 amelioration(procedure.duree_conservation_dossiers_dans_ds_changes): reset les flag d'expirations lorsqu'on change la date de conservation des dosseirs d'une procedure 2023-11-17 11:33:14 +01:00
Martin
3186b0aa68 tech(refactor): centralise/documente les constantes de duree de retentions dans le ns dedié à l'expiration 2023-11-17 11:33:14 +01:00
krichtof
39bdb5f145
Merge pull request #9701 from demarches-simplifiees/carte
Afficher une carte de déploiement de DS par département
2023-11-16 13:18:16 +00:00
Christophe Robillard
ba876f5085 show france map with stats for each departement 2023-11-16 13:27:12 +01:00
Eric Leroy-Terquem
f945c02c3c feat(conditional): add exclude operator 2023-11-16 10:27:03 +01:00
Paul Chavard
8aab0cdfed
Merge pull request #9707 from demarches-simplifiees/remove-routing-feature-flags
Tech : supprime des features flags liés au routage
2023-11-15 09:23:00 +00:00
Paul Chavard
a2ed35d44e spec(dossier): improuve dossier with state factories 2023-11-14 23:59:45 +01:00
Eric Leroy-Terquem
754e4c206b chore(feature flag): remove routing_rules flag call 2023-11-14 17:02:39 +01:00
Martin
fd1f33b6e5 bug(filtres): les filtres par type de champs select ne fonctionnent pas 2023-11-14 09:46:29 +01:00
mfo
7fca13d02c
Merge pull request #9696 from colinux/procedure-visible-by-user-faster
Perf: accélération du chargement des dossiers visibles
2023-11-14 08:22:31 +00:00
Colin Darie
fb318620aa
Merge pull request #9692 from colinux/fix-deprecation-warnings
Tech: fix multiple deprecation warnings
2023-11-13 10:16:06 +00:00
Colin Darie
154a993794 chore(perf): improve perf of Dossier#visible_by_user up to 32% 2023-11-10 15:51:24 +01:00
Colin Darie
8326cf080e
fix: typo in method name extention => extension 2023-11-10 14:20:00 +01:00
Kara Diaby
c53d35401e Tests 2023-11-10 08:54:27 +00:00
Colin Darie
edb47d94f7 test: fix not_to raise_error(SpecificErrorClass) false positive risk 2023-11-09 17:27:55 +01:00
mfo
87c3615774 review(tech): utilise un code unique pr les elements de l'autocomplete, corrections de typos, amelioration du code
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-11-09 11:10:17 +01:00
Martin
0428853f4d amelioration(Champs::EngagementJuridiqueChamp): valide le format 2023-11-09 10:09:14 +01:00
simon lehericey
52752c95ec tech: add api_token_id to graphql logs 2023-11-08 16:50:10 +01:00
krichtof
a6ea607e7a
Merge pull request #9566 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_children_management
Feature ouidou/admin creation delegation gestionnaire page children management
2023-11-08 15:13:10 +00:00
Eric Leroy-Terquem
0968f02a26
Merge pull request #9648 from demarches-simplifiees/add-rnf-service
Ajout d'un nouveau référentiel : le Répertoire National des Fondations (RNF)
2023-11-08 09:06:47 +00:00