Pierre de La Morinerie
ac5303d56d
config: make Sentry ignore rescued ActiveJob exceptions
...
For now the Sentry delayed_job integration reports errors that are
rescued with `retry_on`.
Ignore these errors manually for now.
See https://github.com/getsentry/sentry-ruby/issues/1347
2021-03-18 10:52:10 +01:00
Pierre de La Morinerie
6809621eec
Merge pull request #5993 from tchak/expose-rich-address-information
...
Instructeur : affichage de plus d’informations sur les champs Adresse, Commune et Région (#5993 )
2021-03-18 08:30:49 +01:00
Paul Chavard
d59867c73b
Exposer plus d’informations dans l’interface pour certains champs
2021-03-17 16:28:05 +01:00
Paul Chavard
de5c2d3032
Merge pull request #5992 from tchak/fix-more-address-null-fields
...
Return empty strings for incomplete api entreprise adresses
2021-03-17 14:38:11 +01:00
Paul Chavard
e96d2fb083
Return empty strings for incomplete api entreprise adresses
2021-03-17 12:12:21 +01:00
Paul Chavard
aabf28fa0c
Merge pull request #5970 from tchak/graphql-revisions-filters
...
Add revision dossiers filters to API
2021-03-17 12:08:55 +01:00
Paul Chavard
a6fe1df201
update graphql schema
2021-03-17 11:53:48 +01:00
Paul Chavard
4efc5ff273
Update app/graphql/schema.graphql
...
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2021-03-17 11:53:48 +01:00
Paul Chavard
046b36d386
Update app/graphql/schema.graphql
...
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2021-03-17 11:53:48 +01:00
Paul Chavard
866ae256a3
Add revision dossiers filters
2021-03-17 11:53:48 +01:00
krichtof
d014201521
Merge pull request #5988 from betagouv/5608-upload-accessible
...
Rend accessible le champ Pièce justificative
2021-03-17 11:41:36 +01:00
Christophe Robillard
f47e2e62cd
add button role to supprimer link
2021-03-17 11:31:51 +01:00
Christophe Robillard
6026793c1d
focus to target after toggle
2021-03-17 11:31:51 +01:00
Christophe Robillard
df3bd3a1d2
handle focus during and after upload
2021-03-17 11:31:51 +01:00
Christophe Robillard
43039d1755
add aria-value min, max and now for progressbar upload
2021-03-17 11:31:51 +01:00
Pierre de La Morinerie
02f313c204
Merge pull request #5989 from tchak/improuve-geometry-after-party
...
After_party : correction de la tâche `remove_invalid_geometries after_party`, qui échouait après une heure (#5989 )
2021-03-16 18:32:16 +01:00
Paul Chavard
24138f4d2f
fix n+1 on remove_invalid_geometries after_party
2021-03-16 18:25:14 +01:00
krichtof
dc314dab77
Merge pull request #5966 from betagouv/5885-add-pdf-export
...
[instructeur] ajoute l'export pdf du dossier aux pieces justificatives
2021-03-16 15:26:13 +01:00
Christophe Robillard
dfed8f32ae
update link to download dossier and all pjs
2021-03-16 15:13:17 +01:00
Christophe Robillard
858bbde2d6
remove dead code
2021-03-16 15:13:17 +01:00
Christophe Robillard
60cc4d3697
add pdf to pjs export
2021-03-16 15:13:17 +01:00
Paul Chavard
3d52b60b14
Merge pull request #5987 from betagouv/main
...
2021-03-16-01
2021-03-16 13:21:39 +01:00
Pierre de La Morinerie
e90957dd32
Merge pull request #5986 from tchak/fic-entreprise-serializer
...
API : rend optionnelle la présence du n° de TVA intra-communautaire
2021-03-16 13:06:44 +01:00
Paul Chavard
76aa7bdfe3
Add default nil value for numero_tva_intracommunautaire
2021-03-16 12:57:10 +01:00
Pierre de La Morinerie
729167b954
Merge pull request #5984 from tchak/tests-for-geojson-validation
...
Ajout de tests automatisés pour la validation des polygones GeoJSON (#5984 )
2021-03-16 12:34:25 +01:00
Paul Chavard
4f03c231a3
Add tests for GeoJSON validation
2021-03-16 12:27:28 +01:00
Pierre de La Morinerie
5ab7ea1d79
Merge pull request #5979 from betagouv/refactor-active-storage-concerns
...
Jobs : refactor de la méthode utilisée pour déclencher les jobs de scan anti-virus et de filigranage (#5979 )
2021-03-16 12:16:50 +01:00
Pierre de La Morinerie
be58d82016
specs: clear jobs queue before each test
...
This avoids `perform_enqueued_jobs` to execute jobs from the previous
tests.
2021-03-16 11:49:14 +01:00
Pierre de La Morinerie
75a1046315
active_storage: refactor concerns
...
Follow-up of #5953 .
Refactor the concerns with two goals:
- Getting closer from the way ActiveStorage adds its own hooks.
Usually ActiveStorage does this using an `Attachment#after_create`
hook, which then delegates to the blob to enqueue the job.
- Enqueuing each job only once. By hooking on `Attachment#after_create`,
we guarantee each job will be added only once.
We then let the jobs themselves check if they are relevant or not, and
retry or discard themselves if necessary.
We also need to update the tests a bit, because Rails'
`perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on`
clause of jobs. Instead it forwards the exception to the caller – which
makes the test fail.
Instead we use the inline version of `perform_enqueued_jobs()`, without
a block, which properly ignores errors catched by retry_on.
2021-03-16 11:49:14 +01:00
Pierre de La Morinerie
c14720d915
Merge pull request #5982 from betagouv/ignore-integrity-errors
...
Jobs : lorsqu'une erreur ActiveStorage::IntegrityError se produit pendant le scan des virus, le job est maintenant automatiquement retenté plus tard.
2021-03-16 10:58:53 +01:00
Pierre de La Morinerie
08094e5384
jobs: retry on ActiveStorage::IntegrityError during virus scan
...
This is the same setting than what ActiveStorage::AnalyzeJob uses.
2021-03-16 10:52:12 +01:00
LeSim
3d76319424
Merge pull request #5981 from betagouv/disable-rails-ip-spoofing
...
config: avoid blocking legitimate requests from mobile ISPs
2021-03-16 09:19:40 +01:00
Pierre de La Morinerie
70104d7059
config: avoid blocking legitimate requests from mobile ISPs
2021-03-11 18:28:10 +01:00
Paul Chavard
a105a090bf
Merge pull request #5980 from betagouv/main
...
2021-03-11-01
2021-03-11 17:43:00 +01:00
Paul Chavard
e42d6f4f14
Merge pull request #5977 from tchak/fix-carto
...
Fix invalid GeoJSON handling
2021-03-11 15:58:08 +01:00
Paul Chavard
6f543d3770
Handle invalid GeoJSON in the editor
2021-03-11 15:51:09 +01:00
Paul Chavard
c37feba8d1
Remove invalid geo areas
2021-03-11 15:51:09 +01:00
Paul Chavard
a7fb7bf1ef
Add geo json validation
2021-03-11 15:51:09 +01:00
Paul Chavard
4c9305dbb1
Merge pull request #5978 from tchak/fix-data-fetch-jobs
...
Try to reduce the number of external data fetches
2021-03-11 15:03:53 +01:00
Paul Chavard
d24ee27cac
Try to reduce the number of external data fetches
...
Only fetch external data if the external_id is the current one and data is not yet fetched
2021-03-11 14:56:37 +01:00
Paul Chavard
21d5da379f
remove unused job
2021-03-11 14:56:37 +01:00
LeSim
6e95d1c710
Merge pull request #5976 from tchak/relax-etablissement-validations
...
capital_social and numero_tva_intracommunautaire can be null
2021-03-11 13:38:03 +01:00
Paul Chavard
bee66d41c4
capital_social and numero_tva_intracommunautaire can be null
2021-03-11 11:13:50 +01:00
Kara Diaby
9c6406910e
Merge pull request #5975 from betagouv/main
...
2021-03-10-01
2021-03-10 17:22:54 +01:00
Kara Diaby
2c724cbec3
Merge pull request #5973 from betagouv/claimant-type-to-avis-table-fix
...
Claimant type to avis table fix
2021-03-10 15:26:58 +01:00
kara Diaby
53ba442235
fix after party task
2021-03-10 09:04:23 +01:00
kara Diaby
6383e6b9e7
Revert "Revert "Claimant type to avis table""
...
This reverts commit f4fd220d43
.
2021-03-10 08:48:55 +01:00
Pierre de La Morinerie
873cea8c86
Merge pull request #5972 from betagouv/rspec-5
...
Mise à jour de rspec 3 vers rspec 5
2021-03-09 15:58:37 +01:00
Pierre de La Morinerie
4c3fcfeec2
specs: upgrade to rspec 5
...
Rspec 5 is compatible with Rails 6.1.
2021-03-09 15:51:19 +01:00
Pierre de La Morinerie
5bf499baa0
specs: remove rspec_junit_formatter
...
It was unsed by CircleCI to generate test reports in the JUnit XML
format, but:
- We now use Github Actions, which has its own reporting system,
- It prevents us to upgrade to rspec > 3.
2021-03-09 15:51:19 +01:00