Commit graph

28 commits

Author SHA1 Message Date
Pierre de La Morinerie
4cb747fdb6 specs: always require rails_helper
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Pierre de La Morinerie
28dcbcb85b auth: move the FranceConnect button to a partial 2019-04-03 16:08:09 +02:00
simon lehericey
02dd1e209c FC ParticulierController: implement auto reconciliation based on user email 2018-01-17 16:37:26 +01:00
gregoirenovel
9d75526460 Enable the Layout/MultilineAssignmentLayout cop 2018-01-15 22:33:13 +01:00
simon lehericey
02395e732c FC service: return domain info 2018-01-15 17:14:12 +01:00
simon lehericey
f8519c5345 FC initializers: remove Hashie 2018-01-15 17:08:38 +01:00
Mathieu Magnin
b68a8b37e8 Redesign the login form 2017-06-19 18:21:15 +02:00
gregoirenovel
f1907f4d0e Enable the Layout/EmptyLinesAroundBlockBody cop 2017-06-13 10:35:23 +02:00
gregoirenovel
bc16027ccc Enable the Layout/BlockEndNewline cop 2017-06-13 10:35:19 +02:00
gregoirenovel
9439e1abb1 Enable the Layout/AlignParameters cop 2017-06-13 10:35:16 +02:00
gregoirenovel
c10c2fc31b Selectors must be written in lowercase with hyphens 2017-04-20 10:35:53 +02:00
JC
22a59123c1 Adding launchy to put save_and_open_page in capybara specs, fixing many red tests by removing/changing expectations according to new UI. Need to pursue on spec/features/backoffice/flux_de_commentaires_spec.rb (not priority), and spec/controllers/root_controller_spec.rb (unkonw) 2016-12-13 16:11:11 +01:00
Xavier J
4d812220fd - Add FranceConnectInformation table to make safe FranceConnect pivot identity.
- Adapt source code with the new table
2016-01-21 17:06:09 +01:00
Xavier J
a738128f4a Suppression de FCEntreprise 2016-01-19 17:40:45 +01:00
Xavier J
e8fd212d13 - Code review
- Delete Mandataires sociaux adapter
- Add function to get mandataires sociaux in Enterprise Adapter
2016-01-19 17:19:38 +01:00
Xavier J
5540a786db Disable FC Enterprise 2016-01-11 17:19:25 +01:00
Xavier J
9e0dfb593e Add FranceConnect Particulier
Reactivate FranceConnect Entreprise
2015-12-24 10:12:23 +01:00
Xavier J
229973f14c Rename FranceConnect to FranceConnect::Entreprise 2015-12-18 12:01:26 +01:00
Xavier J
debac1ed91 Désactivation des tests FranceConnect 2015-12-03 15:41:30 +01:00
Xavier J
afaa6a5ac9 - delete route '/users/siret'
- delete route 'users/procedure'
- create route 'users/dossiers/new?procedure_id=:procedure_id'
- delete a part of unused code
- adapt demo page with new procedure URL
2015-12-03 12:00:22 +01:00
Xavier J
5cebb5b621 - Code review
- Delete routes 'users/dossiers/a_traiter - en_attente - termine' for user
- Add routes 'uses/dossiers/?liste=xxx' to reach at file lists for user
2015-12-02 16:52:09 +01:00
Xavier J
58f840ac92 - Redirect User dossier index to User dossier a traiter
- Fix tests
- Order file list by last updated for User
2015-11-30 15:56:06 +01:00
Xavier J
728150b148 [] Revu de code Ok 2015-10-08 11:26:12 +02:00
Tanguy PATTE
968aa92d77 [] prefill siret when user has a siret 2015-10-08 11:22:55 +02:00
Tanguy PATTE
afed93247d [] redirect to correct location after login with france connect 2015-10-07 16:49:42 +02:00
Xavier J
d655b2319a Done test France Connect 2015-10-06 17:41:49 +02:00
Tanguy PATTE
f4e3ec1a72 add feature test on france connect 2015-10-06 17:22:06 +02:00
Xavier J
8445944b76 add spec for features France connect connection 2015-10-06 17:06:59 +02:00