Commit graph

9983 commits

Author SHA1 Message Date
Pierre de La Morinerie
88373ddf20 individual: raise when the individual object cannot be created
Currently, a number of dossiers in production are for procedures for
individuals, but don't have a `individual` object.

This is probably because creating the Individual from France Connect
infos fails – but fails quietly, and nullify the relationship.

As a first step, we now raise an exception when the creation from FC
infos fails. We will then identify the issue, and see if we can fix it –
or if we should be resilient to this kind of issues.
2019-11-12 18:29:37 +01:00
Pierre de La Morinerie
d86e2bfbc5
Remove service.siret from manager (#4509)
Supprime le champ `Service.siret` du Manager
2019-11-12 18:20:48 +01:00
Paul Chavard
ac092089ff Remove service.siret from manager 2019-11-12 17:39:36 +01:00
Pierre de La Morinerie
38ff1c7226
Remove carrierwave (#4508)
Suppression de CarrierWave
2019-11-12 17:37:38 +01:00
Paul Chavard
fe84e8e0f7 Remove carrierwave 2019-11-12 15:26:18 +01:00
Paul Chavard
4bc0006ca0
Merge pull request #4364 from tchak/graphql-dossiers-filters
[GraphQL] Add more filters to dossiers
2019-11-08 00:35:33 +01:00
Paul Chavard
fa741c9bae [GraphQL]: do not return dossiers brouillons 2019-11-07 22:07:42 +01:00
Paul Chavard
990c867c2e [GraphQL] Add more filters to dossiers 2019-11-07 22:07:42 +01:00
Keirua
b9c3d54168
Merge pull request #4502 from Keirua/remove-report-uri-notifications
Suppression des notification vers report-uri
2019-11-07 17:54:01 +01:00
clemkeirua
6351eabfdd remove notification to report-uri in production 2019-11-07 17:32:40 +01:00
Paul Chavard
8d8be8d033
Merge pull request #4500 from tchak/active-storage-file-not-found
Implement ActiveStorage::FileNotFoundError
2019-11-07 17:29:24 +01:00
Paul Chavard
5bc8b5fe12 Implement ActiveStorage::FileNotFoundError 2019-11-07 17:20:09 +01:00
Pierre de La Morinerie
e3382401b9
editor: insert new champs after the last fully visible champ (#4497)
Administrateur : l'éditeur de formulaire insère les nouveaux champs à l'endroit attendu
2019-11-07 16:12:25 +01:00
Pierre de La Morinerie
8a7f4ec769 editor: reduce scroll duration when inserting a new champ
The previous default was 1s, which felt slooooow.
2019-11-07 15:49:15 +01:00
Pierre de La Morinerie
fc8a0d46ff editor: insert new champs after the last fully visible champ
Before, when the "Add new champ" button was clicked, the new champ
was inserted after the **first** fully visible champ.

That was most of the time unexpected. The correct behavior would be to
insert the new champ after the **last** fully visible champ.

That's what this commit does. Now the "Add new champ" behavior feels
much less confusing.
2019-11-07 15:19:11 +01:00
Paul Chavard
91002865b0
Merge pull request #4490 from tchak/fix-more-export-issues
Fix more export issues
2019-11-07 14:33:51 +01:00
Paul Chavard
f22b39b7c5 Handle non unique champ repetable labels
fix #4466
2019-11-07 14:27:52 +01:00
Paul Chavard
2a61ed5b1c Export etablissement information in csv
fix #4440
2019-11-07 14:27:52 +01:00
Paul Chavard
d6744a3c03
Merge pull request #4457 from tchak/graphql-direct-upload
[GraphQL] Add create direct upload mutation
2019-11-07 13:07:28 +01:00
Paul Chavard
4231b81727 [GraphQL] Add create direct upload mutation 2019-11-07 12:48:51 +01:00
LeSim
9e1ede2a51
Merge pull request #4493 from betagouv/feature_flip_routage_for_admin
Renommage de l'option routage afin de l'activer sur les pages manager/admins
2019-11-07 11:41:21 +01:00
simon lehericey
9469734f29 Follow flipper name convention to appears on manager admin page 2019-11-07 11:09:05 +01:00
Keirua
e3513f86ef
Merge pull request #4465 from Keirua/feat/fix-incorrect-emails-retries
#4419 - Ne pas relancer les envois d'email lorsqu'ils échouent car le destinataire est inexistant
2019-11-07 10:53:08 +01:00
clemkeirua
75923f7cb2 add explanation about rescue_from in application_mailer 2019-11-07 10:13:11 +01:00
clemkeirua
7f76ab6671 disable retry sending a mail with an invalid email adress 2019-11-07 10:11:48 +01:00
LeSim
5a310b6c2b
Merge pull request #4474 from betagouv/rgaa-fix
Rgaa 3.0 : corrections pour les pages non connectés
2019-11-06 18:30:32 +01:00
simon lehericey
1a1bd306b1 Add main and headers tags in layout (RGAA 9.2.1) 2019-11-06 17:18:08 +01:00
simon lehericey
9c7feae0b2 RGAA fix : 9.1.2 Dans chaque page Web, la hiérarchie entre les titres (balises h ou balise possédant un role ARIA "heading" associé à une propriété aria-level) est-elle pertinente ? 2019-11-06 17:01:07 +01:00
simon lehericey
b6765a03ae Footer: remove top list and make each column a list as service-public.fr
(note: not so sure because of https://www.service-public.fr/P10025)
2019-11-06 17:01:07 +01:00
simon lehericey
6ec2b084c7 h3 -> p 2019-11-06 17:01:07 +01:00
simon lehericey
16814af474 Make (part of) the html valid again
simple_format always wraps its content so the better idea I have got was to use a span to avoid p in p.
2019-11-06 17:01:07 +01:00
simon lehericey
8efac29eba Better structure footer-site-links in list
it follows service-public.fr structure

- remove extraneous footer-link class
- remove extraneous space with `>` haml weird stuff
- homogenize json-style hash
- merge classes on ul
- use pseudo element for eye candy
2019-11-06 17:01:07 +01:00
simon lehericey
79968f12fb RGAA A : h4 => span in top dropdown item to respect title hierarchy (9.1.2) 2019-11-06 17:01:07 +01:00
simon lehericey
daeeeda583 RGAA: ajout de title aux links 2019-11-06 17:01:07 +01:00
Chaïb Martinez
a00ce94eea RGAA A : ajout de l'attribut alt pour les images
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-11-06 17:01:07 +01:00
Chaïb Martinez
47b177fd31 RGAA A : L'attribut alt est absent pour le logo des demarches
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-11-06 16:50:10 +01:00
LeSim
a21897fc08
Merge pull request #4476 from betagouv/feat-use-sib
Activation de sendinblue
2019-11-06 14:01:30 +01:00
clemkeirua
04c13190c3 introduce smtp_key in order to use 2 different sendinblue keys
client_key is exposed to the client via gon, so if we use it for sending email too we are exposing a key so anybody could send an email.
The current client_key has a different level of right and can't send emails so it's ok to expose it.
2019-11-06 13:34:36 +01:00
clemkeirua
959aacdea5 Sendinblue email balancing using proper credentials
This reverts commit c61981e795.
2019-11-06 13:34:36 +01:00
Paul Chavard
8ec6eb619d
Merge pull request #4483 from tchak/fix-sentry-errors
Fix sentry errors
2019-11-06 13:03:03 +01:00
Paul Chavard
0562e2728f Fix type_de_champ validation error 2019-11-06 12:54:07 +01:00
Paul Chavard
ee62d6fca4 Fix move type de champs 2019-11-06 12:54:07 +01:00
Paul Chavard
a708b071dd Do not crash with champ repetable with no children 2019-11-06 12:54:07 +01:00
Paul Chavard
f5c80f211d Guard for missing attestation on dossier 2019-11-06 12:54:07 +01:00
Paul Chavard
95f98fe605 API v1 correctly handle resultats_par_page 2019-11-06 12:54:07 +01:00
Pierre de La Morinerie
d91d1d9fa8
Correction de la recherche dans la liste des instructeurs (#4486)
Administrateur : correction de la recherche dans la liste des instructeurs
2019-11-06 12:27:51 +01:00
Pierre de La Morinerie
8df91df9fa assigns: strip and lowercase the search filter 2019-11-06 12:16:30 +01:00
Pierre de La Morinerie
0eeac59ecd assigns: fix search among the unassigned instructeurs
This was broken since moving the email out of the Instructeur column.
2019-11-06 12:16:30 +01:00
Pierre de La Morinerie
b2b577d4a9
build(deps): bump loofah from 2.2.3 to 2.3.1 (#4485)
build(deps): bump loofah from 2.2.3 to 2.3.1
2019-11-06 12:14:48 +01:00
dependabot[bot]
c5f2dacb71
build(deps): bump loofah from 2.2.3 to 2.3.1
Bumps [loofah](https://github.com/flavorjones/loofah) from 2.2.3 to 2.3.1.
- [Release notes](https://github.com/flavorjones/loofah/releases)
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md)
- [Commits](https://github.com/flavorjones/loofah/compare/v2.2.3...v2.3.1)

Signed-off-by: dependabot[bot] <support@github.com>
2019-11-06 10:33:00 +00:00