DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
11037 commits 250 branches 1166 tags 78 MiB
Commit graph

127 commits

Author SHA1 Message Date
Christophe Robillard
a072d35211 use traitement model 
when a dossier is terminated (accepte, refuse or classe_sans_suite),
we store now `processed_at` and `motivation` in a traitement instance
 2020-07-08 18:15:15 +02:00
Pierre de La Morinerie
35240e2219 lint: fix Rubocop warnings 
The Rails/UniqueValidationWithoutIndex rule is disabled for now, but
we'll need to re-enable it (and fix the underlying issues) after the
migration to Rails 6.
 2020-07-07 18:03:56 +02:00
Paul Chavard
3cd4597006 Update rubocop roules 2020-03-17 11:25:21 +01:00
Pierre de La Morinerie
cf101d64d8 lint: add a Rubocop rule to forbid the use of unscoped 
`unscoped` often has an effect broader than intended. For instance:

```
user.dossiers.unscoped.destroy_all
```

will not destroy all the user's dossier, including the hidden ones,
but **all the dossiers of all users**.

Instead, narrower unscoping should be used:

```
user.dossiers.unscope(where: :hidden).destroy_all
```

(Or even better, use the new `Dossier.with_hidden` scope).
 2020-01-28 17:32:38 +01:00
Nicolas Bouilleaud
661b80777d Replace old migrations with a single “recreate_structure” 
* copy-paste the description from schema.rb,
 * without the `force: :cascade` options (that drops the tables before recreating them).
* create a new migration with it
* give it the same timestamp as the last deleted migration, so that it exists in the schema_migration table and it is not run in production.
* (Also got rid of some stray changes in schema.rb for mon_avis and unconfirmed_email)
* Run rake db:migrate and make sure nothing moves
 2019-09-16 14:44:37 +02:00
Paul Chavard
3b8d3b7967 Add Style/CollectionMethods to rubocop 2019-09-12 14:48:18 +02:00
Nicolas Bouilleaud
7e80b8a4dc Enable the Rails/InverseOf cop and add missing inverse_of 2019-06-17 13:44:07 +02:00
Mathieu Magnin
dd27167c5d Enforce Timezone rule in Rubocop 2019-02-18 16:19:42 +01:00
gregoirenovel
c51280c40c Enable the Bundler/OrderedGems cop 2019-01-07 10:34:55 +01:00
gregoirenovel
0c8b228fbf Enable the Lint/UselessAssignment cop 2019-01-03 10:53:50 +01:00
gregoirenovel
0596d53ac2 Enable the Lint/UnusedBlockArgument cop 2019-01-03 10:53:50 +01:00
gregoirenovel
ddc71cbacf Enable the Lint/UnderscorePrefixedVariableName cop 2019-01-03 10:53:50 +01:00
gregoirenovel
baf7977786 Enable the Lint/StringConversionInInterpolation cop 2019-01-03 10:53:50 +01:00
gregoirenovel
d473119f9d Enable the Lint/ParenthesesAsGroupedExpression cop 2019-01-03 10:53:50 +01:00
gregoirenovel
186e362701 Enable the Layout/SpaceInsideArrayLiteralBrackets 2019-01-03 10:53:50 +01:00
gregoirenovel
386fbce776 Enable the Layout/SpaceBeforeBlockBraces cop 2019-01-03 10:53:50 +01:00
gregoirenovel
8b0b8162f0 Enable the Layout/SpaceAfterComma cop 2019-01-03 10:53:50 +01:00
gregoirenovel
cc32516c21 Enable more cops 2019-01-03 10:53:50 +01:00
gregoirenovel
abce867fb4 Enable the Rails/CreateTableWithTimestamps cop 2018-12-19 14:40:10 +01:00
gregoirenovel
4b0e632abb Enable the Style/ColonMethodCall cop 2018-12-19 13:56:10 +01:00
gregoirenovel
616e9305e9 Enable the Style/ClassCheck cop 2018-12-19 13:56:10 +01:00
gregoirenovel
fba8d97256 Enable the Stlye/BlockDelimiters cop 2018-12-19 13:56:10 +01:00
gregoirenovel
a8f700b572 Enable the Style/FormatString cop 2018-12-19 13:56:10 +01:00
gregoirenovel
621154fde4 Enable more cops 2018-12-19 13:56:10 +01:00
gregoirenovel
6479de1f6c Bump development gems 
- rubocop (0.59.2 → 0.60.0)
 2018-11-16 12:05:22 +01:00
simon lehericey
4f1cc8a2f0 Rubocop: add TimeZone rule 2018-10-26 10:10:20 +00:00
gregoirenovel
c91a1cf474 Enable Style/SymbolArray 2018-10-03 12:15:48 +02:00
gregoirenovel
2004b9a864 Enable Style/SymbolLiteral 2018-10-03 12:15:48 +02:00
gregoirenovel
d9d4f6fe20 Enable Style/SymbolProc 2018-10-03 12:15:48 +02:00
gregoirenovel
7e4268db67 Enable Style/TrailingCommaInArguments 2018-10-03 12:03:21 +02:00
gregoirenovel
275bb64c1f Enable Style/TrailingCommaInArrayLiteral 2018-10-03 12:03:21 +02:00
gregoirenovel
a171186dd8 Enable Style/TrailingCommaInHashLiteral 2018-10-03 12:03:21 +02:00
gregoirenovel
2ede598f77 Enable Style/UnneededCapitalW 2018-10-03 12:03:21 +02:00
gregoirenovel
ed240cb4d3 Enable Style/UnneededInterpolation 2018-10-03 12:03:21 +02:00
gregoirenovel
82f0df089d Enable Style/UnneededPercentQ 2018-10-03 12:03:21 +02:00
gregoirenovel
9cdad6ce7e Enable Style/VariableInterpolation 2018-10-03 12:03:21 +02:00
gregoirenovel
106d03d982 Enable Style/WhileUntilDo 2018-10-03 12:03:21 +02:00
gregoirenovel
c380abeb24 Explain why Style/WhileUntilModifier is disabled 2018-10-03 12:03:21 +02:00
gregoirenovel
6eeba14885 Enable Style/WordArray 2018-10-03 12:03:21 +02:00
gregoirenovel
d1439f8a52 Enable Style/YodaCondition 2018-10-03 12:00:17 +02:00
gregoirenovel
1f4ef0074f Enable Style/ZeroLengthPredicate 2018-10-03 12:00:17 +02:00
Paul Chavard
bf7c023380 Add webpacker and use it for new_design 2018-07-25 15:14:06 +02:00
gregoirenovel
81ac3d7c6b Bump development gems 
- brakeman (4.3.0 → 4.3.1)
- rubocop (0.56.0 → 0.58.1)
 2018-07-17 17:33:28 +02:00
Pierre de La Morinerie
ae5754e6c6 spring: add Spring to binstubs of default commands 
Binstubs generated with `bundle exec spring binstub --all`.

This allows to type `bin/rails`, `bin/rake` or `bin/rspec` and have it
using Spring (rather than `bin/spring rails`).

On my machine it produces a nice speedup:

- `rake -T`: 5.6s
- `bin/rake -T`: 0.25s

The startup speedup for `rails` and `rspec` is similar.
 2018-06-20 10:31:15 +02:00
gregoirenovel
682823ec93 Bump gems 
- apipie-rails
- brakeman
- dotenv-rails
- openid_connect
- openstack
- rack-mini-profiler
- rubocop
- sentry-raven
- web-console
- webmock
 2018-05-18 18:14:17 +02:00
gregoirenovel
09e0144f30 Bump gems 
- apipie-rails
- brakeman
- byebug
- rubocop
- turbolinks
- skylight
- chartkick
- devise
- dotenv-rails
- uglifier
- web-console
- font-awesome-rails
- pg
- deep_cloneable
- delayed_job_active_record
 2018-04-17 17:24:10 +02:00
gregoirenovel
ecc0f88417 Enable the cop that checks for brackets in method definitions 2018-03-20 18:03:39 +01:00
gregoirenovel
0a9f442260 Enable some Rails cops 2018-03-06 17:18:44 +01:00
gregoirenovel
da3d9d403a Enable some more cops 2018-03-06 17:18:44 +01:00
gregoirenovel
7489b8d1aa Avoid assignments in conditions 2018-03-06 17:18:44 +01:00