DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
1695 commits 250 branches 1166 tags 78 MiB
Commit graph

744 commits

Author SHA1 Message Date
Xavier J
f7c11218db Fix demo controller connexion spec Gestionnaire 2017-01-03 11:35:14 +01:00
Xavier J
f9759d9368 Fix demo controller connexion spec 2017-01-03 11:34:29 +01:00
Xavier J
2750319f77 Fix some tests 2017-01-03 11:32:21 +01:00
JC
d9b59eb70c Forget an 'save_and_open_page' from launchy gem, that openned page during feature tests 2017-01-02 10:53:13 +01:00
Xavier J
a6dc2bab15 Merge branch 'notifications' into develop 2017-01-02 09:46:16 +01:00
JC
0d45b06ffb Changing click for tigger(click) 2016-12-27 17:29:14 +01:00
Xavier J
12edb06a02 Merge branch 'notifications' into develop 2016-12-27 16:03:33 +01:00
Xavier J
e7b7652388 Fix some tests 2016-12-27 15:50:45 +01:00
Xavier J
c01132c788 Delete old attr in database 2016-12-27 11:57:34 +01:00
Xavier J
4d765d3b46 Past all notification to read when gestionnaire is on back office dossier show 2016-12-27 11:23:19 +01:00
Xavier J
2e13cb6818 Get gestionnaire unread notifications for his follows files 2016-12-27 10:57:21 +01:00
Xavier J
ce5bf8d622 Initialize fonction « unread_notifications » in DossierListFacade 2016-12-27 10:47:23 +01:00
Xavier J
4e6adf5bc3 Fix some tests 2016-12-26 18:37:27 +01:00
Xavier J
153c472ef6 Add notifications into procedure list on back office report 2016-12-26 17:25:59 +01:00
Xavier J
9a0a391c40 Exclude notification for dossier state draft and for accompagnateur comments 2016-12-26 14:38:00 +01:00
JC
a727c5146f Cannot have the right feature test about invites, both side User and Gestionnaire 2016-12-26 14:16:08 +01:00
Xavier J
33362d1a52 Add notification for submitted state 2016-12-26 11:57:08 +01:00
Xavier J
e5768b6798 Add notification for piece justificative 2016-12-26 11:42:02 +01:00
Xavier J
6ed91073c4 Add notification for cerfa 2016-12-26 11:33:12 +01:00
JC
4c9c898a69 Feature test about clonning procedures 2016-12-26 10:56:57 +01:00
Xavier J
263d85ccee Merge branch 'develop' into notifications 
# Conflicts:
#	app/views/backoffice/dossiers/_list.html.haml
 2016-12-26 10:53:05 +01:00
JC
2908460c16 Feature test for gestionnaire, index and show (only filtering not tested) 2016-12-23 14:46:50 +01:00
Xavier J
54fbe367c0 Add notifications when user post a comment 2016-12-22 20:40:23 +01:00
Xavier J
a681564b39 Add notification table and model 2016-12-21 17:26:31 +01:00
Xavier J
78bba67995 Fix bug who does not saved Individual information 2016-12-21 15:39:41 +01:00
Xavier J
decde2ee6c Fix bug publish procedure with same path 2016-12-21 11:00:05 +01:00
JC
646fc37daf Adding feature tests for Accompagnateur, continue on page features, then on dossier show 2016-12-20 17:26:54 +01:00
Xavier J
90804c8a33 Add tests for individual information saving but TEST FAILED 2016-12-20 17:02:36 +01:00
Xavier J
927d977541 Add tests and validator for individual model. 2016-12-20 17:01:16 +01:00
Xavier J
e258118825 Reactive cartographie 2016-12-20 14:48:09 +01:00
Xavier J
db10c4023e Fix tests dossier creation for user 2016-12-20 12:37:22 +01:00
Xavier J
83444ab54c Catch error 500 for quartier prioritaire 2016-12-20 12:27:53 +01:00
JC
39a023b3e2 Features tests about user: index of dossiers, sorting and using pagination 2016-12-20 11:58:29 +01:00
Xavier J
d67d32e3c2 Fix bug get_position when établissement is nil 2016-12-20 11:35:16 +01:00
Xavier J
addeaab744 Review UI procedure construction for Administrateur 2016-12-19 19:07:57 +01:00
JC
04a8632bda Merge branch 'develop_v2' into develop 2016-12-19 17:17:10 +01:00
JC
691f061828 Features tests about user: create and edit dossier 2016-12-19 17:16:07 +01:00
Xavier J
f1ae1d8dea Change render « show » by redirect_to backoffice_dossier_path(id) in dossier controller POST action 2016-12-19 17:11:26 +01:00
Xavier J
d7569f3cb2 Add tests for file size validator 2016-12-19 15:43:55 +01:00
Xavier J
2fccbbf4f0 Delete un-use code 2016-12-19 15:08:00 +01:00
Xavier J
2f9444ea14 MAJ spec_helper 2016-12-19 12:04:04 +01:00
Xavier J
5ee455a36f Add real tests for search controller 2016-12-16 17:51:07 +01:00
Xavier J
5b8f0304f9 Add tests for Carto Geocodeur 2016-12-16 17:28:50 +01:00
Xavier J
ee82e7fa8a Add ProcedureController tests 2016-12-16 17:15:13 +01:00
Xavier J
24e0768961 Add tests for invites controller 2016-12-16 15:34:49 +01:00
Xavier J
7c20d1e9a0 Add tests for SearchController 2016-12-16 15:18:34 +01:00
Xavier J
f627957869 Add ChampDecorator tests 2016-12-16 14:40:20 +01:00
Xavier J
e85cb4c24b Delete features unified_login 2016-12-16 14:39:17 +01:00
Xavier J
d9dfff3b6a Refacto invite dossier facades 2016-12-16 14:09:05 +01:00
Xavier J
2aebf9933c Add tests for demo devise sessions 2016-12-16 10:59:16 +01:00
Xavier J
f21f151c9c Add test for GeoAPI driver lib 2016-12-16 10:42:34 +01:00
Xavier J
0aedeba125 Add QuartierPrioritaire test 2016-12-16 10:15:29 +01:00
Xavier J
21dc35215e Add test for DropDownList model 2016-12-16 10:07:40 +01:00
Xavier J
2ac0d2241f Fix dossier and invite dossier tests 2016-12-16 09:56:41 +01:00
Xavier J
fb16d4582d Delete un-user code in DossierDecorator 2016-12-16 09:43:59 +01:00
Xavier J
02ec901777 Add CommentaireDecorator test 2016-12-16 09:38:43 +01:00
Xavier J
a6ff698cf8 Base uploader tests 2016-12-16 09:25:19 +01:00
Xavier J
b03b02371f Add clamav tests 2016-12-16 09:12:16 +01:00
Xavier J
ea5ef257b8 Add tests for remote downloader 2016-12-15 17:59:25 +01:00
Xavier J
14df85d16d Change require for notification mailer spec 2016-12-15 17:59:01 +01:00
Xavier J
3dc26bd9aa Add InviteDossierFacade tests 2016-12-15 17:58:40 +01:00
Xavier J
067097825f Add Github tests 2016-12-15 16:48:39 +01:00
Xavier J
0f2013f002 Add tests for ProceduresDecorator 2016-12-15 16:27:47 +01:00
Xavier J
5e950c1a5f Add tests for FranceConnectInformationDecorator 2016-12-15 15:38:32 +01:00
Xavier J
73261a34c0 Add PingController tests 2016-12-15 15:31:05 +01:00
Xavier J
502f41657b Add DemoController tests 2016-12-15 15:28:35 +01:00
Xavier J
71bd708ffd CGU test 2016-12-15 15:19:28 +01:00
Xavier J
0a1a5613db Add tests for administration controller 2016-12-15 15:09:50 +01:00
Xavier J
c5917db28c Fix tests again 2016-12-14 18:53:40 +01:00
Xavier J
bc4e3860be Fix all tests 2016-12-14 18:41:33 +01:00
JC
4f7bcba8a3 Adding feature test for procedure_creation 2016-12-14 17:15:10 +01:00
JC
22a59123c1 Adding launchy to put save_and_open_page in capybara specs, fixing many red tests by removing/changing expectations according to new UI. Need to pursue on spec/features/backoffice/flux_de_commentaires_spec.rb (not priority), and spec/controllers/root_controller_spec.rb (unkonw) 2016-12-13 16:11:11 +01:00
Xavier J
1c2b2010d1 Synchronised password when user or gestionnaire change this 2016-12-07 17:35:45 +01:00
Xavier J
7cb2e80a3d Sync credentials between user, gestionnaire and administrateur account 2016-12-07 17:24:01 +01:00
Xavier J
715f086957 Can connect admin with user session path 2016-12-07 17:03:36 +01:00
Xavier J
3899991baf Fix spec services 2016-12-01 18:09:26 +01:00
Xavier J
402459437d Fix spec models 2016-12-01 18:07:51 +01:00
Xavier J
f96b87122b Fix controller spec 2016-12-01 18:05:49 +01:00
Xavier J
5c61733199 Display left panel only if layout file exist 2016-12-01 12:19:22 +01:00
Xavier J
eb75d9b337 Merge branch 'develop' into develop_v2 2016-11-25 10:49:28 +01:00
Xavier J
97c2be07ea Change wording submit and receive action 2016-11-25 10:46:08 +01:00
JC
5ba1c85ca7 Change spec according to layout rendering service 2016-11-22 16:30:35 +01:00
Xavier J
7faf1705da Add service RenderPartial 2016-11-22 15:17:37 +01:00
Xavier J
647eaa4ba8 Merge branch 'develop' into develop_v2 
# Conflicts:
#	Gemfile.lock
#	db/schema.rb
 2016-11-17 16:55:41 +01:00
Xavier J
d144047a50 Fix export data dossiers 2016-11-17 11:13:11 +01:00
Julien Portalier
8195a57f9c Fix: distinction des commentaires par champ 
Les commentaires par champ sont distincts des commentaires généraux
(non attachés à un champ). Ils ne faut donc pas les afficher dans
les commentaires sous le récapitulatif du dossier.
 2016-11-16 16:23:43 +01:00
Julien Portalier
96ca5113f7 Flux de commentaires par champs 2016-11-15 18:36:20 +01:00
Xavier J
305410f7a3 Fix Gemfile.lock and tests 2016-11-15 17:20:36 +01:00
Xavier J
b3b03a2449 Fix features tests 2016-11-15 11:01:58 +01:00
JC
0ac3c5fc86 Merging develop branch updated 2016-11-15 10:46:33 +01:00
JC
f1b177e0bb Testing only primary dossier attributes for data_with_champs methods 2016-11-15 10:19:47 +01:00
Xavier J
90cfd3eccb Fix Test spec/controllers/api/*.rb 2016-11-15 09:54:17 +01:00
Xavier J
fc289ba7b3 Remove useless spec 2016-11-15 06:02:49 +01:00
Xavier J
be62dea0e0 Fix major .DEPRECATION WARNING for spec/controllers/users/*.rb 2016-11-15 05:54:27 +01:00
Xavier J
cea85f2d49 Fix DEPRECATION WARNING for spec/controllers/users/dossiers/*.rb 2016-11-15 05:36:32 +01:00
Xavier J
5750eb1aa5 Fix major DEPRECATION WARNING for spec/controllers/admin/*.rb 2016-11-15 05:19:30 +01:00
Xavier J
7c74cbc54b Fix major DEPRECATION WARNING for spec/controllers/backoffice/*.rb 2016-11-15 04:50:18 +01:00
Xavier J
da3ef13522 Fix tests spec/controllers/france_connect/*.rb 2016-11-15 04:42:32 +01:00
Xavier J
15e1bef7e4 Fix DEPRECATION WARNING for spec/controllers/gestionnaires/*.rb 2016-11-15 04:29:05 +01:00
Xavier J
0fc81eb0da Fix DEPRECATION WARNING for spec/controllers/ban/*.rb 2016-11-15 04:26:25 +01:00
Xavier J
430d32dfca Fix DEPRECATION WARNING for spec/controllers/*.rb 2016-11-15 04:24:09 +01:00
Xavier J
d9a5eff21d Fix Views test. 2016-11-15 04:12:22 +01:00
Xavier J
a5a95abf06 Fix test for all Model 2016-11-14 18:36:09 +01:00
Xavier J
bd3df8de22 Fix Devise Helper Controller 2016-11-14 17:50:06 +01:00
JC
a549f95da1 Continue test for data_with_champs 2016-11-14 17:43:34 +01:00
JC
2f96895bb8 Continue tests for data_with_champs method, and add a convert_specific_values_to_string for array 2016-11-14 17:25:17 +01:00
JC
5c3049d6bd Manualy sort type_de_champ by order_place 2016-11-14 14:39:59 +01:00
JC
e49e0b02ef Split methods for export, need to write 2 tests for headers and raw data (export_headers, data_with_champs) 2016-11-14 10:41:56 +01:00
Xavier J
ec4b634f8a Change onglet presentation for gestionnaire. 2016-11-10 15:57:14 +01:00
JC
a89a40df34 Prevent call for headers writting (export with procedures), get filtered dossiers by using the 'yoloServiceRegexCraftedByHandMetaForAllProject' -> extra :), adding tests for generic methods, still need to test export_columns_and_procedure 2016-11-09 17:20:55 +01:00
JC
973570332f Implemented custom method to catch procedure_id while rendering data on each request format 2016-11-09 09:19:57 +01:00
XjulI1
9b9e2be8d8 Merge pull request #4 from sgmap/postgresql-full-text-search-2 
PostgreSQL full text search
 2016-11-08 15:17:57 +01:00
Xavier J
b44da7b43d Fix tests 2016-11-08 15:13:40 +01:00
JC
7b8b5e28e1 Adding tests, reading csv values for Dossier.to_csv, instead... checking String returned by to_ods, to_xlsx, checking encode and fields values for them would be overkill 2016-11-08 14:40:42 +01:00
JC
8dda0d3fb1 Okay... Add some conversion method to catch .ods write of number and boolean values -> as strings, passing on initial test for as_csv method 2016-11-08 11:48:36 +01:00
Xavier J
5284df5ce0 Add page « Procédure terminée » 2016-11-07 17:08:33 +01:00
Xavier J
2f68d540e3 Migrate to ruby 2.3.1 2016-11-07 11:23:21 +01:00
Julien Portalier
ce7e2c8a87 Rework searches to enable cross-table searches 
It allows to search for multiple terms in multiple tables at once.
 2016-11-04 15:41:42 +01:00
Julien Portalier
f9a5e5c5ff Drop textacular (to enable prefix matching) + disable materialized view (for the time being) + specs 2016-11-04 15:38:34 +01:00
Julien Portalier
0ea69cfc3e PostgreSQL full text search [WIP] 2016-11-04 15:34:21 +01:00
Xavier J
a08ded5322 Fix logo image_url 2016-11-03 17:29:59 +01:00
Xavier J
e10c218d3a Add dynamic logo (opensimplif) 2016-11-03 17:20:56 +01:00
Xavier J
68951c3a53 Add locales dynamics (opensimplif) 2016-11-03 16:46:26 +01:00
Xavier J
e596f71b07 Check if starter informations and autorisations_donnees is valid on description dossier page 2016-11-02 16:33:01 +01:00
Xavier J
1376372c9e Revert "Active degraded mode if insee is disabled" 
This reverts commit 6044c120c5.
 2016-11-01 22:56:58 +01:00
Xavier J
6044c120c5 Active degraded mode if insee is disabled 2016-10-30 22:59:57 +01:00
Xavier J
8fb76d1a6e Add type de champ Engagement 2016-10-27 13:43:10 +02:00
JC
c6f5a8b62d Adding button, method in controller, testing call 2016-10-25 17:39:53 +02:00
Xavier J
7f5d5c6320 Fix test OpenSimplif 2016-10-24 16:05:41 +02:00
Xavier J
a5ab7af0f8 Add private champs in tab preference list 2016-10-20 17:14:38 +02:00
Xavier J
a7166d306f Delete tab Nouveau A traiter and En cours d'étude for User and replace this only one call En construction 2016-10-19 17:25:24 +02:00
Xavier J
fd9eaa5a4d Escape apostrophizes char on filter 2016-10-19 15:10:12 +02:00
Xavier J
c2f014e59f Add "99 - Étranger" in Champ département. 2016-10-19 11:33:21 +02:00
Xavier J
6f40424979 Change wording "Valider le dossier" to "Déclarer complet" 2016-10-19 11:23:34 +02:00
Julien Portalier
101bd68252 Add opensimplif feature flip to hide user/gestionnaire tabs 2016-10-18 15:52:14 +02:00
Julien Portalier
86e6dd0233 Hide gestionnaire login link (unified login) 2016-10-18 15:52:14 +02:00
Julien Portalier
c8b7d0eeb3 Create user when creating gestionnaire (unified login) 2016-10-18 15:52:14 +02:00
Julien Portalier
fa762dbb39 Add unified_login feature flip 2016-10-18 15:52:14 +02:00
Julien Portalier
45e14d7a43 Sign associated user/gestionnaire in after password change 2016-10-18 14:25:16 +02:00
Julien Portalier
c2068d055d Sign user + gestionnaire in (OpenSimplif) 
Hacks into users/sessions to sign in and sign out a gestionnaire
and/or a user at the same time, as long as credentials are
identical (same email, same password).
 2016-10-18 14:25:16 +02:00
Julien Portalier
687f87e457 Sync user/gestionnaire credentials (OpenSimplif) 
Syncs email and password when either a gestionnaire or a user is
updated and it has an associated user or gestionnaire (same email).
 2016-10-18 14:25:16 +02:00
Xavier J
49e4d6a9d3 Gestionnaire can be filter on the specifics fields of the form when is on the folder list. 2016-10-14 12:02:39 +02:00
Xavier J
2edcd5a40d Fix test 2016-10-12 14:44:08 +02:00
Xavier J
fe6f6ebad3 Bug fix cookie for user 2016-10-11 18:05:49 +02:00
Xavier J
d5a85d17c7 Active feature "keep actual smart listing page" 2016-10-11 17:40:59 +02:00
Xavier J
64d46a25df Add PreferenceSmartListingPage table and implement the usage 2016-10-11 15:37:16 +02:00
Xavier J
2a2ccec373 Fix bug cookie not valid for back office gestionnaire 2016-10-07 16:01:32 +02:00
Xavier J
177295f6e4 Fix bug download CSV 2016-10-07 15:34:10 +02:00
Xavier J
ac971a805e Adapt search function at the PreferenceListDossier table 2016-10-07 14:58:45 +02:00
Xavier J
7c2bcd0b64 Fix bug and change the implementation to create new preference list column when new gestionnarire is affect on a procedure 2016-10-07 12:10:58 +02:00
Xavier J
71de64e3ec User can save a draft dossier who does not see by the accompagnateur 2016-10-05 16:45:51 +02:00
Xavier J
8160d4d0df User can be add siret when is procedure at the attribut individual and individual_with_siret 2016-10-05 14:28:10 +02:00
Xavier J
1ccf84dac2 Fix bug type_de_champ header section can be mandatory 2016-10-04 19:53:21 +02:00
Xavier J
52249f92b5 Add filter on gestionnaire dossier list 2016-10-04 19:19:03 +02:00
Xavier J
5ff37a270e Fix with migration bad table value for nil table attr 2016-09-27 17:53:46 +02:00
Xavier J
b3d454a53b Smart listing sorting is saved on dossier list 2016-09-27 17:26:49 +02:00
Xavier J
5fb678e53b Fix test 2016-09-16 17:18:29 +02:00
Xavier J
ccd9c0898d Fix test with cloud storage enabled 2016-09-16 15:40:30 +02:00
Xavier J
3014c4c539 Change word "Instruction" to "Examen" 2016-09-14 16:57:51 +02:00
Xavier J
0c9fea1c14 User can invite other user to edit his dossier 2016-09-14 16:36:01 +02:00
Xavier J
60b94fc41b Specialize Invite object 2016-09-13 15:54:26 +02:00
Xavier J
969e5f020a Fix bug clonage private fields 2016-09-09 17:39:56 +02:00
Xavier J
f6ab83f8bd gestionnaire can be filter be procedure on dossier list tab 2016-09-09 17:29:21 +02:00
Xavier J
c5035ca81e When gestionnaire follow an initiated dossier, this paste his state at 'updated' 2016-09-09 15:55:03 +02:00
Xavier J
955c984a88 Gestionnaire can add specific attr on dossier list by procedure 2016-09-09 15:05:46 +02:00
Xavier J
62a0b84048 Filter by procedure is activated on route /backoffice/dossiers/procedure/:id 2016-09-08 16:21:54 +02:00
Xavier J
b56883db16 Clone mail_templates where clone procedure 2016-09-01 10:43:49 +02:00
Xavier J
f03733f3ff Mail for receive dossier is now send. 2016-09-01 10:27:22 +02:00
Xavier J
12ebab66cc Administrateur can be param the acknowledgement of delivery mail object and body. 2016-08-31 16:07:11 +02:00
Xavier J
a69433e8de User can be begin without SIRET 2016-08-30 11:18:43 +02:00
Guillaume Lazzara
fc99dc65d6 Send notification emails when a dossier is closed. 2016-08-25 18:02:56 +02:00
Guillaume Lazzara
09236f32aa Add 'refuser' and 'classer sans suite' buttons 2016-08-25 17:46:26 +02:00
Guillaume Lazzara
0120ce2a32 Add an action to set a dossier as 'recu'. 2016-08-25 15:22:08 +02:00
Guillaume Lazzara
39df032c8c Translate type de champ values 2016-08-24 17:07:13 +02:00
Xavier J
5b0e01f117 delete filter procedure for gestionnaire 2016-08-22 16:36:25 +02:00
Xavier J
b661a2eb38 Updated test for new user status UI 2016-08-22 16:10:48 +02:00
Xavier J
0bb9f5115e Merge branch 'develop' of github.com:sgmap/tps into develop 2016-08-22 10:57:40 +02:00
Guillaume Lazzara
6cf6832c01 Migrate to Rails 4.2.7.1 2016-08-18 16:06:38 +02:00
Xavier J
6adfcac5bf Add new state on User UI. 
/!/ WARNING : No tests fix
 2016-08-12 13:56:10 +02:00
Xavier J
1a92382259 - Add new status for a dossier : received, refused and without_continuation 
- Add new and rename tabs on gestionnaire all dossiers view
/!\ WARNING : One test does not pasted. He will be corrected in the next commit
 2016-08-11 15:27:35 +02:00
Xavier J
85e7af840a Add drop down list on type champ list 2016-08-09 16:21:39 +02:00
Xavier J
9487d47ef8 Add deposit date time on dossier table 2016-08-08 14:12:16 +02:00
Xavier J
480431ea01 Add on gestionnaire dossier view the private form 2016-08-08 12:52:30 +02:00
Xavier J
ddb64878c8 Refactor code for private type de champ 2016-08-04 12:06:46 +02:00
Xavier J
116dd0d94f Administrateur can be define private champs => same as typical champs 2016-08-03 18:19:56 +02:00
Xavier J
bce1b96fee Build default pref list dossier for new gestionnaire 2016-08-02 14:49:41 +02:00
Xavier J
a37320bae9 Add lateral panel to configure dossier list in back office 2016-08-01 18:10:32 +02:00
Xavier J
f6d3e2d780 Fix test welcome mailer 2016-07-26 15:05:24 +02:00
Xavier J
21a18a536f Add total_commentaire in API Dossier and total_dossier on API Procedure 2016-07-22 15:06:30 +02:00
Xavier J
4e6d153893 Fix test 2016-07-22 12:25:23 +02:00
Xavier J
2ad816b6b3 Admin can be transfer a clone of a procédure at an other admin 2016-07-22 11:34:34 +02:00
Xavier J
6796ec26e8 Add suivi tab for gestionnaire 2016-07-19 17:18:41 +02:00
Xavier J
127c9bb138 Add total followers on dossier list and followers list on dossier page for gestionnaire 2016-07-19 16:44:26 +02:00
Xavier J
7d0bcfc35f Delete utilisation of "nom_projet" attribut (no delete in database) 2016-07-19 16:10:50 +02:00
Xavier J
d26ae9539d An accompagnateur can be mark a dossier follow by us 2016-07-18 18:24:29 +02:00
Xavier J
7281ee74b2 Fix bug double procedure path publish 2016-07-12 15:20:10 +02:00
Xavier J
9669fee7fe Add state attribut in API 2016-07-11 14:43:20 +02:00
Xavier J
721ea424ed Merge branch 'develop' of github.com:sgmap/tps into develop 
# Conflicts:
#	app/views/admin/procedures/_modal_publish.html.haml
 2016-06-30 14:17:33 +02:00
Xavier J
09c9d5ea76 async publication procedure 2016-06-30 12:33:43 +02:00
Guillaume Lazzara
582a368107 Code review related updates 2016-06-30 10:24:20 +02:00