Commit graph

8259 commits

Author SHA1 Message Date
Paul Chavard
33fc8a45ab feat(emails): show email errors on procedure page 2022-11-04 09:08:41 +00:00
Paul Chavard
ddd5eab4b1 feat(dsfr): improuve vertical card component 2022-11-04 09:08:41 +00:00
Paul Chavard
dd4c1f2fac feat(emails): validate tags in notification emails 2022-11-04 09:08:41 +00:00
Eric Leroy-Terquem
09c5b9dc99 remove categories_type_de_champ feature flag 2022-11-03 14:28:27 +01:00
Kara Diaby
4d6ff768c4 Ajoute les dossiers déposés dans les statistiques Datagouv 2022-11-03 10:24:04 +01:00
Martin
9562108c60 amelioration(archive.nom-de-fichier): ameliore le nom du fichier d'une archive mensuelle pour eviter les confusion 2022-11-02 16:56:50 +01:00
Martin
e56441b7f5 correctif(Administrateurs::Archives#index): mauvaise comparaison 2022-11-02 14:07:53 +01:00
Paul Chavard
5487ce0458 feat(graphql): implement stored queries 2022-11-02 11:26:57 +01:00
Paul Chavard
91a662fdb9 fix(graphql): make sure dossiers are always loaded with appropriate scope 2022-11-02 11:25:26 +01:00
Paul Chavard
2ed11308a8 feat(graphql): improuve reptition champs schema 2022-11-02 11:09:56 +01:00
Kara Diaby
6a6a9dc006 style css 2022-11-02 10:19:43 +01:00
Kara Diaby
583a08cd6e javascript 2022-11-02 10:19:43 +01:00
Kara Diaby
86afad6250 layout 2022-11-02 10:19:43 +01:00
Kara Diaby
661e5f78ac model 2022-11-02 10:19:43 +01:00
Kara Diaby
2bb7b6156b dashboard 2022-11-02 10:19:43 +01:00
Kara Diaby
329869b929 controllers 2022-11-02 10:19:43 +01:00
Paul Chavard
86a09dd24c fix(procedure): fix procedure cards grid view 2022-11-02 09:29:28 +01:00
Paul Chavard
e7766694d3 fix(messages): retry stale blobs 2022-11-02 09:19:51 +01:00
Paul Chavard
c9adfc3bfa fix(procedure): only set replaced_by if the procedure is effectively published 2022-11-01 15:53:58 +01:00
Martin
ef2064a603 nettoyage(Traitement): supprime une methode morte 2022-11-01 12:43:49 +01:00
Martin
1b1568b2c2 remaniement(Administrateurs::ArchivesController): ne passe pas par la table des traitement pour compter le nombre de dossier traites par mois. Depuis que nous avons redescendu la colonne processed_at sur la table dossiers, ce n'\est plus necessaire et le code est compliqué a comprendre 2022-11-01 12:43:49 +01:00
Martin
cb1726366f correctif(administrateur/procedure/archives#index): ne pas utiliser la table des traitement pour la comptabilisation du nombre de dossier dans une archive car si le dossier a ete accepte [mois n-1], repasse en instruction[mois-n1], accepte[mois-narchive], on se retrouve avec le dossier dans plusieurs archives et des compteurs confusant 2022-11-01 12:43:49 +01:00
simon lehericey
34abf45801 fix(css): overflow in instructeur affectation 2022-11-01 10:33:57 +01:00
simon lehericey
52b7886961 fix(clone): on procedure clone, discard integrity error 2022-11-01 10:17:24 +01:00
Paul Chavard
8cf9aec0f7 refactor(procedure): expose procedure tags on model 2022-10-31 19:50:25 +01:00
Paul Chavard
70a9a7b8bd chore(graphql): update 2022-10-31 19:20:40 +01:00
Christophe Robillard
de072c8b3d use optional chaining 2022-10-31 16:12:02 +01:00
Christophe Robillard
7441218c7f remove useless debug logs 2022-10-31 16:12:02 +01:00
Christophe Robillard
4308f1af26 improve readibility 2022-10-31 16:12:02 +01:00
Christophe Robillard
afcb811a8e correct haml and scss lints 2022-10-31 16:12:02 +01:00
Christophe Robillard
a5a93260cf reinit filters 2022-10-31 16:12:02 +01:00
Christophe Robillard
29be3812af i18n for status 2022-10-31 16:12:02 +01:00
Christophe Robillard
3890b24489 i18n for publication date 2022-10-31 16:12:02 +01:00
Christophe Robillard
619afbacad make selected zones removable 2022-10-31 16:12:02 +01:00
Christophe Robillard
e10e8f1024 autosubmit filter form 2022-10-31 16:12:02 +01:00
Christophe Robillard
0799c40aaa add pagination for all demarches view 2022-10-31 16:12:02 +01:00
Christophe Robillard
3f0279ac45 add main menu for admin procedures views 2022-10-31 16:12:02 +01:00
Christophe Robillard
22fe357d75 list all demarches, filtered by status 2022-10-31 16:12:02 +01:00
Christophe Robillard
9abf1c4af3 list all demarches, filtered by zones 2022-10-31 16:12:02 +01:00
Christophe Robillard
f9f31b721a get zones of an admin 2022-10-31 16:12:02 +01:00
Martin
60dc6a3912 correctif(export.global): Export.find_for_groupe_instructeurs remonte les exports globaux même lorsqu'il y a une procedure presentation 2022-10-31 14:32:17 +01:00
Paul Chavard
d20d9b8625 chore(manager): activate js 2022-10-31 14:06:26 +01:00
Colin Darie
3a06e7e0b3 refactor(tdc): convert fill duration in Duration objects 2022-10-31 12:17:16 +01:00
Colin Darie
010c9a0dcb feat(procedure): includes read duration of explication/non fillable champs
Long explications can significantly increase global fill duration,
so we can't ignore them.

Closes #7963
2022-10-31 12:17:16 +01:00
Colin Darie
7731c6ad64 feat(procedure): estimate fill duration takes account of libelle & description read time
Sometimes long description on types de champ
significantly increases global fill duration.

140 words per minute is a good estimate of attentive off-voice read time.
(This is independent of characters per word).

Closes #7963
2022-10-31 12:17:16 +01:00
Colin Darie
408f57d2d1 fix(rna): date_creation may be null
Closes #7975
2022-10-31 12:02:37 +01:00
Paul Chavard
2ed26e8699 fix(graphql): properly handle variables json parse errors 2022-10-31 11:32:30 +01:00
Paul Chavard
ac75afb77c fix(graphql): do not load brouillon or deleted linked dossier 2022-10-31 10:53:22 +01:00
Martin
5ced9fb431 chore(create_procedure_presentation): homogénéise l'interface sur les procédure présentation. pas d'objet 'build', sinon les export/filtres deviennent compliqués 2022-10-31 09:29:27 +01:00
Martin
50c43f4819 correct(export): la creation d'archive pour un groupe d'instructeur, avec des filtres differents et identique doit etre consistante 2022-10-31 09:29:27 +01:00
Paul Chavard
473a772032 feat(graphql): on api exceptions log query and variables 2022-10-28 12:18:21 +02:00
Colin Darie
9f2fa5ee1c fix(invitation): don't fail when dossier is hidden & user signed on another account
Suite de 45994ff567
Cf https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/events/e1c83ea74dbc410ea22aa17ef29fb329/?project=1429550
2022-10-28 08:56:03 +02:00
Martin
c7c46c9dff design(page de configuration de procedure): passage de la grille au DSFR 2022-10-27 14:00:44 +02:00
simon lehericey
4c98b8f01c fix(merge): ensure service transfert always works 2022-10-27 12:44:02 +02:00
simon lehericey
44aff1a293 fix(silent_error_in_merge): raise if merge update fail 2022-10-26 23:27:53 +02:00
Paul Chavard
7336a62637 refactor(rails/ujs): don’t use @rails/ujs in our own code 2022-10-26 23:06:10 +02:00
simon lehericey
43438f0018 fix(spec): use config debounce delay in editor
and 0 delay in spec
2022-10-26 22:38:33 +02:00
simon lehericey
59e68ab2c7 refactor(haml): swap - and = due to haml 6 2022-10-26 15:20:55 +02:00
simon lehericey
4e082d6424 fix(turbo morph): make the morph morph again 2022-10-26 15:20:55 +02:00
simon lehericey
baefd83f31 fix(editor): remove extra end 2022-10-25 16:32:25 +02:00
simon lehericey
6af4fe624a refactor(service): explicit call to service job to avoid test side effect 2022-10-25 14:44:43 +02:00
simon lehericey
cf592820c6 make linter happier 2022-10-25 14:44:43 +02:00
simon lehericey
dbb5b7deec clean(js): remove unused autosave:reset 2022-10-25 14:44:43 +02:00
simon lehericey
5cadb70d3a refactor(js): add 'debounced-empty' when there are no more debouncing call 2022-10-25 14:44:43 +02:00
simon lehericey
f4f40ded6c refactor(js): send 'autosave:end' when there are no more pending promises 2022-10-25 14:44:43 +02:00
Kara Diaby
476dd7e699 layout 2022-10-21 19:13:12 +02:00
Kara Diaby
cf8e6a9c67 controller 2022-10-21 19:13:12 +02:00
Kara Diaby
492c7f377f migration 2022-10-21 19:13:12 +02:00
Paul Chavard
f2e8dba8e4 fix(dossier): tag can contain non breaking space 2022-10-21 16:34:19 +02:00
Paul Chavard
d7c5dcf8bb fix(dossier): a tag can be preceded by a - 2022-10-21 16:06:32 +02:00
Paul Chavard
85581e72e9 refactor(turbo): simplify custom actions implementation now that turbo has support for it 2022-10-21 10:24:00 +02:00
Martin
527f416f52 amelioration(archives): documentation de la structure de l'archive
Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>
2022-10-20 16:40:53 +02:00
simon lehericey
097082afc9 fix(dolist): reduce message name variability 2022-10-20 15:29:56 +02:00
Martin
2cd74d1010 amelioration(archives): positionne le fichier des reporting des erreurs en tête de l'arborescence 2022-10-20 15:14:57 +02:00
Martin
d46efeef85 amelioration(export): clarifier l'usage des exports pour les instructeurs pour eviter le téléchargement des export zip pour de l'archivage 2022-10-20 14:50:48 +02:00
Colin Darie
5b813a25d6 fix(dsfr/callout): don't nest p, it's already declared by component 2022-10-20 09:18:16 +02:00
Colin Darie
e96d307e56 style(admin): auto expiration styled with DSFR callout 2022-10-20 09:18:16 +02:00
Colin Darie
f5a0842c6e style(dsfr): callout component with support for a bottom section like buttons 2022-10-20 09:18:16 +02:00
Colin Darie
7f28f1fe4c fix(conjugaison): après que + indicatif 2022-10-20 09:18:16 +02:00
Colin Darie
45994ff567 fix(invitation): when dossier is not visible anymore
https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/
2022-10-20 09:08:36 +02:00
Paul Chavard
74aa01479b fix(revision): fix changes list style 2022-10-20 06:56:20 +02:00
Martin
576aa2c1e0 amelioration(export): augment la duree de conservation des exports en cours de generation passant de 12 a 16h. augment la duree de conservation des exports generés passant de 16 à 32h 2022-10-20 06:32:41 +02:00
simon lehericey
5fa5d46d8c fix(admin_merge): a case where 2 admins have the same service 2022-10-19 16:54:34 +02:00
Paul Chavard
5be8810da4 fix(dossier): nullify instructeur and expert id on messages when they are deleted
we keep email on the message so it will be used when instructeur or expert are not available
2022-10-19 11:53:10 +02:00
simon lehericey
c6e7db3622 fix(export): bug when combining revision and conditional 2022-10-18 11:53:13 +02:00
simon lehericey
fbf089d60e refactor(dossier): rename check_mandatory_champs -> check_mandatory_and_visible_champs 2022-10-18 11:13:41 +02:00
simon lehericey
9bba2093be refactor(champ): mandatory_blank_and_visible? -> mandatory_blank?
As the method does not check visibility
2022-10-18 11:13:41 +02:00
simon lehericey
6832b12bd4 clean(haml): remove commented code 2022-10-18 11:13:41 +02:00
simon lehericey
7114623285 fix(champ): rewire champ.mandatory? to type_de_champ.mandatory?
it fixes behaviour in drop_down_list_component which add option if not mandatory (!= not required)
2022-10-18 11:13:41 +02:00
simon lehericey
528b7ec3f8 refactor(champ): add required?
used for the `required` html attribute. It check visibility to avoid hidden required input which prevent the form from being sent.
2022-10-18 11:13:41 +02:00
simon lehericey
dc89ddb639 fix(translation): typo in footer 2022-10-17 22:47:42 +02:00
Martin
6000de2095 feat(manager/outdated_procedure): enhance procedure cleanup 2022-10-17 13:35:37 +02:00
Paul Chavard
736e0b0731 fix(routage): fill dossier groupe instructeur in some edge cases 2022-10-14 17:29:56 +02:00
Paul Chavard
c075a4e415 fix(dossier): we should never detroy user’s dossiers in cascade 2022-10-14 14:14:51 +02:00
Paul Chavard
c097f70543 fix(graphql): hide champs based on conditions 2022-10-14 11:33:25 +02:00
simon lehericey
d5d031e15d fix(export): do not export invisible champ 2022-10-14 10:30:27 +02:00
simon lehericey
40a3fff593 perf(dossiers_controller): do not load pj template in update, -10ms 2022-10-13 22:36:56 +02:00
simon lehericey
f8ee6386b9 perf(champ): check condition.present? without json deserializationl, -6ms 2022-10-13 22:36:56 +02:00
simon lehericey
73b4ee64e6 perf(champ_value): use champ_type instead of tdc.type_champ, -22ms 2022-10-13 22:36:56 +02:00
Eric Leroy-Terquem
c6082ded09 no select for usager if only one groupe_instructeur 2022-10-13 19:49:32 +02:00
Martin
d09c47f5ce correctif(usager.fusion): leve une erreur quand on essaie de fusionner un compte sur lui même 2022-10-13 17:00:20 +02:00
Paul Chavard
25c774b3a1 refactor(dossier): extract dossier edit footer into a component 2022-10-13 14:44:46 +02:00
Paul Chavard
d409b6f4ef feat(dossier): do not save dossier on submit 2022-10-13 14:44:46 +02:00
Paul Chavard
78a1323fc2 refactor(dossier): move dossier submit action in to a new form 2022-10-13 14:44:46 +02:00
Paul Chavard
dd38fa4458 refactor(spec): add wait_for_autosave helper 2022-10-13 14:44:46 +02:00
Colin Darie
e2e9ddd625 style(conditionnel): dsfr button styles 2022-10-13 10:17:21 +02:00
Colin Darie
8153f33896 style(repetition): fix button styles 2022-10-13 10:17:21 +02:00
Colin Darie
9571e9481d style(avis): fix font sizes & colors due to h2 strongly styled 2022-10-12 14:41:31 +02:00
Paul Chavard
1fd1878370 feat(jobs): add request_id to jobs payload 2022-10-12 14:32:23 +02:00
Paul Chavard
7f1dd49bdc chore(flipper): always use feature_enabled? helper 2022-10-12 14:14:30 +02:00
Paul Chavard
0f192fd752 chore(flipper): add feature_enabled? to components 2022-10-12 14:14:30 +02:00
Damien Le Thiec
29a97fac43
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-11 18:59:45 +02:00
Damien Le Thiec
0e995c8bcc
Update app/models/champs/rna_champ.rb
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2022-10-11 16:34:00 +02:00
simon lehericey
7672ad3fe9 fix(editor champ): do not raise on destroy replay 2022-10-11 16:27:49 +02:00
Damien Le Thiec
73f6063c87
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-11 15:36:46 +02:00
Damien Le Thiec
2e8c0512a5 Remove skip_cleanup option 2022-10-11 15:11:51 +02:00
Colin Darie
073656342e fix(api_address): support Adresse BAN without postcode
Des adresses n'ont pas de code postal (dans certains TOM par exemple).
On fallback sur un string vide plutôt que nil pour limiter les effets de bord.
2022-10-11 12:25:12 +02:00
Damien Le Thiec
bcdc9c18ae Remove skip_fetch_data mechanism 2022-10-11 11:52:59 +02:00
simon lehericey
97529ab6af refactor(user dossier): move ruby logic to controller 2022-10-11 11:39:05 +02:00
simon lehericey
32e01b13ef refactor(user dossier): mutualize update/update_brouillon 2022-10-11 11:39:05 +02:00
simon lehericey
437ac44143 perf(user dossier): batch hide/show element finding 2022-10-11 11:39:05 +02:00
Paul Chavard
a19bf050ef fix(iban): format iban after validation 2022-10-11 10:43:32 +02:00
Colin Darie
a9f2bec636 style(css): add deprecation rules and TODO
Co-authored-by: mfo <mfo@users.noreply.github.com>
2022-10-11 09:50:21 +02:00
Colin Darie
59b9ae5c46 TODO: deprecate CSS containers
Co-authored-by: mfo <mfo@users.noreply.github.com>
2022-10-11 09:50:21 +02:00
Colin Darie
03de58c7e2 fix: download link with empty value, otherwise it could be used to name the file 2022-10-11 09:50:21 +02:00
Colin Darie
df672fb493 fix(footer): etalab link with rel=noopener 2022-10-11 09:50:21 +02:00
Colin Darie
d821a3e40c style(new_session): fix buttons style 2022-10-11 09:50:21 +02:00
Colin Darie
9992ab9e09 style(admin): new procedure btn styles 2022-10-11 09:50:21 +02:00
Colin Darie
3e8f040d49 style(usager/dossier): fix summary actions style 2022-10-11 09:50:21 +02:00
Colin Darie
10802d15cc style(instructeur/procedure): re-style header procedure title & dossier number 2022-10-11 09:50:21 +02:00
Colin Darie
c5092fda12 style(expert): fix avis weight/font-size 2022-10-11 09:50:21 +02:00
Colin Darie
df1d7ae2bd style(procedures): dsfr compat instructeurs/expert procedures list 2022-10-11 09:50:21 +02:00
Colin Darie
0480a0336d fix(scss): lint errors 2022-10-11 09:50:21 +02:00
Colin Darie
fa9bc5d185 style(admin): multiple style improvements, essentially links & buttons 2022-10-11 09:50:21 +02:00
Colin Darie
0a2460ba71 style(admin): fix various links / buttons style 2022-10-11 09:50:21 +02:00
Colin Darie
fd3b30d8e6 style(messagerie): improve font-size & styles 2022-10-11 09:50:21 +02:00
Colin Darie
278b58ef78 style(instructeurs): restyle dossier actions 2022-10-11 09:50:21 +02:00
Colin Darie
0e1077487a style(autosave): better font-size & link style 2022-10-11 09:50:21 +02:00
Colin Darie
2ab5fbbb24 style(link): use DSFR underline style everywhere possible.
Par conséquent on commence à remplacer d'anciens "liens-boutons" (qui
auraient récupéré un souligné indésirable), par un vrai boutton dsfr.

Le hack fr-underlined n'est aussi plus nécessaire.
2022-10-11 09:50:21 +02:00
Colin Darie
555c796d19 style(forms): increase forms elements font-size to legacy value & fieldset style 2022-10-11 09:50:21 +02:00
Colin Darie
71996af65b style(avis): use fr-badge for count instead of broken css 2022-10-11 09:50:21 +02:00
Colin Darie
7dd3a42cd7 fix(style): tabs 2022-10-11 09:50:21 +02:00
Colin Darie
72e79eb2d3 fix(css): don't duplicate font declarations from DSFR.
This may cause issues in exact font height computation & underline effect.
2022-10-11 09:50:21 +02:00
Colin Darie
aea2733be1 refactor(css): more landing + new_footer cleanup 2022-10-11 09:50:21 +02:00
Colin Darie
be367503cf fix(footer): add missing title attribute on a 2022-10-11 09:50:21 +02:00
Colin Darie
8bd36921e0 style(footer): drop useless br since we now have a default margin-bottom on p 2022-10-11 09:50:21 +02:00
Colin Darie
10917af523 style: signin button styled accordingly to UX 2022-10-11 09:50:21 +02:00
Colin Darie
5c36c2e317 style(landing): update after reset CSS drop 2022-10-11 09:50:21 +02:00
Colin Darie
08c207e0e4 refactor(scss): remove legacy reset + generic rules, refactor imports 2022-10-11 09:50:21 +02:00
Colin Darie
5a50383a27 style: download links (notice & template) with expected DSFR design & details
Closes #7829
2022-10-11 09:50:21 +02:00