DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
14439 commits 2 branches 1166 tags 85 MiB
Commit graph

14439 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pierre de La Morinerie
27d80153ce
Merge pull request #6905 from adullact/feature/6863-rubocop-rspec-focused 
Remplacement de la gem `rubocop-rspec-focused` dépréciée
 2022-02-08 13:11:17 +01:00
François Vantomme
bebc78b587
chore(rubocop): replace deprecated rspec-focused by rubocop-rspec 
WARNING: We are no longer maintaining this gem, and will eventually
archive this repo. We recommend you use rubocop-rspec instead.

https://github.com/CarooDev/rubocop-rspec-focused
 2022-02-08 12:50:18 +01:00
Pierre de La Morinerie
a3a2bab89b
Merge pull request #6821 from betagouv/improve-email-balancing 
Amélioration de la configuration des fournisseurs d'email
 2022-02-08 12:49:09 +01:00
Pierre de La Morinerie
847abca122 config: simplify mailer configuration again 
Move everything to initializers, and replace the email settings
interceptor by a BalancerDeliveryMethod.

It has the advantage that it can be configured entirely from the
`config/environment.rb` file, without an extra file to look at.
 2022-02-08 12:44:43 +01:00
Pierre de La Morinerie
27b42fe8ae config: better document SENDINBLUE_BALANCING 2022-02-08 12:44:43 +01:00
Pierre de La Morinerie
04cfc8ed9d config: use alternate delivery methods to configure ActionMailer 
Previously `SENDINBLUE_BALANCING` was used only when
`SENDINBLUE_ENABLED` was *disabled* (otherwise only SendInBlue was ever
used).

This commit:

- Ensure that `SENDINBLUE_BALANCING` is used only when SendInBlue is
  *enabled* (which is more intuitive).
- Make it easier to add other delivery methods.
 2022-02-08 12:44:43 +01:00
Pierre de La Morinerie
d3603cf3c5
Merge pull request #6908 from adullact/feature/6866-rubocop-deps-cleanup 
Nettoyage des dépendances de Rubocop
 2022-02-08 12:39:28 +01:00
François Vantomme
2bdf58cb79 style(rubocop): fix Layout/SpaceInsideBlockBraces offense 2022-02-08 12:35:08 +01:00
François Vantomme
f3bf0499b6 chore(rubocop): cleanup dependencies 
Using rubocop-rails_config is a nonsense because:
  - it relies on rubocop-minitest which is useless here (we use RSpec)
  - it relies on rubocop-packaging but disables all its cops
  - it targets ruby version 2.7, but we use 3.0
 2022-02-08 12:35:08 +01:00
Paul Chavard
ad545771b7
Merge pull request #6918 from adullact/feature/6875-improve-landing-contrast 
Amélioration du contraste de la landing page administration
 2022-02-08 12:30:18 +01:00
Paul Chavard
e87e8b2c26
Merge pull request #6899 from adullact/feature/6857-no-sandbox 
ETQ développeur, je voudrais pouvoir influer sur l'option --no-sandbox du pilote Selenium Chrome lors des tests
 2022-02-08 12:29:51 +01:00
Paul Chavard
537112acee
Merge pull request #6926 from adullact/fix/6884-afterparty-rename-conservation-extension 
[AfterParty] échec de la tâche 20210429172327_rename_conservation_extension
 2022-02-08 12:00:50 +01:00
LeSim
fe9adf061c
Merge pull request #6916 from adullact/feature/6873-dinum-vars 
Déplacer toutes les mentions à la DINUM dans des variables
 2022-02-08 11:58:05 +01:00
Paul Chavard
e9f0df0472
Merge pull request #6930 from adullact/fix/6888-uniq-deployment-task-names 
Unicité du nom des tâches de déploiement
 2022-02-08 11:57:11 +01:00
Paul Chavard
7705fdd164
Merge pull request #6909 from adullact/feature/6867-rubocop-sort-cops 
Tri alphabétique des règles Rubocop
 2022-02-08 11:54:10 +01:00
Paul Chavard
dad17ec2f8
Merge pull request #6906 from adullact/fix/6864-franceconnect-application-name 
[FranceConnect] les tests échouent quand la variable d'env APPLICATION_NAME a une autre valeur que celle par défaut
 2022-02-08 11:53:16 +01:00
Paul Chavard
5b147e6d81
Merge pull request #6903 from adullact/fix/6861-feature-test-emails 
Les feature tests touchant aux emails échouent de manière aléatoire
 2022-02-08 11:52:28 +01:00
Paul Chavard
2773e065ed
Merge pull request #6907 from adullact/fix/6865-instructeur-random-test 
Des tests sur les instructeurs échouent aléatoirement
 2022-02-08 11:45:36 +01:00
LeSim
fdc4e5bfbc
Merge pull request #6928 from adullact/feature/6886-watermark-url 
Watermark depuis une URL distante
 2022-02-08 11:45:26 +01:00
Pierre de La Morinerie
d7924dc7c8
Merge pull request #6852 from betagouv/improve-stats 
Amélioration visuelle de l'affichage du temps de traitement habituel
 2022-02-08 11:44:27 +01:00
Pierre de La Morinerie
9a3109d960 stylesheet: add space between big number cards elements 2022-02-08 11:43:32 +01:00
Pierre de La Morinerie
dd49abc672 stats: fix duplicated word 
The message would be formatted as:

> in 7 days days.
 2022-02-08 11:43:32 +01:00
Paul Chavard
8e237208b3
Merge pull request #6939 from betagouv/ignore-gitguardian-for-test-secrets 
Ignore les avertissements GitGuardian de fuite de secrets de test
 2022-02-08 11:43:06 +01:00
Pierre de La Morinerie
b2ae79a99b config: ignore gitguardian warnings for test keys 
Tell GitGuardian not to report our fake testing secrets as leaks.
 2022-02-08 11:31:07 +01:00
Paul Chavard
d11b457838
Merge pull request #6892 from tchak/fix-admin-for-a-day 
fix(manager): remove admins added for a day
 2022-02-08 11:25:21 +01:00
Paul Chavard
0268511264 fix(manager): remove admins added for a day 
fix #6855
 2022-02-08 11:18:44 +01:00
Paul Chavard
f0de64a787
Merge pull request #6919 from adullact/feature/6877-footer-rendering 
Amélioration du rendu du footer
 2022-02-08 11:18:29 +01:00
François Vantomme
eba9a87123
refactor(API Entreprise): raise an error on blank token 2022-02-07 15:18:16 +01:00
François Vantomme
eea3087ef0
fix(task): deal nicely with dropped instructeur_id column on avis table 2022-02-04 19:12:28 +01:00
François Vantomme
efe0b307a1
fix(task): reword duplicated task name 2022-02-04 18:59:56 +01:00
Jon
88d3a6e4c3
feat: can have remote watemark file 2022-02-04 18:55:16 +01:00
François Vantomme
feabae75c6
fix(task): temporary bypass ignored en_construction_conservation_extension column on Dossier 2022-02-04 18:51:29 +01:00
François Vantomme
ab06ec2887
fix(task): deal nicely with dropped tmp_expert_migrated column on avis table 2022-02-04 18:46:16 +01:00
François Vantomme
1f64d45ba4
refactor(footer): improve provided by rendering 2022-02-04 18:30:26 +01:00
François Vantomme
62562ff7a5
feat(landing): improve CTA rendering 2022-02-04 18:26:04 +01:00
François Vantomme
51cfd3d7ad
feat(env): add env variables for the provider data 2022-02-04 18:20:06 +01:00
François Vantomme
370664bae7
style(rubocop): reorder cops alphabetically 2022-02-04 17:44:02 +01:00
François Vantomme
dacc1dca68
fix(groupe instructeur): avoid false-negative tests due to array ordering 2022-02-04 17:43:08 +01:00
François Vantomme
27ccf6bbdd
fix(france connect): stub application name in tests 2022-02-04 17:42:02 +01:00
François Vantomme
9ff7fa73e4
Fix (Expert): clear emails before feature tests 
Failures:

  1) Inviting an expert: as an Instructeur I can invite an expert
     Failure/Error: invitation_email = open_email(expert.email.to_s)

Diff:
  -/procedures/2/avis/2/sign_up/email/expert1@expert.com
  +/procedures/1/avis/1/sign_up/email/expert1@expert.com
 2022-02-04 17:40:03 +01:00
François Vantomme
2032eb8144
Test (Capybara): add no-sandbox option to headless chrome driver 
Activating this option fix the 'DevToolsActivePort file doesn't exist'
error.

https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t
 2022-02-04 17:34:10 +01:00
Kara Diaby
299a98b3cb
Merge pull request #6894 from betagouv/fix-research-hidden-dossier 
Instructeur : le dossier supprimé dans la recherche n'est pas cliquable
 2022-02-04 09:43:50 +01:00
Kara Diaby
5d10158fa6 Instructeur : ne peut plus cliquer sur un dossier supprimé dans la recherche 2022-02-03 11:17:39 +01:00
krichtof
c63a8c83e9
Merge pull request #6827 from betagouv/6788-a11y-demande 
fix a11y-8.9.1
 2022-02-02 19:22:24 +01:00
Christophe Robillard
b80ec84552 fix a11y-8.9.1 for attachement description error 2022-02-02 19:03:40 +01:00
Christophe Robillard
447612abdf fix a11y-8.9.1 
no p tag when Champ text with no value
 2022-02-02 19:03:40 +01:00
Pierre de La Morinerie
1f219de931
Merge pull request #6851 from betagouv/fix-stats-ordering 
Correction de l'ordre des mois sur la page des statistiques
 2022-02-02 17:27:19 +01:00
Pierre de La Morinerie
e6cf07b810 stats: move date formatting out of the Stat model 
Before this commit, the monthly dossiers count was serialized into the
Stat record using human-formatted dates, as:

```ruby
s.dossiers_in_the_last_4_months = {
  "octobre 2021"=>409592,
  "novembre 2021"=>497823,
  "décembre 2021"=>38170,
  "janvier 2022"=>0
}
```

Turns out the ordering of keys in a serialized hash is not guaranteed.
After a round-trip to the database, the keys will be wrongly sorted.

Instead we want to save raw Date objects, which will preserve the
ordering. The date formatting can be applied at display-time by the
controller.

Fix #6848
 2022-02-02 14:13:53 +01:00
Kara Diaby
7c4bb4d1cf
Merge pull request #6853 from betagouv/fix-research-2 
Instructeurs : corrige la recherche cassée dans la précédente release
 2022-02-02 09:47:30 +01:00
Kara Diaby
81249aa798 Instructeurs : fixe la recherche cassée dans la précédente release 2022-02-02 09:33:28 +01:00