Paul Chavard
b516cbc179
Enable republish on démarches dépubliée
2020-04-29 18:04:35 +02:00
Pierre de La Morinerie
4cb747fdb6
specs: always require rails_helper
...
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.
The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.
This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.
Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).
Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.
To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.
Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Paul Chavard
7b947feae4
Rename demarche archivée to demarche close
2019-11-28 15:07:16 +01:00
Pierre de La Morinerie
a462edb9bc
instructeurs: alias instructeur.email
...
This also means we need to replace instances of `pluck` on the email
column.
2019-11-04 10:44:24 +01:00
Nicolas Bouilleaud
72b7ff221c
move procedure to new design
2019-10-31 10:27:19 +01:00
Nicolas Bouilleaud
543f9894c1
Make sure the “commencer” link uses the proper test path
2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
c26a701a17
Refactor and redesign publish modal
...
* remove the autocomplete menu
* use ujs to pre-validate the procedure
* tweak the UI
2019-09-17 16:30:48 +02:00
simon lehericey
a2061fba79
wording
2019-09-02 11:41:12 +02:00
simon lehericey
caf1fbca44
Use assign_to
2019-09-02 11:41:12 +02:00
simon lehericey
b541ef0b41
Procedure has many instructeurs with defaut_groupe_instructeur
2019-09-02 11:41:12 +02:00
simon lehericey
65a53909e1
Update instructeur factory
2019-08-13 15:15:16 +02:00
simon lehericey
3fde2a6f70
Rename gestionnaire in code to instructeur
2019-08-12 13:47:01 +02:00
simon lehericey
6902f84b85
Brutally rename gestionnaire filename to instructeur
2019-08-12 13:47:01 +02:00
simon lehericey
bb8d65c6b4
Subtly rename admin/instructeurs to admin/assigns
2019-08-12 13:47:01 +02:00
Pierre de La Morinerie
0c4cb3b498
admin: remove UI for managing old pj
2019-07-30 16:11:16 +02:00
clemkeirua
314b0f5dc0
fix tests
2019-07-25 17:15:19 +02:00
Paul Chavard
3446782cd0
Remove deprecated editor
2019-05-14 16:18:29 +02:00
Mathieu Magnin
14c3fb7224
[ Fix #3064 ] Add a preview button for state notifications emails
2019-04-11 11:03:13 +02:00
Paul Chavard
c37f649453
Update specs to use multiple administrateurs
2019-03-12 11:59:01 +01:00
Mathieu Magnin
44f28ec565
Remove feature flag for publish draft
2019-03-12 11:26:07 +01:00
Mathieu Magnin
0e6b5678ad
Fix tests
2019-01-17 14:04:59 +01:00
simon lehericey
e7d5f30192
Admin: small reword in admin procedure ui
2019-01-09 16:25:00 +01:00
gregoirenovel
9466442aff
Remove the TypeDeChamp decorators
2019-01-03 12:08:25 +01:00
Paul Chavard
a7de2e68ed
Refactor types_de_champ views to use service instead of facade
2018-11-07 11:36:10 +01:00
Paul Chavard
725e88a89a
Rename :procedure_path -> :path
2018-10-30 12:01:45 +01:00
gregoirenovel
baf69acbcb
[ Fix #2833 ] Move /support files to /fixtures
2018-10-16 10:47:41 +02:00
simon lehericey
88f7e888c3
Administrateur: do not save api_token in clear text anymore
2018-09-27 10:24:56 +02:00
simon lehericey
17285b0368
Profil: display token only once
2018-09-27 10:14:32 +02:00
gregoirenovel
00ecae5f93
Procédure → Démarche
2018-09-05 15:46:24 +02:00
gregoirenovel
3662b82039
accompagnateur → instructeur
2018-08-29 23:09:08 +02:00
gregoirenovel
6b1ab9b552
Remove a now useless facade
2018-08-28 15:38:39 +02:00
Paul Chavard
b57c22cafe
Refactor publish dialog
2018-08-14 16:39:11 +02:00
Frederic Merizen
521aec6af9
[ #1568 ] Remove old previsualisation code
2018-06-19 12:42:46 +02:00
Paul Chavard
7070b0aba0
Fix tests to rely on aasm states
2018-05-23 16:31:27 +02:00
Frederic Merizen
a2ffc4357d
[ #1563 ] Generate a helpful alert on attestation / closed mail mismatch
2018-04-06 10:18:56 +02:00
gregoirenovel
93d8470321
Put the piece justificative champ behind a feature flag
2018-02-15 12:04:03 +01:00
Paul Chavard
0c1d529b61
Unify :type_de_champ public/private factories
2018-02-14 11:49:06 +01:00
Frederic Merizen
9afdb4c2c4
Simplify factory girl configuration for mail templates
2018-01-09 16:24:00 +01:00
Frederic Merizen
63ca52792b
[ #1110 ] Remove legacy tags
2018-01-09 10:39:10 +01:00
Frederic Merizen
deea23139f
[ #1110 ] Use TagsSubstitutionConcern as engine for mail template tags
2018-01-05 17:42:25 +01:00
LeSim
56545933a9
[ fix #504 ] Dossier: initiated -> en_construction
...
The change must not impact the api
2017-12-15 11:52:09 +01:00
gregoirenovel
bb10e13e2f
[Ref #145 ] Don't use Procedure.archived anymore
2017-07-11 15:03:35 +02:00
gregoirenovel
d248afc376
Enable the Layout/ExtraSpacing cop
2017-06-13 10:35:35 +02:00
gregoirenovel
f1907f4d0e
Enable the Layout/EmptyLinesAroundBlockBody cop
2017-06-13 10:35:23 +02:00
gregoirenovel
9439e1abb1
Enable the Layout/AlignParameters cop
2017-06-13 10:35:16 +02:00
Mathieu Magnin
c52a979199
Fix email collision in tests
2017-06-01 18:11:56 +02:00
gregoirenovel
d5e7bbd80d
Files should end with a new line
2017-04-04 16:59:38 +02:00
Mathieu Magnin
4112af6c93
Fix tests
2017-03-20 13:48:42 +01:00
Simon Lehericey
fb2aef1810
Explication: style in edit page
2017-03-14 13:58:59 +01:00
Mathieu Magnin
b2198663d1
Fix test : procedure link is not hidden if archived
2017-02-21 12:20:18 +01:00
