DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
10004 commits 4 branches 1166 tags 84 MiB
Commit graph

10004 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pierre de La Morinerie
c633cd0888 javascript: improve Sentry grouping of direct upload errors 
DirectUpload returns errors as strings, including an HTTP status and a
file name (and without a stack trace).

But Sentry groups issues according to the stack trace, and maybe the
error message in last resort.

So we have an issue: as all DirectUpload errors logged by Sentry are
generated on the same line, with random-looking messages, Sentry groups
them either too or too little aggressively.

Instead of creating all the errors on the same line:

- add some `if`s statements to create them on different lines (and so
  with different stack traces),
- strip the file name from the error message.

This allows Sentry to group the errors properly, with meaningful error
messages.
 2020-04-09 17:38:44 +02:00
Pierre de La Morinerie
499808a384 javascript: upgrade @sentry/browser to 5.15.4 2020-04-09 17:38:44 +02:00
krichtof
8dc0814727
Merge pull request #5029 from betagouv/5015-recevoir-notif-apres-depot 
5015: Les instructeurs qui le souhaitent reçoivent notif par mail après chaque dépôt de dossier
 2020-04-09 17:25:15 +02:00
Christophe Robillard
f683b850c3 Notifie instructeurs le souhaitant lors depot dossier 
Notifie par mail uniquement les instructeurs qui le souhaitent à chaque dépôt de dossier
 2020-04-09 15:02:05 +02:00
Christophe Robillard
ae18ff6627 Notifie tous les instructeurs lors dépôt dossier 
- envoie un mail à tous les instructeurs d'une procédure après le dépôt
d'un nouveau dossier
 2020-04-09 14:33:56 +02:00
krichtof
f618ab5ba2
Merge pull request #4985 from betagouv/4966-envoyer-notif-lors-commentaire 
4966: Les instructeurs le souhaitant sont notifiés à chaque nouveau commentaire sur les dossiers qu'ils suivent
 2020-04-09 14:25:13 +02:00
Christophe Robillard
3ece41a614 homogénéise les majuscules en début de phrase 2020-04-09 14:17:07 +02:00
Christophe Robillard
969478b706 Envoie une notif aux followers_instructeurs le souhaitant 
après chaque message déposé par l'usager
 2020-04-09 14:17:07 +02:00
Christophe Robillard
415d5c765e envoie une notification à chaque follower_instructeur après un commentaire déposé 2020-04-09 14:17:07 +02:00
Keirua
6d5709dbf5
Merge pull request #5027 from tchak/fix-procedure-can-be-deleted 
Fix procedure.can_be_deleted_by_administrateur? check
 2020-04-09 14:03:52 +02:00
Paul Chavard
c83aaf69a6 Fix procedure.can_be_deleted_by_administrateur? check 2020-04-09 13:46:57 +02:00
Paul Chavard
b022a26db5
Merge pull request #5026 from betagouv/js-return-true-errors 
javascript: make DirectUpload errors return true error objects
 2020-04-09 13:09:19 +02:00
Pierre de La Morinerie
bc1c15b81d javascript: make DirectUpload errors return true error objects 
DirectUpload errors are string (instead of error objects). But Sentry
works better if we have true errors, which include the stacktrace.
 2020-04-09 12:50:47 +02:00
Paul Chavard
1c0fecc3ce
Merge pull request #4984 from tchak/process-expired-dossiers-en_construction 
Process expired dossiers en construction
 2020-04-09 11:33:00 +02:00
Paul Chavard
afc76f3066 Only run process expired dossiers task on production servers 2020-04-09 11:19:58 +02:00
Paul Chavard
d810fdf474 Process expired dossiers en construction 2020-04-09 11:19:58 +02:00
Paul Chavard
c24f0b6b0e
Merge pull request #4975 from tchak/remove-legacy-expiration-email 
remove WarnExpiringDossiersJob
 2020-04-09 11:19:16 +02:00
Paul Chavard
61eaca928f remove WarnExpiringDossiersJob 2020-04-09 11:11:51 +02:00
Paul Chavard
f97cf89b43
Merge pull request #5010 from betagouv/activation-mapbox 
Migrate mapReader to mapbox-gl with react
 2020-04-09 11:11:26 +02:00
kara Diaby
d18bc1c421 Improve the mapbox-gl support detection for older browsers 2020-04-09 11:01:20 +02:00
kara Diaby
56e9834389 Revert "Revert "Revert "Revert "feat/4893 - migrate the mapReader to mapbox-gl with react"""" 
This reverts commit 473ed00b6c.
 2020-04-09 11:01:20 +02:00
Keirua
e96e33b9a5
Merge pull request #5022 from tchak/update-graphql 
Update ruby-graphql
 2020-04-09 11:00:56 +02:00
Paul Chavard
537c74fdfc Update ruby-graphql 2020-04-09 10:48:49 +02:00
Paul Chavard
032ad6b7ec
Merge pull request #5019 from betagouv/fix-attachment-redirect 
Fix middle-click on "Delete attachment" button
 2020-04-09 10:47:24 +02:00
Pierre de La Morinerie
7ff381b6f0 attachments: remove the buggy fallback 
The fallback would fail on non-champ attachments.
 2020-04-09 10:40:08 +02:00
Pierre de La Morinerie
7e19dd2cda Revert "Revert "Fix middle-click on "Delete attachment" button"" 
This reverts commit 6e8bd6957f.
 2020-04-09 10:40:08 +02:00
Paul Chavard
d2811bdf73
Merge pull request #4996 from betagouv/feat/user-search-inside-dossiers 
#2191 - Permettre aux usagers de rechercher dans le contenu de leurs dossiers
 2020-04-09 09:52:24 +02:00
clemkeirua
590cee050f add tests for dossier_search_service 2020-04-09 09:42:31 +02:00
clemkeirua
46e14f4033 add test for users/list_dossiers_spec 2020-04-09 09:42:31 +02:00
clemkeirua
8ff3d9ea47 update existing tests 2020-04-09 09:42:31 +02:00
clemkeirua
fbcf3de74c ajout du motif recherché dans l'écran de résultats 2020-04-09 09:42:31 +02:00
clemkeirua
76139dbc71 recherche usager full-text avec plusieurs resultats 2020-04-09 09:42:31 +02:00
clemkeirua
98337f2334 recherche usager full-text avec 1 resultat 2020-04-09 09:42:31 +02:00
clemkeirua
9eafeac622 extract layouts/search_dossiers_form partial 2020-04-09 09:42:31 +02:00
clemkeirua
34188c432c refactor _new_header so that user and instructeur search share similar signature 2020-04-09 09:42:31 +02:00
Paul Chavard
695fd13e77
Merge pull request #5021 from tchak/groupe-instructeur-dossiers 
[GraphQL] allow to query dossiers by groupe instructeur
 2020-04-09 09:40:26 +02:00
Paul Chavard
32f783142c [GraphQL] allow to query dossiers by groupe instructeur 2020-04-09 09:29:28 +02:00
Keirua
7e806f191c
Merge pull request #5020 from tchak/fix-graphql-groupe-instructeur-type 
[GraphQL] fix groupe instructeur type definition
 2020-04-09 09:26:22 +02:00
Paul Chavard
e28c05bb92 [GraphQL] fix groupe instructeur type definition 2020-04-08 18:36:09 +02:00
Pierre de La Morinerie
0b16ca006a
Merge pull request #5014 from betagouv/js-bump-kind-of 
Javascript : mise à jour des dépendances de Webpacker
 2020-04-08 18:20:56 +02:00
Pierre de La Morinerie
fd319fb2ef javascript: bump dependancies of webpacker 
Bump dependancies of webpacker, without bumping webpacker itself.

```
yarn upgrade @rails/webpacker@4.2.2
```

This fixes a moderate security vulnerability in kind-of <= 6.0.2.
 2020-04-08 18:14:09 +02:00
Pierre de La Morinerie
40728f1046
Merge pull request #5017 from betagouv/revert-5012-fix-attachments-controller 
Revert "Fix middle-click on "Delete attachment" button"
 2020-04-08 17:52:00 +02:00
Pierre de La Morinerie
6e8bd6957f
Revert "Fix middle-click on "Delete attachment" button" 2020-04-08 17:40:58 +02:00
Pierre de La Morinerie
b290564df2
Merge pull request #5013 from betagouv/auto-upload-fix-retry 
Usager : améliorations sur le bouton "Réessayer l'envoi" des pièces justificatives
 2020-04-08 17:00:58 +02:00
Pierre de La Morinerie
72d003b62c javascript: fix missign argument to catch 
Some browers complain about this.
 2020-04-08 16:54:31 +02:00
Pierre de La Morinerie
444732b117 javascript: don't allow to retry on direct upload 422 
When the authenticity token is invalid, the creation of the blob before
the direct upload returns a 422.

In that case, the token will never become valid again, and it is useless
to try again. Don’t show the "Retry" button in this case.

NB: of course the real fix is to understand why the authenticity token
is so often invalid – but this will be for later.
 2020-04-08 15:48:23 +02:00
Pierre de La Morinerie
38b0bd645c javascript: fix clicking on the icon of the auto-upload Retry button 
When clicking on the icon, `event target` would be the icon, not
the button.

However delegates configures `this` to be the requested event target.
 2020-04-08 15:48:23 +02:00
Pierre de La Morinerie
aa2d99ef33
Merge pull request #5012 from betagouv/fix-attachments-controller 
Usager : affiche une page de redirection quand le bouton "Supprimer la pièce jointe" est ouvert dans un nouvel onglet
 2020-04-08 15:47:34 +02:00
Pierre de La Morinerie
b748e9773f attachments: fix opening the delete link directly 
When cliking on the "Delete attachment" link, and opening the URL
in a new tab, the `DELETE /attachements/:id` will become
`GET /attachments/:id` – which will cause the `show` action to be
routed with an html format (instead of JS).

In that case, we don't want to throw an error at the user face.
Instead simply re-render the dossier page (if any).

Fix a long-standing error in Sentry.
 2020-04-08 13:40:32 +02:00
Pierre de La Morinerie
0077ff4b75 attachments: refactor the controller specs 2020-04-08 12:05:55 +02:00