DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
13147 commits 250 branches 1166 tags 78 MiB
Commit graph

13147 commits

This branch
This branch
All branches
Author SHA1 Message Date
Nicolas Bouilleaud
769621de46 Explicitly pass the “state” param in notifications_*_procedure methods 2019-09-20 11:06:33 +02:00
Nicolas Bouilleaud
8a06c01f13 Reorder methods in instructeur.rb 
Move token stuff together, out of notification-related stuff.
 2019-09-20 10:48:08 +02:00
LeSim
71db4ea32f
Merge pull request #4347 from betagouv/optimize-notifications-queries 
Use a single query in dossiers_id_with_notifications (instead of four)
 2019-09-20 09:54:38 +02:00
Nicolas Bouilleaud
4f0871dab0 Use a single query in dossiers_id_with_notifications (instead of four) 
This is used in /procedures#show and /procedures#index, to display badges on the “suivis” and “traités” tabs of each procedure. Rails cache helps when it’s the exact same query, but it’s not the case for different tabs.

I’m not certain it’ll be a visible performance improvement but it shouldn’t hurt.
 2019-09-20 09:45:59 +02:00
LeSim
d2b9e9102a
Merge pull request #4346 from betagouv/add_groupe_instructeur_column_in_export 
Ajoute la colonne groupe d'instructeur dans les procédures routées
 2019-09-19 17:12:03 +02:00
simon lehericey
faddbc23ef Eager load procedure: :groupe_instructeurs for export 2019-09-19 12:30:12 +02:00
simon lehericey
a2f82ab8be Add groupe_instructeur_label to export v2 2019-09-19 12:30:12 +02:00
simon lehericey
f577484aa2 Add groupe_instructeur_label to export v1 2019-09-19 12:30:12 +02:00
simon lehericey
3bc20bdb06 Procedure.routee? 2019-09-19 12:30:12 +02:00
LeSim
fb631fb019
Merge pull request #4345 from betagouv/export_and_groupe_instructeur 
Prépare l'export des dossiers au routage
 2019-09-19 12:29:23 +02:00
simon lehericey
8660d4af30 Instructeur: only export its dossiers 2019-09-19 12:24:40 +02:00
Paul Chavard
d2bb1ca1fe
Merge pull request #4343 from betagouv/dev 
2019-09-19-01
 2019-09-19 09:16:43 +02:00
Paul Chavard
f4d4a896a0
Merge pull request #4342 from tchak/revert-proxy 
Revert "Upload through proxy"
 2019-09-19 09:14:32 +02:00
Paul Chavard
6533ec420b Revert "Upload through proxy" 
This reverts commit 91815ad709.
 2019-09-19 09:13:41 +02:00
LeSim
96f78341cb
Merge pull request #4340 from betagouv/procedure_show_and_groupe_instructeur 
Prépare la vue instructeur procedure show à l'arrivée du routage
 2019-09-18 21:08:51 +02:00
simon lehericey
e2acb0a946 ProcedurePresentation: can use groupe instructeur 2019-09-18 15:51:02 +02:00
simon lehericey
f5bbc9e2f9 InstructeurProcedureShow: show dossier for all the gi involved 2019-09-18 15:51:02 +02:00
simon lehericey
9b16bd2037 Dossier: retrieve all dossiers for a procedure 2019-09-18 15:51:02 +02:00
simon lehericey
21577a0f0b Instructeur: dedup procedures with multiple gi 2019-09-18 15:51:02 +02:00
Paul Chavard
10e64b2f92
Merge pull request #4336 from betagouv/dev 
2019-09-18-01
 2019-09-18 14:48:40 +02:00
Paul Chavard
5ca5c640a0
Merge pull request #4262 from tchak/rename-active-storage-files-setep-2 
Remove duplicated attachments (Step 2)
 2019-09-17 18:29:50 +02:00
Paul Chavard
8fcf1353f3 Remove duplicated attachments 2019-09-17 18:12:53 +02:00
LeSim
a3a47b8959
Merge pull request #4310 from betagouv/instructeur_index_stats_and_groupe 
Instructeur index stats and groupe
 2019-09-17 17:26:33 +02:00
simon lehericey
dec42e4886 Instructeur procedure index: show stats by procedure 
Also sum the count from differents groupe_instructeur from the same procedure
 2019-09-17 17:19:14 +02:00
simon lehericey
d338f9b9f3 Factory: can create a dossier with a defined gi 2019-09-17 17:19:14 +02:00
Paul Chavard
dd3bb69638
Merge pull request #4082 from tchak/upload-pj-through-proxy 
Upload through proxy
 2019-09-17 17:12:22 +02:00
Paul Chavard
91815ad709 Upload through proxy 2019-09-17 17:04:52 +02:00
Paul Chavard
45efd99a89
Merge pull request #4208 from pengfeidong/fix_3975_buttons_floating 
[fix #3975] set buttons floating in dossier page
 2019-09-17 17:03:42 +02:00
Paul Chavard
11b4698ef3 Fix test 2019-09-17 16:58:11 +02:00
Pierre de La Morinerie
4b883a57bf stylesheets: make the actions bar sticky 2019-09-17 16:58:11 +02:00
Pierre de La Morinerie
1f8f38f492 stylesheets: align the buttons vertically 2019-09-17 16:58:11 +02:00
Pierre de La Morinerie
974c1b1150 stylesheets: move the dossier floating bar CSS to dossier_edit.scss 
forms.scss is supposed to be for generic elements.
 2019-09-17 16:58:11 +02:00
pedong
09a0f21cac use same look with .champs-editor.buttons 2019-09-17 16:58:11 +02:00
pedong
d2a78abc3a [fix #3975] set buttons floating in dossier page 2019-09-17 16:58:11 +02:00
Nicolas Bouilleaud
b74b72d1c8
Merge pull request #4204 from betagouv/3945-procedure-stats 
First attempt at procedure stats
 2019-09-17 16:55:56 +02:00
Nicolas Bouilleaud
0c98f29d59 Move the cached procedure stats queries to a ProcedureStatsConcern 2019-09-17 16:43:48 +02:00
Nicolas Bouilleaud
06d60cd943 Cache requests in procedures/stats 2019-09-17 16:43:48 +02:00
Nicolas Bouilleaud
3e2985b305 First attempt at procedure stats 
fixes #3945, #3946, #3948
 2019-09-17 16:43:48 +02:00
Nicolas Bouilleaud
394a2773db
Merge pull request #4048 from betagouv/procedure-path 
Cleanup, simplify and readd suggestions for procedure paths
 2019-09-17 16:40:32 +02:00
Nicolas Bouilleaud
78da268ded Improve feature tests for procedure cloning and creation 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
543f9894c1 Make sure the “commencer” link uses the proper test path 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
c26a701a17 Refactor and redesign publish modal 
* remove the autocomplete menu
* use ujs to pre-validate the procedure
* tweak the UI
 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
bd1e0aba38 Add Procedure path suggestion 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
8806eab8d6 Properly validate Procedure.lien_site_web is set when publishing 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
00c37eccb3 Simplify procedure.path and publish event 
* Get rid of the “reopen” event, merge it with “publish” (it’s the same code)
* Remove the “availability” states; “available with brouillon” makes no sense since the brouillons path are always uuids
* Instead of checking if publish can happen, just try it and handle the errors
 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
99f986b815 Cleanup Procedure retrieval in “Commencer” 
Make sure to only fetch active (brouillons or published) procedures.
 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
92e6032115 Remove path availability dead code when creating/editing a procedure 
There’s no “path” field anymore in the Procedure form, it can only be set when publishing.
 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
b9968b76b0 Remove “avec_lien” helpers now that Procedure.path cannot be nil 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
8fa630d2bb Remove Gestionnaire.visible_procedures 
It is actually the same thing as Gestionnaire.procedures. It already included the procedures with paths as well as the archived procedures, and in production, there were no Gestionnaire for who procedures was returning a different result than visible_procedures (expect for two baddata brouillon procedures with a nil path).

In addition, Procedure.path is now nonnull, which means the Procedure.avec_lien scope is pointless.

Finally, the current spec showed that the only procedure not visible to the gestion was the one he was not assigned to.
 2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
e9c6ed80e4 Migration: Index and make Procedure.path nonnull 2019-09-17 16:30:48 +02:00