Commit graph

4892 commits

Author SHA1 Message Date
gregoirenovel
084ee98ab2 Enable the Layout/MultilineMethodDefinitionBraceLayout cop 2018-01-15 22:33:14 +01:00
gregoirenovel
73dd58b6cd Enable the Layout/MultilineMethodCallIndentation cop 2018-01-15 22:33:13 +01:00
gregoirenovel
b77837bfd1 Enable the Layout/MultilineMethodCallBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
5077e654f2 Enable the Layout/MultilineHashBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
9d75526460 Enable the Layout/MultilineAssignmentLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
14c1747645 Enable the Layout/MultilineArrayBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
345b892956 Enable the Layout/LeadingCommentSpace cop 2018-01-15 22:33:13 +01:00
gregoirenovel
19ee24d559 Enable the Layout/InitialIndentation cop 2018-01-15 22:33:13 +01:00
gregoirenovel
1e71188d4d Enable the Layout/IndentationConsistency cop 2018-01-15 22:33:13 +01:00
gregoirenovel
99a49a8144 Enable the Layout/IndentHeredoc cop 2018-01-15 22:33:13 +01:00
gregoirenovel
0be657c0d7 Enable the Layout/IndentHash cop 2018-01-15 22:33:12 +01:00
gregoirenovel
3363e21427 Enable the Layout/IndentAssignment cop 2018-01-15 22:33:12 +01:00
gregoirenovel
9e0e553f80 Enable the Layout/IndentArray cop 2018-01-15 22:33:12 +01:00
gregoirenovel
5125cf8396 Enable the Layout/FirstParameterIndentation cop 2018-01-15 22:14:39 +01:00
gregoirenovel
9f855afdfe Enable the Layout/FirstHashElementLineBreak cop 2018-01-15 22:14:38 +01:00
gregoirenovel
08ed400ec2 Enable the Layout/FirstArrayElementLineBreak cop 2018-01-15 22:14:38 +01:00
LeSim
8f08e2fdf9
Merge pull request #1251 from betagouv/tables-cleanup
Tables cleanup
2018-01-15 18:37:42 +01:00
gregoirenovel
5b1d578726 Delete 3 now unused tables 2018-01-15 18:32:14 +01:00
LeSim
cdebf099d2
Merge pull request #1254 from betagouv/partially_clean_fc
Partially clean fc
2018-01-15 18:27:08 +01:00
simon lehericey
d086b82d44 FC ParticulierController: remove one return 2018-01-15 17:14:12 +01:00
simon lehericey
34bd3a11e9 FC ParticulierController: remove superfluous if 2018-01-15 17:14:12 +01:00
simon lehericey
02395e732c FC service: return domain info 2018-01-15 17:14:12 +01:00
simon lehericey
7024e14d1c FC information: remove funny find_by 2018-01-15 17:14:12 +01:00
simon lehericey
8e26a50f16 FC service: clean syntax 2018-01-15 17:14:12 +01:00
simon lehericey
e68fc0811f FC ParticulierController: callback syntax cleaning 2018-01-15 17:14:12 +01:00
simon lehericey
4294c8eec7 Brakeman: make it happy 2018-01-15 17:14:12 +01:00
simon lehericey
9dc242d907 FC Particulier Controller: simplier login 2018-01-15 17:14:12 +01:00
simon lehericey
fc4ce4460c FC Particulier Controller: do not parse an URI into URI 2018-01-15 17:14:12 +01:00
simon lehericey
b35a88ffd4 FC initializers: simplify 2018-01-15 17:14:12 +01:00
simon lehericey
f8519c5345 FC initializers: remove Hashie 2018-01-15 17:08:38 +01:00
simon lehericey
ec69be0f7b FC ParticulierClient: simplier initializer 2018-01-15 17:00:26 +01:00
Simon Lehericey
0d46f92795 FC: move FC constants under particulier namespace 2018-01-15 16:59:50 +01:00
simon lehericey
06d9c4356e FC ParticulierClientSpec: simplier spec 2018-01-15 16:59:50 +01:00
simon lehericey
4c2da46dd8 FC ParticulierClient: simplier initialize 2018-01-15 16:59:48 +01:00
Simon Lehericey
8c487c65a9 FC: remove unused code 2018-01-15 11:27:56 +01:00
gregoirenovel
aa12eb2c49 Merge branch 'dev' 2018-01-15 11:27:12 +01:00
gregoirenovel
ae46fe8889
Merge pull request #1243 from betagouv/fix-1120
[Fix #1120] Delete the old accompagnateur UI
2018-01-15 11:23:42 +01:00
gregoirenovel
1368cd4b03 [Fix #1120] Delete the old accompagnateur UI 2018-01-15 10:02:10 +01:00
gregoirenovel
1c295eafb6
Merge pull request #1246 from betagouv/unless
Unless
2018-01-15 09:53:24 +01:00
gregoirenovel
22e58a5346 Detect code that could use #present? with rubocop 2018-01-15 09:45:31 +01:00
gregoirenovel
3593adbe66 !foo.empty? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
aedafbaf2e !foo.blank? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
bbaebe0602 !foo.nil? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
3dd03a04cd Detect unless/else patterns with rubocop 2018-01-12 11:32:43 +01:00
gregoirenovel
7c34807f46 Don’t use unless 2018-01-12 11:32:43 +01:00
Frederic Merizen
8c73851cec
Merge pull request #1242 from betagouv/fix_1209-date_de_depot_in_received_mail
Fix 1209 date de depot in received mail
2018-01-11 16:51:44 +01:00
Frederic Merizen
fcb8fb5935 [Fix #1209] test that en_construction is set for initiated mail 2018-01-11 16:47:06 +01:00
Frederic Merizen
ca642abda8 [#1209] Actually put dossier in brouillon state 2018-01-11 16:47:06 +01:00
Frederic Merizen
8807763561 [#1209] Make submission side-effect more explicit 2018-01-11 16:47:06 +01:00
Frederic Merizen
f6986c4db3 [#1209] Clean up formatting 2018-01-11 16:47:06 +01:00