Commit graph

11437 commits

Author SHA1 Message Date
Martin
a4a232dda2 a11y(invite): rework invite menu for easier readability by screen reader 2024-02-21 15:49:55 +01:00
Martin
77927e41bc feat(api.mandataire): add missing mandataire_first_name/last_name
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-21 15:15:55 +01:00
Martin
c2675dfb4d feat(export.user): add when user passthru FranceConnect or not 2024-02-21 14:44:49 +01:00
Martin
c9235c8a3d feat(export.for_tier): add to export 2024-02-21 14:44:49 +01:00
Colin Darie
5f5756a034
Merge pull request #10017 from mfo/US/a11y-after-signup
ETQ usager utilisant un lecteur d'écran: la page de demande de confirmation de compte ne concentre pas le lecteur d'écran sur le champ pour renvoyer un mail de confirmation
2024-02-21 12:25:35 +00:00
Colin Darie
41a27fbad2
Merge pull request #10014 from mfo/US/better-expert-exports
ETQ expert: je retrouve mes avis confidentiel dans les exports. ETQ instructeur, je retrouve les fichiers joint a une demande d'avis expert
2024-02-21 11:25:58 +00:00
Colin Darie
76d903b04e
Merge pull request #10011 from adullact/feature-ouidou/admin_creation_delegation_review
ETQ gestionnaire d'admins: sépare les commentaires par origine + correctifs
2024-02-21 11:21:45 +00:00
Colin Darie
5ab1d45b8a fix(instructeur): don't crash when adding a filter too long 2024-02-21 12:13:47 +01:00
Colin Darie
bda8d66047
fix(clipboard): hide clipboard button when clipboard is blocked 2024-02-21 10:55:24 +01:00
seb-by-ouidou
52db6f712f separate commentaires by origin + few fixes 2024-02-21 09:47:03 +00:00
Paul Chavard
5a8859cd28
Merge pull request #10018 from tchak/fix-address-champ
fix(champ): do not reset data on champs without fetch_external_data
2024-02-21 09:06:24 +00:00
Colin Darie
1671a783a2
Merge pull request #10021 from colinux/fix-email-subject-double-encode
ETQ usager je dois voir de vraies apostrophes à la place de `&#39;` dans les sujets d'email
2024-02-21 08:33:44 +00:00
Paul Chavard
702b9dd8b3 fix(champ): do not reset data on champs without fetch_external_data 2024-02-21 08:54:08 +01:00
Martin
48336f0ca4 a11y(users/confirmations#new): avoid autofocus on input to resend the mail, otherwise screen reader goes straight to the input 2024-02-21 07:56:00 +01:00
Paul Chavard
12598229a7 chore(browser): mark samsung browser as supported browser 2024-02-20 20:22:05 +01:00
Colin Darie
c05aaa5f35 fix(email): dynamic subject should be escaped, cf RFC 2047 which have its own encoding 2024-02-20 18:29:41 +01:00
Colin Darie
560d50f52d fix(dropdown-multiple): a valid option starting by [ may not be a JSON value 2024-02-20 17:41:53 +01:00
Martin
6117aa503f a11y(flash_message): make them assertive, feedback from a request is the priority. 2024-02-20 17:26:13 +01:00
Martin
11eb0a9c56 feat(invite): i18n create/destroy 2024-02-20 17:22:47 +01:00
Martin
497146081d fix(monavisvalidator): restrict to known domains 2024-02-20 11:51:00 +01:00
mfo
de4369db29
Merge pull request #10010 from mfo/US/fix-expert-signup
amelioration(expert.signup): passe la page de creation de compte expert au dsfr
2024-02-19 16:43:31 +00:00
Martin
a151a304e2 feat(pj_service): add expert's avis (even when confidential) to exports asked by same expert 2024-02-19 16:22:08 +01:00
Martin
dd39ac313b feat(pj_service): add introduction_file to exports 2024-02-19 16:21:26 +01:00
Martin
8dc3103ac1 fix(champs.email): allow nil 2024-02-19 15:13:20 +01:00
Martin
e788846894 feat(expert.signup): dsfrize 2024-02-19 11:28:38 +01:00
Paul Chavard
46b12c0c3d
Merge pull request #9990 from tchak/refactor-adresse-champ
refactor(address): use directly BAN data
2024-02-16 16:42:17 +00:00
Martin
1a424beb6f fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken 2024-02-16 14:00:18 +01:00
Paul Chavard
20307f1d21 refactor(address): use directly BAN data 2024-02-16 12:15:14 +01:00
Martin
2200310877 fixup! tech(refactor): extract clone logic inside its own class 2024-02-16 11:23:39 +01:00
Martin
32e8f34511 refactor(PiecesJustificativesService): stop passing flags, pass user_profile and manage ACL from the service itself 2024-02-16 11:23:39 +01:00
Martin
83690529ca tech(refactor): inline PiecesJustificativesService.serialize_champs_as_pjs(object) within DossierSerializer 2024-02-16 11:23:39 +01:00
Martin
56ed901703 tech(clean): remove dead code 2024-02-16 11:23:39 +01:00
Martin
3e64a3bbbc tech(refactor): extract clone logic inside its own class 2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c refactor(export/archives): holds user profile asking for the archive or export 2024-02-16 11:23:38 +01:00
mfo
4dfb3b86ef
Merge pull request #10000 from mfo/US/groupe-instructeur-manageable-for-routee-procedure
ETQ administrateur, je peux gerer la liste des instructeurs même si le routage est activé sur ma démarche
2024-02-16 09:26:06 +00:00
mfo
cc53946d22
Merge pull request #9978 from mfo/US/enforce-real-email-validation
feat(email): stricter validation
2024-02-16 09:25:58 +00:00
Martin
c719a42f8a feat(procedure.instructeurs_self_management_enabled): backfill instructeurs_self_management_enabled since routing_enabled is not one of the option conditionning it 2024-02-16 10:08:36 +01:00
Colin Darie
fc482c1607
Merge pull request #10008 from colinux/fix-draft-procedure-description-cache
ETQ admin: correction du cache de la liste des PJ d'une démarche en brouillon
2024-02-16 07:22:22 +00:00
mfo
4f58795eaa
Merge pull request #10002 from mfo/US/dsfrize-instructeur-invitation-page
ETQ instructeur, la page de gestion des groupes d'instructeur est au format du DSFR
2024-02-16 06:37:49 +00:00
mfo
3e9abd73e4
Merge pull request #10004 from mfo/add_missing_acl_on_instructeurs_self_management_enabled
secu(instructeurs/groupes_instructeurs): s'assure que seul les instructeurs d'une demarche ayant la gestion activé puisse acceder aux ecrans
2024-02-16 06:37:45 +00:00
Colin Darie
a783c50026 fix(commencer): cache on description of draft procedure
Des changements dans le formulaire d'une démarche en brouillon
ne mettent pas à jour la cache_key de la procedure, donc au fait au plus
simple pour éviter un cache stale dans ces cas là.
2024-02-15 18:45:13 +01:00
Martin
a274629719 fix(instructeurs/groupes_instructeurs#*): add some ACL here 2024-02-15 17:11:25 +01:00
Martin
b6c2742cda bug(instructeurs/groupes_instructeurs#*): any ACL here ? 2024-02-15 17:11:25 +01:00
Martin
8488e74bbb review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06 feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert 2024-02-15 16:41:00 +01:00
Martin
05193e1d1e feat(User.validation): validates email when env var is present 2024-02-15 16:41:00 +01:00
Martin
25f92a7760 feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
mfo
51c5244545 review(dsfr): enforce fr-container, fr-table, fr-spacers
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:11:16 +01:00
Martin
2f32468d36 feat(instructeurs/groupes_instructeur): dsfrize 2024-02-15 15:34:22 +01:00
Martin
5407011668 feat(procedure.routing): allow admin to manage instructeur even when procedure has some routing 2024-02-15 13:40:48 +01:00
seb-by-ouidou
9ddd55d5cd feat: remove commentaire_component and replace it by message_component + replace commentaires/_form by messages/_form + few fixes 2024-02-15 07:50:20 +00:00
Paul Chavard
f5f94d9e52
Merge pull request #9989 from tchak/fix-allow-to-edit-more-geo-areas
ETQ usager je peux éditer jusqu'à 50 points ou éléments sélectionnés dans le champ carte
2024-02-14 21:13:09 +00:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Colin Darie
a9b24b897e
Merge pull request #9971 from demarches-simplifiees/harmonize-merci-message-from-admin-apercu-to-user-ldu
ETQ admin, je veux que le message de fin de dépot d'une démarche déclarative soit correct
2024-02-14 15:14:20 +00:00
mfo
3237ea8e9f
Merge pull request #9991 from mfo/US/fix-attestation-template-revision-preloader
perf(mail_template/attestation): preload procedure revisions
2024-02-14 08:58:16 +00:00
Martin
85fa75e8f0 perf(mail_template/attestation): preload procedure revisions 2024-02-13 17:11:21 +01:00
Colin Darie
48644ae407
Merge pull request #9846 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
Délégation de compte: ETQ gestionnaire je peux contacter les gestionnaires des groupes parents
2024-02-13 14:42:03 +00:00
Paul Chavard
7d9cb4d497
Merge pull request #9988 from tchak/refactor-logic-compute-sub-values
refactor(logic): compute sub champ values
2024-02-13 14:22:09 +00:00
Paul Chavard
ff95a812e2 fix(combobox): always sort on the client 2024-02-13 12:26:43 +01:00
Paul Chavard
cf10b68d0d fix(geo_area): allow up to 50 geo_area to be edited 2024-02-13 12:09:03 +01:00
Paul Chavard
93635b3516 refactor(logic): compute sub champ values 2024-02-13 11:57:31 +01:00
seb-by-ouidou
08cffda440 fix: few fixes after review 2024-02-13 11:19:52 +01:00
seb-by-ouidou
fba3cbe331 feat: as gestionnaire, contact gestionnaire of parent groupe 2024-02-13 11:19:52 +01:00
Paul Chavard
641a33e1e0
Merge pull request #9985 from tchak/fix-update-dossier-en-construction
ETQ Usager, je ne veux pas voir un message d'alerte indiquant que la démarche est close lorsque je modifie un dossier en construction
2024-02-13 09:38:08 +00:00
Lisa Durand
f57be9e455 fix(dossier): harmonize merci message from admin apercu to user 2024-02-13 09:28:47 +01:00
Eric Leroy-Terquem
7b539c72b1
Merge pull request #9955 from demarches-simplifiees/fix-simple-routing
ETQ admin je peux faire un routage simple à partir d'un type de champ communes ou epci
2024-02-13 07:56:42 +00:00
Paul Chavard
034015384b fix(dossier): do not warn about closed demarche when updating a fork 2024-02-13 08:19:19 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf 2024-02-12 17:20:07 +01:00
Lisa Durand
a756ab0a63
add address infos for rna in show 2024-02-12 17:20:06 +01:00
Lisa Durand
9e3f28e87b
add rnf and rna address in form view 2024-02-12 17:20:05 +01:00
Colin Darie
7251a5ca01
Merge pull request #9983 from colinux/fix-address-champ
ETQ instructeur: fix génération d'attestation avec une balise "nom de la commune" depuis un champ adresse
2024-02-12 15:48:11 +00:00
Colin Darie
bfb98554ff
fix(active-storage): don't fail on analyzing a blob derivated by watermark
Quand l'analyse du job se produit après le watermark, elle doit comparer
le checksum avec celui du fichier filigrané.
2024-02-12 16:30:58 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address 2024-02-12 15:08:05 +01:00
Colin Darie
f112569192
fix(haml-lint): TrailingEmptyLine 2024-02-12 09:33:23 +01:00
Colin Darie
e3f233cd51
fix(rubocop): Layout/ExtraSpacing et Layout/SpaceAroundOperators 2024-02-12 09:33:22 +01:00
Colin Darie
eeef6176b7
fix(rubocop): Rails/PluckInWhere 2024-02-12 09:33:19 +01:00
Colin Darie
6ab3fa1cf4
fix(rubocop): Rails/RedundantActiveRecordAllMethod 2024-02-12 09:33:18 +01:00
Colin Darie
0da2843f26
fix(rubocop): Rails/FindEach 2024-02-12 09:33:17 +01:00
Colin Darie
9639d68ebf fix(checkbox): show mandatory icon on mandatory champ
Closes #9891
2024-02-09 12:52:21 +01:00
Colin Darie
c4bdef3a1c
Merge pull request #9979 from mfo/US/fix-point-input
ETQ usager: fix comportement des marqueurs de la carte dans les blocs répétables
2024-02-09 10:03:50 +00:00
Martin
4209eec021 fix(cartes): PointInput should not add point to all map on page 2024-02-09 10:41:35 +01:00
Colin Darie
162d8ca752
Merge pull request #9974 from colinux/fix-delai-declarative-instruction
ETQ usager je vois de nouveau le délai d'instruction pour les démarches déclaratives en instruction
2024-02-09 09:16:18 +00:00
Paul Chavard
d9f195a74b fix map zoom hook 2024-02-09 09:24:58 +01:00
Martin
53ae5eeb5b feat(map): stop flyTo/panTo on champ carte by default 2024-02-09 09:23:17 +01:00
Martin
32dcb411ca feat(repetition.carte): add carte to repetition, just to test it 2024-02-09 09:23:17 +01:00
Paul Chavard
23592087ae refactor(instructeur): use precomputed timestamps 2024-02-08 18:36:04 +01:00
Colin Darie
2e68fddd68
Merge pull request #9976 from colinux/carte-design
ETQ usager: le champ carte est un peu plus design (passage au DSFR)
2024-02-08 16:47:12 +00:00
Colin Darie
0bb25765d9 style(carte): passe l'UI au DSFR 2024-02-08 17:25:22 +01:00
Colin Darie
1f731ad14a
chore(ign): match proper style to layers 2024-02-08 16:23:15 +01:00
Paul Chavard
163e6f807e
chore(ign): update to geoplateforme 2024-02-08 16:23:08 +01:00
Colin Darie
8f1818511a
fix(demarche): estimated delay display for declarative en instruction 2024-02-08 12:47:58 +01:00
Colin Darie
b1203faa69
Merge pull request #9973 from demarches-simplifiees/add-padding-in-email-footer-ldu
ETQ usager, améliore le footer dans les emails de démarche avec un petit espace supplémentaire
2024-02-08 11:10:25 +00:00
Eric Leroy-Terquem
79ff2ba779 feat(combobox): can paste many terms separated by semicolons 2024-02-08 11:53:47 +01:00
Colin Darie
0111329b56
Merge pull request #9963 from colinux/fix-datafixer
Tech: fix maintenance task invokation `AddDossiersMissingChampsTask`
2024-02-08 10:29:27 +00:00
Colin Darie
8361938511
Merge pull request #9972 from colinux/upgrade-administrate
Tech: update administrate from 0.18.0 to 0.20.1 (manager)
2024-02-08 10:26:52 +00:00
Lisa Durand
048dd7dd74 add padding in email footer 2024-02-07 17:06:31 +01:00
Colin Darie
88a24e6c0f
Merge pull request #9970 from demarches-simplifiees/remove-estimated-delay-for-procedure-declarative-ldu
ETQ usager, je n'ai pas besoin du détail des délais d'instruction pour les démarches déclaratives
2024-02-07 16:00:31 +00:00
Colin Darie
1e2a6d0461 fix(manager): update templates and make everything works 2024-02-07 16:54:23 +01:00
Lisa Durand
52b334e48b dont display estimated delay for declarative procedure 2024-02-07 16:21:24 +01:00
Lisa Durand
a14d587722 fix missing local when calling partial user_infos 2024-02-07 15:11:29 +01:00
mfo
8d658c60d8
Merge pull request #9953 from mfo/US/fix-archive-without-annotations
correctif: ETQ admin, je souhaite retrouver les annotations privées dans les archives
2024-02-07 10:05:42 +00:00
Colin Darie
fb14afc530 fix(rna): real RNA identifier could contain at least 1 letter, despite of specs 2024-02-06 15:02:57 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
Colin Darie
c9b9338f6e fix(maintenance): dossiers missing champs fixer invokation 2024-02-05 17:01:35 +01:00
seb-by-ouidou
c2c54083e8
feat: display tree structure of a group 2024-02-05 09:30:24 +01:00
Colin Darie
460240713f
Merge pull request #9668 from adullact/feature-ouidou/admin_creation_delegation_commentaire_email_notification
Délégation de compte admin: notification par email à l'ajout d'un commentaire
2024-02-02 14:09:22 +00:00
Colin Darie
eb55abebfc style(attestation): fix for headings style and spacing following charte 2024-02-02 13:49:22 +01:00
Colin Darie
72e59b6473 fix(attestation): can remove headings 2024-02-02 13:18:42 +01:00
Colin Darie
a1359c243e style(attestation): fix h3 font-size 2024-02-02 13:08:55 +01:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle 2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9 feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread 2024-02-02 12:52:36 +01:00
Eric Leroy-Terquem
4ccb61981d feat(manager): add dossiers invites in user dashboard 2024-02-02 10:27:20 +01:00
Colin Darie
6f49dd892d
fix(attestation): multiple tags improvements
- no menu when no matching tags
- insert a space after clicking a button
- allow no space before mention
2024-02-02 09:47:20 +01:00
Colin Darie
58064dc6cd
fix(attestation): improve autosubmit debounce due to tags interactions 2024-02-01 18:56:02 +01:00
Colin Darie
7e02342518
feat(attestation): tiptap default attestation 2024-02-01 18:55:58 +01:00
Colin Darie
ce2ae53def
style(attestation): revamp bottom bar 2024-02-01 18:55:56 +01:00
Colin Darie
475406f3f2
style(attestation): improve editor UI & style 2024-02-01 18:55:55 +01:00
Colin Darie
16478651a9
test(attestation): more tests for v2 2024-02-01 18:55:53 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section 2024-02-01 18:55:52 +01:00
Colin Darie
a842fefa7a
feat(attestation): inform that conditional champs are not tags-available 2024-02-01 18:55:51 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2 2024-02-01 18:55:50 +01:00
mfo
86fb28bda0
Merge pull request #9956 from mfo/US/amelioration-rebase
tech(perf.rebase): améliore la performance pour réconcilier les dossiers d'une procédure lorsqu'un administrateur change le formulaire (donc nouveau milésime 🍷)
2024-01-31 17:26:25 +00:00
Martin
437b3d2a61 fix(perf): last n+1 2024-01-31 17:06:16 +01:00
Martin
47ff3086af fix(rebase): preload revision too 2024-01-31 17:06:16 +01:00
Colin Darie
d4c4b3a212
chore(attestation): preview link to PDF 2024-01-31 17:04:06 +01:00
Colin Darie
fe2661d37c
feat(attestation): can create an attestation v2 2024-01-31 17:04:05 +01:00
Colin Darie
fd829351e8
chore(attestation): browse between 2 versions 2024-01-31 17:04:03 +01:00
Colin Darie
d92200f80b
fix(attestation): various tiptap & axe fixes 2024-01-31 17:04:02 +01:00
Colin Darie
39d00c81de
feat(attestation): show template schema 2024-01-31 17:04:01 +01:00
Colin Darie
89a62bacbb
feat(attestation): intitules & footer limit of rows 2024-01-31 17:04:00 +01:00
Colin Darie
1123222b36
chore(schema): add version to attestation_templates 2024-01-31 17:03:59 +01:00
Colin Darie
dfa07c1c5d
style(attestation): editor sections border instead of background 2024-01-31 17:03:58 +01:00
Colin Darie
3391d75633
style(attestation): cap logo size in free layout 2024-01-31 17:03:56 +01:00
Colin Darie
1c3254755d
chore(schema): add official layout to attestation templates 2024-01-31 17:03:55 +01:00
Colin Darie
8ba78d1cfe
feat(attestation): conditional official layout & logo (start) 2024-01-31 17:03:54 +01:00
Colin Darie
9c9daf162d
feat(attestation): render signature 2024-01-31 17:03:53 +01:00
Colin Darie
3b70b36d2d
feat(attestation): footer save, preview 2024-01-31 17:03:52 +01:00
Colin Darie
e19780445b
feat(attestation): upload de logo and signature 2024-01-31 17:03:51 +01:00
Colin Darie
bb19674339
feat(attestation): improve tags suggestion UX, can validate on click 2024-01-31 17:03:50 +01:00
Colin Darie
277b4f4ec8
style(attestation): improve rendering with almost all nodes 2024-01-31 17:03:48 +01:00
Colin Darie
16cdff8425
feat(tiptap): detect first body paragraph for spacing, handle empty nodes 2024-01-31 17:03:47 +01:00
Colin Darie
eaf4e24a55
feat(attestation): v2 edit form and tags style 2024-01-31 17:03:46 +01:00
Colin Darie
84b8fe4b64
style(attestation): add missing remix icons 2024-01-31 17:03:44 +01:00
Colin Darie
3aae580e26
fix(editor): don't labellize tags with double dash 2024-01-31 17:03:43 +01:00
Colin Darie
d01dc82e8c
refactor(attestation): remove footer from doc structure 2024-01-31 17:03:41 +01:00
Colin Darie
45071b7bb6
fix(tiptap): don't fail on node without content 2024-01-31 17:03:40 +01:00
mfo
fcb2d93056
Merge pull request #9954 from mfo/US/procedure-logo-size
ETQ admin les logos de démarches gardent une résolution convenable
2024-01-31 16:01:07 +00:00
Martin
b964ac6a7a perf(rebase): includes champs.types de champs instead of n+1 on this one 2024-01-31 16:20:50 +01:00
Eric Leroy-Terquem
b04f152733 fix(routing): can create simple routing with communes and epci tdc 2024-01-31 15:27:45 +01:00
Martin
6360ae25b0 feat(procedure.logo): avoid to resize logo to the smallest scale otherwise it gets pixelated 2024-01-31 14:33:28 +01:00