Commit graph

14987 commits

Author SHA1 Message Date
Pierre de La Morinerie
41cf700c15 spec: fix avis/instruction view spec
Due to a faulty naming convention, the test was not executed.
2022-05-10 12:51:27 +02:00
Pierre de La Morinerie
1ad807ab6b spec: fix avis/index view spec
Due to a faulty naming convention, the test was not executed.
2022-05-10 12:51:06 +02:00
Martin
75da4d8c8d Revert "migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id"
This reverts commit 19360e7aac.
2022-05-09 18:45:35 +02:00
Martin
19360e7aac migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id 2022-05-09 18:01:02 +02:00
mfo
f5d2fc7bdd
Merge pull request #7267 from betagouv/main
2022-05-06-01
2022-05-06 14:14:15 +02:00
LeSim
c20e400faa
Merge pull request #7265 from betagouv/fix_create_new_revision
corrige create_new_revision pour les enfants de type de champ répétition
2022-05-06 12:43:40 +02:00
simon lehericey
4ec5b418cb fix create_new_revision 2022-05-06 12:37:59 +02:00
simon lehericey
cb4c35e797 spec: add special case for repetition_type_de_champ 2022-05-06 12:37:59 +02:00
simon lehericey
45f5cd3f4a spec: split procedure creation 2022-05-06 12:37:59 +02:00
LeSim
572e64a5bf
Merge pull request #7161 from betagouv/try_codeql
try codeql analysis
2022-05-06 11:56:18 +02:00
simon lehericey
5040b877d1 remove unused franceconnect.js 2022-05-06 11:50:32 +02:00
LeSim
97b90bb478 try codeql analysis 2022-05-06 11:50:32 +02:00
LeSim
09590cbfac
Merge pull request #7264 from betagouv/refactor_procedure_revision_spec
refactor(procedure_revision_spec)
2022-05-06 11:29:00 +02:00
simon lehericey
02fc25af23 spec: more procedure creation split 2022-05-06 11:23:10 +02:00
simon lehericey
6d38a44f1f spec: be clear we talk about draft 2022-05-06 11:23:10 +02:00
simon lehericey
c1d0256687 spec: split procedure creation 2022-05-06 11:23:10 +02:00
simon lehericey
becdd4a0ed spec: refactor 2022-05-06 11:23:10 +02:00
Paul Chavard
3188719652
Merge pull request #7258 from tchak/remove-sb-tracker
cleanup(sendinblue): remove sendinblue tracking
2022-05-06 11:18:42 +02:00
Paul Chavard
9e0b3b642f cleanup(sendinblue): remove sendinblue tracking 2022-05-06 11:14:44 +02:00
Paul Chavard
b629db2b51
Merge pull request #7263 from tchak/refactor-revison-fix-names
refactor(revision): rename revision methods params to reflect usage of stable_id
2022-05-06 11:13:33 +02:00
Paul Chavard
842506f993 refactor(revision): rename revision methods params to reflect usage of stable_id 2022-05-06 11:08:58 +02:00
Paul Chavard
98814c3812 refactor(revision): test for type_de_champ having a unique revision 2022-05-06 11:08:51 +02:00
LeSim
588641764d
Merge pull request #7243 from betagouv/link_tdc_chidren_by_ProcedureRevisionTypeDeChamp
refactor(spec): lie les champs enfants avec leurs parents avec la nouvelle methode
2022-05-06 10:40:25 +02:00
simon lehericey
2d42b7d57d spec: fix flaky 2022-05-06 10:34:40 +02:00
simon lehericey
d33e7c8cab spec: another isolated type_de_champ_repetition 2022-05-06 10:34:40 +02:00
simon lehericey
0fc71afc29 spec: fix private type de champ repetition 2022-05-06 10:34:40 +02:00
simon lehericey
64175db4dd link children tdc by ProcedureRevisionTypeDeChamp 2022-05-06 10:34:40 +02:00
simon lehericey
ce0a592f3c simplify find_type_de_champ_by_id 2022-05-06 10:34:40 +02:00
mfo
19acfe8795
Merge pull request #7259 from betagouv/US/fix-repetition-add-commune
bug(type_de_champ.repetition): on repetition, when there is a TypeDeChamp::Commune, champs for export should contain 2 entries [one with commune (postal_code), the other for commune (code_insee)].
2022-05-06 09:42:25 +02:00
Martin
8a6c3bbec0 fixup! bug(type_de_champ.repetition): on repetition, when there is a TypeDeChamp::Commune, champs for export should contain 2 entries [one with commune (postal_code), the other for commune (code_insee)]. 2022-05-06 09:38:45 +02:00
Martin
ba7a316f5e fix(Dossier.for_export): instead of iterating champs to build an hash {stable_id: values} ; we iterate on the list of all type de champs, so when there is a type de champ with mutliple values for export, we build the column with the nil value 2022-05-06 09:38:45 +02:00
Martin
b1340586de bug(type_de_champ.repetition): on repetition, when there is a TypeDeChamp::Commune, champs for export should contain 2 entries [one with commune (postal_code), the other for commune (code_insee)]. 2022-05-06 09:38:45 +02:00
Kara Diaby
9a350c4c05
Merge pull request #7256 from betagouv/feat/7178
Ajoute dans l'interface usager le contact du service de la démarche
2022-05-06 09:10:36 +02:00
Kara Diaby
5f6f19871f tests 2022-05-06 09:04:15 +02:00
Kara Diaby
39edea5541 Ajoute dans l'interface usager le contact du service de la démarche en cas de cloture ou suppression 2022-05-05 15:22:34 +02:00
mfo
5e6fcdfee1
Merge pull request #7255 from betagouv/main
2022-05-05-01
2022-05-05 14:01:31 +02:00
Paul Chavard
68148b5662
Merge pull request #7254 from tchak/fix-sentry-error
fix(dossier): on dossier update render empty js response
2022-05-05 13:47:16 +02:00
Paul Chavard
dcd9e44ce7 fix(dossier): on dossier update render empty js response 2022-05-05 13:39:24 +02:00
mfo
68523f46ec
Merge pull request #6981 from betagouv/6952/set-default-expiration-to-true
feat(procedure.expiration) ; enabled by default, also suggest to admin to enable it
2022-05-05 13:13:25 +02:00
Martin
3737311390 feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false
feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure

feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier

clean(Flipper.archive_zip_globale): no more in use, so remove all occurences

Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

Update spec/views/administrateurs/procedures/show.html.haml_spec.rb

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

fix(review): typo, why ena?, who knows

fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED
2022-05-05 13:07:11 +02:00
Paul Chavard
58068b13b9
Merge pull request #7253 from betagouv/main
2022-05-05-01
2022-05-05 12:54:30 +02:00
Paul Chavard
72fad93c61
Merge pull request #7252 from tchak/fix-form-multipart
fix(dossier): annotations privées form
2022-05-05 12:49:02 +02:00
Paul Chavard
fa1bc0b88b fix(dossier): annotations privées form 2022-05-05 12:42:58 +02:00
Paul Chavard
6cd5c07c42
Merge pull request #7250 from tchak/fix-old-edge
fix(js): prevent old Edge from crashing
2022-05-05 09:53:50 +02:00
Paul Chavard
4307445999 fix(js): prevent old Edge from crashing 2022-05-05 09:35:53 +02:00
Pierre de La Morinerie
998105b11f
Merge pull request #7248 from betagouv/fix-accuse-de-depot-dates
Usager : l'accusé de dépôt affiche la première date de dépôt du dossier
2022-05-04 17:46:44 +02:00
Pierre de La Morinerie
63b1ff9e2d dossiers: fix wrong use of created_at in the deposit receipt 2022-05-04 17:41:21 +02:00
Pierre de La Morinerie
982a209e7d dossiers: use the depose_at date in the deposit recepit
A dossier has several submission dates:
- `depose_at` is the first date at which the dossier was submitted
- `en_construction_at` is the last date at which the dossier was
  submitted OR reverted from `en_instruction` to `en_construction`.

For now we prefer to display the earliest date:
- it gives more rights to the user,
- en_construction_at means the administration can reset at will the date
  printed on deposit receipts (by moving the dossier `en_instruction`
  and then back), which we don't want.
2022-05-04 17:41:21 +02:00
Pierre de La Morinerie
0dc249e781
Merge pull request #7247 from betagouv/dossier-vide-improvements
Usager : améliorations de l'affichage d'un dossier vide en PDF
2022-05-04 17:39:59 +02:00
Pierre de La Morinerie
0ffdbbdc6d dossiers: display the procedure libelle properly on several lines
When the procedure libelle overflows on several lines, it should
push the next fields down (instead of overlapping them).
2022-05-04 17:34:13 +02:00