gregoirenovel
1f226d882c
Dont use the class << self pattern
2018-04-09 09:54:10 +02:00
gregoirenovel
e71d3a76fa
Refactor Pipedrive: create adapters and an API files
2018-04-09 09:54:10 +02:00
gregoirenovel
82d6f0b8a8
Add a method name to better separate responsabilities
...
Also rename a method to better reflect what it does
2018-04-09 09:54:10 +02:00
Frederic Merizen
6ed7ae4b53
[ Fix #1809 ] Handle non-champ tags in attestation
2018-04-06 19:22:42 +02:00
gregoirenovel
c60c58ff8b
Fix issues spotted by @fredZen in #1802
2018-04-06 16:39:54 +02:00
kemar
b42e410da0
[ Fix #1494 ] Display a warning when accepting a dossier if needed
...
Show the accompagnateur the unspecified demande
champs and attestations privées needed for the
attestation
2018-04-06 16:15:09 +02:00
simon lehericey
2e3f72bc56
[ fix #1805 ] Notice: display notice only if needed
2018-04-06 12:32:22 +02:00
Frederic Merizen
b27218c7c4
[ #1563 ] Display attestation / closed mail discrepancy alert in admin interface
...
- When changing emails
- When changing attestation
- As a safety net, on summary page
2018-04-06 10:18:56 +02:00
Frederic Merizen
a2ffc4357d
[ #1563 ] Generate a helpful alert on attestation / closed mail mismatch
2018-04-06 10:18:56 +02:00
Frederic Merizen
809638df79
[ #1563 ] Determine if Attestation and Closed mail are out of sync
2018-04-06 10:18:56 +02:00
Paul Chavard
d71aabd291
Job to fetch missing etablissement
2018-04-05 14:52:29 +02:00
Paul Chavard
45ef32e6d9
Add SIRET Type De Champ
2018-04-05 10:29:29 +02:00
Paul Chavard
0b79a3d79d
Add Siret(TypeDe)Champ STI model
2018-04-04 18:44:08 +02:00
Paul Chavard
3cd80af6cb
Add sign and verify to etablissement
2018-04-04 18:44:08 +02:00
Paul Chavard
714ebda2fe
Add SignatureService
2018-04-04 18:44:08 +02:00
simon lehericey
b15be89e0c
[ fix #1797 ][ fix #1063 ] Add notice link to dossier modifier
2018-04-04 18:05:55 +02:00
gregoirenovel
616e0041a5
Add an empty state for carto
...
Avoids parsing errors
2018-04-04 16:35:30 +02:00
simon lehericey
3c8d1f13b6
Individual: remove birthdate proxy
2018-04-04 15:27:30 +02:00
Mathieu Magnin
8c1c2f32ca
[ Fix #1724 ] Ensure that printed json is safe
2018-04-04 14:00:50 +02:00
simon lehericey
c019cb623a
Individual: use birthdate as a ... date :)
2018-04-04 13:19:39 +02:00
simon lehericey
1f536c94ab
Individual: missing individual part in old controller
2018-04-04 12:25:54 +02:00
Frederic Merizen
3e56b6fe9b
[ #1563 ] Include attestation link in default closed mail when it makes sense
2018-04-04 10:44:40 +02:00
Frederic Merizen
db0937d1eb
[ #1563 ] Allow default template name to depend on procedure
2018-04-04 10:44:40 +02:00
Frederic Merizen
7bf7347b9c
[ #1563 ] Clarify constant’s role
2018-04-04 10:44:40 +02:00
Frederic Merizen
66aca60957
[ #1563 ] Remove useless self keywords
2018-04-04 10:44:40 +02:00
Frederic Merizen
84c864ed11
[ #1563 ] Add lien attestation link to closed mail template
2018-04-04 09:34:04 +02:00
Frederic Merizen
abf938ff1b
[ #1563 ] Generalise external link generation for mails
2018-04-04 09:34:04 +02:00
simon lehericey
46fd213ad2
Individual: old controller does not care about individual anymore
2018-04-03 21:16:54 +02:00
simon lehericey
9749365cc7
Etape2 individual: procedure with individual uses the new system
2018-04-03 18:39:48 +02:00
simon lehericey
8828663880
Individual: save the birthdate in Y
2018-04-03 16:23:15 +02:00
Paul Chavard
ee5a3852b5
Show procedure link in manager view
2018-04-03 15:15:27 +02:00
gregoirenovel
3a3afc5797
Remove a now useless flash message
2018-04-03 14:12:56 +02:00
simon lehericey
ce2f076ace
Dossiers show: add notification-col class to avoir weird display
2018-04-03 13:33:27 +02:00
simon lehericey
6fa4fc0046
DossierController: factorize page logic
2018-04-03 13:33:25 +02:00
simon lehericey
05ab4c5ca6
DossierController: add tab for dossiers invites
2018-04-03 13:32:41 +02:00
simon lehericey
0bff7abb0c
User: add has many relation to dossiers_invites
2018-04-03 10:48:46 +02:00
simon lehericey
4ec6c72c96
[ fix #1755 ] clean GeoJSON polygones before save
2018-03-30 16:15:30 +02:00
gregoirenovel
fe333674a0
Remove any reference to our old name
2018-03-30 07:42:09 +02:00
Paul Chavard
fd8674dffc
Give procedure_id to SIRETService
2018-03-29 17:57:09 +02:00
Paul Chavard
a9f078265a
Add STI types de champ models
2018-03-29 17:45:19 +02:00
Paul Chavard
e8f3fda1f0
Add STI champ models
2018-03-29 17:45:19 +02:00
Mathieu Magnin
acc68bc050
[ Fix #1729 ] Do not allow <code> tags in template editors
2018-03-29 17:23:29 +02:00
Frederic Merizen
33f7b03ff2
[ Fix #1677 ] Do not show 'submit' button to invités
2018-03-29 17:03:58 +02:00
Frederic Merizen
dd219d5d40
[ #1677 ] Prevent invites from submitting a dossier
2018-03-29 17:03:58 +02:00
Frederic Merizen
b869efd7d1
[ #1677 ] After editing, send Invites back to invitation page
2018-03-29 17:03:58 +02:00
Frederic Merizen
b606afee3f
[ #1677 ] Extract NewUser::DossiersController#owns_dossier?
2018-03-29 17:02:10 +02:00
Frederic Merizen
baf881a38b
[ #1677 ] Remove no-operation
2018-03-29 17:02:10 +02:00
Frederic Merizen
839a5d43f6
[ #1677 ] Allow invites to edit dossiers
2018-03-29 17:02:10 +02:00
Frederic Merizen
13d7149b5c
[ #1677 ] Extract Dossier#invite_for_user
2018-03-29 16:59:16 +02:00
Frederic Merizen
884c430619
[ #1677 ] No need to use emails when we have users
2018-03-29 16:59:16 +02:00
simon lehericey
b2f04e2503
Usager UI: simple dossier index
2018-03-29 16:23:10 +02:00
simon lehericey
48ddb4cfb6
Dossier status: add brouillon label
2018-03-29 16:23:10 +02:00
simon lehericey
88d46594e9
Dossier status: move partial dans shared
2018-03-29 16:23:10 +02:00
gregoirenovel
094ccecc01
Rename Adapter’s siret_or_siren to siret
2018-03-29 16:06:14 +02:00
gregoirenovel
8938a5b40d
Delete SiretService.siren, move its code to EntrepriseAdapter#get_resource
2018-03-29 16:06:14 +02:00
gregoirenovel
cc9e318210
Add a comment to explain why we reject 206 responses
2018-03-29 15:36:41 +02:00
gregoirenovel
67cf614879
Mutualize some code on ApiEntreprise::Adapter
2018-03-29 11:44:59 +02:00
gregoirenovel
5f1394cd7f
ExercicesAdapter#to_array -> ExercicesAdapter#to_params
2018-03-29 11:44:59 +02:00
gregoirenovel
54ab0ec5f0
Extract code in a #handle_legacy_models! method
2018-03-29 11:44:59 +02:00
gregoirenovel
68c9849977
Mutualize the adapters’ #data_source methods
2018-03-29 11:44:59 +02:00
gregoirenovel
a9360a8be2
Mutualize Adapter initialization in a class and method
2018-03-29 11:44:59 +02:00
Frederic Merizen
2d6a780714
[ Fix #1750 ] Allow newlines in procedure descriptions as paragraph breaks
2018-03-29 11:26:53 +02:00
Frederic Merizen
bdf2831209
[ Fix #1691 ] Do not attempt to 'wrap' <p>s in other <p>s
...
It cannot be done because <p>s don't nest in HTML, so use
<div>s for the wrapping instead
2018-03-29 11:20:17 +02:00
Frederic Merizen
d825c3d586
[ Fix #1689 ] Only allow plain text for procedure descriptions
2018-03-29 10:52:37 +02:00
Paul Chavard
322f93afbe
Add administrateur#feature_enabled? method
2018-03-28 17:19:07 +02:00
gregoirenovel
f343e08ce2
Remove trailing spaces
2018-03-28 15:06:03 +02:00
gregoirenovel
681e33b850
Simplify RNAAdapter#to_params and unify the type of objects it returns
2018-03-28 10:55:15 +02:00
gregoirenovel
caf2e50954
Make #to_params return blank hashes if we have no data
2018-03-28 10:55:15 +02:00
gregoirenovel
0022ea71c5
Use #transform_keys instead of .map.to_h
2018-03-28 10:55:14 +02:00
gregoirenovel
7794973774
Simplify SIRETService#fetch
2018-03-28 10:55:14 +02:00
gregoirenovel
4b6b583120
Delete useless return statements
2018-03-28 10:55:14 +02:00
gregoirenovel
94a257f5b0
Add missing spaces
2018-03-28 10:55:14 +02:00
gregoirenovel
de483ac0f6
Format all attr_to_fetch methods the same way
2018-03-28 10:55:14 +02:00
gregoirenovel
b479833699
Reduce method calls
2018-03-28 10:55:14 +02:00
gregoirenovel
8b46df3176
Add a new variable to improve readability
2018-03-28 10:55:14 +02:00
gregoirenovel
3dd76c3d68
Remove useless success? methods
2018-03-28 10:55:14 +02:00
gregoirenovel
a9c1c9f551
Improve #success? methods
2018-03-28 10:55:14 +02:00
gregoirenovel
19add3f534
Use if-flows instead of rescue-flows
2018-03-28 10:55:14 +02:00
gregoirenovel
182afee970
to_params -> to_array
2018-03-28 10:52:54 +02:00
gregoirenovel
3e16eff9a0
Unify data_source methods
2018-03-28 10:50:27 +02:00
simon lehericey
07c9830da0
[ fix #1550 ] unify HS and activation mail, send doc as well
2018-03-27 18:09:27 +02:00
Paul Chavard
2f68b7c4b3
Tweak timeout API Entreprises
2018-03-27 17:59:51 +02:00
Paul Chavard
5ae8eb3383
Lower timeout for API Entreprise
2018-03-27 17:16:56 +02:00
simon lehericey
66a113c7db
Dossier: remove uncessary query on order_champ_v2
2018-03-27 16:48:38 +02:00
simon lehericey
8ac5415ce0
DossierController: avoid unecessary user fetch
2018-03-27 16:48:38 +02:00
simon lehericey
289ddb5419
[ fix #1670 ] Manager send the refused admin email
2018-03-27 16:02:09 +02:00
simon lehericey
d0431a28f2
Pipedrive: manager can refuse a deal
2018-03-27 15:56:28 +02:00
simon lehericey
2102130fa3
Pipedrive: allow super admin to choose target pipeline
2018-03-27 14:52:39 +02:00
simon lehericey
6a74aaa42a
[ fix #1697 ] Pipedrive: use a job to process an admin creation
2018-03-27 14:52:39 +02:00
simon lehericey
31adc8e990
Pipedrive: Rename pipedrive_dev_id
2018-03-27 14:52:39 +02:00
simon lehericey
ec3d558af0
Pipedrive: extract methods in service
2018-03-27 14:52:39 +02:00
Paul Chavard
6b7d0ccb82
Remove unused rescue in SIRET form controller
2018-03-27 13:56:22 +02:00
Paul Chavard
2fc03e9079
Handle ajax errors on SIRET form
2018-03-27 13:56:22 +02:00
Paul Chavard
a17ac5a9db
Remove debug logger
2018-03-26 17:44:51 +02:00
Paul Chavard
2505419b08
Treat partial success from api entreprises as errors
...
We might refine this later, but for now this will give an error instead of unspecified state
2018-03-26 17:44:37 +02:00
Paul Chavard
f35aef0eb6
Use Typhoeus and set agressive timeouts
2018-03-26 16:53:42 +02:00
gregoirenovel
2385548a03
[Ref #1626 ] Add the administrateurs_procedures table and associations
2018-03-23 11:40:03 +01:00
gregoirenovel
5b04fa2a4c
[ Fix #1687 ] Align sign in/up form to the top
2018-03-22 17:16:39 +01:00
Frederic Merizen
cab670b1ad
[ #1677 ] Simplify code
2018-03-22 16:40:57 +01:00
Frederic Merizen
c413dfa127
[ #1677 ] No longer create InviteGestionnaires
2018-03-22 16:40:57 +01:00
simon lehericey
9eb28faa10
[ fix #1601 ] accept demandes in manager
2018-03-22 15:37:16 +01:00
simon lehericey
9e566596fa
[ fix #1601 ] show pipedrive demandes in manager
2018-03-22 15:37:16 +01:00
Frederic Merizen
2fa88a432b
Add missing brackets around parameters in method definitions
2018-03-20 17:54:51 +01:00
gregoirenovel
862d8051c8
Fix contact link on the landing page
2018-03-20 17:15:41 +01:00
gregoirenovel
4df2eb168d
Remove mandataires_sociaux
2018-03-20 16:09:00 +01:00
gregoirenovel
d0a59058e8
Remove the mandataire_social guess
...
Rationale:
- is true for only 0.06% of Dossiers
- is not displayed anymore anyways
- will be a rare case for now
* FC adoption is not insane
* FC used more for personal than professional
matters
* not always the mandataires sociaux that fill
dossiers for their companies, so not that
relevant
- we can add it back later
2018-03-20 16:09:00 +01:00
gregoirenovel
5658aae96b
SIADE -> ApiEntreprise
2018-03-19 11:39:46 +01:00
gregoirenovel
96f78b6213
data_source methods can be private
2018-03-19 11:39:46 +01:00
gregoirenovel
9a7e13f72f
Mutualise a JSON#parse call
2018-03-19 11:39:46 +01:00
gregoirenovel
57b42e24e5
SIADEURL -> API_ENTREPRISE_URL
2018-03-19 11:39:46 +01:00
gregoirenovel
658bd95f86
Add a constant to SIADEURL
2018-03-19 11:39:46 +01:00
gregoirenovel
a0a56d6f67
Add a variable for legibility
2018-03-19 11:39:46 +01:00
gregoirenovel
5628eba0a4
mandatory_params -> params
2018-03-19 11:39:46 +01:00
gregoirenovel
b71b8ea8e0
Refactor the url method
2018-03-19 11:39:46 +01:00
gregoirenovel
92e0e4c231
Remove the base_url method
2018-03-19 11:39:46 +01:00
gregoirenovel
51c030b945
Move the URL computation to a private method
2018-03-19 11:39:46 +01:00
gregoirenovel
94176f0b53
Pass a resource instead of a url to #call
2018-03-19 11:39:46 +01:00
gregoirenovel
330f99de8a
Mutualise part of the URL
2018-03-19 11:39:46 +01:00
gregoirenovel
2c18541256
Mutualise base_url call
2018-03-19 11:39:46 +01:00
gregoirenovel
6902f502d3
Mutualise mandatory_params call
2018-03-19 11:39:46 +01:00
gregoirenovel
9daf0ee608
Remove useless attribute default
2018-03-19 11:39:46 +01:00
gregoirenovel
df06850d5d
Remove unused images
2018-03-19 11:29:27 +01:00
Mathieu Magnin
621f8143bd
[ Fix #1654 ] Generate procedure export filename with libelle
2018-03-19 11:16:05 +01:00
gregoirenovel
19a2398593
[ Fix #1644 ] In API, current_administrateur -> administrateur
2018-03-19 11:09:30 +01:00
Mathieu Magnin
4e2af06423
Use root_url in admin creation mail
2018-03-19 11:02:36 +01:00
Frederic Merizen
d60765880f
Fix authentication token description
2018-03-16 10:10:43 +01:00
Paul Chavard
e4f07dbae6
Document pagination params in api and allow to set per_page limit
2018-03-15 17:50:41 +01:00
Paul Chavard
87d1948023
Add token authentication to API
2018-03-15 17:43:45 +01:00
gregoirenovel
29f35f29a9
[ Fix #1628 ] Change phone number
2018-03-15 15:05:52 +01:00
Mathieu Magnin
ab368d44a1
[ Fix #1500 ] Add mandatory params to call api entreprise v2
2018-03-15 14:51:42 +01:00
Frederic Merizen
6c669ccc39
[ Fix #1614 ] Show newlines for textarea champs
2018-03-15 12:21:00 +01:00
Frederic Merizen
610058c534
[ Fix #1619 ] Do not consider invitations to deleted dossiers
2018-03-15 11:32:21 +01:00
gregoirenovel
031b9c0bab
Update documentation links to GitBook v2
2018-03-15 09:37:24 +01:00
Mathieu Magnin
69f8353b2f
[ Fix #1479 ] Sanitize Avis email before validation
2018-03-14 17:41:47 +01:00
Mathieu Magnin
a00114d03d
[ Fix #1479 ] Sanitize User email before validation
2018-03-14 17:41:47 +01:00
Mathieu Magnin
8731f7c63b
[ Fix #1479 ] Sanitize Administrateur email before validation
2018-03-14 17:41:47 +01:00
Mathieu Magnin
d9c562c59d
[ Fix #1479 ] Sanitize Gestionnaire email before validation
2018-03-14 17:41:46 +01:00
Mathieu Magnin
38e1609d73
[ Fix #1479 ] Validate Avis email format
2018-03-14 17:41:46 +01:00
Mathieu Magnin
247526578c
[ Fix #1479 ] Avis creation can fail gracefully
2018-03-14 17:41:46 +01:00
Mathieu Magnin
ba3b0b4687
[ Fix #1479 ] Remove unused email format validator
2018-03-14 17:41:46 +01:00
Mathieu Magnin
5650c4aefe
[ Fix #1479 ] Sanitize email format for invite
2018-03-14 17:41:45 +01:00
Mathieu Magnin
e00e8ba01d
[ Fix #1479 ] Validate email format with Rails format validation
2018-03-14 17:41:45 +01:00
Mathieu Magnin
b7de632d6c
[ Fix #1479 ] Create a sanitize email concern
2018-03-14 17:41:45 +01:00
gregoirenovel
4ec782ab15
[ Fix #1599 ] Add rel attribute to target blank links
2018-03-14 16:57:39 +01:00
gregoirenovel
8bf09ac2d4
Do not center balises
2018-03-14 16:45:34 +01:00
gregoirenovel
3f92fe9755
[ Fix #1589 ] Keep all the balises’ spaces
2018-03-14 16:45:34 +01:00
Mathieu Magnin
a90a719d9a
Improve dossier readability with wider libelles
2018-03-14 16:24:04 +01:00
Mathieu Magnin
96b1c83537
Align identite headers to dossier champs headers
2018-03-14 16:24:04 +01:00
Mathieu Magnin
ac068861f5
[ Fix #1607 ] Add email to dossier details
2018-03-14 16:24:03 +01:00
Mathieu Magnin
734950f36b
[ Fix #1609 ] Fix buttons on 2 lines
2018-03-14 12:05:50 +01:00
