DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
10011 commits 4 branches 1166 tags 84 MiB
Commit graph

10011 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pierre de La Morinerie
b290564df2
Merge pull request #5013 from betagouv/auto-upload-fix-retry 
Usager : améliorations sur le bouton "Réessayer l'envoi" des pièces justificatives
 2020-04-08 17:00:58 +02:00
Pierre de La Morinerie
72d003b62c javascript: fix missign argument to catch 
Some browers complain about this.
 2020-04-08 16:54:31 +02:00
Pierre de La Morinerie
444732b117 javascript: don't allow to retry on direct upload 422 
When the authenticity token is invalid, the creation of the blob before
the direct upload returns a 422.

In that case, the token will never become valid again, and it is useless
to try again. Don’t show the "Retry" button in this case.

NB: of course the real fix is to understand why the authenticity token
is so often invalid – but this will be for later.
 2020-04-08 15:48:23 +02:00
Pierre de La Morinerie
38b0bd645c javascript: fix clicking on the icon of the auto-upload Retry button 
When clicking on the icon, `event target` would be the icon, not
the button.

However delegates configures `this` to be the requested event target.
 2020-04-08 15:48:23 +02:00
Pierre de La Morinerie
aa2d99ef33
Merge pull request #5012 from betagouv/fix-attachments-controller 
Usager : affiche une page de redirection quand le bouton "Supprimer la pièce jointe" est ouvert dans un nouvel onglet
 2020-04-08 15:47:34 +02:00
Pierre de La Morinerie
b748e9773f attachments: fix opening the delete link directly 
When cliking on the "Delete attachment" link, and opening the URL
in a new tab, the `DELETE /attachements/:id` will become
`GET /attachments/:id` – which will cause the `show` action to be
routed with an html format (instead of JS).

In that case, we don't want to throw an error at the user face.
Instead simply re-render the dossier page (if any).

Fix a long-standing error in Sentry.
 2020-04-08 13:40:32 +02:00
Pierre de La Morinerie
0077ff4b75 attachments: refactor the controller specs 2020-04-08 12:05:55 +02:00
Pierre de La Morinerie
8ceb555941 routes: cleanup attachment routes 2020-04-08 11:57:06 +02:00
kara Diaby
473ed00b6c Revert "Revert "Revert "feat/4893 - migrate the mapReader to mapbox-gl with react""" 
This reverts commit fe0b3c2215.
 2020-04-07 18:14:07 +02:00
kara Diaby
fe0b3c2215 Revert "Revert "feat/4893 - migrate the mapReader to mapbox-gl with react"" 
This reverts commit 3e21b78142.
 2020-04-07 18:11:11 +02:00
Kara Diaby
f96ee322a0
Merge pull request #5007 from betagouv/revert-4950-feat/4893 
Revert "feat/4893 - migrate the mapReader to mapbox-gl with react"
 2020-04-07 15:37:37 +02:00
Pierre de La Morinerie
3e21b78142
Revert "feat/4893 - migrate the mapReader to mapbox-gl with react" 2020-04-07 15:32:14 +02:00
Paul Chavard
d9015c4e3c
Merge pull request #4980 from tchak/human-readable-cron 
Use human readable expressions instead of cron gibberish
 2020-04-07 13:33:37 +02:00
Paul Chavard
6dc1f3e2c4 Use human readable expressions instead of cron gibberish 
https://github.com/floraison/fugit#fugitnat
 2020-04-07 12:44:58 +02:00
Paul Chavard
a2b50efa3b
Merge pull request #5001 from betagouv/fix-attachment-errors 
javascript: ignore errors of attachments pooler
 2020-04-07 12:44:42 +02:00
Pierre de La Morinerie
38c0cdc360 javascript: ignore errors of attachments pooler 
Pooling for attachment status is a background operation. Errors should
not be reported to the user, who didn't even ask for this operation to
take place.

This is why we ignore all errors, whether Javascript exceptions or
network errors.
 2020-04-07 12:35:54 +02:00
Pierre de La Morinerie
7d712521cf
Merge pull request #5005 from betagouv/add-button-to-avis-request 
Experts : dans l'email d'invitation, le lien pour donner son avis est maintenant un grand bouton bien visible
 2020-04-07 12:35:42 +02:00
Pierre de La Morinerie
dc6ff3b4ea mailers: in avis requests, replace the small CTA link by a large button 
Fix #3402
 2020-04-07 12:05:36 +02:00
Keirua
29a136eb10
Merge pull request #5003 from betagouv/fix_4876_copy_groupe_instructeurs_in_procedure_clone 
#4876 Copy groupe instructeurs when a procedure is cloned
 2020-04-07 09:37:17 +02:00
clemkeirua
ed45c88bdf do not clone groups instructeurs for admin outside the procedure 2020-04-07 09:25:40 +02:00
pedong
7806a26e2c copy groupe_instructeurs when clone 2020-04-07 09:22:33 +02:00
Pierre de La Morinerie
97dc927289
Merge pull request #5002 from betagouv/js-fix-scroll-exceptions 
Usager : corrige une erreur Javascript au moment du Feedback, liée à l'utilisation de `window.scroll`
 2020-04-06 18:32:11 +02:00
Pierre de La Morinerie
52afb41bab js: fix errors on browsers not supporting window.scroll options 
IE and Safari only know about `window.scroll(x, y)`, and not the form
with options.
 2020-04-06 18:30:15 +02:00
Pierre de La Morinerie
6dbbaf9528
Merge pull request #4994 from betagouv/add-validation-to-champ 
Ajoute une validation pour vérifier la cohérence des champs (#4994)
 2020-04-06 18:25:47 +02:00
Christophe Robillard
dc31f41c26 fix tests for procedure_presentation 2020-04-06 17:39:51 +02:00
Christophe Robillard
5b6044803b forbid to create champ with same type_de_champ and same row 2020-04-06 17:39:51 +02:00
Pierre de La Morinerie
0538da3fad
Merge pull request #4993 from betagouv/fix-piece-justificative-in-repetitions 
Usager : correction de l'envoi automatique de pièces justificatives dans un bloc répétable
 2020-04-06 12:03:49 +02:00
Pierre de La Morinerie
ded65cfdb9 dossier: fix rendering of piece_justificative in repetition 
In repetitions we can't render the piece_justificative champ in the way
we do for normal champs (which was already a bit hackish).

Instead we render the whole form partial – and then extract the champ
from the form. In this way, we're sure to render the champ as it
appears in the form, without any hacks to reproduce the form structure.
 2020-04-06 11:50:31 +02:00
Pierre de La Morinerie
c506402dcb dossier: remove the now unused champId in auto-upload 2020-04-06 11:50:31 +02:00
Pierre de La Morinerie
91260e2867 dossier: fix upload route of piece_justificative in repetitions 
In repetitions, `form.index` doesn't make much sense. Turns out we
don't really need the index of the champ: we can just use the champ id.
 2020-04-06 11:50:31 +02:00
krichtof
e869e2741e
Merge pull request #4990 from betagouv/ameliore-decouvrabilite-fichier-telecharge 
instructeurs: ameliore la découvrabilité du fichier téléchargé
 2020-04-06 11:05:31 +02:00
Christophe Robillard
4fcbfffec1 laisse afficher le message flash avec le fichier à télécharger 2020-04-06 10:12:00 +02:00
Christophe Robillard
290edd9e69 ameliore la découvrabilité du fichier téléchargé 2020-04-06 10:12:00 +02:00
Pierre de La Morinerie
d47ec3d3ad
Merge pull request #4970 from betagouv/improve-identite-required-fields 
Usager : simplification de l'apparence des champs sur la page Identité
 2020-04-02 18:05:17 +02:00
Pierre de La Morinerie
e166f89aa0 identite: remove the "*" for required labels 
When all fields are required, it's better to say nothing.
 2020-04-02 17:34:00 +02:00
Pierre de La Morinerie
7f629ffca1 identite: mark the radio buttons as actually required 2020-04-02 17:34:00 +02:00
Kara Diaby
da938d0571
Merge pull request #4950 from betagouv/feat/4893 
feat/4893 - migrate the mapReader to mapbox-gl with react
 2020-04-02 15:56:09 +02:00
kara Diaby
aa56cfd7a0 migrate map to mapbox-gl with a react component 2020-04-02 15:39:47 +02:00
Paul Chavard
bbaffd7f4b
Merge pull request #4988 from tchak/refactor-expired-tests 
Refactor expired dossiers deletion service
 2020-04-02 15:35:15 +02:00
Paul Chavard
ca6c97bf0f Refactor expired dossiers deletion service 2020-04-02 15:24:02 +02:00
Paul Chavard
725cfa45d3 Do not set processed_at if already defined 2020-04-02 15:23:53 +02:00
Pierre de La Morinerie
c3b6e7e30f
Merge pull request #4987 from tchak/fix-order-in-test 
Les dossier.dossier_operation_logs sont par défaut ordonnés par ordre de création
 2020-04-02 14:18:18 +02:00
Paul Chavard
413abccd3c Add default order to dossier.dossier_operation_logs 2020-04-02 14:05:40 +02:00
Pierre de La Morinerie
d7faa7aeab
Merge pull request #4971 from betagouv/autocomplete-identity 
Usager : permet au navigateur web de remplir automatiquement les champs prénom, nom et mot de passes
 2020-04-02 12:15:51 +02:00
Pierre de La Morinerie
c4f2e6cab0 credentials: add autocomplete attributes 
Allow browsers to autofill more informations.

References:
- MDN: Autofill (https://developer.mozilla.org/fr/docs/Web/HTML/Attributs/autocomplete)
- Safari Password Autofill (https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element)
 2020-04-02 12:07:42 +02:00
Pierre de La Morinerie
8f7a21317a
Merge pull request #4981 from betagouv/fix-champ-policy-for-invite 
Usager : corrige les champs Carte, SIRET et pièce justificative pour les invités
 2020-04-02 11:43:55 +02:00
Pierre de La Morinerie
059e11601b policies: fix champ policy for guest users 2020-04-02 11:27:14 +02:00
Pierre de La Morinerie
c17ceb4440 policies: DRY the scope 2020-04-02 11:27:14 +02:00
Pierre de La Morinerie
ac922c456e policies: refactor champ_policy_spec 
Creating champs without attaching them to a procedure works only by
chance.
 2020-04-02 11:27:13 +02:00
Paul Chavard
533b16b6ea
Merge pull request #4976 from tchak/fix-reassign-dossiers-group-instructeur 
Reassign discarded dossiers on group_instructeur
 2020-04-01 18:30:29 +02:00