simon lehericey
d618f7cc0f
only expose chorus col when necessary
2024-10-30 18:28:25 +01:00
simon lehericey
92a863d48c
remove_all as there is no some_usager_columns
2024-10-30 18:28:25 +01:00
simon lehericey
2181a917a2
move col def to private when possible
2024-10-30 18:28:25 +01:00
mfo
656080538b
review(pull/10591#discussion_r1818942794): remove tested enum labels
2024-10-30 18:28:25 +01:00
mfo
fa50e21101
review(pull/10591#discussion_r1818919818): export without user id
2024-10-30 18:28:24 +01:00
mfo
cbb9854f4c
review(pull/10591#discussion_r1818916426): extract groupe_instructeurs_column and followers_instructeurs_email_column
2024-10-30 18:28:24 +01:00
mfo
3bed049a29
tech(style): prefix columns builders by their table, easier to understand
2024-10-30 18:28:24 +01:00
mfo
fc45e537cf
review(pull/10591#discussion_r1818914395): extract and dry archived/motivation column
2024-10-30 18:28:24 +01:00
mfo
d9fc48ad70
review(10591#discussion_r1818752344): homogenize interface for columns builders
2024-10-30 18:28:24 +01:00
mfo
8afe4374c7
review(pull/10591#discussion_r1818744664): extract some column builder
2024-10-30 18:28:23 +01:00
Christophe Robillard
df71c6a689
align columns naming and order for filter and add for export
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-30 18:28:23 +01:00
LeSim
0e589fc7ad
Merge pull request #10984 from demarches-simplifiees/fix-image-processor-job-errors
...
Technique : gestion des cas d'erreurs de ImageProcessorJob
2024-10-30 14:43:43 +00:00
Paul Chavard
c6329ef10a
feat(column): add column get_value
2024-10-30 08:10:50 +01:00
mfo
af878ca5b7
Merge pull request #10988 from mfo/US/fix-exports-recasting-simple-to-multiple
...
Correctif: ETQ instructeur je peux exporter des mes dossiers au format xlsx même si le formulaire usager a changer
2024-10-28 08:55:55 +00:00
mfo
d66487138f
fix(sentry#6013588148): allowing recasting from drop_down_list to multiple_drop_down_list raises due to call to .selected_options
2024-10-25 13:49:32 +02:00
Eric Leroy-Terquem
4dc13cc56c
fix(image processing): process only authorized image and pdf types
2024-10-24 18:48:27 +02:00
Eric Leroy-Terquem
e6845cd94d
fix(image processing): handle case of blob without attachments
2024-10-24 18:48:27 +02:00
simon lehericey
b22f049318
fix: do not allow empty filter in models
2024-10-24 12:06:32 +02:00
Paul Chavard
08490bfb82
ETQ Instructeur, je veux pouvoir faire la difference entre un champ Oui/Non vide et “Non”
2024-10-22 21:18:17 +02:00
Thibaut Poullain
5195ebd5c7
🛠️ Fix | Procedure minimal admins presence
2024-10-22 17:01:57 +02:00
Paul Chavard
51a8c3cf98
refactor(export): do not use dossier.champs in export
2024-10-22 12:31:40 +02:00
simon lehericey
0137763d42
feat: add empty_brouillon scope
2024-10-22 12:03:03 +02:00
Paul Chavard
94b06cb50f
fix(logic): we need to expose raw typed values for champs
2024-10-21 13:09:49 +02:00
Paul Chavard
5024b5b549
refactor(champs): no need to project empty champs for tag
2024-10-21 13:09:49 +02:00
Paul Chavard
1ded040730
fix(iban): format iban through type_de_champ
2024-10-21 13:09:49 +02:00
Paul Chavard
02934188b4
refactor(champ): move champ value format methods from TypeDeChamp class to instance
2024-10-21 13:09:49 +02:00
Paul Chavard
fb07bdb8aa
fix(dossier): fix preloader with champs outside of revision
2024-10-18 18:17:17 +02:00
Paul Chavard
4e8336ce88
Merge pull request #10897 from tchak/refactor-dossier-diff-merge
...
ETQ dev, je ne veux plus de méthode `champs_for_revision`
2024-10-17 09:54:08 +00:00
Paul Chavard
0529718c4b
refactor(dossier): the end of champs_for_revision
2024-10-17 11:33:24 +02:00
Paul Chavard
dd97c2fffd
refactor(dossier): diff and merge
2024-10-17 11:33:24 +02:00
Paul Chavard
8c8bb870fc
refactor(dossier): filled champs
2024-10-17 11:33:24 +02:00
Paul Chavard
ad7458a12f
Merge pull request #10931 from tchak/better-handle-api-entreprise-jobs
...
fix(api_entreprise): better handle api entreprise errors
2024-10-17 09:30:09 +00:00
simon lehericey
4059bfdc11
fix: make filter works on multiple_drop_down_list
2024-10-16 18:09:51 +02:00
Colin Darie
5522efc3e5
Merge pull request #10954 from tchak/fix-dossier-merge-with-multiple-rows
...
ETQ usager, fix soumission d'un dossier en construction quand multiples lignes de champs répétables ont été modifiées
2024-10-16 15:00:26 +00:00
LeSim
6862f6c6bd
Merge pull request #10875 from demarches-simplifiees/add_id_to_column_third_part
...
Utilisation des colonnes dans l'affichage et le filtrage
2024-10-16 14:53:30 +00:00
Paul Chavard
c417614695
fix(dossier): fix apply_diff with multiple changed rows
2024-10-16 14:15:26 +02:00
Mathieu Magnin
04bbf09097
Merge pull request #10939 from demarches-simplifiees/fix-10919
...
Correction bug champ carto
2024-10-15 18:13:13 +00:00
simon lehericey
5621edcca8
remove unused filtered? method
2024-10-15 16:09:09 +02:00
simon lehericey
f850924dc0
remove procedure_presentation from export
2024-10-15 16:09:09 +02:00
simon lehericey
71bcbbc440
remove useless snapshot
2024-10-15 16:09:09 +02:00
simon lehericey
b5ed8c9b61
export cache_key based on column
2024-10-15 16:09:08 +02:00
simon lehericey
954d232a47
add filtered and sorted columns to export
2024-10-15 16:09:08 +02:00
simon lehericey
603c2a108e
remove useless Export.by_key procedure_presentation arg
2024-10-15 16:09:08 +02:00
simon lehericey
d1530b40a1
use the filter_service
2024-10-15 16:09:08 +02:00
simon lehericey
4d7715fbb6
extract filter and sort function to a filter_service
2024-10-15 16:09:08 +02:00
simon lehericey
16e93a217b
reset procedure_presentation if a pb occurs with a column deserialization
2024-10-15 16:09:07 +02:00
mfo
112d49cb51
tech(deadcode): remove unused constant on ProcedurePresentation
2024-10-15 16:09:07 +02:00
simon lehericey
e41326dad5
tech(clean): remove sva_columns(for_filters)
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
3677f3b2d3
tech(clean): remove Column classname: attribute
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
30fcb75da4
extract dossier_state_column
2024-10-15 16:09:07 +02:00
simon lehericey
14483270ba
default default_displayed_column
2024-10-15 16:09:06 +02:00
simon lehericey
0a54db6db5
remove human_to_filter
2024-10-15 16:09:06 +02:00
simon lehericey
b2754cd26c
move validations concern to filtered_column
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:06 +02:00
simon lehericey
6b5efbda07
remove now unused code
2024-10-15 16:09:06 +02:00
simon lehericey
14fe11b612
use displayed_columns !
2024-10-15 16:09:06 +02:00
simon lehericey
7e4ca07df2
use filtered_column to filter !
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:05 +02:00
simon lehericey
4c5d7e2950
remove now useless add_filters and remove_filters
2024-10-15 16:09:05 +02:00
simon lehericey
175f303399
display filter tags
2024-10-15 16:09:05 +02:00
simon lehericey
d54ab64e40
add filtered_column type
2024-10-15 16:09:05 +02:00
simon lehericey
4e0d3c2df1
improve Column not found error message
2024-10-15 15:48:41 +02:00
Mathieu Magnin
097074fdc7
Merge pull request #10865 from demarches-simplifiees/fix-10799
...
ETQ Admin / Instructeur je veux être savoir si le jeton api entreprise d'une démarche a expiré ou va expirer prochainement
2024-10-15 13:25:20 +00:00
Paul Chavard
d13c475170
fix(api_entreprise): better handle api entreprise errors
2024-10-15 15:24:37 +02:00
Benoit Queyron
c8f69283cc
Merge pull request #10713 from demarches-simplifiees/etq-admin-bug-message-info-character-limit
...
Tech : amélioration de la gestion des types_de_champ.options
2024-10-15 13:02:33 +00:00
Paul Chavard
8ddec687e6
Merge pull request #10873 from tchak/refactor-repetition-remove-parent_id
...
ETQ dev, je ne veux plus avoir de relation entre les champs et leur parent
2024-10-15 13:00:52 +00:00
Mathieu Magnin
029a75404d
[ #10799 ] Fixes after @E-L-T review's
2024-10-15 14:40:51 +02:00
Mathieu Magnin
c897893e8a
[ #10799 ] Remove dead code
2024-10-15 14:40:50 +02:00
Mathieu Magnin
e172f3ed6c
[ #10799 ] Fix tests
2024-10-15 14:40:50 +02:00
Mathieu Magnin
6b326b634e
[ #10799 ] Modifications after Marlene's comments
2024-10-15 14:40:50 +02:00
Mathieu Magnin
64297f9ee8
[ #10799 ] Add error on procedure#show if api entreprise token is expiring
2024-10-15 14:40:50 +02:00
Mathieu Magnin
99a1b68185
[ #10799 ] reorder methods A->Z
2024-10-15 14:40:49 +02:00
Mathieu Magnin
ec2c913ab4
[ #10799 ] Display token error on related card
2024-10-15 14:40:49 +02:00
Mathieu Magnin
703a722c54
[ #10799 ] Handle the case when api_entreprise_token is not nil then set to nil
2024-10-15 14:40:49 +02:00
Mathieu Magnin
7009eed9d7
[ #10799 ] Move api entreprise token logic in a concern
2024-10-15 14:40:49 +02:00
Mathieu Magnin
2d9854dc01
[ #10799 ] Declare api_entreprise_token_expires_at attribute and feed it on save
2024-10-15 14:40:49 +02:00
benoitqueyron
e88d84cf57
ajout d'un nettoyage des options des types_de_champ lors de la publication d'une procedure ou d'une nouvelle revision
2024-10-15 14:40:33 +02:00
benoitqueyron
4f62590b7a
ProcedureRevision#compare_type_de_champ: fix bug comparaison character_limit chaine vide vs nil
2024-10-15 14:40:33 +02:00
benoitqueyron
3c5749e45a
TypeDeChamp: purge notice explicative lors d'un changement de type_champ
2024-10-15 14:40:33 +02:00
simon lehericey
b588b77571
TypeDeChamp: amélioration de la gestion des drop_down_options
2024-10-15 14:40:15 +02:00
Mathieu Magnin
49c9f274e4
[ #10919 ] When data in geo_area is invalid do not crash when .label is called
2024-10-15 14:37:32 +02:00
Paul Chavard
bd32f5693d
refactor(repetition): remove parent_id
2024-10-15 11:42:36 +02:00
Christophe Robillard
47a4f40939
destroy export_templates when destroy groupe_instructeur
2024-10-15 11:18:58 +02:00
Colin Darie
1c32a30b80
fix(filters): drop down list filters can have much longer values.
...
Notre infra supporte des urls d'au moins 8000 caractères, probablement
plus encore, donc on est large.
2024-10-14 16:01:48 +02:00
Kara Diaby
f025e08336
Ajoute la table procedure tags et la liaison entre procedure et procedures tags
2024-10-14 10:26:46 +02:00
Paul Chavard
960385831e
Merge pull request #10904 from tchak/remove-some-complex-champs-from-prefill
...
chore(prefill): remove unused prefill support on complex champs
2024-10-14 08:11:30 +00:00
Paul Chavard
f0d334ea69
Merge pull request #10916 from tchak/graphql-fix-n+1
...
fix(graphql): n+1 on procedure and france_connect_informations
2024-10-11 15:20:53 +00:00
Paul Chavard
a3375be7c5
fix(graphql): n+1 on procedure and france_connect_informations
2024-10-11 12:20:24 +02:00
Eric Leroy-Terquem
d9f604e8ce
feat(gallery): notify instructeur if pieces jointes updates
2024-10-11 11:20:46 +02:00
Paul Chavard
e56bc9d35b
chore(prefill): remove unused prefill support on complex champs
2024-10-09 12:11:42 +02:00
simon lehericey
34b0379203
procedure.find_column raise NotFound to fit AR interface
2024-10-09 09:23:06 +02:00
simon lehericey
14809b35af
add comments
2024-10-09 09:21:44 +02:00
simon lehericey
450420aa81
cache columns per request using Current
2024-10-08 22:51:26 +02:00
simon lehericey
249ddf291f
update_displayed_fields can use sorted_column
2024-10-08 22:51:26 +02:00
simon lehericey
4f0cac251d
use sorted_column to sort dossier
2024-10-08 22:51:26 +02:00
simon lehericey
ba91f2f66e
remove now useless validation
2024-10-08 22:51:25 +02:00
simon lehericey
da98aa556b
use update(sorted_column:) and remove obsolete update_sort(column_id:, order:)
2024-10-08 22:51:25 +02:00
simon lehericey
76fee12653
remove now unused procedure_presentation.opposite_order_for
2024-10-08 22:51:25 +02:00
simon lehericey
7349dd183a
notified_toggle_component use sorted_column
2024-10-08 22:51:24 +02:00
simon lehericey
22cbf725ec
column_table_header compute update_sort_path
2024-10-08 22:51:24 +02:00
simon lehericey
21533f91e3
add storted_column_type
2024-10-08 22:47:37 +02:00
simon lehericey
9652cf78c3
add default_sorted_column
2024-10-08 22:47:37 +02:00
simon lehericey
305b31e53b
add sorted_column
2024-10-08 22:47:37 +02:00
simon lehericey
693629afc8
add column type
2024-10-08 22:47:36 +02:00
mfo
5cba847d10
perf(Instructeurs/Dossiers#demande): remove n+1
2024-10-08 14:47:34 +02:00
simon lehericey
d5a722c143
weird frozen_string bug
2024-10-07 22:09:21 +02:00
simon lehericey
a418cf6632
remove_filter double_write
2024-10-07 22:09:21 +02:00
simon lehericey
870d67e844
add_filter double write
2024-10-07 22:09:21 +02:00
simon lehericey
5f6d8e93ca
update_display double write
2024-10-07 22:09:20 +02:00
simon lehericey
98c2b7e954
update_sort double write
2024-10-07 22:09:20 +02:00
simon lehericey
0abee08329
add filters for
2024-10-07 22:09:20 +02:00
simon lehericey
3d79c6176e
add columns_ids to procedure_presentations table
2024-10-07 22:09:20 +02:00
simon lehericey
e3697bd976
colonne.id = { procedure_id:, column_id: }.to_json
...
because:
- id should be a string as other id
- id need procedure_id to allow ColumnType.deserialize(id) -> Column as the columns are built by a procedure
2024-10-07 22:09:20 +02:00
simon lehericey
a8b41e90cc
remove make_id
2024-10-07 21:47:03 +02:00
simon lehericey
3740a79219
add procedure_id to column.id
2024-10-07 21:46:59 +02:00
simon lehericey
3c7521a428
extract dossier_id_column, notifications_column
2024-10-07 15:49:58 +02:00
simon lehericey
c6559577f1
remove old comment
2024-10-07 14:50:35 +02:00
Paul Chavard
274e43c5e6
fix(dossier): projected champs should have updated_at
2024-10-05 22:22:04 +02:00
Paul Chavard
70699a681d
Merge pull request #10889 from tchak/fix-dossier-follow-should-bump-updated-at
...
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-05 08:58:05 +00:00
Paul Chavard
ecbf985147
refactor(dossier): champs_* -> project_champs_*
2024-10-04 12:05:55 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic
2024-10-04 12:05:54 +02:00
Paul Chavard
25977fd97d
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-03 18:10:04 +02:00
mfo
5879d54145
Merge pull request #10866 from mfo/US/fix-filter-ilike
...
amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc...
2024-10-03 13:08:49 +00:00
simon lehericey
fb66434a15
remove empty option at the start of default options
2024-09-30 15:37:02 +02:00
simon lehericey
c638ac0261
rename drop_down_list_value -> drop_down_option_from_text
2024-09-30 15:37:02 +02:00
simon lehericey
5fc0eb11f5
rename remaining drop_down_list_enabled_non_empty_options(other: true) -> drop_down_options_with_other
2024-09-30 15:37:02 +02:00
simon lehericey
532f0f48fa
replace drop_down_list_enabled_non_empty_options by drop_down_options when possible
2024-09-30 15:37:02 +02:00
simon lehericey
cfb03fc747
remove enabled_non_empty_options indirection
2024-09-30 15:37:01 +02:00
simon lehericey
77b754a08d
no more empty case
2024-09-30 15:37:01 +02:00
simon lehericey
5a19cc1a09
remove drop_down_list_value reader
2024-09-30 15:37:01 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods
2024-09-27 11:34:06 +02:00
mfo
75063ae31e
fix(filter): filtering types_de_champs by enum should not ilike. nows it search by exact match since enum are normalized so findable with simple where
2024-09-24 20:48:10 +02:00
mfo
b30cbf3032
tech(doc): explain which columns are ilikable for user/individual
2024-09-24 20:48:09 +02:00
mfo
51ce0cd562
clean(filter): avis column are not filterable, not needed to ilike them
2024-09-24 20:47:43 +02:00
mfo
284bdc5b2b
clean(deadcode): their is no column for avis.label. so clean this one
2024-09-24 20:47:09 +02:00
Colin Darie
99534ef834
Merge pull request #10812 from colinux/date-last-updated-at-tag
...
ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR"
2024-09-24 12:21:07 +00:00
Colin Darie
2b07826202
fix(sva): add sva/svr decision date tag for relevant template emails
...
Closes #10033
2024-09-24 11:28:18 +02:00
Colin Darie
861f7359b1
feat(attestation): support last champ updated at as tag
...
closes #9825
2024-09-24 11:28:17 +02:00
Mathieu Magnin
af0692163b
Merge pull request #10839 from demarches-simplifiees/fix-10837
...
ETQ Administrateur, si j'oublie de renseigner le SIRET de mon service, je souhaite recevoir un message d'erreur explicite pour m'alerter.
2024-09-24 08:31:47 +00:00
mfo
12ef66c2b0
Merge pull request #10847 from mfo/US/clean-db
...
amélioration : ETQ tech je souhatie que ma base de donnée ne stock pas de donnée inutile
2024-09-24 08:12:09 +00:00
mfo
a71e83dabe
clean(db): remove ignored column
2024-09-24 10:04:04 +02:00
Paul Chavard
b5eb87de6a
fix(champ): improve row_id validation and remove it during export
2024-09-23 17:06:33 +02:00
mfo
7adbdaa4de
tech(clean): unused index and column
2024-09-23 14:53:37 +02:00
Paul Chavard
4ab9ef1f3f
Merge pull request #10842 from tchak/revert-du-revert-de-refactoring-champs
...
Revert "Revert "Merge pull request #10771 ""
2024-09-23 12:27:04 +00:00
Lisa Durand
0272f79c6a
migration to remove hidden_at from dossiers
2024-09-23 10:58:36 +02:00
Paul Chavard
3429a72f53
fix(dossier): do not show repetitions in header sections summary
2024-09-23 10:51:38 +02:00
Paul Chavard
6254b50de9
Revert "Revert "Merge pull request #10771 from tchak/refactor-champs-revert""
...
This reverts commit 10a1ae5534
2024-09-23 10:21:07 +02:00
Paul Chavard
e4ac781b54
fix(rnf): remove deprecated status attribute
2024-09-20 16:58:51 +02:00
Mathieu Magnin
e9b5c4a615
[ #10837 ] Add an explicit message when SIRET is not valid on service
2024-09-20 15:44:46 +02:00
mfo
cd8c55b161
Merge pull request #10814 from demarches-simplifiees/fix-10813
...
[bug] Ne pas afficher de 500 quand value_json d'un champ SIRET est nil
2024-09-19 15:22:45 +00:00
simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
...
This reverts commit c902061ebfb4ed11c788
2024-09-19 11:09:01 +02:00
LeSim
d32124d732
Merge pull request #10807 from demarches-simplifiees/slow_drop_down_cleaning
...
Tech: simplification de la logique des champs listes
2024-09-18 12:46:15 +00:00
