Commit graph

13089 commits

Author SHA1 Message Date
simon lehericey
9469734f29 Follow flipper name convention to appears on manager admin page 2019-11-07 11:09:05 +01:00
Keirua
e3513f86ef
Merge pull request #4465 from Keirua/feat/fix-incorrect-emails-retries
#4419 - Ne pas relancer les envois d'email lorsqu'ils échouent car le destinataire est inexistant
2019-11-07 10:53:08 +01:00
clemkeirua
75923f7cb2 add explanation about rescue_from in application_mailer 2019-11-07 10:13:11 +01:00
clemkeirua
7f76ab6671 disable retry sending a mail with an invalid email adress 2019-11-07 10:11:48 +01:00
LeSim
5a310b6c2b
Merge pull request #4474 from betagouv/rgaa-fix
Rgaa 3.0 : corrections pour les pages non connectés
2019-11-06 18:30:32 +01:00
simon lehericey
1a1bd306b1 Add main and headers tags in layout (RGAA 9.2.1) 2019-11-06 17:18:08 +01:00
simon lehericey
9c7feae0b2 RGAA fix : 9.1.2 Dans chaque page Web, la hiérarchie entre les titres (balises h ou balise possédant un role ARIA "heading" associé à une propriété aria-level) est-elle pertinente ? 2019-11-06 17:01:07 +01:00
simon lehericey
b6765a03ae Footer: remove top list and make each column a list as service-public.fr
(note: not so sure because of https://www.service-public.fr/P10025)
2019-11-06 17:01:07 +01:00
simon lehericey
6ec2b084c7 h3 -> p 2019-11-06 17:01:07 +01:00
simon lehericey
16814af474 Make (part of) the html valid again
simple_format always wraps its content so the better idea I have got was to use a span to avoid p in p.
2019-11-06 17:01:07 +01:00
simon lehericey
8efac29eba Better structure footer-site-links in list
it follows service-public.fr structure

- remove extraneous footer-link class
- remove extraneous space with `>` haml weird stuff
- homogenize json-style hash
- merge classes on ul
- use pseudo element for eye candy
2019-11-06 17:01:07 +01:00
simon lehericey
79968f12fb RGAA A : h4 => span in top dropdown item to respect title hierarchy (9.1.2) 2019-11-06 17:01:07 +01:00
simon lehericey
daeeeda583 RGAA: ajout de title aux links 2019-11-06 17:01:07 +01:00
Chaïb Martinez
a00ce94eea RGAA A : ajout de l'attribut alt pour les images
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-11-06 17:01:07 +01:00
Chaïb Martinez
47b177fd31 RGAA A : L'attribut alt est absent pour le logo des demarches
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-11-06 16:50:10 +01:00
Pierre de La Morinerie
a731cbb138
2019-11-06-02 (#4489)
2019-11-06-02
2019-11-06 14:42:35 +01:00
LeSim
a21897fc08
Merge pull request #4476 from betagouv/feat-use-sib
Activation de sendinblue
2019-11-06 14:01:30 +01:00
clemkeirua
04c13190c3 introduce smtp_key in order to use 2 different sendinblue keys
client_key is exposed to the client via gon, so if we use it for sending email too we are exposing a key so anybody could send an email.
The current client_key has a different level of right and can't send emails so it's ok to expose it.
2019-11-06 13:34:36 +01:00
clemkeirua
959aacdea5 Sendinblue email balancing using proper credentials
This reverts commit c61981e795.
2019-11-06 13:34:36 +01:00
Paul Chavard
8ec6eb619d
Merge pull request #4483 from tchak/fix-sentry-errors
Fix sentry errors
2019-11-06 13:03:03 +01:00
Paul Chavard
0562e2728f Fix type_de_champ validation error 2019-11-06 12:54:07 +01:00
Paul Chavard
ee62d6fca4 Fix move type de champs 2019-11-06 12:54:07 +01:00
Paul Chavard
a708b071dd Do not crash with champ repetable with no children 2019-11-06 12:54:07 +01:00
Paul Chavard
f5c80f211d Guard for missing attestation on dossier 2019-11-06 12:54:07 +01:00
Paul Chavard
95f98fe605 API v1 correctly handle resultats_par_page 2019-11-06 12:54:07 +01:00
Pierre de La Morinerie
ec6026ef2c
2019-11-06-01 (#4487)
2019-11-06-01
2019-11-06 12:33:51 +01:00
Pierre de La Morinerie
d91d1d9fa8
Correction de la recherche dans la liste des instructeurs (#4486)
Administrateur : correction de la recherche dans la liste des instructeurs
2019-11-06 12:27:51 +01:00
Pierre de La Morinerie
8df91df9fa assigns: strip and lowercase the search filter 2019-11-06 12:16:30 +01:00
Pierre de La Morinerie
0eeac59ecd assigns: fix search among the unassigned instructeurs
This was broken since moving the email out of the Instructeur column.
2019-11-06 12:16:30 +01:00
Pierre de La Morinerie
b2b577d4a9
build(deps): bump loofah from 2.2.3 to 2.3.1 (#4485)
build(deps): bump loofah from 2.2.3 to 2.3.1
2019-11-06 12:14:48 +01:00
dependabot[bot]
c5f2dacb71
build(deps): bump loofah from 2.2.3 to 2.3.1
Bumps [loofah](https://github.com/flavorjones/loofah) from 2.2.3 to 2.3.1.
- [Release notes](https://github.com/flavorjones/loofah/releases)
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md)
- [Commits](https://github.com/flavorjones/loofah/compare/v2.2.3...v2.3.1)

Signed-off-by: dependabot[bot] <support@github.com>
2019-11-06 10:33:00 +00:00
Paul Chavard
4e454a7e15
Merge pull request #4480 from tchak/use-webdrivers
Use webdrivers gem to keep webdrivers updated
2019-11-06 11:31:29 +01:00
Paul Chavard
efd03f0169 Use webdrivers gem to keep webdrivers updated 2019-11-06 11:20:40 +01:00
Paul Chavard
88a4befbc5
Merge pull request #4479 from tchak/fix-carto-errors
[API Carto]: use typhoeus and correctly handle errors
2019-11-06 11:20:08 +01:00
Paul Chavard
08b1a0f90d [API Carto]: use typhoeus and correctly handle errors 2019-11-06 11:10:56 +01:00
LeSim
d52f600b2e
Merge pull request #4484 from betagouv/fix-readme
met à jour la doc d'install
2019-11-06 09:02:22 +01:00
Christophe Robillard
91db5f4ec2 met à jour la doc d'install 2019-11-05 18:47:16 +01:00
Pierre de La Morinerie
3a33b9fd40
2019-11-05-01 (#4481)
2019-11-05-01
2019-11-05 16:57:23 +01:00
LeSim
ee877e7d89
Merge pull request #4478 from betagouv/simplify_active_notion
Déplacement de la méthode active? sur le model User
2019-11-05 16:28:04 +01:00
simon lehericey
9f5169eb7d Remove unused Administrateur.reset_password method 2019-11-05 14:10:39 +01:00
simon lehericey
395aba8bbc Remove administrateur active notion 2019-11-05 14:10:39 +01:00
simon lehericey
5643e671a0 Code use user.active? 2019-11-05 14:10:39 +01:00
simon lehericey
b193dd1465 User get the active notion 2019-11-05 14:10:39 +01:00
LeSim
40af20b733
Merge pull request #4475 from betagouv/fix-instructeur-invitation
instructeurs: fix email casing in invitation
2019-11-05 11:26:51 +01:00
Pierre de La Morinerie
c37bfc7349 instructeurs: fix email casing in invitation
When inviting an instructeur, the code first looked up an existing
instructeur using the normalized (downcased) email address–but then
tried to promote it using the non-normalized version, which failed.

This fixes the issue by always using the normalized email.
2019-11-05 10:54:58 +01:00
LeSim
1adda1b405
Merge pull request #4477 from betagouv/fix_4473_invite_an_administrateur
Répare l'invitation des administrateurs
2019-11-05 10:49:52 +01:00
simon lehericey
aeb44dd2aa Cleaning spec 2019-11-05 10:29:39 +01:00
simon lehericey
e3d7688e66 [fix #4473] Invite_administrateur!: do not reset password if the user is active 2019-11-05 10:29:39 +01:00
simon lehericey
53c7997081 Invite_administrateur!: characterization test 2019-11-05 10:29:39 +01:00
simon lehericey
243bc2887f Invite_administrateur!: remove unused return 2019-11-05 10:29:39 +01:00