Commit graph

9248 commits

Author SHA1 Message Date
Lisa Durand
38c84115e6 reorganise file order for more consistency 2023-03-16 11:32:05 +01:00
Lisa Durand
eddd7a2192 add flash alert if email field empty 2023-03-16 11:32:05 +01:00
Lisa Durand
1cbafd1e0b remove unused view instruction for instructeur 2023-03-16 11:32:05 +01:00
Lisa Durand
5b0570d289 add new fields to serializer 2023-03-16 11:32:05 +01:00
Lisa Durand
0679fdc55f delete duplicated form file 2023-03-16 11:32:05 +01:00
Lisa Durand
a4a99a72ec first step to add question in experts avis 2023-03-16 11:32:05 +01:00
Paul Chavard
4ba3c0e650 fix(graphql): return empty array when no attachments 2023-03-16 10:59:08 +01:00
simon lehericey
8b5d493f12 clean: log current_user in api v2, when not using token_v3 2023-03-16 10:06:23 +01:00
simon lehericey
7a6658700e clean: log current_user in api v1 2023-03-16 10:06:23 +01:00
simon lehericey
c0ca9f156e clean: remove unused Current.instructeur 2023-03-15 21:51:02 +01:00
simon lehericey
a984c21f64 clean: remove unused Current.administrateur 2023-03-15 21:51:02 +01:00
Paul Chavard
d481222110 refactor(graphql): extract compute_demarche_authorization 2023-03-15 19:09:49 +01:00
Paul Chavard
42e74dfc76 feat(api_token): enable fin graned access rights on tokens 2023-03-15 19:09:49 +01:00
Paul Chavard
8ee13f1719 feat(api_token): add allowed_procedure_ids and write_access 2023-03-15 19:09:49 +01:00
Paul Chavard
85d31632e3 feat(graphql): add read_only check to mutations 2023-03-15 19:09:49 +01:00
Paul Chavard
64f79bb6d8 feat(api_token): add allowed_procedure_ids to api tokens 2023-03-15 19:09:49 +01:00
Colin Darie
84271526f3 fix(admin): translation keys for private revision changes 2023-03-15 19:00:17 +01:00
Colin Darie
e2ec46a5ba
chore(sentry): set dossier scope for instructeurs as well 2023-03-15 18:59:44 +01:00
Colin Darie
b628cf85cd
feat(siret): render siret formatted like INSEE 2023-03-15 12:43:56 +01:00
Colin Darie
37afd142cb
fix(entreprise): don't leak entreprise name if it's not diffusable 2023-03-15 12:43:56 +01:00
Colin Darie
fc0f9ce193
Merge pull request #8757 from colinux/manager-save-click-to-admin
Manager: liens directs vers les pages ETQ admin et ETQ instructeur d'une démarche
2023-03-14 15:55:01 +00:00
Paul Chavard
53e6ad135f Update app/controllers/concerns/turbo_champs_concern.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-03-14 15:22:13 +01:00
Paul Chavard
c521724cf4 Update app/components/dossiers/edit_footer_component.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-03-14 15:22:13 +01:00
Paul Chavard
cbaa77fca7 feat(annotations): activate autosave 2023-03-14 15:22:13 +01:00
Lisa Durand
ff10a03ffe
Merge pull request #8755 from demarches-simplifiees/adjust-badge-for-usager
[design] Corriger l'alignement des badges du dossier côté usager
2023-03-14 13:11:57 +00:00
LeSim
2d203d6461
Merge pull request #8756 from colinux/fix-cron-expired-dossiers-brouillon
fix(job): ExpiredDossiersDeletionJob détruit en batch les dossiers en brouillon expirés
2023-03-14 12:35:41 +00:00
Lisa Durand
2554f72668 remove useless class in html 2023-03-14 11:04:19 +01:00
Colin Darie
219c50ccaa feat(manager): direct link to procedure admin & instructeur pages 2023-03-13 11:01:14 +01:00
Colin Darie
520142a9c6 fix(job): Cron::ExpiredDossiersDeletionJob destroy brouillon expired in batch 2023-03-13 10:32:53 +01:00
Lisa Durand
17c8450450 adjust badge alignement for users dossiers 2023-03-10 17:54:10 +01:00
mfo
df05c4fbc5
Merge pull request #8754 from mfo/US/fix-duree-conservation-dans-ds
correctif(procedure.maj): quand la duree conservation dans ds est supérieur a 12, on ne pouvait plus mettre a jour la procedure
2023-03-10 09:28:31 +00:00
Lisa Durand
1f03130d52
Merge pull request #8728 from demarches-simplifiees/revoke-usager-transfert-demande
[usager] peut révoquer une demande de transfert
2023-03-10 09:21:59 +00:00
Martin
0b3f279012 correctif(procedure.maj): utilise procedure.max_duree_conservation_dossiers_dans_ds plutot que duree_conservation_etendue_par_ds pour contraindre la saisie du champs duree_conservation_dossiers_dans_ds 2023-03-10 10:18:29 +01:00
Colin Darie
6a2a7fa2d0
Merge pull request #8753 from colinux/fix-auto-numering-in-repetition
Fix(dossier): ne numérote pas automatiquement les titres de section dans les répétitions
2023-03-09 15:41:57 +00:00
Colin Darie
88efef0718
Merge pull request #8749 from colinux/fix-tags-persistence
Administrateur: ne supprime pas les tags quand on n'interagit pas avec la liste de sélection
2023-03-09 15:25:15 +00:00
Colin Darie
6243e5fb92
Merge pull request #8748 from colinux/fix-clone-estimated-dossier
Administrateur: le clone d'une démarche ne copie pas le cache du nombre de dossiers
2023-03-09 15:25:08 +00:00
Colin Darie
bc1ade02c0
Merge pull request #8750 from colinux/fix-jobs
Jobs: rallonge durée max pour les exports, fix des timeouts, isole DossierRebase
2023-03-09 15:22:30 +00:00
Colin Darie
f33d192142 fix(dossier): don't auto-number header sections in repetitions 2023-03-09 16:15:56 +01:00
Colin Darie
4288f28ac8 chore(job): same max_run_time between ArchiveCreationJob and ExportJob 2023-03-09 15:37:13 +01:00
Colin Darie
697aeeb348 refactor(job): DossieRebaseJob in new queue so they don't interfere with others
Ces jobs sont empilés par milliers d'un coup et peuvent mettre des dizaines
de minutes à s'écouler. On ne veut pas que ça interfère avec d'autres jobs,
notamment les scans antivirus qui, si retardés, empilent des "poll" pour
connaitre le status du fichier.
2023-03-09 15:18:14 +01:00
Lisa Durand
6ba47b731b refacto destroy action and add spec for unauthorized user 2023-03-09 14:58:47 +01:00
Lisa Durand
507d01dd44 use dsfr table for transfer receiver view 2023-03-09 14:58:44 +01:00
Lisa Durand
3d5bf40c0f allow transfer sender to revoke a transfer 2023-03-09 14:57:59 +01:00
Colin Darie
9e6d06fd9c fix(job): attempt to fix a pg timeout int Cron::NotifyDraftNotSubmittedJob 2023-03-08 18:45:02 +01:00
Colin Darie
86f15b8c05 chore(job): config delayed job for long-living export jobs 2023-03-08 18:37:41 +01:00
Colin Darie
6b87c290cb fix(cron): PurgeOldEmailEvent in batches 2023-03-08 15:31:10 +01:00
Colin Darie
d20114f978 chore(sentry): use "procedure" tag everywhere for a better debug experience 2023-03-08 13:48:44 +01:00
Colin Darie
c112018ec3 fix(administrateur): tags persistence when non interacting with tags combobox 2023-03-08 11:27:31 +01:00
Eric Leroy-Terquem
9e0753a710 fix(groupe instructeur mailer): do not notify if no added instructeurs 2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem
e1906febcc feat(groupe instructeur): can enable routing from import 2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
9f0f5b0dc5 feat(groupe instructeur): allow import of many groups when procedure is not routed yet 2023-03-08 10:48:02 +01:00
Colin Darie
d6887f8aa4 fix(procedure): clone reset estimated_dossiers_count 2023-03-07 19:11:30 +01:00
Colin Darie
126819939b
Merge pull request #8678 from colinux/fix-explication-read-more-button
fix(a11y): improve Explication "lire plus"  accessibility
2023-03-07 15:37:02 +00:00
Martin
2b99bbd836 correctif(cadastre): certaines parcelles cadastrales ne contiennent pas la surface. cf: cadastre : numero: 4120 commune: 73094 prefixe: 000 section: A à CREST VOLAND 2023-03-07 14:42:44 +01:00
Martin
5e24c0e19a correctif(dossier.export.pdf): l'export au format pdf d'un dossier ayant un champ de type repetition contenant un titre est bien sous-sectionné 2023-03-07 07:00:28 +01:00
mfo
6e86a0e622
Merge pull request #8744 from mfo/US/8737/correctif-export-sans-avis-expert
correctif(export.zip): integre les avis dans l'export au format pdf du dossier
2023-03-06 15:35:57 +00:00
Colin Darie
d87495c5fc
Merge pull request #8723 from colinux/fix-failing-jobs
Attempts to fix timeout and errors cron jobs
2023-03-06 14:02:55 +00:00
Martin
c470cca9ab correctif(export.zip): integre les avis dans l'export au format pdf du dossier 2023-03-06 14:58:26 +01:00
Colin Darie
43613009d6
fix(job): Cron::WeeklyOverviewJob simplified and respect dolist API rate limiting 2023-03-06 14:39:55 +01:00
Colin Darie
f8f14830a6
fix(missing-antivirus-job): retry when backend is unavailable 2023-03-06 14:39:55 +01:00
Lisa Durand
875d5b7ce5
Merge pull request #8710 from demarches-simplifiees/use-DSFR-class-badge-for-dossier-states
[Design] Implémentation des classes DSFR pour les badges d'état des dossiers
2023-03-06 11:45:42 +00:00
Lisa Durand
4a75dffa08 simplification for duplicated when and re-implement .label class in case it is still used 2023-03-06 12:27:21 +01:00
Lisa Durand
d65050ff44
Merge pull request #8701 from demarches-simplifiees/improve-instruction-dropdown
[instructeurs] amelioration UX du bouton d'instruction
2023-03-06 10:45:00 +00:00
Colin Darie
35674838d1
Merge pull request #8720 from demarches-simplifiees/feat/8549
ETQ administrateur, je souhaite filtrer avec plusieurs tags
2023-03-06 10:19:22 +00:00
Colin Darie
8722ee028d
Merge pull request #8729 from colinux/fix-groupe-instructeur-wrongly-invalid
fix(groupe-instructeur): un groupe instructeur inactif est valide tant qu'il reste un groupe actif
2023-03-06 10:13:16 +00:00
Kara Diaby
cb0417aad4 Possibilité de selectionner plusieurs tags dans la page toutes les demarches 2023-03-03 11:50:47 +01:00
Lisa Durand
d334d70f13 use DSFR class for dossier states badge 2023-03-02 16:37:05 +01:00
Lisa Durand
99c5a1f298 use DSFR classes for btn and form inside the dropdown 2023-03-02 16:34:58 +01:00
Lisa Durand
7130ea7e99 fix specs 2023-03-02 16:34:58 +01:00
Lisa Durand
a4932a749c improve UX of instruction dropdown menu 2023-03-02 16:34:58 +01:00
Colin Darie
20d4a8153d
fix(groupe-instructeur): a closed groupe with an active groupe is a valid record 2023-03-02 16:34:18 +01:00
Damien Le Thiec
687c05e6d1
Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue
Dossier prefill get without stored queries
2023-03-02 14:01:04 +00:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
2023-03-02 13:28:23 +00:00
Paul Chavard
e89e31c66f
Merge pull request #8725 from mfo/US/fix-change-pj
correctif(admin/procedures#champs): ajoute le formulaire pour supprimer une PJ
2023-03-02 13:01:32 +00:00
Paul Chavard
6647be216b
Merge pull request #8722 from E-L-T/do-not-notify-group-when-instructeurs-removed
feat(groupe instructeur): do not notify group when instructeurs removed
2023-03-02 12:51:23 +00:00
Martin
81c389a465 correctif(admin/procedures#champs): ajoute le formulaire pour supprimer une PJ 2023-03-02 13:51:00 +01:00
Christophe Robillard
6af01077b6 disable 2FA according to config
2FA is disabled for superadmin unless `SUPER_ADMIN_OTP_ENABLED` is equal
to `enabled` (default value)
2023-03-02 13:47:48 +01:00
Colin Darie
e9585632d9 fix(job): hopefully fix pg timeouts in Cron::PurgeUnattachedBlobsJob 2023-03-02 13:42:04 +01:00
Paul Chavard
ac00a91984 fix(graphql): fix etablissement in degraded mode 2023-03-02 13:32:17 +01:00
Eric Leroy-Terquem
f6c4986e86 feat(groupe instructeur mailer): do not notify group when instructeurs removed 2023-03-02 09:46:58 +01:00
Colin Darie
9512ac467c fix(job): attempt for timeout on Cron::ExpiredDossiersDeletionJob 2023-03-01 19:00:52 +01:00
sebastiencarceles
00fa8dc895 transform value to also populate external id 2023-03-01 14:03:54 +01:00
sebastiencarceles
a7b21fcd7c let address champ be prefillable 2023-03-01 14:03:54 +01:00
Colin Darie
f752dd7085
Merge pull request #8718 from tchak/feat-old-browsers-datetime
fix(datetime): improuve datetime field on old browsers
2023-03-01 11:52:11 +00:00
Paul Chavard
d3ef0fcf79 fix(datetime): improuve datetime field on old browsers 2023-03-01 12:30:25 +01:00
Christophe Robillard
6851a9ee52 falsify opendata flag for some procedures
`procedures:falsify_opendata_procedures` rake task allows to falsify
opndata flag for procedures listed in csv file given in input (with only
one column : id column)
2023-03-01 11:47:11 +01:00
Paul Chavard
ef970dbfe5
Merge pull request #8716 from tchak/feat-number-input
fix(form): disable scroll wheel on number inputs
2023-03-01 10:31:38 +00:00
Paul Chavard
983c533eef fix(form): disable scroll wheel on number inputs 2023-03-01 11:11:37 +01:00
krichtof
5840c8c7f9
Merge pull request #8711 from demarches-simplifiees/8708-demarches-publiques
Ne pas publier le descriptif de toutes les procedures sur datagouv
2023-03-01 10:09:47 +00:00
Damien Le Thiec
8a7cb3f1fe
Merge branch 'main' into fix/stored_query_issue 2023-03-01 10:22:40 +01:00
Colin Darie
3f15647b8e
refactor(a11y/combosearch): every combo with screen reader better support 2023-03-01 09:38:45 +01:00
Colin Darie
71d43e9591
feat(a11y/combosearch): translatations for screen reader 2023-03-01 09:38:44 +01:00
Colin Darie
acffd45a22
feat(a11y/combosearch): add aria-ownws props
However it may be redundant due to aria-controls presence.

Cf #8643
2023-03-01 09:36:08 +01:00
Colin Darie
07579c9a58
feat(a11y/combosearch): announce results to screen readers
From http://haltersweb.github.io/Accessibility/autocomplete.html

Closes #8643
2023-03-01 09:36:08 +01:00
Colin Darie
6dd7e867d2
feat(a11y/combosearch): add screen reader instructions
Cf #8643
2023-03-01 09:36:07 +01:00
Sébastien Carceles
3c0eaae24c
Merge pull request #8625 from demarches-simplifiees/prefill/annuaire-education
feat(dossier): prefill annuaire education champ
2023-03-01 08:20:59 +00:00
Colin Darie
ee6e3911cd
Merge pull request #8712 from colinux/fix-annotations-privees-auto-numbering
fix(annotations-privees): initialisation de la numérotation automatique
2023-02-28 17:53:22 +00:00
Paul Chavard
c8571f0ee4
Merge pull request #8639 from tchak/a11y-progress-bar
refactor(progress): move progress bar markup to haml
2023-02-28 17:50:22 +00:00
Paul Chavard
f31241e067 fix(graphql): fix etablissement as_degraded_mode? 2023-02-28 18:09:13 +01:00
Colin Darie
c05cc4a42d fix(annotations-privees): auto counter was not properly enabled 2023-02-28 17:49:39 +01:00
Christophe Robillard
9ff88db48c publish only some opendata procedures for datagouv
- only published or closed procedures
- only procedures with flag opendata
- only procedures with 4 or more dossiers
- only procedures without word "mail" in lien_site_web
- only procedures without word "intra" in lien_site_web
2023-02-28 17:02:08 +01:00
Damien Le Thiec
a6db8a6556 Remove prefill token expire at 2023-02-28 16:54:52 +01:00
Paul Chavard
47a8d33d85 refactor(progress_bar): should be a component 2023-02-28 16:36:18 +01:00
Julie Salha
af31e097fb Add a11y attributes progressbar
Peux-tu également prévoir une traduction pour l'attribut aria-label stp ? ("File upload").
N'hésite pas si tu as des questions.
2023-02-28 16:36:18 +01:00
Paul Chavard
97f0df0598 refactor(progress): move progress bar markup to haml 2023-02-28 16:36:18 +01:00
Paul Chavard
294a5135ce feat(public/api): add dossier state api 2023-02-28 16:35:25 +01:00
sebastiencarceles
f52554b5a3 review: update value with async fetch
1 - spec cover the job which fetches external data

2 - refactor the job with guard clauses

3 - delegate update operation to the champ itself

4 - annuaire education: override the update operation
to let the value be populated by the fetched data

5 - prefilling: don't fetch data synchronously
2023-02-28 14:53:08 +01:00
sebastiencarceles
d7bfb9dc18 enrich value from education api 2023-02-28 14:23:38 +01:00
Paul Chavard
c339f609c0 fix(demarches): improuve turbo refresh on demarches page 2023-02-28 14:05:23 +01:00
sebastiencarceles
71f1e785ab let annuaire education champ be prefillable 2023-02-28 13:26:35 +01:00
krichtof
dee499d386
Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones
liste toutes les démarches, même celles non associées à des zones
2023-02-28 10:58:07 +00:00
Colin Darie
cc6ea04539
Merge pull request #8702 from colinux/fix-ban-shortcut-noresult
fix(combo-address): provide a valid empty response
2023-02-28 09:00:21 +00:00
sebastiencarceles
a08bb1bddc fix epci: all possible values 2023-02-28 08:37:52 +01:00
sebastiencarceles
2ae2d99e93 fix communes: all possible values 2023-02-28 08:36:43 +01:00
Colin Darie
396f545cf2 fix(comboadress): provide a valid empty response 2023-02-27 18:41:02 +01:00
Lisa Durand
07bb27a3af add repasser_en_instruction to dossiers expirants 2023-02-27 17:57:46 +01:00
Lisa Durand
e076981571
add comment in dsfr.scss
Co-authored-by: mfo <mfo@users.noreply.github.com>
2023-02-27 17:49:48 +01:00
Colin Darie
da5618b9fc
Merge pull request #8673 from colinux/translate-help-dropdown
Accessibilité: traduit les menus contextuels d'aide, normalise l'affichage et les icônes (dsfr)
2023-02-27 16:40:27 +00:00
Colin Darie
ae93d3927e refactor(dossier): extract sections logic in a concern 2023-02-27 17:29:22 +01:00
Colin Darie
8156e1cc01 feat(admin): notice about auto numbering of header section 2023-02-27 17:29:22 +01:00
Colin Darie
1981bfc88e feat(tdc): strip libelle so header section titles always start with something 2023-02-27 17:29:22 +01:00
Colin Darie
d7880f7e58 feat(dossier/pdf): header sections numbering 2023-02-27 17:29:22 +01:00
Colin Darie
3de089d6c7 fix(conditional): dynamic title counters using css
Closes #8086
2023-02-27 17:29:22 +01:00
Colin Darie
4d1a5f230c feat(a11y/i18n): inject user locale to chat / crisp 2023-02-27 17:23:43 +01:00
Colin Darie
8a340b6f74 fix(upload): missing i18n key 2023-02-27 17:23:43 +01:00
Colin Darie
a931bea712 feat(a11y/i18n): translate skiplinks 2023-02-27 17:23:43 +01:00
Colin Darie
7a67345d49 refactor(help_dropdown): fix font sizes & use dsfr icons 2023-02-27 17:23:43 +01:00
Colin Darie
11fb3a5ca8 fix(i18n): translate contextual procedure help dropdown
Cf #8665
2023-02-27 17:23:43 +01:00
Paul Chavard
7076d6d99e fix(turbo): rerender only top part of the header 2023-02-27 16:06:11 +01:00
sebastiencarceles
35f4874b69 allow integers only 2023-02-27 15:16:40 +01:00
sebastiencarceles
13229158bd let dossier link champ be prefillable 2023-02-27 15:14:39 +01:00
sebastiencarceles
0e3126cf83 review: readability 2023-02-27 14:35:11 +01:00
sebastiencarceles
39545671f3 refacto: better error management 2023-02-27 14:35:11 +01:00
Sébastien Carceles
e89c8385a4 fetch association data when editing the dossier 2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2 don't clean the rna champ value
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.

Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Sébastien Carceles
7e55aca107 allow rna prefill 2023-02-27 14:35:11 +01:00
sebastiencarceles
396ebbcf2b refactor rna controller to use that new ability 2023-02-27 14:31:58 +01:00
sebastiencarceles
7d65a34bc6 rna champ can fetch it's own association 2023-02-27 14:31:58 +01:00
Lisa Durand
636e6aa6cb fix broken tabs with turbostream 2023-02-27 14:30:10 +01:00
Sébastien Carceles
e16f2bc39d
Merge branch 'main' into prefill/siret 2023-02-27 14:13:03 +01:00
sebastiencarceles
becf4da70a fix raison social fetch 2023-02-27 13:54:35 +01:00
Paul Chavard
2a6065ea31
Merge pull request #8694 from tchak/fix-filter-options
fix(filter): fix find type de champ by stable_id
2023-02-27 12:48:25 +00:00
sebastiencarceles
30eef3e128 review: detailled error message 2023-02-27 13:45:16 +01:00
Sébastien Carceles
2ad4e4c01f refacto: better error management 2023-02-27 13:45:16 +01:00
Sébastien Carceles
b6c74b0e83 fetch etablissement when editing the dossier 2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542 don't clean the siret champ value
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Sébastien Carceles
3eb76d8a43 allow siret prefilling 2023-02-27 13:45:16 +01:00
Sébastien Carceles
88136daf14 refactor siret controller to use that new ability 2023-02-27 13:39:31 +01:00
Sébastien Carceles
5876dab096 siret champ can fetch it's own etablissement 2023-02-27 13:39:31 +01:00
Paul Chavard
b9080e2ff5
Merge pull request #8698 from tchak/fix-adresse-select
fix(autocomplete): avoid double escape of query params
2023-02-27 11:32:46 +00:00