DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
9208 commits 4 branches 1166 tags 84 MiB
Commit graph

9208 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Chavard
39afa6659c
Merge pull request #4588 from tchak/clean-up-demarche-states 
Clean up procedure states
 2019-11-28 14:45:24 +01:00
Paul Chavard
c1c8ab7ac6 Disable transition from publiée to brouillon 2019-11-28 14:17:47 +01:00
Paul Chavard
3e334a3306 Drop test_started_at 
# Conflicts:
#	spec/models/procedure_spec.rb
 2019-11-28 14:17:47 +01:00
Pierre de La Morinerie
23af0d5d93
Merge pull request #4589 from betagouv/upgrade-capybara 
Mise à jour de Capybara
 2019-11-28 12:25:53 +01:00
Pierre de La Morinerie
e7dd9e36d6 specs: fix Capybara warning 
Capybara logs several warnings during tests:

> Locator Integer:243 for selector :link must be an instance of String
> or Symbol. This will raise an error in a future version of Capybara.

This is because we use selectors like `have_link(dossier.id)`, where the
locator is a Number (instead of a String or Symbol).
 2019-11-28 12:09:12 +01:00
Pierre de La Morinerie
939a162057 gems: upgrade Capybara 
Fix #4536
 2019-11-28 11:31:42 +01:00
LeSim
88d3fd718c
Merge pull request #4585 from betagouv/benjaminhenkel-patch-2 
Correction d'une petite faute
 2019-11-27 17:20:59 +01:00
benjaminhenkel
09d0c8d8a4 Correction d'une petite faute 2019-11-27 16:13:17 +00:00
LeSim
5ad4844977
Merge pull request #4583 from betagouv/fix-autosave-on-file-inputs 
Corrige la fonction de sauvegarde automatique qui n'ignorait pas les bons champs
 2019-11-27 15:03:35 +01:00
Pierre de La Morinerie
b9fd844633 dossiers: fix autosave not ignoring file inputs 
The dossier autosave is supposed to ignore file inputs (which are
handled differently by ActiveStorage).

Fix a typo in the CSS selector.
 2019-11-27 13:57:39 +00:00
LeSim
a78e4dc584
Merge pull request #4578 from betagouv/fix_add_instructeur_with_empty_mails 
Corrige une erreur lors de l'affectation d'instructeur avec une adresse vide
 2019-11-27 14:45:14 +01:00
simon lehericey
6657459f9c Fix add instructeur with empty mail 
As select2 does not handle required attribute, we can only add server side logic
 2019-11-27 14:39:16 +01:00
LeSim
944338206c
Merge pull request #4574 from betagouv/landing_accessibility 
Améliore l'accessibilité de la page d'accueil
 2019-11-27 14:10:03 +01:00
simon lehericey
71051441d6 only one h1 2019-11-27 12:59:08 +00:00
simon lehericey
38d433b53d Add some role 2019-11-27 12:59:08 +00:00
simon lehericey
07112f2e15 Remove alt on decorative image 2019-11-27 12:59:08 +00:00
simon lehericey
2f47495173 Use h1 tag for .hero-tagline 2019-11-27 12:59:08 +00:00
simon lehericey
9296e24452 Reduce marianne image to 65px wide as ie11 cannot resize svg 2019-11-27 12:59:08 +00:00
simon lehericey
d4f256b735 Use text instead of image for logo 
- "it is good design practice to use actual text that is styled with CSS rather than image-based text presentation" (https://www.w3.org/WAI/tutorials/images/textual)

- mm markup que https://www.gov.uk/ et que https://www.w3.org/WAI/tutorials/images/decorative/#decorative-image-as-part-of-a-text-link
 2019-11-27 12:59:08 +00:00
Pierre de La Morinerie
c4fc213384
[GraphQL]: normalize date names in French (#4561) 
GraphQL : normalise le nom des dates en français
 2019-11-27 12:29:57 +01:00
Paul Chavard
e9f993fe0c [GraphQL]: normalize date names in French 2019-11-27 12:23:00 +01:00
Pierre de La Morinerie
752bd50e05
Fix editeur de champs specs (#4577) 
Administrateur : amélioration de la stabilité de l'éditeur de champs
 2019-11-27 12:11:19 +01:00
Pierre de La Morinerie
a328e8d94a features: refactor the editor specs 
- Add an `add_champ` helper
- Stop relying on a default champ being created
- Wait for all champs to be created by watching the "Add champ" button 

This should fix the flakiness of these tests.

Refs #4417
 2019-11-27 11:58:46 +01:00
Pierre de La Morinerie
52051914aa editor: disable the "Add champ" button until the champ is saved 
Otherwise some champs are created before the previous one has been
saved, and React complains that several champs have the same
`champ-undefined` key.

(Plus it made the tests flaky and unreliable.)
 2019-11-27 11:58:46 +01:00
Pierre de La Morinerie
7ed649dfca editor: don't create a champ by default 
Before the editor attempted to create a default champ as soon as the
list became empty.

This created many race conditions, which made the tests flaky.

Remove this behavior, and add an empty label instead.
 2019-11-27 11:58:45 +01:00
Pierre de La Morinerie
d0cd875e91 features: add a leave_browser_open helper 2019-11-27 11:58:45 +01:00
Pierre de La Morinerie
0ef4a5253c features: move feature matchers to their own file 
This allows to have the same syntax than native Capybara matchers.
 2019-11-27 11:58:45 +01:00
Pierre de La Morinerie
5d797abb8c
Autosave : amélioration de la fiabilité (#4571) 
Usager : amélioration de la fiabilité de l'enregistrement automatique
 2019-11-27 11:58:21 +01:00
Pierre de La Morinerie
f58f9f9950 dossiers: render a valid response after an autosave 
This helps Firefox DevTools to mark the request as valid and completed
successfuly.
 2019-11-27 10:37:33 +00:00
Pierre de La Morinerie
30b822b135 dossiers: don't trigger an autosave when an attachment is modified 
The draft autosave should not be triggered when attaching a file
(as file inputs are handled separately).
 2019-11-27 10:37:33 +00:00
Pierre de La Morinerie
c6eab70679 dossiers: autosave shouldn't send files being uploaded 
When a file is being uploaded asynchronosely, hidden input fields
are created by DirectUpload to contain the result of the upload.

However, before the upload finishes, the value of these inputs is not
meaningful. Moreover, it makes the ActiveRecord signature invalid – thus
preventing drafts from being saved.

Exclude these fields from the auto-save.
 2019-11-27 10:37:33 +00:00
Pierre de La Morinerie
64d96646a3 javascript: autosave with explicit cookies settings 
Older browsers implemented a different default value for `window.fetch`
credentials: it was omitted unless explicitely set.

So we force the value for these older browsers:

- Firefox 39-60
- Chrome 42-67
- Safari 10.1-11.1.2

See https://github.com/github/fetch#sending-cookies
 2019-11-27 10:37:33 +00:00
Pierre de La Morinerie
2309017727 javascript: add a window.fetch polyfill 
This allows the autosave to work on browsers that don't support fetch:

- IE 11
- Edge < 14
- Safari < 11
 2019-11-27 10:37:33 +00:00
LeSim
44f28241c4
Merge pull request #4540 from maatinito/issue/bad_closing_hour 
Prise en compte des fuseaux horaires pour la fermeture des procédures
 2019-11-26 16:56:19 +01:00
maatinito
9de9a1fd71 Use time.zone functions instead of server time functions 
(Time.zone.today vs Date.today)
 2019-11-26 14:26:36 +01:00
maatinito
14bc2b99b9 auto-archive badly occurs in UTC time and not in local time (1 hour too late in France, 10 hours before in Tahiti ;-) 2019-11-25 14:39:42 +01:00
LeSim
6c2c3aae14
Merge pull request #4569 from betagouv/fix-instructeur-admin-dashboard 
manager: fix Instructeur and Administrateur email
 2019-11-25 14:38:09 +01:00
Pierre de La Morinerie
c2c332244e manager: fix Instructeur and Administrateur email 
Use the email attribute on the User (rather than the deprecated email
column on Instructeur or Administrateur).

Fix #4565
 2019-11-25 13:01:22 +01:00
Keirua
77abd65bab
Merge pull request #4547 from Keirua/4378-pjs-messagerie-durant-telechargement 
Ajout des fichiers de la messagerie dans l'export zip du dossier
 2019-11-25 10:38:01 +01:00
clemkeirua
789fcf72ca ajout d'un test automatisé 2019-11-25 10:37:10 +01:00
clemkeirua
9503a363e5 4378 Ajout des PJ de la messagerie dans le zip des PJs du dossier 2019-11-25 10:36:32 +01:00
LeSim
9a3be41c90
Merge pull request #4564 from betagouv/fix-routage-feature-spec 
Corrige un test bout en bout peu fiable sur le routage
 2019-11-21 20:43:25 +01:00
Pierre de La Morinerie
1de4ef8a9a specs: fix error in routing feature test by waiting for Turbolinks 2019-11-21 18:37:51 +01:00
Pierre de La Morinerie
b78134c691 specs: make the routing feature test more robust 
- Use human-readable form labels
- Always wait for the result of the previous action to be loaded before
  starting another action
 2019-11-21 18:29:45 +01:00
LeSim
04f29b404f
Merge pull request #4556 from betagouv/more_accessibility 
Corrige des fautes syntaxiques html
 2019-11-21 17:17:09 +01:00
simon lehericey
054181a16f Champ Repetition has no label, thus it's displayed as a section 2019-11-21 15:34:59 +01:00
simon lehericey
2162522814 ul should have li childs 2019-11-21 15:34:59 +01:00
simon lehericey
bc85e9b7ec Use aria-describedby to link notice and input again 
https://www.w3.org/WAI/tutorials/forms/instructions/#using-aria-describedby
 2019-11-21 15:34:59 +01:00
simon lehericey
84b125d272 p cannot be included in label 
The main problem come from
%label{for: input_id}
  #{champ.libelle}
  %span.notice= string_to_html(champ.description)
%input

where string_to_html contains p tags

The proposed solution is
%label #{champ.libelle}
%p.notice
%input

It should be iso in the graphic sense.
 2019-11-21 15:34:59 +01:00
simon lehericey
d5da7916e5 Placeholder not allowed in date input 2019-11-21 15:34:59 +01:00