Commit graph

8496 commits

Author SHA1 Message Date
clemkeirua
43424e4f4e merge with the work of paul, using 3 links 2019-10-22 09:51:14 +02:00
clemkeirua
70ea5e167e procedure download is performed through a controller in order not to leak the URL 2019-10-22 09:50:58 +02:00
clemkeirua
1af2b63ed1 initial implementation of async export 2019-10-22 09:50:58 +02:00
Keirua
e66a94d7d2
Merge pull request #4420 from betagouv/add-expert-specs
Ajout de tests d'acceptance pour les Experts

On garde les todos qui restent pour une autre fois.
2019-10-21 16:52:14 +02:00
Pierre de La Morinerie
f0c2599d18 specs: improve feature spec for experts
- Move the avis feature spec to a separate file
- Add more test cases
2019-10-21 12:57:10 +02:00
Pierre de La Morinerie
ec6ec6f4aa specs: improve avis factory
The instructeur, dossier and claimant where created regardless of
wether they already existed or not.

With this commit:

- Associations are declarated in a more idiomatic way
- They are correctly not created if they are provided when creating the
object.
2019-10-21 12:57:10 +02:00
Pierre de La Morinerie
a56dc0f653 specs: re-order method in feature helpers 2019-10-21 11:45:03 +02:00
Pierre de La Morinerie
0807fed258 specs: rename instructeur_spec.rb to instruction_spec.rb
This clarifies the difference between this spec and the other
instructeur specs in the same directory.
2019-10-21 11:27:35 +02:00
LeSim
d84a966f45
Merge pull request #4418 from betagouv/add_query_timeout
Suppression des requètes qui font plus de 60s en base
2019-10-17 17:38:36 +02:00
simon lehericey
1e8e45232a Setup a timeout on long query 2019-10-17 16:45:18 +02:00
LeSim
ee6f0db5fb
Merge pull request #4407 from betagouv/usager_use_groupe_instruction
Rajoute la liste déroulante qui permet à l'usager d'utiliser le routage
2019-10-17 15:54:29 +02:00
simon lehericey
18de25fac7 Display the dossier.groupe_instructeur.label on various screens 2019-10-17 15:48:14 +02:00
simon lehericey
b7434c3132 User can choose its gi 2019-10-17 15:48:14 +02:00
simon lehericey
6b8cefa551 Procedure: defaut_groupe_instructeur is the first group
Especially useful when the defaut groupe is renamed ...
2019-10-17 15:48:14 +02:00
simon lehericey
5897464224 Build Dossier champ only once 2019-10-17 15:48:14 +02:00
LeSim
b235e7f403
Merge pull request #4412 from betagouv/add_web3_web4
Add web3 and web4
2019-10-16 11:06:32 +02:00
simon lehericey
3c5eaed2f3 Add web3 and web4 2019-10-16 10:58:54 +02:00
LeSim
8debd07b84
Merge pull request #4406 from betagouv/add_name_to_groupe_instructeur_list
Ajoute une colonne dans la table procédure qui contiendra le label de la liste de routage
2019-10-16 10:36:41 +02:00
simon lehericey
6389a29f60 Add procedure routing criteria name 2019-10-16 10:30:55 +02:00
Pierre de La Morinerie
dec5cd58e4
[Instructeur] Améliore le dropdown de changement d'état d'un do… (#4401)
Instructeur : amélioration du menu de changement d'état d'un dossier
2019-10-15 13:35:48 +02:00
Pierre de La Morinerie
db0fede521 views: improve the state button
- Turn the "accepted" infos into standard dropdown sections
- Display the justificatif even if there is no motivation
2019-10-15 12:48:14 +02:00
Pierre de La Morinerie
dd57953b76 views: refactor the state button
Now that all states have a dropdown, we can simplify the code.

This also brings the "Repasser en instruction" action for all states
(including when no attestation or motivation is present).
2019-10-15 12:48:14 +02:00
Pierre de La Morinerie
07f75ff20e views: fix missing attestation link
- Fix the missing link to see attestations (see #4400)
- Fix the "Repasser en instruction" wording being confusing for
  accepted state
- Add lot of tests
2019-10-15 12:48:14 +02:00
Pierre de La Morinerie
e3d61a8303
[Instructeur] Improve attestation preview (#4404)
Instructeur : la prévisualisation de l'attestation est plus simple
2019-10-15 12:48:06 +02:00
Pierre de La Morinerie
0e5f66c5ba views: make the "Voir l'attestation" UI simpler
Instead of adding a button, just turn the "attestation" text into a link
2019-10-15 12:41:37 +02:00
Pierre de La Morinerie
0064c2c610 views: tell an attestation will be sent only if it is true
Previously the message stating "an attestation will be sent" was
displayed even when the attestation was disabled.
2019-10-15 12:41:37 +02:00
LeSim
17d8167390
Merge pull request #4405 from betagouv/improve-avis-layout
avis: improve layout and wording
2019-10-15 10:50:01 +02:00
Pierre de La Morinerie
e0571a8ae3 avis: improve layout and wording 2019-10-14 16:03:08 +02:00
Pierre de La Morinerie
51c194e253
Refactoring : in tasks, replace puts by rake_puts (#4397)
Refactoring : in tasks, replace `puts` by `rake_puts`
2019-10-09 10:17:09 +02:00
Pierre de La Morinerie
669f21d1d8 tasks: replace puts by rake_puts
It avoids tasks logs to clutter the tests output.
2019-10-08 16:54:57 +02:00
Pierre de La Morinerie
fed723cc77
ChampsPolicy: allow instructeurs to access private annotations (#4396)
Instructeur : corrige l'utilisation des cartes dans les annotations privées (#4388)
2019-10-08 15:13:15 +02:00
Pierre de La Morinerie
c2e82e4145 champ_policy: allow instructeurs to access private annotations
Fix #4388
2019-10-08 14:34:12 +02:00
Pierre de La Morinerie
a20b6b73a2 policies: rename "Scope" to "ApplicationScope"
For clarity.
2019-10-08 14:28:26 +02:00
LeSim
e1c046f4d8
Merge pull request #4393 from betagouv/remove_simple_form
Supprime la gem 'simple_form'
2019-10-08 14:00:16 +02:00
simon lehericey
f31c184b56 [fix #1537] Remove simple_form gem 2019-10-08 11:08:35 +02:00
simon lehericey
785b8fd78f Remove simple form from mail_templates 2019-10-08 10:57:35 +02:00
LeSim
c4ed341847
Merge pull request #4391 from betagouv/dependabot/bundler/rubyzip-1.3.0
Bump rubyzip from 1.2.2 to 1.3.0
2019-10-08 10:36:18 +02:00
dependabot[bot]
eba1825a03
Bump rubyzip from 1.2.2 to 1.3.0
Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.2 to 1.3.0.
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.2...v1.3.0)

Signed-off-by: dependabot[bot] <support@github.com>
2019-10-08 08:19:56 +00:00
LeSim
13f4e2c3fb
Merge pull request #4390 from betagouv/admin_active
Corrige la notion d'administrateur actif
2019-10-08 10:14:35 +02:00
simon lehericey
725798da6a [fix #4361] Update user table sign_in 2019-10-08 10:09:16 +02:00
simon lehericey
0c15326df6 User: inactive user have never signed_in 2019-10-08 10:09:16 +02:00
LeSim
b1bc7a2642
Merge pull request #4387 from betagouv/small_optims
Small optims
2019-10-08 10:06:47 +02:00
simon lehericey
3e0f1b9c66 User: eager load instructeur and administrateur to remove 2 db requests per http request 2019-10-08 09:53:40 +02:00
simon lehericey
5143d341ec Admin: 1 query for crips 2019-10-08 09:53:40 +02:00
Paul Chavard
b52dfebfca
Merge pull request #4368 from tchak/auto-link
Auto-link valeur des champs
2019-10-07 21:37:49 +02:00
Paul Chavard
e7ed408e08 Auto-link valeur des champs
closes #2865
2019-10-07 21:20:24 +02:00
Pierre de La Morinerie
d92cf6617a
Ajout de template d'issues (#4389)
Ajout de modèles par défaut lors de la création d'une issue
2019-10-07 17:34:45 +02:00
Pierre de La Morinerie
cfa42343bc Ajout de template d'issues
Les templates d'issues sont affichés lorsque on clique sur le bouton "New issue" dans GitHub.

Deux objectifs :

- **Améliorer nos rapports de bugs interne** : nous encourager à décrire le problème des utilisateurs (plutôt que juste la solution proposée).
- **Améliorer les issues des contributeurs externes** : encourager les contributeurs à créer des issues claires (plutôt que des tableaux Excels imbitables).
2019-10-07 17:33:36 +02:00
Pierre de La Morinerie
03616b9709
Bump some javascript dependencies (#4344)
Mise à jour des dépendances Javascript
2019-10-07 15:49:14 +02:00
Paul Chavard
2c486b8fe2 Bump some javascript dependencies 2019-10-07 15:40:27 +02:00