sebastiencarceles
f52554b5a3
review: update value with async fetch
...
1 - spec cover the job which fetches external data
2 - refactor the job with guard clauses
3 - delegate update operation to the champ itself
4 - annuaire education: override the update operation
to let the value be populated by the fetched data
5 - prefilling: don't fetch data synchronously
2023-02-28 14:53:08 +01:00
sebastiencarceles
447ea1b9a8
don't prefill with an incorrect value
2023-02-28 14:23:38 +01:00
sebastiencarceles
d7bfb9dc18
enrich value from education api
2023-02-28 14:23:38 +01:00
sebastiencarceles
71f1e785ab
let annuaire education champ be prefillable
2023-02-28 13:26:35 +01:00
sebastiencarceles
a08bb1bddc
fix epci: all possible values
2023-02-28 08:37:52 +01:00
sebastiencarceles
2ae2d99e93
fix communes: all possible values
2023-02-28 08:36:43 +01:00
Colin Darie
ae93d3927e
refactor(dossier): extract sections logic in a concern
2023-02-27 17:29:22 +01:00
Colin Darie
1981bfc88e
feat(tdc): strip libelle so header section titles always start with something
2023-02-27 17:29:22 +01:00
Colin Darie
d7880f7e58
feat(dossier/pdf): header sections numbering
2023-02-27 17:29:22 +01:00
Colin Darie
3de089d6c7
fix(conditional): dynamic title counters using css
...
Closes #8086
2023-02-27 17:29:22 +01:00
sebastiencarceles
35f4874b69
allow integers only
2023-02-27 15:16:40 +01:00
sebastiencarceles
13229158bd
let dossier link champ be prefillable
2023-02-27 15:14:39 +01:00
sebastiencarceles
39545671f3
refacto: better error management
2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2
don't clean the rna champ value
...
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Sébastien Carceles
7e55aca107
allow rna prefill
2023-02-27 14:35:11 +01:00
sebastiencarceles
7d65a34bc6
rna champ can fetch it's own association
2023-02-27 14:31:58 +01:00
sebastiencarceles
becf4da70a
fix raison social fetch
2023-02-27 13:54:35 +01:00
sebastiencarceles
5dce401a14
review: add missing spec
2023-02-27 13:47:56 +01:00
sebastiencarceles
30eef3e128
review: detailled error message
2023-02-27 13:45:16 +01:00
Sébastien Carceles
2ad4e4c01f
refacto: better error management
2023-02-27 13:45:16 +01:00
Sébastien Carceles
b6c74b0e83
fetch etablissement when editing the dossier
2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542
don't clean the siret champ value
...
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Sébastien Carceles
3eb76d8a43
allow siret prefilling
2023-02-27 13:45:16 +01:00
Sébastien Carceles
5876dab096
siret champ can fetch it's own etablissement
2023-02-27 13:39:31 +01:00
sebastiencarceles
da6ce0f528
add example
2023-02-27 12:20:11 +01:00
sebastiencarceles
76c9d1ada5
add possible values
2023-02-27 11:53:25 +01:00
sebastiencarceles
40b7ea3af2
transform the input value to assignable attributes
2023-02-27 11:51:24 +01:00
sebastiencarceles
46091cb6b4
let communes champ be prefillable
2023-02-27 11:50:25 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
...
Prefill repeatable
2023-02-27 09:58:53 +00:00
Paul Chavard
21f47dcb01
feat(procedure): include deleted dossiers in stats
2023-02-23 17:14:25 +01:00
Paul Chavard
eb3039aeca
fix(demarche): exclude preview and deleted dossiers from stats
2023-02-23 16:38:40 +01:00
Damien Le Thiec
731cd56594
Merge branch 'main' into feature/prefill_repetible
2023-02-22 19:49:06 +01:00
Damien Le Thiec
ca29079c27
Fix rubocop
2023-02-22 19:40:52 +01:00
Damien Le Thiec
fbe4fe251a
Fix format prefill repetition
2023-02-22 19:32:25 +01:00
Sébastien Carceles
28c6fd8cfc
Improve EPCI specs ( #8634 )
...
* fix nonsense spec
* refactor spec
2023-02-22 09:16:58 +00:00
Damien Le Thiec
cc2ec995d6
Fix tests
2023-02-21 17:32:24 +01:00
Damien Le Thiec
2052bc7840
Remove dependency type_de_champ -> procedure
2023-02-21 16:00:58 +01:00
Christophe Robillard
c5acd82e6e
update dossiers count when passing to construction
2023-02-21 10:06:07 +01:00
Christophe Robillard
bd92291f8a
cache dossiers count
2023-02-21 10:06:07 +01:00
Damien Le Thiec
d2452980fe
Fix merge conflict spec
2023-02-16 20:17:05 +01:00
Damien Le Thiec
dce4c84f9a
Merge branch 'main' into feature/prefill_repetible
2023-02-16 17:08:30 +01:00
Damien Le Thiec
6231c75e07
Fix tests conflicts
2023-02-16 16:58:55 +01:00
Paul Chavard
c0ad7853cb
fix(administrateur): procedure page n+1
2023-02-16 11:29:21 +01:00
sebastiencarceles
d5ffd61ab6
validate values inclusion
2023-02-16 10:49:15 +01:00
sebastiencarceles
d648ac31c2
add prefill decorator for multiple drop down list
2023-02-16 10:49:15 +01:00
sebastiencarceles
cbe2dc9c2d
let the multiple drop down list be prefillable
2023-02-16 10:49:15 +01:00
Damien Le Thiec
96b9ec3f42
First fix tests
2023-02-15 18:13:16 +01:00
Damien Le Thiec
539b9e4f10
Merge branch 'main' into feature/prefill_repetible
2023-02-15 17:53:06 +01:00
Damien Le Thiec
4876d583b6
Merge branch 'main' into feature/prefill_repetible
2023-02-15 17:39:19 +01:00
Damien Le Thiec
4b3d403d7e
fix spec
2023-02-15 17:14:29 +01:00
Damien Le Thiec
5a89a2dbe4
Use Stable ID for repetitions prefill
2023-02-15 12:15:34 +01:00
sebastiencarceles
8aa31522b6
cover feature with specs
2023-02-15 12:14:11 +01:00
sebastiencarceles
07b5a3b4b5
manage types de champ with multiple example values
2023-02-15 12:14:11 +01:00
sebastiencarceles
edf90a77f3
validate epci to reject incorrect prefill values
2023-02-15 12:14:11 +01:00
sebastiencarceles
5ac80f968a
add possible and example values
2023-02-15 12:14:11 +01:00
sebastiencarceles
f836f57e98
transform the input value to assignable attributes
...
Use the prefill decorator to transform the input value (for example
['01', '200042935']) into assignables attributes (for example
{ code_departement: '01', value: '200042935' }), in order to let the
champ be prefilled successfully.
2023-02-15 12:14:11 +01:00
sebastiencarceles
0f483668cf
let epci champ be prefillable
2023-02-15 12:14:11 +01:00
Paul Chavard
8b74a6f39b
fix(geometry): implement our own bbox to replace rgeo
2023-02-15 11:58:59 +01:00
Damien Le Thiec
2533ca50d4
Merge branch 'main' into feature/prefill_repetible
2023-02-15 11:07:56 +01:00
sebastiencarceles
681e1cf518
♻️ refactor possible_values impl for clarity
2023-02-14 13:45:30 +01:00
sebastiencarceles
67ef3a16fa
review: put example values in translation yamls
2023-02-14 09:23:52 +01:00
Sébastien Carceles
12abf9045b
add external_id and value validation
2023-02-14 09:23:11 +01:00
Sébastien Carceles
a235829ddd
add possible and example values
2023-02-14 09:19:55 +01:00
Sébastien Carceles
cd3a72ddce
make departements champ prefillable
2023-02-14 09:19:19 +01:00
Damien Le Thiec
899c8a6589
Add documentation json parse rescue repetition
2023-02-13 14:17:53 +01:00
Sébastien Carceles
1a72b80f8f
fix: "remove" a champ to prefill ( #8612 )
...
* fix: "remove" a champ to prefill
Removing a champ to prefill on /preremplir used to fail, because of a
collusion (having the same form multiple times on un page looks like a
bad idea, when it comes to multiple input fields).
* fix specs
2023-02-13 08:17:22 +00:00
Damien Le Thiec
ea126612a1
Refacto to_assignable_attributes for prefill_repetition
2023-02-12 13:02:30 +01:00
Damien Le Thiec
fc94aaaa21
Use "to_assignable_attributes"
2023-02-12 11:55:28 +01:00
Damien Le Thiec
dbb92e7fd3
Merge branch 'main' into feature/prefill_repetible
2023-02-11 22:40:56 +01:00
Damien Le Thiec
2a3ba28343
Fix tests possible value prefill
2023-02-11 22:27:16 +01:00
Damien Le Thiec
a4d707f942
Improve format prefill possible_values (tests missing)
2023-02-09 18:08:51 +01:00
Damien Le Thiec
c5f1f80d25
Add prefill params tests repetition
2023-02-08 17:38:51 +01:00
Paul Chavard
dc9a455d22
fix(dossier): prevent crash in rebase
2023-02-08 11:11:14 +01:00
Damien Le Thiec
a51ed0094b
Fix tests
2023-02-07 00:28:21 +01:00
Damien Le Thiec
b9c2d1251b
Add missing tests repetition prefill
2023-02-06 17:38:59 +01:00
Paul Chavard
6924b8e46d
feat(dossier): optional repetition champ should not add first row
2023-02-06 11:53:32 +01:00
Damien Le Thiec
63e7c17fda
First tests for prefill repetition
2023-02-03 12:14:18 +01:00
Paul Chavard
2971100081
fix(dossier): do not try to rebase if procedure is not published
2023-02-02 10:11:46 +01:00
Paul Chavard
fc31ef6da3
chore(dossier): move concern spec to concern folder
2023-02-02 10:11:29 +01:00
Lisa Durand
120fbb0ef7
Overload the finished_at
2023-02-01 17:06:04 +01:00
Lisa Durand
d0a131dc55
change the way we set the finished_at on batch operation job to fix alert display bug
2023-02-01 17:06:04 +01:00
Damien Le Thiec
e7c78321d9
Fix new failing tests
2023-02-01 13:35:32 +01:00
Damien Le Thiec
a4645855d3
Fix tests prefillable repetition
2023-02-01 12:02:09 +01:00
Paul Chavard
9c83939431
fix(dossier): fix adding repetition in a new revision
2023-02-01 10:36:46 +01:00
Damien Le Thiec
d7b01255fe
Merge branch 'main' into feature/prefill_repetible
2023-01-31 16:39:00 +01:00
Colin Darie
5cddb1c74e
fix(procedure_presentation): options groupe_instructeur for that procedure only
2023-01-31 13:55:06 +01:00
Paul Chavard
dcbe16603a
fix(dossier): fix parser with dashes
2023-01-31 10:40:48 +01:00
Paul Chavard
ca05fb753b
fix(only_present_on_draft?): broken when type_de_champ is removed from later revisions
2023-01-31 09:26:50 +01:00
Martin
dbe64cf0c8
correctif(date_champ): renforce la validation avec le parsing de la date plutot qu'une approche par regexp
2023-01-30 13:01:24 +01:00
Martin
78f9910fd0
bug(date): la validation est trop lache
2023-01-30 13:01:24 +01:00
Paul Chavard
2f4e85f163
fix(dossier): set rebased_at only on changed champs
2023-01-30 12:01:11 +01:00
Paul Chavard
298721f90d
fix(dossier): fix clone with data
2023-01-30 10:58:26 +01:00
Colin Darie
923ee59e92
refactor(instructeurs/perf): don't load anymore geo areas for each champ because of header
...
Economise 1 requête par champ sur chaque page instructeur d'un dossier
à cause du header juste pour savoir s'il faut afficher
le bouton d'export GeoJSON.
2023-01-26 14:57:45 +01:00
Colin Darie
51c1736d00
refactor(conditional): extract in a ChampConditionalConcern with tests
2023-01-26 09:06:30 +01:00
Colin Darie
81f00774af
feat(logic): operators sources
2023-01-26 09:06:30 +01:00
Sébastien Carceles
49ce255e29
feat(dossier): prefill region champ ( #8442 )
...
* make regions champ prefillable
* add possible and example value
* add external_id and value validation
2023-01-24 11:25:17 +00:00
mfo
84a667b8bd
Merge pull request #8454 from tchak/feat-epci
...
feat(types de champ): add EPCI champ
2023-01-23 16:56:18 +01:00
Sébastien Carceles
92c769de4f
fix(prefill): code pays display ( #8477 )
...
* show translated text AND possible values
* show less possible values
* show countries possible values
2023-01-23 14:08:20 +00:00
Sébastien Carceles
68ddae7382
feat(demarche): prefilling stats ( #8436 )
...
* force json content type for POST / PATCH / PUT
* add specs about stats dossiers funnel
* new endpoint to render stats about a procedure
2023-01-20 13:28:02 +00:00
Paul Chavard
a4cbbe721e
feat(types de champ): add EPCI champ
2023-01-20 11:32:36 +01:00