DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
7860 commits 250 branches 1166 tags 78 MiB
Commit graph

7860 commits

This branch
This branch
All branches
Author SHA1 Message Date
clemkeirua
765b10026e more generic elements to the security policy 2019-06-17 09:51:27 +02:00
Pierre de La Morinerie
71c4589257
Merge pull request #3935 from betagouv/fix-pj-migration-changing-timestamps 
Corrige la tâche de migration des PJ
 2019-06-13 14:25:33 +02:00
Pierre de La Morinerie
f12668fbfb tasks: prevent the PJ migrations task updating from touching dossiers 2019-06-12 19:07:45 +02:00
Pierre de La Morinerie
60a61da644 tasks: extract dossier migration to a separate method 2019-06-12 18:58:47 +02:00
Pierre de La Morinerie
77e6296842
Fix 3710 correct show date with letter english (#3936) 
Les dates sont maintenant affichées au format "12 juillet 2019"
 2019-06-12 18:57:34 +02:00
pedong
7ef1a558f4 change date format for all, use try_format_date of helper 2019-06-12 17:48:12 +02:00
simon lehericey
ee296f2b44 Use default format for date and datetime champ 2019-06-12 17:48:12 +02:00
pedong
abcd58c35d [fix #3710] date with letter 
Co-Authored-By: simon lehericey <mail@simon.lehericey.net>
 2019-06-12 17:48:12 +02:00
Pierre de La Morinerie
d11e246112
Display “previously following” gestionnaires (#3940) 
Instructeur : affiche tous les instructeurs ayant suivi le dossier à un moment donné
 2019-06-12 17:44:34 +02:00
Nicolas Bouilleaud
5acb7a3f1b Make rubocop happy 
I did make some changes some lines above this 🤷.
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
1ac6cad132 Display previous followers in “personnes impliquées” 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
6b90bc1ea1 Add “previously followed” dossiers and gestionnaires 
Using an “inactive” Follow scope, similar to the “active” scope.

(I was tempted to use a default_scope, but this breaks when trying to `unscope` it in associations.)
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
be4c575622 Add Follow.unfollowed_at 
The active scopes is used indirectly in the dossier<->gestionnaire associations: the existing tests in dossier and gestionnaire just work™.
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
d417907f36 Just rely on the constraints to avoid duplicate Follows 
Don’t check manually in advance: just try to create the new Follow and silently fail.

Since we have both Rails validation and DB constraints in place, we have two types of errors to check. I’m not actually sure this change improves the legibility of the code.
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
ba48a1da6e Ensure Follow dates can not be not null 
* Add Follow.unfollowed_at
* Change the unicity constraint to gestionnaire/dossier AND unfollowed_at
 2019-06-12 17:33:53 +02:00
Pierre de La Morinerie
66a683fab7
Clear the “add admin” field after submit (#3934) 
Administrateur : le champ "Ajouter un nouvel administrateur" est correctement réinitialisé après l'ajout
 2019-06-12 17:07:37 +02:00
Nicolas Bouilleaud
8e04b4f0c9 Clear the “add admin” field after submit 
Extract the add_admin form to its own partial and re-render it when an admin is successfully added.
 2019-06-12 16:58:30 +02:00
Pierre de La Morinerie
c57ac8de0d
build(deps): bump chartkick from 3.0.2 to 3.2.0 (#3941) 
Mise à jour de Chartkick
 2019-06-12 16:51:31 +02:00
dependabot[bot]
18b7ddb2da
build(deps): bump chartkick from 3.0.2 to 3.2.0 
Bumps [chartkick](https://github.com/ankane/chartkick) from 3.0.2 to 3.2.0.
- [Release notes](https://github.com/ankane/chartkick/releases)
- [Changelog](https://github.com/ankane/chartkick/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/chartkick/compare/v3.0.2...v3.2.0)

Signed-off-by: dependabot[bot] <support@github.com>
 2019-06-12 14:44:56 +00:00
Pierre de La Morinerie
14e5e2b61f
api_entreprise: display better error message when SIRET is private (#3953) 
Usager : meilleur message d'erreur lorsque les informations d'une entreprise ne sont pas publiques
 2019-06-12 16:03:54 +02:00
Pierre de La Morinerie
55c9dfc001 api_entreprise: display better error message when SIRET is private 
Previously we blamed the network.

Now we say that the entreprise infos cannot be retrieved. Which is not
ideal, but better.
 2019-06-12 11:58:04 +02:00
Paul Chavard
8c7d7f2eed
Merge pull request #3930 from betagouv/fix-activestorage-events-on-ie11 
javascript: fix payload of ActiveStorage events missing on IE 11
 2019-06-06 15:20:13 +02:00
Pierre de La Morinerie
78f75744e3 javascript: fix payload of ActiveStorage events missing on IE 11 
Under some circumstances (like dispatching events just before a page
navigation), IE 11 events will be dispatched twice by the browser: once
with the payload, and a second time without.

To prevent these errors, ignore the events if the payload is missing.
 2019-06-06 15:00:57 +02:00
Pierre de La Morinerie
d9f7bad049
🚒 Corrige les notifications Instructeur sur les dossiers migrés avant-hier (#3931) 
🚒 Corrige les notifications Instructeur sur les dossiers migrés avant-hier
 2019-06-06 11:42:31 +02:00
Pierre de La Morinerie
0b49e61ec0 tasks: repair updated_at of dossiers wrongly touched by PJ migration 
When running the PJ migration task, migrated dossiers have their
updated_at attribute modified.

This means a yellow notification badge pops up on the Instructeurs
pages.

This PR repairs the affected dossiers, by restoring an approximative
updated_at from the latest workflow value (or the timestamp of the
migrated champ).
 2019-06-06 11:11:29 +02:00
Pierre de La Morinerie
e0d2a31880
Chat with admin (#3758) 
Intégration de l'API Crisp
 2019-06-05 17:51:27 +02:00
Chaïb Martinez
eccd456325 Add crisp 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-05 17:41:47 +02:00
Pierre de La Morinerie
edbfd4e2b5
Fix default button type (#3925) 
Usager : les bloc répétables ne disparaissent plus lorsqu'on appuie sur la touche Entrée dans un champ
 2019-06-04 18:08:24 +02:00
Paul Chavard
5a216b5583 Fix default button type 
fix #3924
 2019-06-04 17:59:02 +02:00
Pierre de La Morinerie
b8b88201fa
Merge pull request #3908 from betagouv/fix-3899-view-admin-vip 
- Manager : ajout de colonnes "nombre de dossiers par an" et "échéance souhaitée".
 2019-06-04 17:04:51 +02:00
Chaïb Martinez
9198f7f437 Remove useless select options 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-04 16:55:11 +02:00
Chaïb Martinez
3b513af32a Add nb_of_dossiers by years and deadline to PipeDrive Person 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-04 16:55:11 +02:00
Pierre de La Morinerie
3ae6b64994
Wait for ajax (#3920) 
Corrige certains tests automatisés qui échouaient aléatoirement
 2019-06-04 16:38:15 +02:00
Paul Chavard
6d312e1716 spec: refactor wait_for_ajax to work with out new ajax utils 
`wait_for_ajax` is not used anymore, but it may be in the future.
 2019-06-04 16:30:36 +02:00
Paul Chavard
f621bd63e5 spec: fix flaky test by using new wait_until helper 
Fix #3911
 2019-06-04 16:30:36 +02:00
Paul Chavard
cc80939a42 spec: remove tests for old pj (probably) dead code 2019-06-04 16:30:36 +02:00
Pierre de La Morinerie
c2fcc6057e spec: add a wait_until helper 2019-06-04 16:30:36 +02:00
Paul Chavard
e870ba186f spec: add a pause helper 2019-06-04 16:16:53 +02:00
Pierre de La Morinerie
d050b9dc07
Return dossiers on api with stable order (#3921) 
API : l'ordre des dossiers renvoyés dans les résultats paginés est maintenant stable
 2019-06-04 15:44:32 +02:00
Paul Chavard
d5911071f8 Return dossiers on api with stable order 2019-06-04 15:34:49 +02:00
Pierre de La Morinerie
5624b5a997
stylesheets: fix font of dropdown items on Firefox (#3917) 
Correction de l'affichage des menus déroulants dans Firefox
 2019-06-04 11:53:09 +02:00
Pierre de La Morinerie
1f69c6c6eb stylesheets: fix font of dropdown items on Firefox 
Styling `<select>` elements is notoriously hard. Here, it seems that
Firefox doesn't handle custom fonts on `<option>` elements. As we have
no fallback font, the browser uses its default font, Times.

Having fallback fonts is good practice anyway.
 2019-06-04 11:37:40 +02:00
Pierre de La Morinerie
9ec2e4edf6
Améliore la rapidité et la fiabilité des tests d'intégration (#3914) 
Améliore la rapidité et la fiabilité des tests d'intégration
 2019-06-04 11:23:16 +02:00
Pierre de La Morinerie
b829d105d9 brouillon_spec: fix the slow use of have_select(locator, selected: …) 
Capybara's `have_select` can be very slow for elemtns with many options
(see https://github.com/teamcapybara/capybara/issues/1527)

This is because Capybara asserts that no other elements than the
required ones are selected.

This faster version is not as complete, but helps when checking the
countries list or the years in a date picker.
 2019-06-04 11:03:09 +02:00
Pierre de La Morinerie
5419c130f4 brouillon_spec: make the login sequence faster 
Log the user with `login_as` (rather than the browser).
 2019-06-04 11:03:09 +02:00
Paul Chavard
d8ba8d72e0
Merge pull request #3915 from betagouv/disable-map-tiles-during-tests 
carte: disable tiles layer during tests
 2019-06-04 11:00:53 +02:00
Pierre de La Morinerie
f2f16e2580 carte: disable tiles layer during tests 
During integration tests, we don't want to load the tiles from OSM:

- It hits OSM servers during every test run;
- It it slow (Capybara waits for the tiles to be loaded to proceed);
- It makes test time out when tiles cannot be loaded for some reason.

Fix #3913
 2019-06-03 17:24:15 +02:00
Pierre de La Morinerie
c7cde75b53
Merge pull request #3912 from betagouv/improve-specs 
Amélioration de la fiabilité des tests d'acceptance
 2019-06-03 14:07:44 +02:00
Pierre de La Morinerie
a555b24675 specs: precompile Webpack assets before running the specs suite 
This avoids the first feature spec stalling for a few dozens of seconds
because Webpack assets are compiling (and thus reduce the risk of the
spec timing out).

Pre-compilation takes ~ 10s.
 2019-06-03 12:50:59 +02:00
Pierre de La Morinerie
2bd749a325 specs: clear the React champ before adding a new value 
This prevents the value from being
`Nouveau champ TexteLibellé de champ carte`.
 2019-06-03 12:47:03 +02:00