Commit graph

2599 commits

Author SHA1 Message Date
Pierre de La Morinerie
e25bd7139f layouts: use a common procedure_context layout for the demarche overview 2019-01-07 15:39:58 +01:00
simon lehericey
7b935a6486 login_token: lets constantize 2019-01-07 08:18:29 +01:00
simon lehericey
5daa565a80 login_token: add missing tests 2019-01-07 08:18:29 +01:00
gregoirenovel
5fa5f2aa37 Bump development gems
- rubocop (0.61.1 → 0.62.0)
2019-01-05 11:47:55 +01:00
Pierre de La Morinerie
98127b6778 signature: refactor specs 2019-01-03 17:48:53 +01:00
Pierre de La Morinerie
2c0108190c spec: fix specs failing randomly
This is because creating a procedure attempts to create an admin from
scratch, and fails to do so.

Broken by 802f2086d6
2019-01-03 17:42:43 +01:00
Pierre de La Morinerie
86b9e2d092 stats: fix exception when HelpScout env vars are missing
This fixes the stats page, which used to raise an exception when
HelpScout env vars are not present.
2019-01-03 17:27:56 +01:00
Pierre de La Morinerie
d77530c461 Make Procedure state consistent after switching types de champ order
Fixes an issue where, after clicking the "move champ up" button,
the new form is rendered with an incoherent order.
2019-01-03 15:13:14 +01:00
gregoirenovel
9466442aff Remove the TypeDeChamp decorators 2019-01-03 12:08:25 +01:00
gregoirenovel
9c130c41da Remove ProcedureDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
b41764ec03 Remove ChampDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
b8f57415cd Remove the unused decorator DossierDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
559df6b82a Remove the unused decorator ProceduresDecorator 2019-01-03 12:08:24 +01:00
gregoirenovel
4f30e30a08 Remove the unused decorator FranceConnectInformationDecorator 2019-01-03 12:08:24 +01:00
gregoirenovel
0336ecf639 Remove useless arguments from some methods 2019-01-03 10:53:50 +01:00
gregoirenovel
0596d53ac2 Enable the Lint/UnusedBlockArgument cop 2019-01-03 10:53:50 +01:00
gregoirenovel
ddc71cbacf Enable the Lint/UnderscorePrefixedVariableName cop 2019-01-03 10:53:50 +01:00
gregoirenovel
baf7977786 Enable the Lint/StringConversionInInterpolation cop 2019-01-03 10:53:50 +01:00
gregoirenovel
186e362701 Enable the Layout/SpaceInsideArrayLiteralBrackets 2019-01-03 10:53:50 +01:00
gregoirenovel
386fbce776 Enable the Layout/SpaceBeforeBlockBraces cop 2019-01-03 10:53:50 +01:00
gregoirenovel
8b0b8162f0 Enable the Layout/SpaceAfterComma cop 2019-01-03 10:53:50 +01:00
Chaïb Martinez
802f2086d6 Redirect admins with no démarches to the new demarche page 2018-12-28 18:57:51 +01:00
maatinito
4ad3a60e25 [Fix #2575] Créer automatiquement un compte instructeur aux administrateurs 2018-12-26 09:44:20 -10:00
gregoirenovel
03eb47016c Fix a gestionnaire sign in bug 2018-12-26 18:14:04 +01:00
maatinito
8304ce12e1 Make some email previews database-independent 2018-12-20 17:07:03 +01:00
maatinito
e1b97b3303 Make more emails previewable 2018-12-20 17:06:57 +01:00
maatinito
e37372d261 Fix a typo 2018-12-20 16:21:27 +01:00
maatinito
9842142a9a Add InviteMailerPreview 2018-12-20 16:21:27 +01:00
maatinito
a1a11adb83 [#325] Make the notification layout inherit from the general layout 2018-12-20 16:21:27 +01:00
Mathieu Magnin
904d8d208b [Fix #3192] Fix data 2018-12-20 15:45:48 +01:00
Mathieu Magnin
b40c706d98 [Fix #3192] Clone service if procedure is transferred 2018-12-20 15:45:48 +01:00
Paul Chavard
eb9edc1cee Order types de champ in scope 2018-12-20 14:14:15 +01:00
Paul Chavard
5d1c24f3d8 Add type de champ repetition models (with row) 2018-12-19 15:31:11 +01:00
gregoirenovel
df7e0a9881 Remove dead code 2018-12-19 14:59:15 +01:00
Frederic Merizen
d1cfe4468d Encourager la création de champs PJ plutôt que de vieilles PJS 2018-12-19 11:57:23 +01:00
Frederic Merizen
832b4a61bc Drop CleverCloud Service for ActiveStorage 2018-12-19 10:36:02 +01:00
Frederic Merizen
57a136c861 Make champ PJ generally available 2018-12-18 11:11:23 +01:00
Pierre de La Morinerie
d614ea6bd5 stats: display contact rate 2018-12-18 10:38:59 +01:00
maatinito
af8eee25ad [Fix #249] added test for too short passwords 2018-12-17 11:14:35 -10:00
Mathieu Magnin
edf3eefa87 Fix Sentry 114, Instructeur can delete pj in private champs 2018-12-13 17:27:05 +01:00
simon lehericey
5a87fad02e [fix #3154] order export 2018-12-10 16:41:37 +01:00
Pierre de La Morinerie
a0ae1afb45 typhoeus: add a cache store for successful requests 2018-12-10 11:41:07 +01:00
Frederic Merizen
270c7568fa [#2180] Avoid fetching old PJ modification times separately
Speeds up transfer
2018-12-08 15:55:40 +01:00
Frederic Merizen
907e87809b [#2180] Iterate over storage keys rather than blobs
To create less confusion on dev
2018-12-07 15:30:10 +01:00
pedong
f70f276ae9 [fix #2813] set lien_notice nil when clone a procedure 2018-12-06 21:28:08 +01:00
simon lehericey
db6c86b242 DossierController: user can destroy pjs 2018-12-06 10:45:10 +01:00
Frederic Merizen
4699e515ed [Fix #2999] Send gestionnaire back to what they were doing after email verification 2018-12-06 10:03:21 +01:00
Paul Chavard
ee93b4e33d Revert legacy carte API to parsed json 2018-12-05 18:19:15 +01:00
Paul Chavard
35494df78e Procedure export dossiers with champs siret 2018-12-05 17:09:39 +01:00
Pierre de La Morinerie
e206f3d4d4 gestionnaire: display draft procedures in the list
Fix #3088
2018-12-05 15:38:20 +01:00
Pierre de La Morinerie
421f125c45 gestionnaire_spec: factorize a assign helper 2018-12-05 15:38:20 +01:00
Paul Chavard
a08f170dbd Assign users and gestionnaires to commentaires
fix #2052
2018-12-05 13:40:57 +01:00
gregoirenovel
121086eedd Bump rails 2018-12-04 11:16:42 +01:00
gregoirenovel
873bf2fc0f Tell puma to STFU 2018-12-04 10:35:13 +01:00
gregoirenovel
478fb88618 Bump capybara (2.18.0 → 3.11.0) 2018-12-04 10:35:13 +01:00
gregoirenovel
94b6783a65 Slightly change some tests to comply with puma 2018-12-03 16:28:18 +01:00
gregoirenovel
b3d0a113eb Use non-breaking spaces in tests 2018-12-03 16:28:18 +01:00
Paul Chavard
e873b6a9c4 Expose selection utilisateur size on champ carte 2018-12-03 12:49:03 +01:00
Paul Chavard
d77a5c9f15 More tests and fixes on carte champ 2018-11-30 13:28:30 +01:00
Paul Chavard
097a15d624 Test and fix all possible cases of champ carte serialization 2018-11-30 12:02:27 +01:00
Paul Chavard
35d2bc36fc cleanup selection_utilisateur geo_json 2018-11-29 17:10:14 +01:00
Paul Chavard
ca147969ab Fix number champs validation 2018-11-29 15:12:31 +01:00
Paul Chavard
1883c57c87 Add stable ids to types_de_champ after every update 2018-11-29 11:41:13 +01:00
Paul Chavard
b9af07b845 Add admin support contact form 2018-11-28 16:50:37 +01:00
Paul Chavard
575a437f97 Remove carto from admin/procedure controller 2018-11-27 16:11:25 +01:00
Paul Chavard
1897b2775c Remove old migration task 2018-11-27 16:11:25 +01:00
Paul Chavard
c6ef30f3e1 Remove unused carto from instructeur interface 2018-11-27 16:11:25 +01:00
Paul Chavard
9ff65efea8 Remove deprecated carto from dossiers controller 2018-11-27 16:11:25 +01:00
Paul Chavard
d988638c58 Simplify API carte serializer 2018-11-27 16:11:25 +01:00
Paul Chavard
36f6f54337 Remove unused carto models 2018-11-27 16:11:25 +01:00
Paul Chavard
5632929d3d Remove old caro editor 2018-11-27 16:11:25 +01:00
Paul Chavard
37a7e26fc3 Remove unused users/carte_controller 2018-11-27 16:11:25 +01:00
Pierre de La Morinerie
ea8bc0c961 mailers: improve notification layout 2018-11-27 15:51:26 +01:00
Pierre de La Morinerie
4e801b188c tasks: remove outdated footers in mail templates
Fix #1863
2018-11-27 15:32:02 +01:00
Paul Chavard
98d388b64d Use state change methods on dossier in dossier auto archive job 2018-11-27 12:49:40 +01:00
Paul Chavard
b5b6832be8 Use state change methods on dossier in dossier auto recieve job 2018-11-27 12:49:40 +01:00
Paul Chavard
febf625dd9 Make difference between error and empty geo json 2018-11-27 12:36:10 +01:00
Paul Chavard
f2e7feec1d Do not send error json to backend - it doesn’t need it and it creates bad data 2018-11-27 11:45:24 +01:00
Mathieu Magnin
718a30639f [Fix #2929] Improve readability of invitation for avis 2018-11-23 13:18:36 +01:00
pedong
0d02f5896e [Fix #1339] properly display avis confidentiality to experts 2018-11-22 18:38:31 +01:00
Chaïb Martinez
0e8d235800 Add some params to track forms submissions 2018-11-21 18:25:47 +01:00
Mathieu Magnin
7c1768e5bb [Fix #3016] Do not crash if PJ has no extension 2018-11-21 14:15:45 +01:00
Paul Chavard
c99ef811b6 Do not save error json in database 2018-11-21 13:03:01 +01:00
Pierre de La Morinerie
f983bc68e2 mailers: fix dossier mailer spec 2018-11-20 17:45:50 +01:00
Pierre de La Morinerie
a5f9be00e0 mailers: add preview URL to all previewable mailers 2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
f2eaf66a9a mailers: add missing previews for notification emails 2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
e5303fd986 mailers: streamline the NotificationMailer
Notifications are now only for demarche-templated emails.
2018-11-20 14:46:31 +01:00
Paul Chavard
d43068ace5 Disable carto for new procedures 2018-11-20 12:14:10 +01:00
Paul Chavard
864d1df413 Test carto migration task 2018-11-20 10:58:22 +01:00
Paul Chavard
e374a5c726 Refactor ChampSerializer 2018-11-20 10:53:14 +01:00
Paul Chavard
0b017580c5 Expose migrated legacy carto champs on api 2018-11-20 10:53:14 +01:00
Paul Chavard
fe630847e9 Refactor legacy carto serializer 2018-11-20 10:53:14 +01:00
Paul Chavard
2462e42b53 Stop using legacy api carto after migration 2018-11-20 10:53:14 +01:00
Frederic Merizen
101e8e2588 [#2999] Rediriger vers la bonne page apres login
(ne corrige pas le cas ou l'utilisateur est passe par le mail de confirmation)
2018-11-16 15:44:20 +01:00
Paul Chavard
2eb61bd6ed Move dossier invites handler to invites controller 2018-11-14 15:16:49 +01:00
Pierre de La Morinerie
b6521625e4 procedure_spec: add missing Timecop.return statement
Fix order-dependant test.
2018-11-14 14:49:41 +01:00
Pierre de La Morinerie
35613992fe rspec: by default use the safer bisect runner for bisecting 2018-11-14 14:49:41 +01:00
Pierre de La Morinerie
acc6df2662 spec: fix Mina enabling Rails traces during tests
When requiring mina files, it automatically enables Rails traces. But
we don't want Rails traces during tests.

Fix this by disabling Rails traces before running tests.

Fix #2989
2018-11-14 11:55:21 +01:00
Pierre de La Morinerie
83031b5cdd procedure: compute the usual instruction time only for the last month 2018-11-13 17:23:31 +01:00
Pierre de La Morinerie
b693e055b7 procedure: make usual_instruction_time spec more robust 2018-11-13 17:23:31 +01:00
Pierre de La Morinerie
b1296df4c3 procedure: refactor usual_instruction_time spec 2018-11-13 17:23:31 +01:00
simon lehericey
fb76197404 SessionController: flipflop trusted device 2018-11-13 10:41:45 +01:00
simon lehericey
0d8d2de5a6 Session: add trusted_device cookie 2018-11-13 10:41:45 +01:00
simon lehericey
5690599289 Session: send a mail to confirm gestionnaire login 2018-11-13 10:41:45 +01:00
simon lehericey
2613d05a4f An admin has always a gestionnaire role 2018-11-13 10:41:45 +01:00
Pierre de La Morinerie
7635aede98 dossier: improve wording of estimated time
Ref #2970
2018-11-12 10:21:57 +01:00
Pierre de La Morinerie
e59bec51ef procedure: use 90th percentile to estimate the completion delay 2018-11-08 18:29:17 +01:00
Pierre de La Morinerie
5c921182ea procedure: rename mean_instruction_time to usual_instruction_time
Ref #2970
2018-11-08 17:20:06 +01:00
Pierre de La Morinerie
c7ac43cfe7 confirmation: add a dedicated page with confirmation instructions
Fix #2586
2018-11-08 16:20:05 +01:00
Paul Chavard
33c6ddc452 Remove dead code related to dossier state 2018-11-08 14:56:45 +01:00
Paul Chavard
0fe59a7c65 Add dossier_legacy_state helper 2018-11-08 14:56:45 +01:00
Paul Chavard
f09a7a01c8 Add dossier_display_state helper 2018-11-08 14:56:45 +01:00
Paul Chavard
80189def98 Remove n+1 calls from API queries 2018-11-08 14:45:09 +01:00
Paul Chavard
a7de2e68ed Refactor types_de_champ views to use service instead of facade 2018-11-07 11:36:10 +01:00
Paul Chavard
1c87eda6e1 Move types_de_champ helper to service 2018-11-07 11:36:10 +01:00
Paul Chavard
2d647f9fa7 Move types_de_champ facade to service 2018-11-07 11:36:10 +01:00
Pierre de La Morinerie
8355b690f0 users: add integration tests for sign-up 2018-11-06 18:24:34 +01:00
Pierre de La Morinerie
b0541fba79 users: sign-in after confirming an account within a short time 2018-11-06 18:24:34 +01:00
Pierre de La Morinerie
0fb9c123c9 invite: mutualize feature helper for signing in 2018-11-06 17:26:20 +01:00
Pierre de La Morinerie
d4b2b04875 spec: clear deliveries before every example 2018-11-06 17:26:20 +01:00
simon lehericey
9d406770a8 [fix #2956] YesNo: fixing to_s 2018-11-06 16:59:47 +01:00
Frederic Merizen
d564eb1225 [#835] Report failed and successful invitations 2018-11-06 16:40:42 +01:00
Frederic Merizen
8cf235f2fd [#835] Enable html5 validation of multiple mails 2018-11-06 15:44:43 +01:00
Frederic Merizen
c7358a8f53 [Fix #835] Enable asking for multiple avis at the same time 2018-11-06 15:44:43 +01:00
Paul Chavard
9ac85295c6 Do not serialize properties on carte champs 2018-11-06 14:26:32 +01:00
Paul Chavard
074050a91a Add IntegerNumberChamp 2018-11-06 11:28:44 +01:00
Paul Chavard
45bfb2fd47 Add DecimalNumberChamp 2018-11-06 11:28:44 +01:00
Paul Chavard
cfd1950e17 Migrate commencer to new_user 2018-11-01 13:10:41 +01:00
Paul Chavard
8ff45c7978 Fix commentaire file_url generator 2018-10-31 12:53:14 +01:00
simon lehericey
2f2f1e1321 Let the API return times in UTC for now 2018-10-31 11:43:48 +01:00
Paul Chavard
e391fe6bec Clarify procedure path availability code 2018-10-30 15:59:37 +01:00
Mathieu Magnin
c656e36ec2 [Fix #2276] Test to ensure form is not cleared if service creation failed 2018-10-30 15:49:18 +01:00
Paul Chavard
fcdc0114fd Add id to geo areas 2018-10-30 12:16:09 +01:00
Paul Chavard
725e88a89a Rename :procedure_path -> :path 2018-10-30 12:01:45 +01:00
Paul Chavard
f1fd1b38ec Refactor procedures_controller 2018-10-30 12:01:45 +01:00
Paul Chavard
78dc582588 Remove ProcedurePath 2018-10-30 12:01:45 +01:00
Frederic Merizen
cf9024d36f Fix test that doesn't work just after daylight saving time changes
If I submit a request on Friday at 8am, and get a response on
Monday at 8am, the response time is 72h...

except if there was a daylight saving time change on Sunday, in
which case the response time is either 71h or 73h, making the test
fail
2018-10-30 10:58:20 +01:00
Frederic Merizen
aff93ecd6a Simplify test syntax 2018-10-26 17:53:36 +02:00
Frederic Merizen
f6207bee26 Do not take time of day into account when searching dates 2018-10-26 17:53:26 +02:00
simon lehericey
a06f872a4b ProcedurePresentation: rescue big int as a datetime value 2018-10-26 14:39:17 +02:00
simon lehericey
63db387984 ProcedurePresentation: display dossier date in d/m/Y 2018-10-26 10:10:20 +00:00
simon lehericey
3685c65fb7 [fix #2905] fix DATE_TRUNC usage
DATE_TRUNC is played on the db where the timestamp are stored in utc.
So if a user search for 12/12/2012 in Paris timezone and that we truncate it should do something similar to :

SELECT DATE_TRUNC('day', foo.timezone) from (SELECT timestamp '2012-12-12 00:00:00' AT TIME ZONE 'Europe/Paris') as foo;
=> 2012-12-11

To avoid such pb, I suggest avoiding DATE_TRUNC when exact results are needed
2018-10-26 10:10:20 +00:00
simon lehericey
9475795143 fix spec 2018-10-26 10:10:20 +00:00
simon lehericey
26ae29ea52 Time.local => Time.zone.local 2018-10-26 10:10:20 +00:00
simon lehericey
3078b377c7 Time.new => Time.zone.local 2018-10-26 10:10:20 +00:00
simon lehericey
e684cec516 DateTime.new => Time.zone.local 2018-10-26 10:10:20 +00:00
simon lehericey
f620e4aee2 DateTime.parse => Time.zone.parse 2018-10-26 10:10:20 +00:00
simon lehericey
2238e5bd9f Time.now => Time.zone.now 2018-10-26 10:10:20 +00:00
simon lehericey
13ffa61435 DateTime.now => Time.zone.now 2018-10-26 10:10:20 +00:00
simon lehericey
b00dec4bf6 Conf: storage.apientreprise.fr -> static.demarches-simplifiees.fr 2018-10-25 17:05:22 +02:00
Frederic Merizen
64cb231b01 [#2675] Fix notification sort order 2018-10-24 17:10:30 +02:00
Paul Chavard
c0344fc30e Fix procedures with multiple dossier link champs 2018-10-24 10:44:28 +02:00
Paul Chavard
4abcffe278 Test ApiGeo RPGAdapter 2018-10-23 18:13:45 +02:00
Paul Chavard
fd490efb59 GeoArea on API expose fields per source type 2018-10-23 18:13:44 +02:00
Paul Chavard
5a8a4b393f Add RPG carte source 2018-10-23 18:13:44 +02:00
Paul Chavard
ed46e2c3be Use Typhoeus in ApiGeo adapter 2018-10-23 18:13:44 +02:00
Frederic Merizen
14fd60bee7 [Fix #2604] Handle ProcedurePresentations that have gone invalid 2018-10-23 16:41:51 +02:00
Frederic Merizen
7baa239095 [#2604] Introduce errors when retrieving ProcedurePresentation 2018-10-23 16:34:38 +02:00
Frederic Merizen
85f698bc71 [#2604] Clean up GestionnaireSpec 2018-10-23 16:34:31 +02:00
Frederic Merizen
eab8da43fc [#2604] Introduce explicit context in GestionnaireSpec 2018-10-23 16:34:28 +02:00
Frederic Merizen
91cfa69220 [#2604] Clean up AssignTo spec 2018-10-23 16:34:25 +02:00
Frederic Merizen
86f01a9120 [#2604] Factor AssignTo spec 2018-10-23 16:34:22 +02:00
Paul Chavard
c4d790b4d0 Test champs carte controller 2018-10-23 09:35:25 +02:00
Paul Chavard
c8c75fc254 Better handle empty user selection layers 2018-10-23 09:35:25 +02:00
Paul Chavard
93ef0a02b7 Remove unused lien_demarche from procedure 2018-10-23 09:25:29 +02:00
Paul Chavard
53a261f424 Don’t rely on a decorator for ProcedureSerializer#geographic_information 2018-10-22 23:28:16 +02:00
Paul Chavard
2e7a4a4098 Add state to ProcedureSerializer 2018-10-22 23:28:16 +02:00
Paul Chavard
4ebc0b7f4c Refactor link attribute generation on ProcedureSerializer 2018-10-22 23:28:16 +02:00
Paul Chavard
7cf225d443 Add Carte champs support to the API 2018-10-22 23:28:00 +02:00
Paul Chavard
17418edb54 Add SIRET champs support to the API 2018-10-22 23:28:00 +02:00
gregoirenovel
0ae8c1d719 [Fix #2880] Do not show our phone number to instructeurs 2018-10-18 18:38:04 +02:00
Frederic Merizen
447e54fe45 [Fix #2874] Allow archived dossiers to appear in search results 2018-10-18 16:05:19 +02:00
Pierre de La Morinerie
65bdfacd8c dossier: remove old SIRET code, controllers and views 2018-10-18 15:46:00 +02:00
gregoirenovel
3a973999a3 [Ref #2738] Hide exercices if not gestionnaire 2018-10-17 15:07:29 +02:00
Frederic Merizen
0dea9f9ece [#2741] Additional test to filtered_ids to be sure 2018-10-17 12:16:51 +02:00
Frederic Merizen
c652cf3ae5 [#2741] Expand unit tests for sorted_ids just to be sure 2018-10-17 12:16:51 +02:00
Frederic Merizen
37fb358bd5 [#2741] Expand unit tests for #get_value just to be sure 2018-10-17 12:16:51 +02:00
Frederic Merizen
a2bd0582b9 [Fix #2741] Filter / sort by en_construction_at 2018-10-17 12:16:51 +02:00
Pierre de La Morinerie
c178e9226b spec: add integration tests for the new SIRET flow 2018-10-17 10:37:06 +02:00
Pierre de La Morinerie
015b74ae56 spec: refactor dossier creation spec 2018-10-17 10:37:06 +02:00
Pierre de La Morinerie
879dfa0fcc spec: move dossier_creation_spec to from user to new_user 2018-10-17 10:37:06 +02:00
Pierre de La Morinerie
93f1a53dfc dossier: add page for etablissement 2018-10-17 10:37:06 +02:00
Pierre de La Morinerie
310f4b92d1 dossier: add action to save SIRET number 2018-10-17 10:37:06 +02:00
Pierre de La Morinerie
54ba0f8e50 dossier: add new page for SIRET identification 2018-10-17 10:37:06 +02:00
Paul Chavard
93ba94a9e6 Add carte champ and geo area models 2018-10-16 14:01:12 +03:00
gregoirenovel
baf69acbcb [Fix #2833] Move /support files to /fixtures 2018-10-16 10:47:41 +02:00
gregoirenovel
99894961a5 AddressController#get → #suggestions 2018-10-16 09:38:53 +02:00
gregoirenovel
43f9fc93de AddressController#get_address_point → #geocode 2018-10-16 09:38:53 +02:00
gregoirenovel
79ebdc3443 Ban::SearchController → AddressController 2018-10-16 09:38:53 +02:00
gregoirenovel
0018326451 Add some spacing to specs 2018-10-16 09:33:16 +02:00
gregoirenovel
22088b167d Remove ApiAdresse::Geocodeur 2018-10-16 09:33:16 +02:00
gregoirenovel
145880555e ApiAdresse::PointAdapter#point → #geocode 2018-10-16 09:33:16 +02:00
gregoirenovel
af716fa3c6 ApiAdresse::PointRetriever → ApiAdresse::PointAdapter 2018-10-16 09:33:16 +02:00
gregoirenovel
7af41b35a2 ApiAdresse::AddressAdapter#list → #get_suggestions 2018-10-16 09:33:16 +02:00
gregoirenovel
517c0ad3fc ApiAdresse::AddressRetriever → ApiAdresse::AddressAdapter 2018-10-16 09:33:16 +02:00
gregoirenovel
76cf9ab746 ApiGeo::Driver → ApiGeo::API 2018-10-15 23:31:23 +02:00
gregoirenovel
8b4ba42f15 Simplify ApiAdresse 2018-10-15 23:31:23 +02:00
gregoirenovel
a841a517df ApiAdresse::Driver → ApiAdresse::API 2018-10-15 23:31:23 +02:00
gregoirenovel
5db4de6c53 QuartiersPrioritaires::Adapter → QuartiersPrioritairesAdapter 2018-10-15 23:31:23 +02:00
gregoirenovel
918a91a985 ApiCarto::Cadastre::Adapter → ApiCarto::CadastreAdapter 2018-10-15 23:31:23 +02:00
gregoirenovel
dc28e79ab4 Group API Entreprise mock responses in a folder 2018-10-15 23:31:23 +02:00
gregoirenovel
7ae5e8ce52 Group API Adresse mock responses in a folder 2018-10-15 23:31:23 +02:00
gregoirenovel
bfa2d5748d Properly name a support files folder 2018-10-15 23:31:23 +02:00
gregoirenovel
2a57c093c0 Remove a duplicated cassette 2018-10-15 20:55:46 +02:00
gregoirenovel
5e9e913dce Carto::Geocodeur → ApiAdresse::Geocodeur 2018-10-15 20:55:46 +02:00
gregoirenovel
d726fbf698 CARTO::SGMAP → ApiCarto 2018-10-15 20:55:46 +02:00
gregoirenovel
bf63e7d6ab Use HTTPS for the API Adresse URL 2018-10-15 20:55:46 +02:00
gregoirenovel
dac2019675 Carto::Bano → ApiAdresse 2018-10-15 20:55:46 +02:00
gregoirenovel
4903a6b189 Carto::GeoAPI → ApiGeo 2018-10-15 20:55:46 +02:00
gregoirenovel
2c76b9386e Remove unused cassettes 2018-10-15 19:57:50 +02:00
gregoirenovel
34ac68b27f 2018-10-15 17:12:34 +02:00
gregoirenovel
b162c68844 Use Hash#slice 2018-10-15 17:12:34 +02:00
gregoirenovel
22beb41240 Unify #generate_qp with #generate_cadastre 2018-10-15 16:45:30 +02:00
gregoirenovel
2ed4c1da1c Use round brackets 2018-10-15 16:45:30 +02:00
gregoirenovel
1f0af303f3 Remove the unused ModuleApiCarto#classes method 2018-10-15 16:16:16 +02:00
Pierre de La Morinerie
47af56cf8b spec: move /spec/lib/rake to /spec/lib/tasks
This reflects the structure of the `/lib/tasks` directory.
2018-10-15 11:51:49 +02:00
Paul Chavard
38091963c1 Update carto tests 2018-10-14 12:34:44 +02:00
Paul Chavard
b5a3fc76fb Remove legacy carto routes 2018-10-14 12:34:43 +02:00
simon lehericey
888bbee097 [fix #2818] DossierController: ensure save_draft is authorized 2018-10-12 12:14:49 +02:00
Frederic Merizen
3dca3c7dee [Fix #1961] Check that sorted_ids works for individual 2018-10-11 12:13:03 +02:00
Frederic Merizen
abd066c6f4 [#1961] filtered_ids for individual 2018-10-11 12:13:03 +02:00
Frederic Merizen
34da620b0f [#1961] get_value for individual 2018-10-11 12:13:03 +02:00
Frederic Merizen
5d862ae92b [#1961] Add individual fields 2018-10-11 12:13:03 +02:00
Frederic Merizen
577475f26e [Fix #2580] Filter by created_at / updated_at 2018-10-10 18:18:28 +02:00
gregoirenovel
c8f872c566 InviteUser → Invite 2018-10-10 12:07:10 +02:00
gregoirenovel
ed11852300 Delete the InviteGestionnaire model 2018-10-10 12:07:10 +02:00
Frederic Merizen
40a5ff0266 [#2750] do parsing of displayed_fields inside ProcedurePresentation
rather than in the view
2018-10-10 09:07:57 +02:00
Frederic Merizen
9fa7a6fd0e [#2750] Move get_value to ProcedurePresentation 2018-10-10 09:07:57 +02:00
Frederic Merizen
fc157c3e4c [#2750] Move sorted_ids to ProcedurePresentation 2018-10-10 09:07:57 +02:00
Frederic Merizen
2e9dafb4c3 [#2750] Move filtered_ids to ProcedurePresentation 2018-10-10 09:07:57 +02:00
Frederic Merizen
0e9b40ccf6 [#2750] Move fields from Procedure to ProcedurePresentation 2018-10-10 09:07:57 +02:00
Frederic Merizen
efcac5192a [#2750] Move fields_for_select to ProcedurePresentation 2018-10-10 09:07:57 +02:00
gregoirenovel
f3caa8ef7f Remove apipie (and maruku) 2018-10-09 17:23:07 +02:00
gregoirenovel
98d348aab1 Remove the delete demarche feature for admins 2018-10-09 16:42:32 +02:00
simon lehericey
2288303de9 [fix #2777] DossiersSerializer: add state 2018-10-08 18:36:49 +02:00
simon lehericey
87e731bc75 Dossier: move state translation to model dossier 2018-10-08 17:55:20 +02:00
Frederic Merizen
33f29f35ab Avoid recreating service too often 2018-10-04 18:09:39 +02:00
Frederic Merizen
eafd0e8348 Evite de cacher la whitelist trop longtemps 2018-10-04 18:09:39 +02:00
gregoirenovel
12f0c99b5a Remove FC fields from instructeur table customisation 2018-10-04 13:54:07 +02:00
gregoirenovel
5107b33af8 Remove FC fields from search 2018-10-04 13:54:07 +02:00
Paul Chavard
44511acfed Do not reload page when instructeur change dossier state
fix #2425
2018-10-04 11:12:43 +02:00
Frederic Merizen
b36d153620 Fix missing sort columns 2018-10-03 17:09:49 +02:00
gregoirenovel
7e4268db67 Enable Style/TrailingCommaInArguments 2018-10-03 12:03:21 +02:00
gregoirenovel
a171186dd8 Enable Style/TrailingCommaInHashLiteral 2018-10-03 12:03:21 +02:00
gregoirenovel
ed240cb4d3 Enable Style/UnneededInterpolation 2018-10-03 12:03:21 +02:00
gregoirenovel
6eeba14885 Enable Style/WordArray 2018-10-03 12:03:21 +02:00
Frederic Merizen
8bb08a1b8b [#2579] Validate columns on ProcedurePresentation model 2018-10-03 10:17:46 +02:00
Frederic Merizen
6fa0c8d2d6 [#2579] Add unit tests for get_value 2018-10-03 10:17:46 +02:00
Frederic Merizen
d2362c29ed [#2579] Add unit tests for DossierFieldService.sorted_ids 2018-10-03 10:17:46 +02:00
Frederic Merizen
b8f88ece5c [#2579] Fix injection SQL dans le filtrage instructeur 2018-10-03 10:17:46 +02:00
Paul Chavard
941c529b2c Remove CGU checkbox
fix #2725
2018-10-03 08:59:02 +02:00
Pierre de La Morinerie
36c1aa118d dossier: remove RecapitulatifController
And add a redirection to the new URLs.
2018-10-02 15:42:29 +02:00
Pierre de La Morinerie
bf9f427299 dossier: remove DescriptionController 2018-10-02 14:40:47 +02:00
Pierre de La Morinerie
3392df0029 dossier: remove CommentairesController 2018-10-02 14:40:38 +02:00
Pierre de La Morinerie
758ccff984 dossier: remove feature flag 2018-10-02 12:25:44 +02:00
Pierre de La Morinerie
f007eaa2ee dossier: enable new UI by default 2018-10-02 12:23:53 +02:00
gregoirenovel
cf69c28979 Fix scope for logo/notice/deliberation deletion 2018-10-02 11:03:48 +02:00
Pierre de La Morinerie
cd938b4c36 dropdown: refactor to make the button an actual button 2018-09-27 17:43:08 +02:00
Pierre de La Morinerie
c79c1a2636 carto: update link to dossier 2018-09-27 17:22:59 +02:00
Pierre de La Morinerie
0526551e71 templates: update link to dossier 2018-09-27 17:22:59 +02:00
Pierre de La Morinerie
40cf7ebdcb mailers: update links to messagerie 2018-09-27 17:22:59 +02:00
Pierre de La Morinerie
08dfe7d13a support: update link to messagerie 2018-09-27 17:22:59 +02:00
Pierre de La Morinerie
421a4107da dossier: rename dossier_spec to brouillon_spec 2018-09-27 17:22:59 +02:00
simon lehericey
6725c5e34c Procedure: add test on mean_instruction_time 2018-09-27 15:02:38 +02:00
simon lehericey
88f7e888c3 Administrateur: do not save api_token in clear text anymore 2018-09-27 10:24:56 +02:00
simon lehericey
912371fbd6 DossierController: use new token validation 2018-09-27 10:24:56 +02:00
simon lehericey
3c95273d6f ProcedureController: use new token validation 2018-09-27 10:24:56 +02:00
simon lehericey
4a04f2e59f ApiController: check token validity for a given admin 2018-09-27 10:24:56 +02:00
simon lehericey
6837c79dd1 Spec: use have_http_status matcher 2018-09-27 10:24:56 +02:00
simon lehericey
2b46a56259 Spec: simplify 2018-09-27 10:24:56 +02:00
simon lehericey
d14944fba3 Spec: mutualize subject 2018-09-27 10:24:56 +02:00
simon lehericey
7b27f00a23 Spec: do not use the deprecated api_token 2018-09-27 10:24:56 +02:00
simon lehericey
9a6e985bac Spec: remove useless require 2018-09-27 10:24:56 +02:00
simon lehericey
674d231194 Spec: add spaces for readability 2018-09-27 10:24:56 +02:00
simon lehericey
1af789b9a8 Profile: add breadcrumb 2018-09-27 10:14:32 +02:00
simon lehericey
8c4f8347ca Api Token: store token in an encrypted form 2018-09-27 10:14:32 +02:00
simon lehericey
1997f45d7e Api Token: do not generate one token by default 2018-09-27 10:14:32 +02:00
simon lehericey
17285b0368 Profil: display token only once 2018-09-27 10:14:32 +02:00
simon lehericey
bd04972f65 Profile: move to new design 2018-09-27 10:14:32 +02:00
Paul Chavard
f94a24d7ce Add path field to procedure information form 2018-09-26 10:53:45 +02:00
Mathieu Magnin
499021588d [Fix #1285] Password strength is ensured when saving an administrateur 2018-09-26 09:03:03 +02:00
Frederic Merizen
998754ab73 [Fix #2258] Validate options for linked dropdown menus 2018-09-25 20:32:19 +02:00
Frederic Merizen
3fea14c07d [#2258] Let dynamic type validate the type de champ 2018-09-25 20:31:34 +02:00
Pierre de La Morinerie
aae1a22b3b dossier spec: add tests to demande view 2018-09-25 16:47:16 +02:00
Pierre de La Morinerie
613900a053 dossier spec: mutualize demande view specs 2018-09-25 16:47:16 +02:00
Frederic Merizen
7631bde16a [#2550] Generate attestation on auto-accepted dossier 2018-09-25 15:53:57 +02:00
Pierre de La Morinerie
8a3f455aa3 dossier spec: test invitation behavior with the new dossier UI 2018-09-25 11:39:31 +02:00
Pierre de La Morinerie
12ee9ba3ce dossier spec: add navigate_to_invited_dossier helper 2018-09-25 11:39:31 +02:00
Pierre de La Morinerie
1c7ad4d37b dossier spec: rename user to owner
This makes the distinction between the invited user and the owner 
clearer.
2018-09-25 11:39:31 +02:00
Pierre de La Morinerie
fe4921bf8e dossier spec: deprecate the old UI tests 2018-09-25 11:39:31 +02:00
Pierre de La Morinerie
c534a9a792 dossier spec: extract the dossier edition behaviors to a shared spec
This will allow to test behavior for invited users.
2018-09-25 11:39:31 +02:00
Pierre de La Morinerie
df2bbba201 dossier spec: create a simple_procedure factory 2018-09-25 11:39:30 +02:00
Pierre de La Morinerie
2b2dbcb112 dossier spec: move visit_dossier to a before block 2018-09-25 11:38:30 +02:00
Frederic Merizen
9beaa293cd [#1421] Use delegation rather than STI for TypeDeChamp 2018-09-25 08:26:56 +02:00
Frederic Merizen
112fdb71fb [#2613] Remove dead code 2018-09-24 20:19:26 +02:00
Frederic Merizen
26ece1d144 [Fix #2613] Filter by date creation entreprise 2018-09-24 20:19:26 +02:00
Frederic Merizen
7d382837d9 [Fix #2622] Change filters to proper JSONB 2018-09-24 19:39:01 +02:00
Frederic Merizen
1419e9b73f [#2622] Change sort to proper JSONB 2018-09-24 19:39:01 +02:00
Frederic Merizen
68608307ad [#2622] Change displayed_fields to proper JSONB 2018-09-24 19:39:01 +02:00
Pierre de La Morinerie
23820988be fixup! dossier: allow inviting users on the dossier page 2018-09-24 17:12:15 +02:00
Pierre de La Morinerie
01599ac1e1 dossier: allow inviting users on the dossier page 2018-09-24 17:05:26 +02:00
gregoirenovel
5db408efdb [Fix #1511] Remove the now obsolete DS logo 2018-09-24 12:16:58 +02:00
gregoirenovel
227006d87b [Fix #329] Properly translate the “password is too short” error 2018-09-23 22:39:01 +02:00
Frederic Merizen
ac82a72dcc [#1946] Monthly expiring dossiers summary mail 2018-09-20 17:44:31 +02:00
Frederic Merizen
43d8db88d9 [#1946] Check if a dossier’s retention period has expired 2018-09-20 17:44:31 +02:00
Frederic Merizen
b672377f5b [#1946] Query dossiers by remaining retention time 2018-09-20 17:44:31 +02:00
Frederic Merizen
5e16b5d80e [#1946] Set en_instruction_at for factorybot-created dossiers 2018-09-20 17:44:31 +02:00
Frederic Merizen
e00aa4a250 [#1946] Make assertions independent 2018-09-20 17:43:06 +02:00
gregoirenovel
0c9628c180 Fix some files according the the .editorconfig rules 2018-09-20 16:23:09 +02:00
gregoirenovel
a87e79ac1f Update a test to comply with Rubocop rules 2018-09-20 16:23:09 +02:00
Paul Chavard
f2139552c2 Reset Flipflop before each test 2018-09-20 16:13:34 +02:00
gregoirenovel
b317b49b3d Confirmation → activation 2018-09-20 10:43:07 +02:00
Pierre de La Morinerie
e5f4056fe2 invite: fix prefilling the invited user email 2018-09-19 12:41:09 +02:00
Pierre de La Morinerie
bfa2a4b89d invite: refactor the syntax of the submit_login_form helper 2018-09-19 12:41:09 +02:00
Pierre de La Morinerie
a63e035daf spec: fix Flipflop state not being reseted after test
This would cause the Support specs to fail randomly with an unexpected
redirection.
2018-09-19 12:41:09 +02:00
gregoirenovel
f3a257d81d Show the mean verification time in the Résumé tab 2018-09-19 12:31:59 +02:00
gregoirenovel
d55c9dff4d Show the mean instruction time in the Résumé tab 2018-09-19 12:31:59 +02:00
Pierre de La Morinerie
082ef92a99 invite: move invites link to the after_confirmation callback
Refactored from 6a69d958da

The `after_confirmation_path_for` isn't really made to be a callbback.
For instance, it is not executed during tests.

Moving the invitations linking to a proper documented callback allows
the linking to work in a testing environment, when invoking `user.confirm`.
2018-09-19 12:08:28 +02:00
gregoirenovel
4e4b7c617f [Fix #2618] Do not enforce Luhn for La Poste SIRET numbers 2018-09-19 10:29:43 +02:00
gregoirenovel
471f6799c8 Refactor Siret tests 2018-09-19 10:15:42 +02:00
Paul Chavard
db1a93ab35 fix procédure -> démarche 2018-09-18 11:22:06 +02:00
Pierre de La Morinerie
ea3267c0d7 dossier: don't display 'brouillon' in the timeline if not required
Unless the user is actually editing a brouillon, we don't need to show
this state.
2018-09-18 10:33:11 +02:00
Pierre de La Morinerie
27727eabf3 dossier: add link to attestation when accepted 2018-09-17 16:29:48 +02:00
Pierre de La Morinerie
fd7f07a244 dossier: add link to messagerie when rejected 2018-09-17 16:29:48 +02:00
gregoirenovel
cedf1ba427 footer → dossier_footer 2018-09-13 10:46:32 +02:00
Paul Chavard
55a9b31b93 Cleanup SIRET champ 2018-09-12 15:53:02 +02:00
Paul Chavard
3f6cc668a7 Implement check_availability route 2018-09-12 12:37:15 +02:00
Pierre de La Morinerie
926dc3e107 dossier: display latest message on summary page 2018-09-12 10:09:16 +02:00
Pierre de La Morinerie
968952ff46 Reorder a test to prepare for a future one 2018-09-12 10:09:16 +02:00
gregoirenovel
c1bec7cf0b Pass the connected_user object instead of its email 2018-09-11 18:17:40 +02:00
gregoirenovel
f8a6765367 [Fix #2540] Allow an instructeur to send a dossier to several instructeurs 2018-09-11 18:00:24 +02:00
Paul Chavard
f3333595a0 Drop text_summary endpoint 2018-09-07 19:41:34 +01:00
Paul Chavard
c49db4b5a4 Add a champs/dossier_link endpoint and use it to fetch dossier info 2018-09-07 19:41:33 +01:00
Pierre de La Morinerie
353ab812fc messagerie: fix 'Invité' label in message sender 2018-09-07 12:02:26 +02:00
Pierre de La Morinerie
211674435e messagerie: better format message dates 2018-09-07 12:02:26 +02:00
gregoirenovel
095166e38f Add original states restoration after some tests
To avoid failing tests
2018-09-07 10:31:39 +02:00
gregoirenovel
87e59e2bfb Streamline DossierController#update_brouillon and #update 2018-09-07 10:19:10 +02:00
gregoirenovel
1341074325 Add DossierController#update 2018-09-07 10:19:10 +02:00
gregoirenovel
cd46ee06e1 Add DossierController#modifier 2018-09-07 10:19:10 +02:00
gregoirenovel
338ffb8b50 DossierController#update → #update_brouillon 2018-09-07 10:19:10 +02:00
gregoirenovel
5ac8117c69 DossierController#modifier → #brouillon 2018-09-07 10:19:10 +02:00
Pierre de La Morinerie
19908ede25 gestionnaire: fix dossier printing page
Fix the invalid template, and add tests.
2018-09-05 16:17:26 +02:00
gregoirenovel
00ecae5f93 Procédure → Démarche 2018-09-05 15:46:24 +02:00
lucien mollard
b2f2e75f43 mailer: add layout for notifications emails 2018-09-05 15:31:08 +02:00
Pierre de La Morinerie
2a5a8cf621 mailer: fix typo in spec 2018-09-05 15:25:46 +02:00
Pierre de La Morinerie
d7dd027cb8 mailer: improve naming in specs 2018-09-05 15:25:46 +02:00
Pierre de La Morinerie
af5df2d661 dossier: add "Messagerie" tab 2018-09-05 14:02:12 +02:00
Pierre de La Morinerie
63472f00e6 messagerie: generalize the current user email 2018-09-05 13:56:12 +02:00
Pierre de La Morinerie
4e2a5f0b9b messagerie: move templates to a shared location 2018-09-05 13:56:12 +02:00
Pierre de La Morinerie
d77e0e938f dossier: fix status overview test 2018-09-05 13:55:52 +02:00
Pierre de La Morinerie
d99e606206 dossier: rename status_progress to status_overview 2018-09-05 11:52:04 +02:00
gregoirenovel
6b88968889 Formulaire → demande, when not editable 2018-09-05 11:07:11 +02:00
Pierre de La Morinerie
750e1e0c83 gestionnaire: move commentaire creation into a service 2018-09-04 18:52:43 +02:00
gregoirenovel
f66d8451b1 Fix FactoryBot warnings 2018-09-04 16:46:48 +02:00
gregoirenovel
b2dc502ed5 Use an env var for Carrierwave's cache_dir 2018-09-04 16:07:59 +02:00
gregoirenovel
75ee41b7fa [Fix #2494] Improve deletion warning text 2018-08-31 15:41:51 +02:00
Frederic Merizen
559d080ca6 [#1946] Show data retention time in footer 2018-08-30 18:03:01 +02:00
Paul Chavard
4866f9724a Add support controller send_form tests 2018-08-30 15:16:35 +01:00
Paul Chavard
8e88f2c27f Cleanup support controller tests 2018-08-30 15:12:50 +01:00
Paul Chavard
ea5248dde1 Flatten tags list, cast to array and remove blank elements 2018-08-30 15:12:50 +01:00
Frederic Merizen
37c45f0d29 [#2486] Always order champs
to help activerecord cache the champs collection
2018-08-30 14:13:32 +02:00
gregoirenovel
e60aa0c37b Use scopes when possible 2018-08-30 13:16:14 +02:00
gregoirenovel
3662b82039 accompagnateur → instructeur 2018-08-29 23:09:08 +02:00
Frederic Merizen
580c6145d0 Migrate nutriscore dossiers from old procedure to new procedure 2018-08-29 19:40:02 +02:00
gregoirenovel
4b071ecf06 Use enum to the fullest with Dossier.states 2018-08-29 17:31:08 +02:00
gregoirenovel
ee25bba38c Use enum to the fullest with Service.type_organismes 2018-08-29 17:31:08 +02:00
gregoirenovel
2d3b553e4d Use enum to the fullest with TypeDeChamp.type_champs 2018-08-29 17:31:08 +02:00
gregoirenovel
16a719922b Use enum to the fullest with User.loged_in_with_france_connects 2018-08-29 17:31:08 +02:00
gregoirenovel
606b56033a Use enum to the fullest with VirusScan.statuses 2018-08-29 17:31:08 +02:00
Paul Chavard
509613afe6 Use contact_link helper instead of mailto 2018-08-29 16:08:01 +01:00
gregoirenovel
0ac160c824 Remove the now useless stats API 2018-08-29 14:54:49 +02:00
Paul Chavard
bad107ffae Add contact form 2018-08-29 10:44:12 +01:00
Paul Chavard
6453b53a41 Add helpscout API adapter 2018-08-29 10:43:00 +01:00
gregoirenovel
6b1ab9b552 Remove a now useless facade 2018-08-28 15:38:39 +02:00
gregoirenovel
cccad7dbdf Remove a now useless method 2018-08-28 15:19:54 +02:00
gregoirenovel
19789b6848 Remove the stats part of the procedure info page for admins
- the numbers are wrong (:termine state does not
  exist)
- the chart does not work
2018-08-28 15:19:31 +02:00
gregoirenovel
9f3650b12f Remove 2 months old call for suggestions 2018-08-28 10:11:09 +02:00
gregoirenovel
d6748bde20 Update a factory so that it uses rating instead of mark 2018-08-27 17:12:01 +02:00
gregoirenovel
3d7b239f2b Improve the feedback form question 2018-08-27 14:16:20 +02:00
Paul Chavard
9abb3c7a5a [ENV] Pipedrive key config 2018-08-23 15:55:32 +02:00
Mathieu Magnin
db8e750f1a [ENV] Configure Api Entreprise token 2018-08-23 15:55:32 +02:00
Frederic Merizen
cef0eafb1a [#2179] Tolerate spurious spaces around search terms 2018-08-23 11:57:06 +02:00
Frederic Merizen
7643459a55 [#2179] Reuse search spec for search service 2018-08-23 11:57:06 +02:00
Frederic Merizen
3b2919a326 [#2179] Use new updated value for search terms
Rather than old in-database value
2018-08-23 10:34:25 +02:00
Paul Chavard
097b06e314 Fix test dossier page 2018-08-14 16:47:31 +02:00
Paul Chavard
b57c22cafe Refactor publish dialog 2018-08-14 16:39:11 +02:00
Pierre de La Morinerie
af95e56b50 dossier: add a page with the form 2018-08-14 15:25:27 +02:00
Pierre de La Morinerie
86539413ee gestionnaire: move dossier partials to a shared location 2018-08-14 15:06:44 +02:00
Pierre de La Morinerie
c286e5fa41 specs: improve dossier details tests 2018-08-14 15:06:44 +02:00
Pierre de La Morinerie
242f9d0af7 specs: fix order-dependant tests in spec/models/gestionnaire_spec.rb
Test run that would fail randomly before:

```
bin/rspec --seed 10002 spec/models/dossier_spec.rb spec/models/gestionnaire_spec.rb
```
2018-08-14 11:48:54 +02:00
Paul Chavard
7237ff80cc Drop procedure dossiers when updating brouillon 2018-08-14 11:21:05 +02:00
Paul Chavard
9de3e6e74b Make info extraction method more safe 2018-08-13 18:32:00 +02:00
Paul Chavard
a6a4790a35 Replace logstasher with lograge 2018-08-13 12:44:00 +02:00
Pierre de La Morinerie
1b7950058d dossier: add details résumé 2018-08-13 11:32:27 +02:00
Pierre de La Morinerie
18d13d76d8 dossier: add details header 2018-08-13 11:32:27 +02:00
simon lehericey
b33f11115c [fix #2358] Checkbox: serialize in attestation by oui or no 2018-08-10 16:25:34 +02:00
lucien mollard
9ecc5f7928 add a user satisfaction form' 2018-08-09 11:41:26 +02:00
Pierre de La Morinerie
5e01be0f15 mailer: add direct link to dossier in creation email
Fix #2341
2018-08-08 15:24:17 +02:00
simon lehericey
9c023095da [fix #2359] Fix link in avis mail for gestionnaire 2018-08-08 13:19:54 +02:00
Pierre de La Morinerie
77eb89cb0f dossier: add a stub page for the new dossier details 2018-08-08 11:49:15 +02:00
Pierre de La Morinerie
0ac28da207 dossier: make Dossiers#show a stub redirecting to the correct location 2018-08-08 11:49:15 +02:00
Paul Chavard
8b79c32a55 Do not rely on javascript for form submits without direct upload 2018-08-07 16:58:49 +02:00
Paul Chavard
a0979b1d57 Fix logstasher custom fields 2018-08-07 16:26:44 +02:00
Pierre de La Morinerie
93ba063612 specs: improve reliability of procedure creation features
The 'etape_suivante' button is sometimes not activated, and it could
be because the event handler on the checkbox sometimes doesn't run.
2018-08-07 14:28:52 +02:00
Pierre de La Morinerie
cc15b0bb28 specs: make checkbox click cleaner 2018-08-07 14:28:52 +02:00
Pierre de La Morinerie
9ec5befa09 specs: increase Capybara default timeout
Because CircleCI machines are slow, and tests sometimes timeout.
2018-08-07 14:28:52 +02:00
Paul Chavard
c91abe73c5 Remove old user dossier form 2018-08-07 14:13:27 +02:00
Pierre de La Morinerie
c8409ecb89 dossier: remove route hack for show 2018-08-07 12:15:38 +02:00
Paul Chavard
46e75ac8ef Only notify on dossier supression if dossier is en_construction 2018-08-02 17:07:24 +02:00
Pierre de La Morinerie
1ca2ca9121 invite: support remote forms
This allows to keep the draft content when inviting a new user.
2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
1cac0b80af invite: add button for invite someone to collaborate on a draft 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
9541e781bb invite: rename 'email' to 'invite_email' 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
a386a0ffb2 specs: add spec for DossierController#forbid_invite_submission! 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
bdd05937e2 specs: refactor invites_controller_spec.rb 2018-08-01 17:41:12 +02:00
Pierre de La Morinerie
2a3ce61dd9 specs: move list_dossiers from user to new_user 2018-08-01 17:41:11 +02:00
Pierre de La Morinerie
dee4acd802 dossier_facade: remplace followers by an equivalent implementation 2018-08-01 17:41:11 +02:00
Pierre de La Morinerie
8d9b65e556 specs: wait for ajax requests completion where required 2018-08-01 11:01:46 +02:00
Pierre de La Morinerie
270384f8dd specs: remove redundant line 2018-08-01 11:01:26 +02:00
Pierre de La Morinerie
8af86fb110 specs: move config line where it makes more sense 2018-08-01 11:00:17 +02:00
Pierre de La Morinerie
45d9de0995 spec: remove useless comment 2018-08-01 10:59:54 +02:00
Paul Chavard
e358e72867 Do not display gestionnaire emails in the messaging interface
fix #2302
2018-07-31 15:27:36 +02:00
Pierre de La Morinerie
56e3a56bad specs: fix application_job_spec 2018-07-30 11:03:16 +02:00
Pierre de La Morinerie
1eb110ac7c specs: fix random seed being always the same when using Spring 2018-07-30 11:03:16 +02:00
Frederic Merizen
0e639030f9 [#2179] Generate denormalized search terms value for Dossier 2018-07-27 11:11:52 +02:00
Mathieu Magnin
84937e3d43 Fix Sentry error 2755 2018-07-26 17:38:19 +02:00
Paul Chavard
bf7c023380 Add webpacker and use it for new_design 2018-07-25 15:14:06 +02:00
gregoirenovel
abbd4e3c69 [Fix #2277] Do not crash when creating a service with invalid data 2018-07-25 14:22:44 +02:00
Pierre de La Morinerie
13182ad291 dossier: send deletion email also to the following gestionnaires 2018-07-25 13:49:55 +02:00
Pierre de La Morinerie
6daa31d410 spec: add tests for Dossier#delete_and_keep_track 2018-07-25 13:49:55 +02:00
Pierre de La Morinerie
0f1811dd4e dossier: add an button to delete a brouillon 2018-07-24 18:31:10 +02:00
gregoirenovel
eb95fce194 [Fix #2272] Add a SIRET field to the Service form 2018-07-19 15:43:13 +02:00
gregoirenovel
ed436bfe77 [Fix #2260] Add a search field in the usager UI 2018-07-17 17:26:42 +02:00
gregoirenovel
4d41381155 Move the attestation route inside the member block 2018-07-17 17:26:42 +02:00
Pierre de La Morinerie
40aae2e20b mailers: mention the procedure when notifying about dossier deletion 2018-07-16 15:49:34 +02:00
Pierre de La Morinerie
d6624aeca7 mailers: add tests for dossier_mailer 2018-07-16 15:38:03 +02:00
simon lehericey
0e8a1f1678 [fix #2241] GestionnaireDossierController: allow linked drop down value in update 2018-07-12 14:11:42 +02:00
Pierre de La Morinerie
0282994990 form: move the procedure notice link to a button 2018-07-11 17:13:18 +02:00
Pierre de La Morinerie
defee1d2d5 tests: refactor modifier.html.haml_spec.rb to use "subject" 2018-07-11 17:12:35 +02:00
Pierre de La Morinerie
f5d3adba5e dossiers: remove unused dossiers list code
This code is unused since the user dossiers list uses the new UI.
2018-07-04 12:23:49 +02:00
Pierre de La Morinerie
33c743ab77 helper: simplify DossierHelper.url_for_dossier
The argument is never an Invite
2018-07-04 11:43:39 +02:00
Pierre de La Morinerie
394019b70c specs: save a screenshot of failing integration tests 2018-07-04 09:43:22 +02:00
Pierre de La Morinerie
b0a9e49549 procedures: group new_from_existing list by organization
As procedures are not grouped by Service (which are unique to an
administrator) but by organization, this allows procedures with the same
organization name to be displayed together.
2018-07-03 23:43:42 +02:00
Pierre de La Morinerie
56987e5147 procedures: add tests for new_from_existing 2018-07-03 23:43:41 +02:00
Pierre de La Morinerie
d1301762d4 pipedrive: fix deals when no deals are returned 2018-07-02 17:07:24 +02:00
Pierre de La Morinerie
b4b533f0c5 dossiers: change all links to use the new user dossiers list 2018-07-02 13:58:58 +02:00
Pierre de La Morinerie
148dc164f7 dossiers: generate the correct link to see the dossier details 2018-07-02 13:58:58 +02:00
Pierre de La Morinerie
f2ee88b278 dossiers: put last updated dossiers first 2018-07-02 13:58:58 +02:00
Pierre de La Morinerie
d70f01a6b2 form: cleanup dossier feature spec 2018-07-02 12:30:27 +02:00
Mathieu Magnin
e694e7f9b9 [Fix #2145] When procedure is archived, usager should see a message explaining dossier submission is closed 2018-07-02 11:10:34 +02:00
Mathieu Magnin
9afbd16bbf [Fix #2145] When procedure is archived, usager should not be able to submit a dossier 2018-07-02 11:10:33 +02:00
Frederic Merizen
b003fe9221 [Fix #2176] Allow setting page size in API 2018-06-29 17:34:35 +02:00
Frederic Merizen
b326cb9c3e [#1421] Handle mandatory fields 2018-06-28 20:06:32 +02:00
Frederic Merizen
e794515c8e [#1421] Format linked dropdown menus in spreadsheet export 2018-06-28 20:06:32 +02:00
Frederic Merizen
04892f6c55 [#1421] Format value for display 2018-06-28 20:06:32 +02:00
Paul Chavard
d0a6957862 Remove old cerfa code 2018-06-28 15:16:20 +02:00
Pierre de La Morinerie
0cebf60c46 [#1421] replace master/slave by primary/secondary 2018-06-27 17:02:46 +02:00
Frederic Merizen
dad3bc092b [#1421] linked dropdwon user view 2018-06-27 17:02:46 +02:00
Frederic Merizen
7b1e8c2110 [#1421] Extract values for both drop down lists 2018-06-27 17:02:46 +02:00
Frederic Merizen
2214fc6b86 [#1421] Extract contents of both drop down lists 2018-06-27 17:02:46 +02:00
Pierre de La Morinerie
d77530b6a6 dossiers: move link back to the old ui 2018-06-27 11:37:06 +02:00
Pierre de La Morinerie
9f70e72d83 dossiers: add a button to start a new demarche 2018-06-26 18:13:52 +02:00
Pierre de La Morinerie
8c36c8d26f dossiers: add an empty state 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
06de1d6cee dossiers: link individual dossiers to the old UI 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
f242c73974 dossiers: make link in the header point to the new UI 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
b9c8a1ffbe dossiers: simpler display when there are not invited dossiers 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
663c39ea11 specs: improve speed of dossiers specs (12s -> 6s) 2018-06-26 18:04:04 +02:00
Pierre de La Morinerie
51e256e122 header: fix link to the contact email 2018-06-25 11:26:45 +02:00
Frederic Merizen
15e8d8af05 [#1421] Add linked dropown fields 2018-06-21 16:19:20 +02:00
Mathieu Magnin
4f93354107
Merge branch 'dev' into fix-rake-specs 2018-06-21 11:44:02 +02:00
simon lehericey
c3610fc96e [fix #2067] Resend confirmation mail if the user is not confirmed 2018-06-20 13:30:32 +02:00
Pierre de La Morinerie
9f502c536b spec: only load tasks once
When a task is loaded several times, a single call of `task.invoke`
will run the task several times too.

This made `add_annotion_privee_to_procedure_spec` fail when it wasn't
the first task being tested.
2018-06-20 11:35:20 +02:00
Pierre de La Morinerie
c4057a0807 dossier: display user infos on edit page 2018-06-19 16:27:53 +02:00
Pierre de La Morinerie
60475d0165 factories: add parenthesis around method arguments 2018-06-19 16:01:35 +02:00
Frederic Merizen
0239f936d7 [#1421] Move departements to DepartementChamp 2018-06-19 15:20:01 +02:00
Frederic Merizen
5b59bce0b6 [#1421] Move regions to RegionChamp 2018-06-19 15:20:01 +02:00
Frederic Merizen
521aec6af9 [#1568] Remove old previsualisation code 2018-06-19 12:42:46 +02:00
Frederic Merizen
fd10310cbf [Fix #1568] Use new procedure preview 2018-06-19 12:42:46 +02:00
Mathieu Magnin
e05fb2d0ae Allow dossier deletion if instruction has not started 2018-06-19 10:05:00 +02:00
Pierre de La Morinerie
790704ef58 tasks: silence output of tasks during tests
Currently, when running specs, the output of rake tasks is spamming
the tests results.

This PR configures Rake so that it runs in quiet mode during specs. This
disables the internal messages of rake during tests.

However our own `puts` also need to be conditionned to the verbosity of
rake. Using a simple `rake_puts` helper allows the info messages to be
displayed when running the rake task manually, but not during tests.

Before:

```
$ bin/rspec spec/lib/rake
Randomized with seed 6544
1 Mails::ClosedMail to clean
cleaning Mails::ClosedMail #1
1 Mails::InitiatedMail to clean
cleaning Mails::InitiatedMail #1
1 Mails::ReceivedMail to clean
cleaning Mails::ReceivedMail #1
1 Mails::RefusedMail to clean
cleaning Mails::RefusedMail #1
1 Mails::WithoutContinuationMail to clean
cleaning Mails::WithoutContinuationMail #1
.....Champ 0/1
.Champ 0/1
.
```

After:

```
$ bin/rspec spec/lib/rake

Randomized with seed 6544
.......
```
2018-06-13 11:05:15 +02:00
Mathieu Magnin
cd4615b10d When a new PJ is uploaded enqueue a anti virus scan job 2018-06-12 15:12:39 +02:00
Frederic Merizen
3ba0dd1620 [#2071] Fix test now that mails are multipart 2018-06-10 11:53:51 +02:00
simon lehericey
e11392981d [fix #2072] DossierController: check the user can update the dossier 2018-06-08 16:24:29 +02:00
gregoirenovel
24e37842ee Fix a typo 2018-06-08 15:14:22 +02:00
gregoirenovel
b88cea3c18 Change a deliver into a deliver_later 2018-06-07 15:14:26 +02:00
Frederic Merizen
65e9025d5d Add at least minimal test for AdministrationMailer 2018-06-06 16:08:18 +02:00
Frederic Merizen
695f5b2705 Fix class methods on BizDev module
and add missing tests
2018-06-06 16:07:29 +02:00
gregoirenovel
41e8350cbe [Fix #1735] Sign the admin account creation email 2018-06-01 20:48:50 +02:00
Frederic Merizen
52bb40ab20 [#1946] Show retention times in procedure administration summary 2018-06-01 17:35:04 +02:00
gregoirenovel
b82ed65568 [Fix #885] Convert .text.erb to .html.haml 2018-06-01 17:14:48 +02:00
Frederic Merizen
346687bd33 [#1946] Once durees de conservation have been set, forbid unsetting them 2018-06-01 16:46:39 +02:00
Frederic Merizen
42765efb91 [#1946] Add validation to durees conservation 2018-06-01 16:46:39 +02:00
Frederic Merizen
648483ac76 [#1946] Allow admins to edit data retention time 2018-06-01 16:46:39 +02:00
Frederic Merizen
5325830d62 [#1946] Extract test helper method 2018-06-01 16:46:39 +02:00
gregoirenovel
4f2509861b Improve the wording of the avis email 2018-06-01 15:42:56 +02:00
Frederic Merizen
c39a58749f Remove duplicate translations
There is a default translation for `blank` already
2018-06-01 15:21:25 +02:00
gregoirenovel
b364b8bfb3 Improve many subjects 2018-06-01 11:35:40 +02:00
simon lehericey
c72421fb9e Procedure: Once deliberation or cadre_juridique have been set, forbid unsetting them 2018-06-01 11:12:53 +02:00
simon lehericey
1f0e46a4ff Procedure: required juridique stuff only if needed 2018-06-01 11:12:53 +02:00
gregoirenovel
185f08f63e Add constants for email addresses 2018-06-01 00:00:11 +02:00
simon lehericey
18ad227df5 [fix #1897] Procedure: can delete a deliberation 2018-05-31 16:56:28 +02:00
simon lehericey
0e690c90cc Procedure: clone the deliberation 2018-05-31 16:56:28 +02:00
simon lehericey
fa14db1cbf Procedure: add deliberation 2018-05-31 16:56:28 +02:00
simon lehericey
a96889310b Procedure: add legal reference 2018-05-31 16:55:31 +02:00
gregoirenovel
0329b1db68 Use User#owns_or_invite? instead of Dossier#owner_or_invite? 2018-05-31 14:39:43 +02:00
gregoirenovel
4e9565a5df Adds User#owns? 2018-05-31 14:39:43 +02:00
Frederic Merizen
2f769ca933 [#1995] Add gender and birthdate fields to API 2018-05-31 14:21:37 +02:00
gregoirenovel
a57e2388f6 Unify NotificationMailer methods’ signatures 2018-05-31 12:10:06 +02:00
Mathieu Magnin
eb1fbb7dbc Delete button, notify user and admin then delete dossier 2018-05-30 18:01:36 +02:00
Frederic Merizen
a62adb4307 [#1999] Remove dead code 2018-05-30 17:07:29 +02:00
simon lehericey
c00f56d454 DubiousProcedure: improve spec 2018-05-30 14:21:41 +02:00
simon lehericey
9f06308dbd DubiousProcedure: ensure that hidden procedure are not detected 2018-05-30 14:21:41 +02:00
Paul Chavard
86b2cb211e Do not attempt to archive already archived procedures 2018-05-29 14:29:26 +02:00
Mathieu Magnin
0f32821b27 Add dossier state to deletion email 2018-05-29 12:16:22 +02:00
Paul Chavard
87d7bd4fb2 Fix clone procedure 2018-05-28 14:58:40 +02:00
Frederic Merizen
fd168c4a72 [Fix #1972] Make devise mails async 2018-05-28 12:02:13 +02:00
Frederic Merizen
07b1c147d9 [Fix #1972] Always send mails asynchronously 2018-05-28 12:02:13 +02:00
Frederic Merizen
cce00e19c6 [#1972] Avoid passing unsaved templates to ActionMailer
So that all mail arguments can be serialized
2018-05-28 12:02:13 +02:00
Mathieu Magnin
152cf03d72 [Fix #1801] rename and move html_formatted_description in a generic helper 2018-05-24 18:05:00 +02:00
gregoirenovel
5d188c191d Move transform_keys calls directly to #process_params methods 2018-05-24 17:54:51 +02:00
Paul Chavard
d99eed122d Use new models in controllers and views 2018-05-24 17:54:51 +02:00
Paul Chavard
753a81c2d3 Update tag substitution concern 2018-05-24 17:54:51 +02:00
Paul Chavard
3f249d6663 Remove unused decorators 2018-05-24 17:54:51 +02:00
Paul Chavard
ad24fd5991 Remove entreprise and rna_information models 2018-05-24 17:54:51 +02:00
Paul Chavard
7fb7d77886 Use aasm_state in scopes 2018-05-24 17:49:24 +02:00
Mathieu Magnin
aaf1bc0b99 [Fix #1931] User can ask support to delete dossier 2018-05-24 16:42:16 +02:00
Paul Chavard
7070b0aba0 Fix tests to rely on aasm states 2018-05-23 16:31:27 +02:00
Paul Chavard
365bbe931b make propper state transitions in procedure traits 2018-05-23 16:31:27 +02:00
simon lehericey
0b87944368 [#1915] Devise: avoid leaking registered people 2018-05-23 15:55:52 +02:00
simon lehericey
7fed476e29 Welcome Mailer: remove obsolete mailer 2018-05-23 15:55:52 +02:00
simon lehericey
6a69d958da Devise: move after_sign_up to after_confirmation 2018-05-23 15:55:52 +02:00
simon lehericey
5bd589344e Devise: confirm user email 2018-05-23 15:55:52 +02:00
Paul Chavard
ceddf65f6c Fix crash with inexistent paths 2018-05-23 15:36:50 +02:00
Paul Chavard
94d253c6dc Add commencer/test/:procedure_path route 2018-05-23 11:32:26 +02:00
gregoirenovel
a246181afd Add API_GEO_URL 2018-05-22 19:01:46 +02:00
Paul Chavard
785fe3410e Clone procedure notice 2018-05-22 17:43:44 +02:00
gregoirenovel
682823ec93 Bump gems
- apipie-rails
- brakeman
- dotenv-rails
- openid_connect
- openstack
- rack-mini-profiler
- rubocop
- sentry-raven
- web-console
- webmock
2018-05-18 18:14:17 +02:00
simon lehericey
928227a610 Procedure: remove now duplicate organisation and direction 2018-05-18 16:21:27 +02:00
simon lehericey
39bb56d1d9 Service: add organisme, email, tel, horaires, adresse 2018-05-18 16:21:27 +02:00
simon lehericey
30513bcb4f Procedure Clone: ensure the service is kept 2018-05-18 16:21:26 +02:00
simon lehericey
f2357acb27 Service: cannot published a procedure without a service 2018-05-18 16:21:26 +02:00
simon lehericey
6b8a878ec1 Service: can be destroyed 2018-05-18 16:21:26 +02:00
simon lehericey
af7be58132 Service: add service to procedure 2018-05-18 16:21:26 +02:00
simon lehericey
5d7455f436 Service: keep procedure_id 2018-05-18 16:21:26 +02:00
Frederic Merizen
365cb9b44d Service: can update a service 2018-05-18 16:21:26 +02:00
simon lehericey
c54c85bad8 Service: can create a service 2018-05-18 16:21:26 +02:00
simon lehericey
fc17b68dc1 Service: create model 2018-05-18 16:21:26 +02:00
simon lehericey
3cfffc2615 [fix #1922] add one annotation to a procedure 2018-05-18 11:48:19 +02:00
Frederic Merizen
f8273ca8ae Make match order-insensitive
to avoid spurious test failures
2018-05-10 12:10:47 +01:00
Frederic Merizen
93e068421b [#1833] New procedure button defaults to procedure library 2018-05-09 16:16:09 +02:00
Mathieu Magnin
3e176d4e08 Remove use of staging.apientreprise 2018-05-09 13:56:29 +02:00
Frederic Merizen
5ef129d960 [#1563] Remove attestation mail attachment 2018-05-09 10:42:40 +02:00
Mathieu Magnin
7f4e6eae6b No dubious proc. email == Everything is ok || Something went wrong. We should always send dubious procedure email. 2018-05-07 12:24:05 +02:00
Mathieu Magnin
a2bbf1b4d6 [Fix #1907] A new token should be regenerated, because the one in db is encrypted 2018-05-04 14:23:05 +02:00
gregoirenovel
8848abc536 #to_sorted_values -> #sorted_values 2018-05-03 23:35:51 +02:00
gregoirenovel
886431b120 Make some methods private 2018-05-03 23:35:51 +02:00
Paul Chavard
0b7cf3ae75 #full_data_strings_array -> #export_values 2018-05-03 23:35:51 +02:00
gregoirenovel
12cda1739b #export_entreprise_data -> #export_etablissement_data 2018-05-03 23:35:51 +02:00
simon lehericey
bb4d29ee8f [fix #1855] Gestionnaire: are now invited to create their password 2018-04-27 14:10:06 +02:00
simon lehericey
3d53366678 [fix #1877] add maintenance mode 2018-04-26 15:06:34 +02:00
Frederic Merizen
5b9f25271f [Fix #1865] Expose attachment field over API 2018-04-24 20:29:25 +02:00
simon lehericey
366ef2d2b5 Procedure: add new preview view 2018-04-24 16:54:05 +02:00
simon lehericey
c90ddb92a6 Procedure: add #new_dossier
Create a new instance of a dossier and its champs without saving them in the db
2018-04-24 16:49:42 +02:00
Frederic Merizen
b0037d50c8 Allow downloads with a HTTP range header 2018-04-24 16:07:19 +02:00
Frederic Merizen
47e06812b1 Cosmetic: nicer indentations for multiline strings 2018-04-24 16:07:19 +02:00
simon lehericey
9d0b568ef5 Procedure: add parent_procedure 2018-04-24 15:48:20 +02:00
simon lehericey
28ce027025 [fix #1832] Procedure Stat: display procedure cloned ratio 2018-04-24 14:22:22 +02:00
simon lehericey
f46bf5a67e Procedure: procedure cloned from library are tagged 2018-04-24 14:22:22 +02:00
Paul Chavard
e965203e73 Disable failing test 2018-04-18 16:51:21 +02:00
Paul Chavard
45019ce75c Use Flipflop instead of Feature 2018-04-18 16:51:21 +02:00
Paul Chavard
3f3358db16 Add flipflop config 2018-04-18 16:51:21 +02:00
Frederic Merizen
35e1030eed Also create users for avis gestionnaires 2018-04-12 16:40:24 +02:00
Frederic Merizen
ee67e7b154 Always create a corresponding User account for Admin accounts 2018-04-12 16:40:24 +02:00
simon lehericey
0ab526de5a [fix #932] Let an adminstrateur upload a pj template 2018-04-09 18:19:24 +02:00
Paul Chavard
408feaa52e Display etablissement information for siret champ 2018-04-09 13:18:10 +02:00
Mathieu Magnin
f6d53be873 [Fix #1799] Send automatic emails to improve administrateur activation 2018-04-09 11:08:13 +02:00
Paul Chavard
27592ae072 Add simple web hooks to procedures 2018-04-09 11:02:24 +02:00
Frederic Merizen
6ed7ae4b53 [Fix #1809] Handle non-champ tags in attestation 2018-04-06 19:22:42 +02:00
kemar
b42e410da0 [Fix #1494] Display a warning when accepting a dossier if needed
Show the accompagnateur the unspecified demande
champs and attestations privées needed for the
attestation
2018-04-06 16:15:09 +02:00
Frederic Merizen
a2ffc4357d [#1563] Generate a helpful alert on attestation / closed mail mismatch 2018-04-06 10:18:56 +02:00
Frederic Merizen
809638df79 [#1563] Determine if Attestation and Closed mail are out of sync 2018-04-06 10:18:56 +02:00
Paul Chavard
45ef32e6d9 Add SIRET Type De Champ 2018-04-05 10:29:29 +02:00
Paul Chavard
0b79a3d79d Add Siret(TypeDe)Champ STI model 2018-04-04 18:44:08 +02:00
Paul Chavard
3cd80af6cb Add sign and verify to etablissement 2018-04-04 18:44:08 +02:00
Paul Chavard
714ebda2fe Add SignatureService 2018-04-04 18:44:08 +02:00
simon lehericey
3c8d1f13b6 Individual: remove birthdate proxy 2018-04-04 15:27:30 +02:00
Mathieu Magnin
8c1c2f32ca [Fix #1724] Ensure that printed json is safe 2018-04-04 14:00:50 +02:00
simon lehericey
c019cb623a Individual: use birthdate as a ... date :) 2018-04-04 13:19:39 +02:00
Frederic Merizen
3e56b6fe9b [#1563] Include attestation link in default closed mail when it makes sense 2018-04-04 10:44:40 +02:00
Frederic Merizen
84c864ed11 [#1563] Add lien attestation link to closed mail template 2018-04-04 09:34:04 +02:00
simon lehericey
46fd213ad2 Individual: old controller does not care about individual anymore 2018-04-03 21:16:54 +02:00
simon lehericey
8828663880 Individual: save the birthdate in Y 2018-04-03 16:23:15 +02:00
simon lehericey
05ab4c5ca6 DossierController: add tab for dossiers invites 2018-04-03 13:32:41 +02:00
simon lehericey
4ec6c72c96 [fix #1755] clean GeoJSON polygones before save 2018-03-30 16:15:30 +02:00
Paul Chavard
9cc6d494a4 Spec STI loading champ/type de champ 2018-03-29 17:45:19 +02:00
Mathieu Magnin
20fd7e52e6 [Fix #1729] Clean mail templates with <code> tags 2018-03-29 17:23:30 +02:00
Frederic Merizen
dd219d5d40 [#1677] Prevent invites from submitting a dossier 2018-03-29 17:03:58 +02:00
Frederic Merizen
b869efd7d1 [#1677] After editing, send Invites back to invitation page 2018-03-29 17:03:58 +02:00
Frederic Merizen
839a5d43f6 [#1677] Allow invites to edit dossiers 2018-03-29 17:02:10 +02:00
Frederic Merizen
884c430619 [#1677] No need to use emails when we have users 2018-03-29 16:59:16 +02:00
gregoirenovel
5f1394cd7f ExercicesAdapter#to_array -> ExercicesAdapter#to_params 2018-03-29 11:44:59 +02:00
Frederic Merizen
d825c3d586 [Fix #1689] Only allow plain text for procedure descriptions 2018-03-29 10:52:37 +02:00
Paul Chavard
322f93afbe Add administrateur#feature_enabled? method 2018-03-28 17:19:07 +02:00
gregoirenovel
caf2e50954 Make #to_params return blank hashes if we have no data 2018-03-28 10:55:15 +02:00
gregoirenovel
182afee970 to_params -> to_array 2018-03-28 10:52:54 +02:00
simon lehericey
66a113c7db Dossier: remove uncessary query on order_champ_v2 2018-03-27 16:48:38 +02:00
simon lehericey
32913aae55 DubiousProcedureSpec: fix test (build 8212) 2018-03-27 16:06:52 +02:00
simon lehericey
289ddb5419 [fix #1670] Manager send the refused admin email 2018-03-27 16:02:09 +02:00
Frederic Merizen
c413dfa127 [#1677] No longer create InviteGestionnaires 2018-03-22 16:40:57 +01:00
gregoirenovel
4df2eb168d Remove mandataires_sociaux 2018-03-20 16:09:00 +01:00
gregoirenovel
d0a59058e8 Remove the mandataire_social guess
Rationale:
- is true for only 0.06% of Dossiers
- is not displayed anymore anyways
- will be a rare case for now
  * FC adoption is not insane
  * FC used more for personal than professional
    matters
  * not always the mandataires sociaux that fill
    dossiers for their companies, so not that
    relevant
- we can add it back later
2018-03-20 16:09:00 +01:00
Frederic Merizen
13d251d970 describe '#method' rather than describe '.method' for instance methods 2018-03-20 16:00:30 +01:00
gregoirenovel
5658aae96b SIADE -> ApiEntreprise 2018-03-19 11:39:46 +01:00
gregoirenovel
9a7e13f72f Mutualise a JSON#parse call 2018-03-19 11:39:46 +01:00
Mathieu Magnin
621f8143bd [Fix #1654] Generate procedure export filename with libelle 2018-03-19 11:16:05 +01:00
Mathieu Magnin
2441d21f4b Fix siade tests 2018-03-15 18:08:14 +01:00
Paul Chavard
e4f07dbae6 Document pagination params in api and allow to set per_page limit 2018-03-15 17:50:41 +01:00
Paul Chavard
87d1948023 Add token authentication to API 2018-03-15 17:43:45 +01:00
Mathieu Magnin
ab368d44a1 [Fix #1500] Add mandatory params to call api entreprise v2 2018-03-15 14:51:42 +01:00
Frederic Merizen
610058c534 [Fix #1619] Do not consider invitations to deleted dossiers 2018-03-15 11:32:21 +01:00
Mathieu Magnin
69f8353b2f [Fix #1479] Sanitize Avis email before validation 2018-03-14 17:41:47 +01:00
Mathieu Magnin
38e1609d73 [Fix #1479] Validate Avis email format 2018-03-14 17:41:46 +01:00
Mathieu Magnin
e00e8ba01d [Fix #1479] Validate email format with Rails format validation 2018-03-14 17:41:45 +01:00
Mathieu Magnin
b7de632d6c [Fix #1479] Create a sanitize email concern 2018-03-14 17:41:45 +01:00
Mathieu Magnin
9f6d6e61fb [Fix #1577] logo link in navbar on gestionnaire UI should not link to admin UI 2018-03-08 14:10:26 +01:00
Frederic Merizen
0e0d17e5eb Merge branch 'image_optim' into dev
Closes #1558
2018-03-07 11:06:08 +01:00
gregoirenovel
0a9f442260 Enable some Rails cops 2018-03-06 17:18:44 +01:00
gregoirenovel
d3f0fc703a Enable some cops to remove ambiguity 2018-03-06 17:18:44 +01:00
gregoirenovel
b5b73c8639 Enable all the Security cops 2018-03-06 17:18:44 +01:00
Frederic Merizen
3894fc48f6 [Fix #1543] Strip html tags from textarea champs 2018-03-06 16:51:12 +01:00
gregoirenovel
e26f4148ff Bump development gems
- brakeman
- rubocop
- scss_lint
2018-03-06 16:17:22 +01:00
Guillaume RISCHARD
06c34c4920 Optimisation des images 2018-03-06 16:14:59 +01:00
gregoirenovel
fe7f8da636 Revert "Bump development gems"
This reverts commit d6ad3fc3fd.
2018-03-06 15:11:26 +01:00
gregoirenovel
d6ad3fc3fd Bump development gems
- brakeman
- rubocop
- scss_lint
2018-03-06 10:36:35 +01:00
Mathieu Magnin
875766279d [Fix #1510] Send email after dossier is received 2018-03-05 19:08:17 +01:00
simon lehericey
28c4dde96d _explication: display champ.description instead of champ.value 2018-03-01 11:25:57 +01:00
gregoirenovel
0af270faa0 tps.apientreprise.fr -> demarches-simplifiees.fr 2018-03-01 10:33:53 +01:00
gregoirenovel
1b8b6a3274 TPS -> demarches-simplifiees.fr 2018-02-28 18:14:06 +01:00
simon lehericey
eb937649a1 new user: thanks page 2018-02-28 17:34:27 +01:00
Frederic Merizen
43dfbf1986 Separate ActiveStorage facade from Cellar machinery 2018-02-28 14:39:27 +01:00
Frederic Merizen
6907650bcb Use bulk delete in CellarService when possible 2018-02-28 14:39:27 +01:00
simon lehericey
abc9068412 DossierController: allow upload of empty 2018-02-27 17:39:17 +01:00
Paul Chavard
da14cceadc Refactor siade adapters 2018-02-27 16:22:53 +01:00
Paul Chavard
0b2ad653fa Fix camelcase attribute 2018-02-27 16:22:53 +01:00
simon lehericey
a0667f5ad9 [fix #1411] user: link new screen to the rest of the application 2018-02-27 15:24:51 +01:00
simon lehericey
d702a0c083 [fix #1411] user: new form ui 2018-02-27 15:24:50 +01:00
Mathieu Magnin
2b6edc0fa4 Remove unused procedure_filter 2018-02-26 17:25:28 +01:00
Mathieu Magnin
3db941ea06 [Fix #1475] Ensure date is parsable before doing it (to avoid errors) 2018-02-26 13:20:23 +01:00
gregoirenovel
3d10dbf0e4 Refactor assignement-related methods 2018-02-23 17:12:58 +01:00
gregoirenovel
1b1460c191 Move a service to the gestionnaire model 2018-02-23 17:12:24 +01:00
gregoirenovel
8902a81f23 Remove a useless assignment 2018-02-23 17:12:24 +01:00
simon lehericey
c94d57db79 AutoReceivedDossiersForProcedure: fix job by changing symbole to string 2018-02-23 15:18:32 +01:00
simon lehericey
26c9f28407 Gestionnaire Namespace: fix last_week_overview 2018-02-23 13:45:21 +01:00
simon lehericey
4189a2790d MailPreview: fix last_week_overview 2018-02-23 13:45:21 +01:00
simon lehericey
377e4d689a Gestionnaire Namespace: fix send_dossier 2018-02-23 13:45:21 +01:00
simon lehericey
c4cd113fbd MailPreview: add send_dossier 2018-02-23 13:45:21 +01:00
simon lehericey
630f22e205 Gestionnaire: various missing procedure urls 2018-02-22 17:02:20 +01:00
simon lehericey
864b98c6dc Gestionnaire: various missing avis urls 2018-02-22 17:02:20 +01:00
simon lehericey
9db5e82b41 Gestionnaire: move avis_path to gestionnaire_avis_path 2018-02-22 17:02:20 +01:00
simon lehericey
0308345008 Gestionnaire: move procedures_path to gestionnaire_procedures_path 2018-02-22 17:02:20 +01:00
simon lehericey
4a70087f7a Gestionnaire: move procedure_path gestionnaire_procedure_path 2018-02-22 17:02:20 +01:00
simon lehericey
0dc101e375 Gestionnaire: move dossier_path gestionnaire_dossier_path 2018-02-22 17:02:20 +01:00
simon lehericey
c1bbe72dbd Gestionnaire: move sign_up_avis_path to sign_up_gestionnaire_avis_path 2018-02-22 17:02:20 +01:00
simon lehericey
3b3849e4f3 Gestionnaire: move messagerie_avis_path to messagerie_gestionnaire_avis_path 2018-02-22 17:02:20 +01:00
simon lehericey
c58b32a26d Gestionnaire: move instruction_avis_path to instruction_gestionnaire_avis_path 2018-02-22 17:02:20 +01:00
simon lehericey
63163e5022 Gestionnaire: move avis_dossier_path to avis_gestionnaire_dossier_path 2018-02-22 17:02:20 +01:00
simon lehericey
87a4029f1a Gestionnaire: move annotations_privees_dossier_path to annotations_privees_gestionnaire_dossier_path 2018-02-22 17:02:20 +01:00
simon lehericey
be191a680e Gestionnaire: move messagerie_dossier_path to messagerie_gestionnaire_dossier_path 2018-02-22 17:02:20 +01:00
Mathieu Magnin
0c6aa42f55 [Fix #1454] Send weekly overview emails async, overview param is not correctly serialized by activejob so it is computed again when email is send 2018-02-21 18:22:56 +01:00
Paul Chavard
49bb4f0b54 Set processed_at on auto received dossiers
Closes #1089
2018-02-21 16:38:25 +01:00
Mathieu Magnin
3e5621f633 [Fix #1409] Plug identite new design to current workflow 2018-02-20 11:01:47 +01:00
Mathieu Magnin
9627ba43c0 [Fix #1409] Identite can be updated 2018-02-20 11:01:47 +01:00
Paul Chavard
35a4367114 Fix multi submit bug with direct upload 2018-02-16 12:53:00 +01:00
gregoirenovel
93d8470321 Put the piece justificative champ behind a feature flag 2018-02-15 12:04:03 +01:00
Frederic Merizen
07134684d4 Prefix_delete for cellar 2018-02-15 10:56:47 +01:00
Frederic Merizen
76c72bf4e0 Ability to delete files from Cellar 2018-02-15 10:54:45 +01:00
Frederic Merizen
741100d4f5 Active storage and Clever Cloud Cellar integration 2018-02-15 10:43:56 +01:00
Paul Chavard
db42c0c0cf Fix public and private champs scopes 2018-02-14 18:13:23 +01:00
Paul Chavard
0c1d529b61 Unify :type_de_champ public/private factories 2018-02-14 11:49:06 +01:00
Paul Chavard
31d638ae2a Remove TypeDeChampPublic/TypeDeChampPrivate STI 2018-02-14 11:49:06 +01:00
Paul Chavard
b3e07d8504 Use in? in type_champ tests 2018-02-13 17:59:27 +01:00
Paul Chavard
0c10f2bd47 Always use factories in spec 2018-02-13 15:05:10 +01:00
Paul Chavard
793768684e Checkbox should take a “on” not “true” value 2018-02-13 14:56:55 +01:00
Paul Chavard
52749713ab Remove ChampPublic/ChampPrivate STI 2018-02-13 12:07:13 +01:00
Frederic Merizen
283e6e927b [Fix #1397] Hide 'envoyer' button when no potential recipient 2018-02-08 20:38:20 +01:00
Mathieu Magnin
50f35ee905 [Fix #1296] Birthday field is optional in procedure 2018-02-07 15:57:48 +01:00
Mathieu Magnin
d49659fc73 [Fix #478] /recherche can deal with very big int ☺️ 2018-02-07 11:56:22 +01:00
gregoirenovel
142241dd16 Remove notifications 2018-02-06 14:07:20 +01:00
Paul Chavard
8a55ac79f1 Remove global BROWSER and use browser helper 2018-02-05 10:35:51 +01:00
Frederic Merizen
d919d62cf7 [Fix #1012] Send dossier to other accompagnateur 2018-02-01 16:58:01 +01:00
gregoirenovel
a38d96b2f8 Disable a failing test 2018-01-30 16:56:51 +01:00
gregoirenovel
c2e0959d6c Fix a test 2018-01-30 16:56:49 +01:00
gregoirenovel
2da724d681 Remove an unused Gestionnaire method and its tests
The tests would fail with rails 5.1
2018-01-30 16:56:49 +01:00
gregoirenovel
7ccae2c4f1 render nothing: true has been removed from Rails
Use head instead
2018-01-30 16:56:49 +01:00
gregoirenovel
3fa9774123 params is now an object and no longer a hash 2018-01-30 16:56:46 +01:00
gregoirenovel
5b706cc7d4 Add missing params wrapping to some tests 2018-01-30 16:40:04 +01:00
gregoirenovel
25aef60354 Use string interpolation 2018-01-30 15:50:52 +01:00
gregoirenovel
c9a79b4f08 Use map when possible 2018-01-30 15:50:52 +01:00
gregoirenovel
b2fe1b856c Use #sum instead of #inject when possible 2018-01-30 15:45:32 +01:00
Frederic Merizen
0ce26055d8 [#1374] Revert "Merge pull request #1373 from betagouv/fix_pagination"
This reverts commit 5a56fe0182, reversing
changes made to 31aabcd6b6.
2018-01-30 15:04:21 +01:00
Mathieu Magnin
50abb36c81 [Fix #1309] Format datetime before save 2018-01-30 13:49:16 +01:00
Mathieu Magnin
dcb38d79a3 [Fix #1309] Datetime value should be print with yyyy-mm-dd format 2018-01-30 13:49:16 +01:00
Paul Chavard
fdd6cedeb8 Remove data_provide and data_date_format attributes 2018-01-30 13:49:16 +01:00
simon lehericey
691b12688d Revert "[#1360] Upgrade SmartListing to fork of 1.2.1"
This reverts commit 506a505477.
2018-01-29 17:43:30 +01:00
Mathieu Magnin
839c0e6aa9 Invite admin mail is previewable 2018-01-29 11:08:19 +01:00
Frederic Merizen
506a505477 [#1360] Upgrade SmartListing to fork of 1.2.1 2018-01-25 17:47:10 +01:00
gregoirenovel
a2f4e8b283 factory_girl is now factory_bot 2018-01-23 17:15:42 +01:00
gregoirenovel
5eb4f12b48 Remove a now deprecated Capybara option from tests 2018-01-23 17:14:13 +01:00
Mathieu Magnin
469aca999b Revert "Remove data_provide and data_date_format attributes"
This reverts commit 273b3f2faf.
2018-01-19 13:20:53 +01:00
Mathieu Magnin
e9ec9e410f [Fix #1304] If procedure has no path do not crash when hiding it 2018-01-18 18:52:54 +01:00
Frederic Merizen
9b4ce1517c Use lambda instead of send for etablissement tag 2018-01-18 18:35:07 +01:00
Frederic Merizen
8f41ab89cf [#1203] Do not include champs privés in accusé de réception 2018-01-18 18:26:14 +01:00
Frederic Merizen
eebab14954 [Fix #1203] No début d’instruction tag in accusé de réception mails
Doesn’t make sense functionnally
2018-01-18 18:26:14 +01:00
Frederic Merizen
9f7ffddb31 [#1203] Allow filtering tags based on an arbitray status 2018-01-18 18:26:14 +01:00
Frederic Merizen
1282fc2113 [#1203] Use factory girl to instanciate model in spec 2018-01-18 18:26:14 +01:00
gregoirenovel
5723c4c894 Remove any reference to the SGMAP 2018-01-18 17:39:56 +01:00
Mathieu Magnin
d945001e0a [Fix #1302] sanitize_url can deal with nil values 2018-01-18 17:35:19 +01:00
Paul Chavard
e42626c588 Add user info to LogStasher 2018-01-18 17:14:42 +01:00
Paul Chavard
273b3f2faf Remove data_provide and data_date_format attributes 2018-01-18 15:13:48 +01:00
gregoirenovel
2df14691e7 Enable the Layout/TrailingBlankLines cop 2018-01-18 10:53:35 +01:00
gregoirenovel
d30ea70c08 Enable the Layout/SpaceInsideParens cop 2018-01-18 10:53:35 +01:00
gregoirenovel
b138dcd876 Enable the Layout/SpaceInsideHashLiteralBraces cop 2018-01-18 10:53:35 +01:00
gregoirenovel
897a30da0c Enable the Layout/SpaceInsideBlockBraces cop 2018-01-18 10:53:34 +01:00
gregoirenovel
05b1fd96fd Enable the Layout/SpaceBeforeSemicolon cop 2018-01-18 10:53:34 +01:00
gregoirenovel
f605cd35ac Enable the Layout/SpaceAfterColon cop 2018-01-18 10:53:34 +01:00
Mathieu Magnin
d5c036362b Remove old controller and templates 2018-01-17 18:04:23 +01:00
Mathieu Magnin
67f89d5f86 Move administrateur creation in Administrate 2018-01-17 18:04:21 +01:00
Simon Lehericey
d70b6f4af0 FC ParticulierController: cleaner update attribute 2018-01-17 16:37:26 +01:00
Simon Lehericey
2651c5e029 FC ParticulierControllerSpec: final clean 2018-01-17 16:37:26 +01:00
Simon Lehericey
69c121a879 FC ParticulierControllerSpec: simplify ... well you know 2018-01-17 16:37:26 +01:00
Simon Lehericey
570f779bb2 FC ParticulierControllerSpec: without an associate user, better test 2018-01-17 16:37:26 +01:00
Simon Lehericey
b2f59e2b14 FC ParticulierControllerSpec: simplify without an associate user 2018-01-17 16:37:26 +01:00
Simon Lehericey
e1ac33f420 FC ParticulierControllerSpec: simplifier with an associate user case 2018-01-17 16:37:26 +01:00
Simon Lehericey
49f5d570ed FC ParticulierControllerSpec: mutualize subject 2018-01-17 16:37:26 +01:00
Simon Lehericey
ab02f796b3 FC ParticulierControllerSpec: one liner expectation 2018-01-17 16:37:26 +01:00
Simon Lehericey
4008d8e44d FC ParticulierControllerSpec: remove unless context 2018-01-17 16:37:26 +01:00
Simon Lehericey
28bf45e536 FC ParticulierControllerSpec: use controller to store_location 2018-01-17 16:37:26 +01:00
Simon Lehericey
ab116895b7 FC ParticulierControllerSpec: remove one context 2018-01-17 16:37:26 +01:00
simon lehericey
4f86b6305b FC ParticulierControllerSpec: callback handle empty string 2018-01-17 16:37:26 +01:00
simon lehericey
9b6b6bde97 FC ParticulierControllerSpec: simplier auth spec 2018-01-17 16:37:26 +01:00
simon lehericey
02dd1e209c FC ParticulierController: implement auto reconciliation based on user email 2018-01-17 16:37:26 +01:00
simon lehericey
7cbd6ed067 FC ParticulierController: create is private
yep, I know this is strange
2018-01-17 16:37:26 +01:00
Paul Chavard
a6cdf714a6 Use capybara-selenium with headless chrome 2018-01-16 14:02:10 +01:00
gregoirenovel
80ed589a17 Use string interpolation 2018-01-16 11:08:57 +01:00
Paul Chavard
bbf55ab85e Create administrateurs with invitation link and no password 2018-01-16 10:49:07 +01:00
Paul Chavard
0cf40f4f18 Add invitation related methods to administrateur model 2018-01-16 10:49:07 +01:00
gregoirenovel
73dd58b6cd Enable the Layout/MultilineMethodCallIndentation cop 2018-01-15 22:33:13 +01:00
gregoirenovel
b77837bfd1 Enable the Layout/MultilineMethodCallBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
5077e654f2 Enable the Layout/MultilineHashBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
9d75526460 Enable the Layout/MultilineAssignmentLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
14c1747645 Enable the Layout/MultilineArrayBraceLayout cop 2018-01-15 22:33:13 +01:00