Pierre de La Morinerie
4cb747fdb6
specs: always require rails_helper
...
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.
The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.
This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.
Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).
Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.
To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.
Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Pierre de La Morinerie
724ff50363
factories: rename dossier for_individual to with_individual
...
This clarifies the distinction between
```
create :procedure, :for_individual
```
and
```
create :dossier, :with_individual
```
2020-01-21 17:24:56 +01:00
Chaïb Martinez
dd6c6bfe7a
mailers: add a NO_REPLY address to transactional emails
2019-09-10 13:37:28 +02:00
Pierre de La Morinerie
8313752663
mailers: add CTA to templated emails
2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
f32357f527
specs: avoid weird hacks to test NotificationMailer private method
...
- testing private methods is a code smell
- this setup is especially brittle
- we test the equivalent public method right below
2019-07-22 16:22:20 +02:00
Nicolas Bouilleaud
bd47bf2691
Disable Messagerie in archived Dossiers and procedures
...
* Use the existing Dossier#messagerie_available? method
* Raise when attempting to build a Commentaire if not messagerie_available?
* Disable the Messagerie form if not messagerie_available?
* Add tests :)
* Tweak the Horaires formatting while we’re here.
2019-07-01 09:39:39 +02:00
Mathieu Magnin
1a97cd42de
Fix missing helper in notification mailer
2019-04-11 12:25:55 +02:00
maatinito
e37372d261
Fix a typo
2018-12-20 16:21:27 +01:00
maatinito
a1a11adb83
[ #325 ] Make the notification layout inherit from the general layout
2018-12-20 16:21:27 +01:00
Pierre de La Morinerie
ea8bc0c961
mailers: improve notification layout
2018-11-27 15:51:26 +01:00
Pierre de La Morinerie
e5303fd986
mailers: streamline the NotificationMailer
...
Notifications are now only for demarche-templated emails.
2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
40cf7ebdcb
mailers: update links to messagerie
2018-09-27 17:22:59 +02:00
lucien mollard
b2f2e75f43
mailer: add layout for notifications emails
2018-09-05 15:31:08 +02:00
Pierre de La Morinerie
2a5a8cf621
mailer: fix typo in spec
2018-09-05 15:25:46 +02:00
Pierre de La Morinerie
d7dd027cb8
mailer: improve naming in specs
2018-09-05 15:25:46 +02:00
gregoirenovel
b82ed65568
[ Fix #885 ] Convert .text.erb to .html.haml
2018-06-01 17:14:48 +02:00
gregoirenovel
b364b8bfb3
Improve many subjects
2018-06-01 11:35:40 +02:00
gregoirenovel
a57e2388f6
Unify NotificationMailer methods’ signatures
2018-05-31 12:10:06 +02:00
Frederic Merizen
cce00e19c6
[ #1972 ] Avoid passing unsaved templates to ActionMailer
...
So that all mail arguments can be serialized
2018-05-28 12:02:13 +02:00
Frederic Merizen
5ef129d960
[ #1563 ] Remove attestation mail attachment
2018-05-09 10:42:40 +02:00
gregoirenovel
1b8b6a3274
TPS -> demarches-simplifiees.fr
2018-02-28 18:14:06 +01:00
gregoirenovel
142241dd16
Remove notifications
2018-02-06 14:07:20 +01:00
Frederic Merizen
56749769d6
[ Fix #1186 ] Rename object to subject for mail templates
2018-01-09 16:00:31 +01:00
Mathieu Magnin
0f945e2fea
Simplify mailer parameters to be serializable (even if mail_template.id is nil)
2017-10-13 21:27:17 +02:00
Simon Lehericey
e60ce35ae8
[ Fix #196 ] Attestation: join the attestation to the closed mail
...
Add a upper limit to the attachment size as it could be a problem with Mailjet and receiver
(https://www.mailjet.com/support/what-is-the-size-limit-for-attachments-files-sent-via-mailjet,289.htm )
If the attestation cannot be sent, it is logged in sentry
2017-06-16 12:11:10 +02:00
gregoirenovel
70f637f088
[ Fix #198 ] Add a Commentaire when we send a Notification email to a user
2017-05-12 14:03:48 +02:00
gregoirenovel
ddf02ccd6d
Use a non-breaking space after the “numéro” contraction
2017-04-19 11:19:53 +02:00
gregoirenovel
aa41349f0c
Lowercase the “n” of “numéro” contraction where needed
2017-04-19 11:19:53 +02:00
gregoirenovel
ba4ee68019
Use masculine ordinal indicator instead of the degree sign
...
It’s the right way to contract “numéro”
We should use the superscript lowercase o but
it’s hard to do in places where only raw text is
available
2017-04-19 11:19:53 +02:00
Simon Lehericey
6c560e65eb
Notification Mailer: use send_notification for all the mails
2017-03-07 10:27:13 +01:00
Simon Lehericey
7b336922cc
Cleaning
2017-03-07 10:25:34 +01:00
Simon Lehericey
65d399b4b0
NotificationMailer: add send notification
2017-03-07 10:25:34 +01:00
Mathieu Magnin
4cc6aedfb9
Fix tests after workflow simplication
2017-02-27 11:56:26 +01:00
Mathieu Magnin
6444aa5be6
Use has_one instead of scope
2017-02-06 16:52:57 +01:00
Mathieu Magnin
b40193e7b5
New customizable mail : mail_validated, new balise --lien_dossier--
2017-01-26 12:12:52 +01:00
Xavier J
21f58c0725
Fix notification Mailer tests
2017-01-03 11:36:08 +01:00
Xavier J
14df85d16d
Change require for notification mailer spec
2016-12-15 17:59:01 +01:00
Xavier J
6f40424979
Change wording "Valider le dossier" to "Déclarer complet"
2016-10-19 11:23:34 +02:00
Xavier J
f03733f3ff
Mail for receive dossier is now send.
2016-09-01 10:27:22 +02:00
Xavier J
a69433e8de
User can be begin without SIRET
2016-08-30 11:18:43 +02:00
Xavier J
d7dbd28507
fix test cerfa flag
2016-02-04 14:08:35 +01:00
Xavier J
563e739958
Minor fix bug
2015-12-17 12:53:43 +01:00
Xavier J
ed8b4ff083
Add mailer submitted dossier.
2015-12-17 10:06:40 +01:00
Xavier J
a24ff681fc
- Send email when gestionnaire write a new commentaire
...
- Change url on mail => redirect on dossier recapitulative page
2015-12-15 15:33:21 +01:00
Xavier J
372011e4d6
NotificationMailer : dossier_validated
2015-12-15 11:41:50 +01:00
Xavier J
25937b2635
NotificationMailer : new answer
2015-12-15 11:02:07 +01:00
