Commit graph

88 commits

Author SHA1 Message Date
mfo
3a895fbd4a
tech(review): add a guard clause to prevent missing pdf, enhance specs 2024-04-02 10:04:22 +02:00
Colin Darie
455086c1d7
fix(champs): don't fail on updated_at comparison when champ is not persisted 2024-03-19 11:46:08 +01:00
Paul Chavard
1b2315cd45 fix(champ): fix multiple champ copies bug 2024-03-18 12:13:22 +01:00
Paul Chavard
fd2e253ebc refactor(champs): use ViewableChamp::SectionComponent 2024-03-17 23:51:45 +01:00
Paul Chavard
deb19177f7 refactor(test): update tests 2024-03-04 10:59:11 +01:00
Paul Chavard
d76123831c fix(drop_down_list): fix other option with combobox and some cleanup 2023-10-27 18:11:26 +02:00
Christophe Robillard
08363546d5 update spec for placeholder 2023-09-25 18:17:04 +02:00
Colin Darie
e47761860a fix(demande): don't crash when siret siege social is missing 2023-07-10 15:41:50 +02:00
Colin Darie
2476fa7eb8
test(champs): remove obsolete test about updated champ of routed procedure 2023-07-04 10:47:41 +02:00
Colin Darie
e899fe5f5f
style(demande): layout with 2 columns 2023-07-04 10:47:41 +02:00
Eric Leroy-Terquem
7fe4ec67c3 update previous routing system tests 2023-07-03 14:58:45 +02:00
Martin
dfb525892a amelioration(instructeurs/dossiers/show): ETQ instructeur, je vois les champs saisi, les champs qui ont ete vidé apres le depot du dossier, je ne vois pas les champs facultatif jamais saisis 2023-06-29 07:59:32 +02:00
Colin Darie
0cec8947d9 chore(demande): no facultatif word on instructeur profile 2023-06-28 09:55:57 +02:00
Martin
43c6f03d10 amelioration(users/dossiers#demande): passage a la nouvelle ui/ux
wip
2023-06-22 16:54:17 +02:00
Martin
50da50a7ac amelioration(bilan_bdf.resultat_exercice): implement la logique d'affichage du resultat d'un exercice sur l'API v3 2023-06-01 15:04:09 +02:00
Christophe Robillard
42acc71cbe display v2 and v3 bilans bdf 2023-06-01 14:03:31 +02:00
Paul Chavard
08a2a2c9aa
feat(dossier): fork dossier when editing en construction 2023-05-09 17:16:47 +02:00
Nicolas Cavigneaux
e483bfbc76
fix: remove hardcoded .html.haml from render calls since it no longer works 2023-05-03 10:10:38 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
Colin Darie
37afd142cb
fix(entreprise): don't leak entreprise name if it's not diffusable 2023-03-15 12:43:56 +01:00
Sébastien Carceles
5c7b2ba1f3
feat(dossier): prefill drop down list champ (#8361)
* feat(dossier): prefill drop down list champ

* decorate the types de champ to avoid if / else

In order to avoid doing if this a drop down ? / else at several places,
we decorate the types de champ and let the decorator give the possible
and example values.

* show all possible values when there are too many

* allow to prefill 'other' option

* review: remove duplicate

* review: refactor for readability

* validate that value is in options

* review: exclude disabled options
2023-01-18 09:47:22 +01:00
Sébastien Carceles
fa6fc077b4
normalize boolean values (#8320)
* extract parent for yes no and checkbox champs

* checkbox stores true / false instead of on / off

* normalize blank value to nil

* normalize invalid value to false

* after party task: normalize checkbox values

* after party task: normalize yes_no values
2023-01-05 11:18:27 +00:00
Colin Darie
b609c3dae4 refactor(attachment): bring batch user_can_destroy, update tests 2022-12-05 10:47:10 +01:00
Paul Chavard
e6288c39f2 refactor(dossier): champs -> champs_public 2022-11-10 22:44:39 +00:00
Paul Chavard
5e87539d6d fix(groupe_instructeur): add explicit order to groupe_instructeurs 2022-11-09 10:56:40 +00:00
Eric Leroy-Terquem
5578115acf update routee? method 2022-11-04 12:03:43 +01:00
Damien Le Thiec
0131a41266
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-05 12:38:24 +02:00
Colin Darie
6a943ad13f feat(champ_pj): warn administrators about ephemeral template links
Closes #7681
2022-09-28 17:01:25 +02:00
Damien Le Thiec
bd0df2b60b Clean rna champ_row 2022-09-22 17:14:05 +02:00
Colin Darie
fcb478eb53 refactor(fc_info): use Dsfr::Notice for france connect informations 2022-09-21 15:47:35 +02:00
Colin Darie
a5e1d8865b style(france_connect_account): convert notice about FC user to DSFR 2022-09-21 15:47:35 +02:00
Paul Chavard
31d80d80bd fix(dossier): prevent users from removing mandatory fiels after submission 2022-07-28 11:19:47 +02:00
Colin Darie
dea1ce40a9 feat(dossier): allows user to edit identity from a brouillon dossier
Closes #7386
2022-07-18 09:57:19 +02:00
Colin Darie
8c08d0295b Revert "feat(champ): customizable placeholders for text & textarea champs"
This reverts commit 9e26ee932e.

Finalement les champs génériques ne doivent pas avoir de placeholder
personnalisable, ce sera uniquement via la description.
2022-07-12 11:37:58 +02:00
Colin Darie
93d18e2f53
fix: better email placeholder 2022-07-11 17:16:20 +02:00
Colin Darie
9e26ee932e
feat(champ): customizable placeholders for text & textarea champs
Closes #7429
2022-07-11 17:16:20 +02:00
Colin Darie
9768f4e1c9
style(champ): add placeholders for email, iban, phone, siret champs
Closes #7428
2022-07-11 17:16:19 +02:00
Paul Chavard
d2ab8b5593 feat(message): replace message partial with MessageComponent 2022-04-26 14:54:58 +02:00
Paul Chavard
009c44cc20 refactor(avis): remove unused controller action 2022-04-26 14:54:58 +02:00
Paul Chavard
64c599e208 refactor(stimulus): initiate react components via stimulus 2022-04-20 14:08:47 +02:00
Paul Chavard
c671f25d34 fix(dossier): do not show unwanted closed procedure banners 2022-04-14 12:22:37 +02:00
Kara Diaby
b2bcc34cfd tests 2022-03-31 15:48:18 +02:00
Kara Diaby
71614d4ba3 tests 2022-03-29 12:30:52 +02:00
Martin
8e9b15aef4 clean(expiration_banner): dedicated to user not shared 2021-12-06 07:05:17 +01:00
Martin
1bb868714c fix(spec/lint/review): lint and fix spec of previous commits, also fix based on tchak feedback 2021-12-06 07:05:17 +01:00
Martin
725521c3a1 fix(expiration_banner): only show expirations info when flip is enabled
fix(lint): lint haml

fix(spec): enable flipper and allow procedure to receive flipper check when checking banner presence

fix(doc): add missing documentation on readme regarding system testing with a visual feedback

fix(typo): add missing accent

clean(PR): feedback from Tchak, better to wrap feature check for expirability by procedure within dossier.expirable? helper
2021-11-30 16:05:32 +01:00
mfo
e7d9d047fe
Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible 2021-11-24 14:07:32 +01:00
Pierre de La Morinerie
970c3e4b2b specs: avoid executing business logic in Procedure factory
Calling business logic in a factory is a code-smell, because it
usually requires the object to be saved into database, and may have
unintended consequences when the business logic is changed.

Also, this allows to just build a published procedure, without saving it
to the database.
2021-11-23 08:07:07 +01:00
Martin
b6adf5fc72 feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states
fix(spec): broken due to last refactoring

spec(dossier.extend_conservation): add system spec

lint(ruby): still not yet ready for auto lint in IDE...
2021-11-23 05:50:25 +01:00
Martin
0aecc301c9 refactor(Commentarie.soft_delete): use discard 2021-11-16 14:28:38 +01:00