Commit graph

13180 commits

Author SHA1 Message Date
Pierre de La Morinerie
49345e95e0 gems: update zipline
This (unreleased) version contains a fix for a pre-Ruby 3.0 kwargs use.

It fixes a warning in specs using zip files:

> warning: Using the last argument as keyword parameters is deprecated
2021-09-09 09:58:42 -05:00
Pierre de La Morinerie
407f46b7de gems: remove smart_listing
It was only used in the old design, which we recently removed
completely.
2021-09-09 09:58:41 -05:00
Pierre de La Morinerie
5cbf939911 spec: fix syntax of get requests in archives_controller_spec
Those were generating Ruby warnings:

> warning: Using the last argument as keyword parameters is deprecated
2021-09-09 09:58:41 -05:00
Pierre de La Morinerie
92ca41ee4b
Merge pull request #6417 from betagouv/fix-password-strength-meter
Administrateur : rétablissement de l'indicateur de complexité lors d'un changement de mot de passe (#6417)
2021-09-09 09:58:29 -05:00
Pierre de La Morinerie
4a71b1d202 app: remove former password complexity views
The old component is now unused and ca be removed.
2021-09-09 09:40:40 -05:00
Pierre de La Morinerie
e5f449b595 devise: unify password reset views
By default, Devise will look for views:

1. First in `views/resource/passwords/…`,
2. Then in `views/devise/passwords/…` if not found.

By moving the views to `views/devise`, we avoid having a partial in
`views/shared` that we need to include manually, and instead let Devise
do the job automatically.
2021-09-09 09:40:40 -05:00
Pierre de La Morinerie
80f9d4adc0 devise: use password_strength component in SuperAdmin::PasswordsController 2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
62e4f7ee32 devise: use password_complexity in User::PasswordsController
This fixes the password strength meter no longer being displayed when
an admin changes their password.
2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
ed8b19d2eb app: use password_complexity in Administrateurs::ActivateController 2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
428ca8755f app: add a password_complexity component
This component will replace the previous `password_field` component.
2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
586f8ec543 models: improve password complexity specs 2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
e97b7164dd models: extract password complexity to a concern 2021-09-09 09:40:39 -05:00
Pierre de La Morinerie
02bdfef893 devise: cleanup Users::PasswordController 2021-09-09 08:03:34 -05:00
Paul Chavard
c6b0eddd0b
Merge pull request #6359 from tchak/transfer-dossiers
Allow users to transfer dossiers
2021-09-09 14:43:07 +02:00
Paul Chavard
00c7c7c419 test(dossier): test dossier transfer 2021-09-08 15:49:04 +02:00
Paul Chavard
3235f42a63 feat(dossier): add dossier transfers UI 2021-09-08 15:10:43 +02:00
Paul Chavard
5985755229 feat(dossier): add purge stale dossier transfers job 2021-09-08 14:39:46 +02:00
Paul Chavard
46226b7930 fix(i18n): use size instead of count in dossier mailers 2021-09-08 14:39:46 +02:00
Paul Chavard
d6cbdf2a48 feat(dossier): add dossier transfer models 2021-09-08 14:39:46 +02:00
Paul Chavard
dfafc57bb9 feat(dossier): add dossier_transfers and dossier_transfer_logs 2021-09-08 14:39:45 +02:00
LeSim
188c1e70a8
Merge pull request #6460 from tchak/fix-add-kosovo
fix(i18n): add Kosovo to countries list
2021-09-08 13:42:53 +02:00
Paul Chavard
44eb0ada4f fix(i18n): add Kosovo to countries list
Kosovo is not part of ISO 3166 as of time of writing. https://en.wikipedia.org/wiki/ISO_3166-2:RS#cite_ref-1
2021-09-08 12:11:25 +02:00
Paul Chavard
b67cc4a254
Merge pull request #6457 from betagouv/fix-localized-emails
i18n : correction des traductions manquantes dans l'email "Retrouvez votre brouillon"
2021-09-08 09:36:07 +02:00
Paul Chavard
a7ec43a21e fix(i18n): fix email previews 2021-09-08 09:21:19 +02:00
Paul Chavard
ef12ded3ed i18n: fix localization of notify_revert_to_instruction email 2021-09-08 09:21:19 +02:00
Paul Chavard
c8d8976a7c i18n: fix localization of notify_new_answer email 2021-09-08 09:21:19 +02:00
Pierre de La Morinerie
f8d7b7b1e3 i18n: fix localization of notify_new_draft email 2021-09-08 09:21:19 +02:00
Paul Chavard
61557db145
Merge pull request #6455 from betagouv/fix-sentry-warnings
Correction d'erreurs Javascript mineures
2021-09-08 09:11:26 +02:00
Pierre de La Morinerie
4f33a7b72e js: improve auto-save-controller documentation 2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
ad8dcc7f7d js: don't report autosave failures that are timeouts
This prevents spamming Sentry with "[Autosave] Error: 0" messages.
2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
8dce7d59ed js: redirect to sign-in when a ujs link_to receives a 401
Before, when a 401 was received by a ujs-enabled link (like `link_to …,
method: :delete, data: { remote: true }`, rails-ujs tried to insert the
response text as a Javascript script.

As the script was something like `Please sign-in`, which is not valid
Javascript, the browser would throw an "Unexpected token" error.

The typical use-case is:

1. The user open a form in a tab,
2. The user disconnects in another tab,
3. In the first tab, the user clicks on a remote "Delete" link_to

In that case the browser raised an error in the console (and in Sentry),
but the user would see nothing.

With this commit, all 401 ujs errors are turned into redirects to the
sign-in page.

Fix https://sentry.io/organizations/demarches-simplifiees/issues/2522512693/activity/
2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
1f7c4422b5 js: update Sentry SDK to the latest version 2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
255c00c174 js: ignore a new variant of the same warning 2021-09-07 16:45:52 -05:00
Paul Chavard
d553920fdc
Merge pull request #6451 from betagouv/fix-dossier-pdf-generation
Correction de la génération PDF de dossiers comportant des champs "Pays"
2021-09-07 18:09:02 +02:00
Pierre de La Morinerie
905fca0bd3 models: ensure Champs::Pays#to_s is always a string
Before this, the result of `Champs::Pays#to_s` could be `nil`, which
would break various things (like the PDF rendering of these champs).
2021-09-07 10:47:18 -05:00
LeSim
8adbebb525
Merge pull request #6448 from betagouv/add_test_to_dossier_projection_service_fix
Ajoute un test a dossier_projection_service concernant l'external id
2021-09-07 15:25:04 +02:00
simon lehericey
9fc195f0e5 add test to dossier_projection_service 2021-09-07 15:17:06 +02:00
Paul Chavard
9c5f624e84
Merge pull request #6437 from tchak/feat-graphql-disable-notifications
[GraphQL] Add an option to dossier state change mutations to disable notifications
2021-09-07 14:30:33 +02:00
Paul Chavard
74e277d0a2 feat(graphql): add an option to dossier state change mutations to disable notifications 2021-09-07 14:21:48 +02:00
Paul Chavard
9e30d5fc22 fix(virus scan): prevent virus scans in specs 2021-09-07 14:21:48 +02:00
Paul Chavard
96cbbc0192 fix(virus scan): prevent virus scan on archives and signatures uploads 2021-09-07 14:21:48 +02:00
Paul Chavard
92f463bc03
Merge pull request #6446 from tchak/fix-procedure-external_id
fix(dossier_projection_service): select external_id on champs
2021-09-07 14:18:41 +02:00
Paul Chavard
084e48c8e3 fix(dossier_projection_service): select external_id on champs 2021-09-07 14:07:55 +02:00
Paul Chavard
830828abd2
Merge pull request #6444 from ismo1/6443-delete_flag_make_experts_notifiable
delete features flag option : 'make_experts_notifiable'
2021-09-07 13:59:49 +02:00
Ismael MOUSSA S. (T0194673)
9d012d51e8 delete features flag option : 'make_experts_notifiable' 2021-09-07 10:49:20 +02:00
LeSim
581cd8dd03
Merge pull request #6442 from betagouv/fix_undestructible_secondary_value
Dans une liste déroulante liée, on s'assure que la réinitialisation de la valeur primaire, réinitialise la valeure secondaire
2021-09-07 10:29:01 +02:00
simon lehericey
367f508e2e linked_drop_down_list: empty primary => empty secondary 2021-09-07 10:09:18 +02:00
Paul Chavard
1f23295f91
Merge pull request #6436 from tchak/feat-save-user-locale
feat(i18n): use locale from user preferences when sending notifications
2021-09-07 10:04:57 +02:00
Paul Chavard
6a5a8233b5 feat(i18n): send dossier emails with its user locale and improuve translations 2021-09-07 09:51:23 +02:00
Paul Chavard
cd9f7df502 feat(i18n): send dossier notifications with its user locale 2021-09-07 09:51:23 +02:00