Commit graph

13506 commits

Author SHA1 Message Date
Pierre de La Morinerie
14d3956419
Merge pull request #6610 from betagouv/improve-graphql-specs
Amélioration de la vitesse d'exécution des tests GraphQL (#6610)
2021-11-03 19:44:55 +01:00
Pierre de La Morinerie
5f2233d07d specs: reduce BCrypt complexity during tests
BCrypt is used to compute Instructeur tokens, and takes a surprisingly
ong time during specs.

Reducing the complexity to speed it up.

Speeds up this spec from 0m 57s to 0m 20s.
2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
0a541d678d graphql_controller_spec: create several dossiers only when required
Creating dossiers is faster than creating a procedure, but still slow.
We can create a single dossier in the default case, and only create
several others when the example requires it.

Speeds up this spec from 0m 57s to 0m 49s.
2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
f0e045ad25 graphql_controller_spec: create all types de champs only when required
Creating a procedure with all available types de champ is slow. We can
create a simpler procedure in the default case, and only create all
types de champs when the example requires it.

Speeds up this spec from 1m 55s to 0m 57s.
2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
e02251c0e5 graphql_controller_spec: populate all champs only when required
Creating a dossier with available champs populated is slow. We can
create simpler dossiers in the default case, and only populate all
champs when the example requires it.

Speeds up this spec from 2mn 20s to 1m 55s.
2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
bb1bc9140d graphql_controller_spec: remove unused line 2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
04159056af specs: clarify spec by replacing some context by describe 2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
b06183d7bf specs: rename Dossier's with_all_champs to with_populated_champs
This better reflects what the trait is used for, and disambiguate it
from the similarly named trait in the Procedure factory.
2021-11-03 19:38:01 +01:00
Pierre de La Morinerie
6c60c940d4 gems: update aasm 2021-11-03 19:38:01 +01:00
Paul Chavard
a99bb7f0d2
Merge pull request #6577 from tchak/fix-repetition-revisions
fix(revisions): fix repetitions export with revisions
2021-11-03 18:30:43 +01:00
Paul Chavard
f6b8689a97 fix(revisions): fix repetitions export with revisions 2021-11-03 18:20:48 +01:00
Paul Chavard
39c94992a7
Merge pull request #6590 from tchak/fix-create-deleted-dossier
fix(dossiers): wrap dossier discard in a transaction
2021-11-03 10:19:44 +01:00
Paul Chavard
0e2f09dd6f fix(dossiers): wrap dossier discard in a transaction
By doing this we ensure that deleted_dossier are not created when dossier is not discarded
2021-11-02 18:17:35 +01:00
Paul Chavard
47fb7e5021
Merge pull request #6600 from tchak/fix-destroy-groupe-instructeur
fix(grope_instructeur): can not destroy groupe_instructeur with discarded dossiers
2021-11-02 12:22:09 +01:00
Paul Chavard
7ef73f13e4 fix(grope_instructeur): can not destroy groupe_instructeur with discarded dossiers 2021-11-02 12:15:24 +01:00
Paul Chavard
e404529d37
Merge pull request #6601 from tchak/feat-graphql-logs
feat(graphql): add graphql_operation to rails logs
2021-11-02 12:15:09 +01:00
Paul Chavard
3c2515ce6d feat(graphql): add graphql_operation to rails logs 2021-11-02 12:02:00 +01:00
Kara Diaby
5c09cba0af
Merge pull request #6596 from betagouv/fix/6541
ETQ usager, je veux voir les titres des démarches en plus grand dans mon interface
2021-10-29 14:16:52 +02:00
kara Diaby
87ed764f9b enlarge procedure title in user dossier 2021-10-29 14:05:49 +02:00
Paul Chavard
199f128a49
Merge pull request #6594 from tchak/fix-repetition-add-row-button
Fix repetition add row button
2021-10-28 15:03:07 +02:00
Paul Chavard
da49a6447f refactor(repetition): optimize and add a transaction around repetition add row 2021-10-28 14:54:33 +02:00
Paul Chavard
f9a8fb4ada fix(repetition): prevent rage clicks on add row button 2021-10-28 14:54:32 +02:00
Paul Chavard
a8dcf934f8
Merge pull request #6589 from tchak/fix-remove-instructeur-from-group
fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur
2021-10-28 14:54:14 +02:00
Paul Chavard
c4b93f8d4a fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur 2021-10-28 14:45:52 +02:00
LeSim
88c2bfed8e
Merge pull request #6585 from betagouv/merge_and_delete
Supprime le vieux compte lors d'un merge
2021-10-28 14:44:47 +02:00
simon lehericey
8fe1e2bf71 wrap merge in transaction 2021-10-28 14:39:13 +02:00
simon lehericey
7935e42109 Add merge log 2021-10-28 14:39:13 +02:00
simon lehericey
3328c9a132 merge move invite as well 2021-10-28 14:39:13 +02:00
simon lehericey
f2ccb39912 merge destroys the old role and account 2021-10-28 14:39:13 +02:00
simon lehericey
1401d163ba add dependent_destroy to user instructeur / admin / expert roles 2021-10-28 14:39:13 +02:00
simon lehericey
c725999582 move merge method to user 2021-10-28 14:39:13 +02:00
simon lehericey
3d524e9488 Change factory user password to be compatible with admin pass constraint 2021-10-28 14:39:13 +02:00
Paul Chavard
aaf1498fff
Merge pull request #6598 from tchak/fix-rebase-champ-repetition
fix(rebase): fix repetition champ rebase
2021-10-28 13:39:11 +02:00
Paul Chavard
1393b7b07b fix(rebase): fix repetition champ rebase 2021-10-28 13:27:53 +02:00
LeSim
a66257884d
Merge pull request #6597 from tchak/fix-typos
fix(typo): addresse -> adresse
2021-10-28 13:04:16 +02:00
Paul Chavard
d659595cde fix(typo): addresse -> adresse 2021-10-27 18:59:18 +02:00
Paul Chavard
e7f7e4eb91
Merge pull request #6591 from tchak/fix-disable-pj-on-bulk-messages
fix(bulk_messages): disable pj on bulk messages
2021-10-27 15:47:32 +02:00
Paul Chavard
6599f9a992 fix(bulk_messages): disable pj on bulk messages 2021-10-27 15:41:53 +02:00
Kara Diaby
1fee02e6e4
Merge pull request #6553 from betagouv/feat/6517
ETQ Administrateur je voudrai pouvoir ajouter une option autre aux menus déroulants
2021-10-27 12:52:37 +02:00
Paul Chavard
7ebc439630 refactor(drop_down_list_champ): other option 2021-10-27 12:01:15 +02:00
Paul Chavard
8154daf847 refactor(drop_down_list_champ): other option 2021-10-27 12:00:39 +02:00
kara Diaby
f1f2b76a3d revisions 2021-10-27 12:00:39 +02:00
kara Diaby
71aa13f468 tests 2021-10-27 12:00:39 +02:00
kara Diaby
c2fcd3992d add other option for dropdown select 2021-10-26 16:11:15 +02:00
kara Diaby
0e65916e44 add other option for dropdown radio 2021-10-26 16:11:15 +02:00
kara Diaby
dc35d9521f add other option to liste deroulante champ 2021-10-26 16:11:15 +02:00
Pierre de La Morinerie
8bc925ae50
Merge pull request #6584 from betagouv/system-specs
Migration des tests d'intégration vers des "system specs" (#6584)
2021-10-26 12:43:30 +02:00
Pierre de La Morinerie
9fd38cae5e specs: migrate from features to system specs
System specs have been available since Rails 5.1, and are better
integrated with the Rails framework.

- Rename `spec/features` to `spec/system`
- Rename `feature do` to `describe do`
- Configure Capybara for system specs

Steps mostly taken from https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6
2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
df9fa258ae specs: remove database_cleaner
This is not needed for integration tests since Rails 5.1.

See https://www.nicholasjacques.io/blog/you-probably-dont-need-databasecleaner/
2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
b1eee27dd7 specs: remove outdated workaround for silencing puma logs 2021-10-26 12:24:46 +02:00