DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
9093 commits 4 branches 1166 tags 84 MiB
Commit graph

9093 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Chavard
42fd2a4774
Merge pull request #4721 from betagouv/rubocop-unscoped 
Ajout d'une règle Rubocop pour interdire `unscoped`
 2020-01-28 21:47:39 +01:00
Pierre de La Morinerie
cf101d64d8 lint: add a Rubocop rule to forbid the use of unscoped 
`unscoped` often has an effect broader than intended. For instance:

```
user.dossiers.unscoped.destroy_all
```

will not destroy all the user's dossier, including the hidden ones,
but **all the dossiers of all users**.

Instead, narrower unscoping should be used:

```
user.dossiers.unscope(where: :hidden).destroy_all
```

(Or even better, use the new `Dossier.with_hidden` scope).
 2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
96932faa3f models: add a Dossier#with_hidden scope, and remove unscoped usages 2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
1448d5b098 models: add a Procedure#with_hidden scope, and remove unscoped usages 
This avoids the broad use of `unscoped` to remove the `hidden_at`
clause.
 2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
4efea77280 specs: regroup dossier scope specs together 2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
780cb965a5
Update javascript dependencies and add webpack-bundle-analyzer (#4656) 
Mise à jour des dépendances Javascript ; ajout de webpack-bundle-analyzer
 2020-01-28 17:29:18 +01:00
Paul Chavard
4982039086 Fix fontawesome not tree shaking properly 2020-01-28 16:37:44 +01:00
Paul Chavard
7ebebf2e80 Refactor leaflet code for better loading 2020-01-28 16:37:44 +01:00
Paul Chavard
a223eb05da Update javascript dependencies and add webpack-bundle-analyzer 2020-01-28 16:37:44 +01:00
Keirua
f2179979fe
Merge pull request #4684 from betagouv/feat/admin-edit-email 
Modification d'un email d'un utilisateur dans le manager
 2020-01-28 16:23:01 +01:00
clemkeirua
5f65665b07 added a method for modifying a user email 2020-01-28 16:15:46 +01:00
Pierre de La Morinerie
4eb7d854a9 workflows: fix trailing whitespace 2020-01-28 15:48:02 +01:00
Pierre de La Morinerie
897cdf6632
[GraphQL] use Execution::Interpreter (+ update Skylight) (#4626) 
GraphQL : mise à jour de l'analyse des performances
 2020-01-28 15:47:34 +01:00
Paul Chavard
f7c59cffc0 Fix tests for skylight 2020-01-28 15:39:37 +01:00
Paul Chavard
0a928b2d6b [GraphQL] use Execution::Interpreter 
GraphQL-Ruby 1.9.0 includes a new runtime module which you may use for your schema. Eventually, it will become the default.
 2020-01-28 15:39:37 +01:00
Paul Chavard
7478a51846 [GraphQL] use official skylight support 2020-01-28 15:39:37 +01:00
Pierre de La Morinerie
f7128e81da
workflows: update auto-rebase bot 
Update to latest version of the auto-rebase bot
 2020-01-28 15:38:32 +01:00
Pierre de La Morinerie
9993b8ca86
Rend l'indicateur d'autosave tout le temps visible sous IE 11 (#4570) 
Usager : rend l'indicateur de sauvegarde automatique visible sous IE 11
 2020-01-28 15:30:43 +01:00
Pierre de La Morinerie
6eaf0f7804 dossiers: fix the sticky bar on IE 11 
This allows IE 11 users to see the draft autosave indicator.

The layout on IE 11 is still buggy though - but it's better than
nothing.
 2020-01-28 15:20:30 +01:00
Pierre de La Morinerie
2c795a5ff4
Revert "app: hide IE11 deprecation banner during the strike" (#4713) 
Le bandeau indiquant qu'Internet Explorer 11 est très ancien est à nouveau affiché
 2020-01-28 15:19:01 +01:00
Paul Chavard
df8b35a9e0
Merge pull request #4716 from tchak/add-more-info-to-avis-export 
Ajouter les informations de l’instructeur et de l’expert dans l’export des avis
 2020-01-28 15:18:28 +01:00
Pierre de La Morinerie
745b00366f Revert "app: hide IE11 deprecation banner during the strike" 
This reverts commit c2882b6cc3.
 2020-01-28 15:18:18 +01:00
Paul Chavard
eec38bad73 Ajouter les informations de l’instructeur et de l’expert dans l’export des avis 
fix #4667
 2020-01-28 15:09:41 +01:00
Pierre de La Morinerie
d73dbc5056
Fix empty value in routing dropdown (#4718) 
Usager : empêche l'usager de sélectionner un groupe de routage vide
 2020-01-28 15:08:32 +01:00
Pierre de La Morinerie
9da4fa9f4d dossier: ensure the dossier groupe_instructeur is always present 
Otherwise we loose the link to the dossier's procedure, which is
definitely a bad thing.
 2020-01-28 14:58:34 +01:00
Pierre de La Morinerie
eb9388d59f dossier: ensure the routing dropdown must be selected 
A blank routing dropdown nullify the groupe_instructeur – which
also removes the link between the dossier and the procedure.

Fix #4717
 2020-01-28 14:58:34 +01:00
Keirua
0f88409f4a
Merge pull request #4710 from betagouv/4703-fix-menu-deroulant-liee 
#4703 - fix menu déroulant lié obligatoire
 2020-01-28 14:35:50 +01:00
clemkeirua
696e39761f deal with secondary_options that can be nil 2020-01-28 14:30:26 +01:00
clemkeirua
65b4bcf3a1 Permet de déposer un dossier lorsqu'un menu déroulant lié obligatoire n'a pas de valeur (car la liste est légitimement vide) dans le second champ. 2020-01-28 14:30:26 +01:00
Paul Chavard
81fd91ce41
Merge pull request #4619 from tchak/add-canonical-procedure 
Register canonical procedure when démarche republished under existing path
 2020-01-28 13:00:06 +01:00
Paul Chavard
67dea1ee50 Update spec/models/procedure_spec.rb 
Co-Authored-By: Pierre de La Morinerie <kemenaran@gmail.com>
 2020-01-28 12:49:53 +01:00
Paul Chavard
517ab25783 Register canonical procedure when demarche republished under existing path 2020-01-28 12:49:53 +01:00
Paul Chavard
04ad829e3f Add canonical_procedure_id to procedures 2020-01-28 12:49:53 +01:00
Paul Chavard
4a600a5514
Merge pull request #4715 from tchak/update-rspec 
Update rspec
 2020-01-28 12:49:12 +01:00
Paul Chavard
12c02a602f Update rspec 2020-01-28 12:43:07 +01:00
Paul Chavard
926b092d05
Merge pull request #4714 from betagouv/add-exercice-spec 
specs: add an actual test case to the Exercice spec
 2020-01-28 12:34:43 +01:00
Pierre de La Morinerie
aaaf6f393b specs: add an actual test case to the Exercice spec 
This fixes the "No timing found for 'spec/models/exercice_spec.rb'"
warning message during specs.
 2020-01-28 12:00:34 +01:00
Paul Chavard
a8c71f851e
Merge pull request #4711 from betagouv/fix-circleci-yarn-cache 
Improve CircleCI caches
 2020-01-28 11:00:01 +01:00
Pierre de La Morinerie
9a18f40720 ci: increase the change of cache hits 
See https://circleci.com/docs/2.0/caching/#restoring-cache
 2020-01-27 18:12:29 +01:00
Pierre de La Morinerie
bd1a2caad9 ci: save webpacker cache 2020-01-27 17:58:09 +01:00
Pierre de La Morinerie
9e7371d19a ci: don't allow yarn to update the lockfile during CI builds 
Yarn will now throw an error if there's a mismatch between the
package.json and the package.lock content.
 2020-01-27 17:38:01 +01:00
Pierre de La Morinerie
0ce1919cfb ci: save yarn cache after installing it 2020-01-27 17:26:17 +01:00
Pierre de La Morinerie
5755bdc836
Bug circleci not dispatching tests according previous time to r… (#4706) 
Bug circleci not dispatching tests according previous time to run them
 2020-01-27 17:19:11 +01:00
maatinito
b767f0a7f7 Bug circleci not dispatching tests according previous time to run them 
(store_test_results requires a directory)
 2020-01-27 17:12:09 +01:00
Keirua
e6fdf0d89e
Merge pull request #4709 from betagouv/4698-autocomplete-inclure-pas-resultats 
#4698 - Possibilite de selectionner un resultat quand il n'y a rien de suggéré dans le champ adresse
 2020-01-27 16:53:53 +01:00
Keirua
455f164d02
Detail the reason why we include the search term in the results 
Co-Authored-By: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>
 2020-01-27 16:47:32 +01:00
clemkeirua
9e858ae5ad possibilite de selectionner un resultat quand il n'y a rien dans le champ adresse 2020-01-27 12:51:06 +01:00
Paul Chavard
35aceeb5e6
Merge pull request #4699 from tchak/search-by-code 
Search departements by code
 2020-01-23 20:43:19 +00:00
Paul Chavard
f03cca4386 Search departements by code 2020-01-23 14:12:19 +00:00
Pierre de La Morinerie
032731c3e8
Revert "4127 fix superadmin supprime compte usager" (#4695) 
Revert "4127 fix superadmin supprime compte usager"
 2020-01-21 19:10:12 +01:00