Martin
aceb8996c1
feat(instructeur/procedure#show): enhance sort by notifications as planned by UX
...
Update app/javascript/controllers/checkbox_controller.ts
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2022-09-30 10:29:51 +02:00
Paul Chavard
462cc41caa
refactor(block): use block? instead of repetition?
2022-09-29 17:49:14 +02:00
simon lehericey
7a9c5e8d19
refactor(ujs): turbo use an id for turbo_stream.update id
not a class
2022-09-29 17:04:15 +02:00
Paul Chavard
b0aa777315
refactor(ujs): france_connect controller to use turbo
2022-09-29 16:51:54 +02:00
Paul Chavard
099eecaa6c
refactor(ujs): adapt safari-11-empty-file-workaround to turbo
2022-09-29 16:51:54 +02:00
Paul Chavard
5de74ae322
refactor(ujs): remove dead code
2022-09-29 16:51:53 +02:00
Paul Chavard
582ba7a16e
refactor(ujs): remove ujs spinner
2022-09-29 16:51:53 +02:00
simon lehericey
7d547e5e11
fix(linked_drop_down): in repetiton the second choice is saved
...
the filter was not applied in repetition block so an additional empty input was send which overrided the real value
2022-09-29 14:50:02 +02:00
Martin
ba6c5b4db7
feat(instructeur/procedure#index): enhance filter to support processed_at and state [plus en_instruction_at/since]
...
feat(filter): enable filter on dossiers.state, dossiers.processed_at(since), dossiers.en_instruction_at(since)
2022-09-27 17:19:54 +02:00
Colin Darie
53cd041060
refactor(dsfr): components import order accordingly to their README
2022-09-21 15:47:35 +02:00
Colin Darie
55fd4307a1
refactor(header/notice): convert JS to stimulus
2022-09-21 15:47:35 +02:00
Colin Darie
4d5f03b99c
style(header): remove fr-header__with-notice-info when notice is closed
2022-09-21 15:47:35 +02:00
Colin Darie
a5e1d8865b
style(france_connect_account): convert notice about FC user to DSFR
2022-09-21 15:47:35 +02:00
Colin Darie
80daf3ede1
style(dsfr): dossier form header + notice link
2022-09-21 15:47:35 +02:00
Colin Darie
7e1c542807
fix: FranceConnect button was not visible anymore, convert to DSFR
2022-09-21 09:28:54 +02:00
Kara Diaby
f3549a7a4d
Modify CSS overide and import footer from DSFR
2022-09-19 13:34:43 +02:00
Colin Darie
2bacd175df
feat(dsfr): import icons sets
2022-09-16 10:43:59 +02:00
Paul Chavard
d6f5be622c
feat(dossier): autosave en construction
2022-09-08 11:26:29 +02:00
Colin Darie
abcfc4a64a
fix(home/administration): button hover visibility since dsfr + bottom cards
2022-09-07 17:56:19 +02:00
Martin
f674f6981b
feat(DSFR.ie11): enable legacy mode with our own packaging system
2022-09-07 17:41:56 +02:00
Martin
96cdae0dd5
feat(DSFR.header): switch to DSFR header
2022-09-06 10:09:12 +02:00
Paul Chavard
ab3404714a
fix(css): rename css file to fix legacy browsers
2022-09-02 19:07:10 +02:00
Paul Chavard
ebfed21fa8
chore(npm): update dependencies
2022-09-01 09:32:50 +02:00
Colin Darie
f4c76ca677
fix(a11y/flash): add role=alert or status to flash messages
2022-08-31 17:46:04 +02:00
Colin Darie
69fe333aad
refactor(rgaa/contact): question type as radio buttons for better rgaa compliance
...
On suit les recommandations de l'audit RGAA 2021, mais il y aurait encore
peut-être à redire…
2022-08-31 17:46:04 +02:00
Martin
cc2b9b95bf
clean(import): dsfr
2022-08-31 15:18:21 +02:00
Martin
14625c29d1
fix(lint): fixlint
2022-08-31 14:56:01 +02:00
Martin
39b328a984
ui(Administrateur::Procedure::Service): use ds-fr table and some ui refinements
2022-08-31 14:56:01 +02:00
Martin
f086302455
feat(Administrateurs::Procedure::Service#form): wrap explanation within DSFR::CallOut
2022-08-31 14:56:00 +02:00
Martin
a2311b1b75
perf(dsfr): only include what alert and its dependencies as refered in README of each components
2022-08-31 14:56:00 +02:00
Martin
1bdbf2a7d7
feat(DesignSysteme): add DSfr and switch to Marianne font
2022-08-31 14:56:00 +02:00
Paul Chavard
d1ae98b9a7
feat(css): add dsfr
2022-08-31 14:53:50 +02:00
simon lehericey
adf194cc08
fix(editeur_de_champ): can join an pj template
2022-08-11 15:01:48 +02:00
Paul Chavard
cf315b7246
fix(autosave): on check condition requests do not send file inputs
2022-08-03 12:04:39 +02:00
Paul Chavard
fdbcdfd043
fix(utils): explicitly exclude file type from text inputs
2022-08-03 12:04:39 +02:00
Paul Chavard
c2091e0978
refactor(vite): use turbo-polyfills
2022-07-26 13:07:24 +02:00
Paul Chavard
01c0b4350b
fix(autosave): error.message can be readonly
2022-07-26 11:02:15 +02:00
Paul Chavard
d9eea35ae8
fix(dossier): decoralate dropdown behaviour from autosave
2022-07-21 18:40:16 +02:00
Paul Chavard
e85fe71887
fix(champ): allow to submit when secondary options are empty
2022-07-20 10:49:07 +02:00
Martin
850f9375b7
fix(ujs-error-handling): sometimes body is not yet ready,other calls regarding ajax namespace are wired on document, copy/paste
2022-07-19 10:52:55 +02:00
Martin
5932f2a1f6
fix(MutationObserver): IE 11 kind of silent error: https://stackoverflow.com/questions/50593385/mutationobserver-syntax-error-on-ie-11
2022-07-19 10:52:55 +02:00
Paul Chavard
a45b76e63a
fix(gon): matomo key can be a number
2022-07-18 16:08:42 +02:00
Colin Darie
1c96ca59dd
style(combo): better inputs sizes for pays/regions/departement/communes champs
2022-07-18 09:48:35 +02:00
Paul Chavard
d00a91aea5
feat(dossier): check conditions on en construction dossier
2022-07-13 10:49:17 +02:00
Paul Chavard
24aae95c63
fix(react): prevent warning about controlled inputs
2022-07-12 11:47:33 +02:00
Paul Chavard
a4681d8832
refactor(autosave): improuve events handling
2022-07-12 11:47:33 +02:00
Paul Chavard
1c8efea465
fix(preview): gon should not crash on preview pages
2022-07-12 11:16:41 +02:00
Martin
4c0aac8e0c
fix(linked_dropdown/dropdown): for dropdown_list, drop blank option because rails add it when the field is required. kind of same behaviour for linked_dropdown_list [but requires to manage it on the front too]
2022-07-11 14:47:26 +02:00
Paul Chavard
f5e75d5e8e
chore(stimulus): stimulus controllers can be lazy loaded
2022-07-06 14:26:17 +02:00
Paul Chavard
2c3503d7d0
test(js): add vitest
2022-07-05 13:38:00 +02:00
simon lehericey
7b02fa9353
typeDeChampIdValue -> typeDeChampStableIdValue
2022-07-05 11:53:18 +02:00
simon lehericey
1342356651
after_id -> after_stable_id
2022-07-05 11:53:18 +02:00
Paul Chavard
23fe07bfbd
Revert "Merge pull request #7511 from betagouv/US/fix-dynamic-imports-on-ff-60-69"
...
This reverts commit d2fd5b83a9
, reversing
changes made to 183dc4eb2b
.
2022-07-01 10:07:39 +02:00
Martin
3c8a78dc7f
polyfills: fails ont custom relative path to polyfills/dataset
2022-07-01 09:54:46 +02:00
Martin
f85c97f96e
fix(js): dynamic import with import keyword does not work on ffx[60,68]
2022-07-01 09:54:46 +02:00
Paul Chavard
45472f2fe7
chore(axe-core): add a11y reports in dev environement
2022-06-30 10:54:32 +02:00
Paul Chavard
4844f27404
Revert "Merge pull request #7509 from betagouv/US/fix-dynamic-imports-on-ff-60-69"
...
This reverts commit 8e13015e85
, reversing
changes made to 3a16905d79
.
2022-06-30 09:34:08 +02:00
Martin
a736c8300a
fix(js): dynamic import with import keyword does not work on ffx[60,68]
2022-06-30 07:27:24 +02:00
Martin
4ec61e58ac
feat(EditComponent): add max_file_size and content_types to upload buttons inspired by dsfr
2022-06-28 17:44:35 +02:00
Martin
22ab2a258c
fix(Rails.ujs): missing Rails.start
2022-06-27 14:06:47 +02:00
Paul Chavard
1ab609d108
refactor(react): eager load react components
2022-06-23 15:22:55 +02:00
Paul Chavard
eba1973d5f
refactor(stimulus): eager load stimulus controllers
2022-06-23 15:22:55 +02:00
Paul Chavard
ea18c2b9ba
chore(build): use vitejs
2022-06-23 15:22:54 +02:00
Kara Diaby
7695ad47cf
ETQ Usager, je veux entrer mon Iban de manière plus simple (avec espaces)
2022-06-22 15:07:31 +02:00
Paul Chavard
6801b04b7b
feat(type_de_champ): type_de_champ editor in stimulus/turbo
2022-06-17 11:04:09 +02:00
Paul Chavard
cf81e8ecd5
feat(turbo): add turbo:morph helper
2022-06-17 11:04:09 +02:00
Paul Chavard
65bd996f2a
refactor(types_de_champ_editor): remove old react editor
2022-06-17 11:04:09 +02:00
Martin
7ed9d586cf
fix(drop_down_list): ensure to skip disabled input when sending data via autosave
2022-06-02 09:06:37 +02:00
Paul Chavard
906eea188e
refactor(stimulus): use stimulus in message forms
2022-05-30 18:21:32 +02:00
Pierre de La Morinerie
c738d7d07f
js: display estimated duration in champ editor
2022-05-25 21:50:49 +02:00
Pierre de La Morinerie
3bd637fc56
js: add estimateFillDuration query
2022-05-25 21:50:49 +02:00
Pierre de La Morinerie
6596ea0bab
js: support payload-less requests
2022-05-25 21:50:49 +02:00
Paul Chavard
88eb14c623
feat(autosave): submit on input events
2022-05-24 15:05:14 +02:00
Paul Chavard
df914d273f
feat(turbo): add turbo-poll controller
2022-05-17 16:08:47 +02:00
Paul Chavard
e8c875a461
fix(fetch): prevent double parsing of fetch error messages
2022-05-17 10:38:19 +02:00
Paul Chavard
6d0b3d93ed
fix(autosave): prevent autosave if current champ is detached from the form
2022-05-16 14:07:02 +02:00
Paul Chavard
2e8bc7e1d0
fix(js): polyfill Node.isConnected for IE
2022-05-11 16:23:42 +02:00
Paul Chavard
b076ecaf96
feat(a11y): implement accessible menu button
2022-05-11 16:23:42 +02:00
Paul Chavard
10f6378cf0
fix(upload): silence common client errors in sentry
2022-05-11 13:44:50 +02:00
Paul Chavard
531464fab1
fix(js): bring back js request for now
2022-05-11 09:34:19 +02:00
Paul Chavard
c9b8d43acd
feat(autosave): use new autosave controller
2022-05-10 18:10:20 +02:00
Paul Chavard
3fea34732e
feat(autosave): add stimulus autosave-status controller
2022-05-10 18:10:20 +02:00
Paul Chavard
adb19a941f
feat(autosave): add stimulus autosave controller
2022-05-10 18:10:20 +02:00
Paul Chavard
525eebf600
feat(js): implement auto upload class
2022-05-10 18:10:20 +02:00
Paul Chavard
b29116817b
refactor(js): improuve uploader
2022-05-10 18:10:20 +02:00
Paul Chavard
ce58ab98c1
refactor(js): move around stimulus initializers
2022-05-10 18:10:20 +02:00
Paul Chavard
39761f45a0
cleanup(js): remove old autosave/autoupload code
2022-05-10 18:10:20 +02:00
Paul Chavard
3d8980f686
feat(httpRequest): add error body parsing
2022-05-10 18:10:20 +02:00
Paul Chavard
12884e0242
cleanup(js): remove unused utils
2022-05-10 18:10:20 +02:00
Paul Chavard
59c6fd1763
refactor(ts): improuve utils types
2022-05-10 18:10:20 +02:00
Paul Chavard
9b01b2cff9
feat(stimulus): add onGlobal helper
2022-05-10 18:10:20 +02:00
Paul Chavard
83afe1ad8c
fix(multiselect): allow to have options with the same label
2022-05-10 13:30:40 +02:00
simon lehericey
5040b877d1
remove unused franceconnect.js
2022-05-06 11:50:32 +02:00
Paul Chavard
9e0b3b642f
cleanup(sendinblue): remove sendinblue tracking
2022-05-06 11:14:44 +02:00
Paul Chavard
4307445999
fix(js): prevent old Edge from crashing
2022-05-05 09:35:53 +02:00
Paul Chavard
1a9f2f0eef
refactor(champ): improuve repetition champ
2022-05-04 17:18:52 +02:00
Paul Chavard
2db892d876
refactor(turbo): champ siret and dossier_link use turbo
2022-05-04 14:11:43 +02:00
Paul Chavard
1c2bd5543f
refactor(turbo): champ carte use turbo
2022-05-04 14:11:43 +02:00
Paul Chavard
1500a1cf28
feat(turbo): add enable and disable mutations
2022-05-04 14:11:43 +02:00
Paul Chavard
cfb83bbdda
feat(turbo): add on
method to stimulus application controller
2022-05-04 14:11:43 +02:00
Paul Chavard
af363b721b
refactor(js): use httpRequest instead of getJSON and ajax
2022-05-03 15:09:30 +02:00
Paul Chavard
229eb1a775
feat(js): add httpRequest
2022-05-03 15:09:30 +02:00
Paul Chavard
3f4004b188
fix(js): add DocumentFragment.children polyfill for IE
2022-05-03 12:38:17 +02:00
Paul Chavard
a16d07ef7c
fix(js): fix IE 11 fucked template element support
2022-04-29 18:24:53 +02:00
Paul Chavard
1890c05974
fix(js): more polyfills for IE
2022-04-29 14:11:00 +02:00
Paul Chavard
67ba8acff7
fix(react): too soon for strict mode
2022-04-28 14:45:35 +02:00
Paul Chavard
5c77bc139a
refactor(carto): remove preview special case
2022-04-28 12:20:41 +02:00
Paul Chavard
20a78f08c9
fix(js): add turbo and stimulus polyfills
2022-04-28 11:14:26 +02:00
Paul Chavard
86df16ebda
feat(view_components): add view_components
2022-04-26 14:54:58 +02:00
Paul Chavard
02f977fd8d
refactor(champs): refactor champs components to use typescript
2022-04-26 13:56:26 +02:00
Kara Diaby
b1ab0c6ed2
Ajoute un avertissement sur les champs de type Titre Identité
2022-04-26 08:33:30 +02:00
Paul Chavard
bca97268a8
fix(upload): errorFromDirectUploadMessage should take Error or string
2022-04-24 11:47:17 +02:00
Paul Chavard
62dca1c7b0
refactor(js): remove ds:page:update event
2022-04-22 10:24:39 +02:00
Paul Chavard
b585808924
refactor(js): add geo-area stimulus controller
2022-04-22 09:40:52 +02:00
Paul Chavard
22aefbaa4a
refactor(js): remove geo-area event handlers
2022-04-22 09:40:17 +02:00
Paul Chavard
0dac59bffc
refactor(js): use DOMContentLoaded instead of ds:page:update
2022-04-22 09:40:17 +02:00
Paul Chavard
0bd71ad51a
feat(turbo): add turbo event helpers
2022-04-21 19:41:27 +02:00
Paul Chavard
55d6b787c8
feat(js): add turbo
2022-04-21 19:41:27 +02:00
Paul Chavard
64c599e208
refactor(stimulus): initiate react components via stimulus
2022-04-20 14:08:47 +02:00
Paul Chavard
c96adbf2d2
chore(chartkick): upgrade to 4.1 and use built-in lazy loading
2022-04-15 12:12:18 +02:00
Paul Chavard
2ce9c842a1
refactor(type_de_champs): use typescript in type de champs editor
2022-04-08 14:34:27 +02:00
Paul Chavard
cd4d7b5d36
refactor(react): useDeferredValue
2022-03-31 12:39:17 +02:00
Paul Chavard
4a7324951b
refactor(react): useId
2022-03-31 12:39:17 +02:00
Paul Chavard
44c64669e9
Revert "Merge pull request #6787 from tchak/use-vite"
...
This reverts commit 5d572727b5
, reversing
changes made to 43be4482ee
.
2022-03-31 12:07:52 +02:00
Paul Chavard
187e84a010
feat(assets): use vitejs to build javascript
2022-03-29 16:27:08 +02:00
Paul Chavard
af166f5520
fix(carto): render GeoJSON layers after map style changes
2022-03-22 09:26:11 +01:00
Paul Chavard
d2e9cb5253
fix(map): remove IGN token
2022-03-17 11:55:20 +01:00
Paul Chavard
31da6178cc
refactor(maplibre): improuve type imports
2022-03-17 11:55:20 +01:00
Paul Chavard
b8a22ae8b2
fix(multi-select): fix labels on multi select component
2022-03-02 09:48:54 +00:00
Paul Chavard
2a42690388
fix(carto): show map UI before loading map styles
2022-03-01 11:08:07 +00:00
Paul Chavard
7c8e97f084
chore(eslint): ignore type of global react-query queryFn
2022-02-23 15:28:51 +01:00
Paul Chavard
cd2273ba54
chore(eslint): ignore any types in maplibre styles
2022-02-23 15:28:51 +01:00
Paul Chavard
67bfeb261a
chore(eslint): fix gon types
2022-02-23 15:28:51 +01:00
Paul Chavard
12ddaa0533
chore(eslint): disable types because we use mapbox plugin with maplibre
2022-02-23 15:28:51 +01:00
Paul Chavard
96e9024694
chore(eslint): disable types on complicated event handlers
2022-02-23 15:28:51 +01:00
Paul Chavard
4e218ba562
chore(eslint): fix react-query cancelable promise type
2022-02-23 15:28:51 +01:00
Paul Chavard
a914950982
chore(eslint): fix getJSON reponse type
2022-02-23 15:28:51 +01:00
Paul Chavard
beafa21796
chore(eslint): fix isNumeric types
2022-02-23 15:28:51 +01:00
Paul Chavard
95b9e47993
chore(eslint): fix flash message root element query
2022-02-23 15:28:51 +01:00
Paul Chavard
68e89af775
chore(eslint): make react-hooks/exhaustive-deps rule as an error
2022-02-23 15:28:51 +01:00
Pierre de La Morinerie
50cafc033f
js: fix OperationQueue error handling
...
When an exception is raised, `response.json()` may have been called
already. In that case, when accessing `response.text()` in the error
handler, a "Response.text: Body has already been
consumed." error will be raised.
2022-02-15 12:23:18 +01:00
François Vantomme
cc6cb2ea30
feat(matomo): use env variables to set the domain
2022-02-15 09:25:23 +01:00
Paul Chavard
1f661325a5
refactor(carto): use maplibre instead of mapbox
2022-02-09 10:29:00 +01:00
Paul Chavard
ea6aec8b1a
chore(webpack): enable typescript
2022-02-09 10:29:00 +01:00
Pierre de La Morinerie
d4fada9f6c
config: add MATOMO_HOST environment variable
2022-01-19 15:43:44 +01:00
Paul Chavard
902f7f6cb3
fix(select): improuve multi select onBlure
2022-01-13 17:49:16 +01:00
Paul Chavard
7e81b257b1
test(system): simplify select menu selector
2022-01-13 17:49:16 +01:00
Paul Chavard
4a718eae92
fix(select): always show menu on click in the input
...
fix #6655
2022-01-11 12:11:45 +01:00
Paul Chavard
967699c305
fix(select): improuve no results found message
2022-01-11 12:10:20 +01:00
Paul Chavard
d6b6bb0f2a
a11y(combobox): add support for describedby and labelledby and improuve external fields handling
2022-01-05 12:33:40 +01:00
Paul Chavard
6776a5e05a
fix(react): remove register component cache
2022-01-03 19:41:23 +01:00
Pierre de La Morinerie
07230870d3
js: don't track external links
...
This fixes an issue where, by default, links to private attachments are
reported to Matomo.
This is benign: attachments URLs can be filtered out server-side, and
expire after one hour anyway. But we don't want to ship an insecure
configuration by default.
2021-12-23 09:50:21 +01:00
Paul Chavard
f8d245d2f8
refactor(js): use dynamic import
2021-12-21 17:09:49 +00:00
Paul Chavard
ed2cbdc966
fix(champ): save departement name without code prefix
2021-12-06 20:58:08 +01:00
Pierre de La Morinerie
115ca5e24a
js: don't create invalid menus by default
...
When a new "Menu" type de champ is added, it comes pre-filled with a
menu title – and nothing else. Which is confusing, and invalid.
Instead pre-fill the type de champ with actual values (no titles).
2021-12-02 09:00:37 +01:00
Paul Chavard
7d189575af
fix(commune): do not display foreign departement when selecting commune
2021-11-25 13:49:57 +03:00
mfo
91c3a8be19
fix(eslint): max columns
2021-11-25 13:43:28 +03:00
Martin
0d486981a6
fix(ComboCOmmunesSearch.typo): fix combo communes search typo
2021-11-25 13:43:28 +03:00
Paul Chavard
ae09b37e72
fix(champs): save departement info on champ commune
2021-11-17 14:52:47 +03:00
Paul Chavard
ba0211ba52
feat(champ): ask for departement before asking for commune
2021-11-04 11:55:25 +01:00
Paul Chavard
7ebc439630
refactor(drop_down_list_champ): other option
2021-10-27 12:01:15 +02:00
Paul Chavard
8154daf847
refactor(drop_down_list_champ): other option
2021-10-27 12:00:39 +02:00
kara Diaby
c2fcd3992d
add other option for dropdown select
2021-10-26 16:11:15 +02:00
kara Diaby
0e65916e44
add other option for dropdown radio
2021-10-26 16:11:15 +02:00
kara Diaby
dc35d9521f
add other option to liste deroulante champ
2021-10-26 16:11:15 +02:00
Paul Chavard
d308448f02
feat(type_de_champ): add secondary label and description do linked drop downs
2021-10-26 12:18:01 +02:00
simon lehericey
933d7b8c8d
merge with another preexisting account
2021-10-14 14:47:50 +02:00
simon lehericey
ce40e1127d
merge with another new account
2021-10-14 14:47:50 +02:00
simon lehericey
19f81b594b
merge with an existing account by using the password
2021-10-14 14:47:50 +02:00
Pierre de La Morinerie
b2774ed2f6
js: fix pays API request on older Edge and Safari
...
The /api/pays API requires user authentication. However older versions
of Edge and Safari don't transmit cookies by default during a
`fetch` request.
Use the `credentials: 'same-origin'` option explicitely to fix the
countries list.
2021-09-30 16:21:24 +02:00
Pierre de La Morinerie
4f33a7b72e
js: improve auto-save-controller documentation
2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
ad8dcc7f7d
js: don't report autosave failures that are timeouts
...
This prevents spamming Sentry with "[Autosave] Error: 0" messages.
2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
8dce7d59ed
js: redirect to sign-in when a ujs link_to receives a 401
...
Before, when a 401 was received by a ujs-enabled link (like `link_to …,
method: :delete, data: { remote: true }`, rails-ujs tried to insert the
response text as a Javascript script.
As the script was something like `Please sign-in`, which is not valid
Javascript, the browser would throw an "Unexpected token" error.
The typical use-case is:
1. The user open a form in a tab,
2. The user disconnects in another tab,
3. In the first tab, the user clicks on a remote "Delete" link_to
In that case the browser raised an error in the console (and in Sentry),
but the user would see nothing.
With this commit, all 401 ujs errors are turned into redirects to the
sign-in page.
Fix https://sentry.io/organizations/demarches-simplifiees/issues/2522512693/activity/
2021-09-07 16:45:52 -05:00
Pierre de La Morinerie
255c00c174
js: ignore a new variant of the same warning
2021-09-07 16:45:52 -05:00
Jérôme Desboeufs
7079af2fd4
Update photographies-aeriennes basemap URL
2021-09-01 21:58:12 +02:00
Pierre de La Morinerie
7380d27d78
js: fix null xhr in autosave error handling
...
Sentry reports many cases of the xhr object being missing in the
error handler.
Ensure the error handling code doesn't crash because of the missing xhr.
2021-08-31 14:54:02 -05:00
Paul Chavard
5d63ced246
fix(eslint): fix eslint warnings
2021-08-31 18:14:04 +02:00
Paul Chavard
a3cc072bbd
feat(i18n): translate countries selector
2021-08-31 13:15:26 +02:00
Paul Chavard
b81cfea0e4
fix(combo-search): can input empty value
2021-08-18 15:48:37 +01:00
Paul Chavard
2a84f14521
Make generic
2021-08-18 12:09:20 +02:00
Pierre de La Morinerie
e1909ed29f
brouillon: redirect to sign-in when disconnected
...
There are two cases where the draft auto-save might fail because the
user is no longer authenticated:
- The user signed-out in another tab,
- The brower quit and re-opened, so the Session cookie expired.
In both cases, the auto-save will never succeed until the user
authenticates again, so displaying a "Retry" button is cruel.
Moreover, in plus of all auto-save requests failing with a small error,
the actual hard failure only occurs after filling all the form and
trying to submit it. Then the user is redirected to the sign-in page –
but all their changes are lost.
Instead, we now redirect to the sign-in page on the first 401 error
during the auto-save, let the user sign-in, and then redirect back to
the form.
2021-07-22 11:58:02 +02:00
Pierre de La Morinerie
7808f6dd4f
js: document utils.ajax()
2021-07-22 11:58:02 +02:00
Pierre de La Morinerie
c6fff58f38
js: fix typo in comment
2021-07-22 11:58:01 +02:00
Pierre de La Morinerie
071d9145ca
js: don't attempt to log unexistent statusText
2021-07-22 11:58:01 +02:00
Paul Chavard
c7b0b8495b
Get more results from communes API and use local matcher
2021-07-20 13:34:17 +02:00
Pierre de La Morinerie
63cde95fc9
js: ignore errors generated by a Microsoft crawler
...
Sentry has a lot of Javacript errors stating:
> UnhandledRejection: Non-Error promise rejection captured with value: Object Not Found Matching Id:2
This is apparently caused by a Microsoft crawler (maybe for scanning
targets of email links), and can be safely ignored.
See https://forum.sentry.io/t/unhandledrejection-non-error-promise-rejection-captured-with-value/14062/12
2021-07-20 09:21:59 +02:00
Paul Chavard
38fdaa7404
Trigger onStyleChange when leyers are toggled
2021-07-07 16:23:55 +02:00
Paul Chavard
1e4c943392
Fix map controls checkbox labels
2021-07-07 15:38:21 +02:00
Paul Chavard
65adce1e24
Fix cadastres layer
2021-07-07 15:38:21 +02:00
Paul Chavard
527db7631e
Add a point on map from coordinates input
2021-07-07 13:33:28 +02:00
Paul Chavard
0ce708028d
Prevent crashes in combo boxes
2021-07-06 15:06:38 +02:00
Paul Chavard
87fb98f5ed
Make IGN layers opacity configurable
2021-07-06 10:36:12 +02:00
Paul Chavard
fc966a2761
IGN layers on maps can now be disabled by the user
2021-06-30 20:07:52 +02:00
Paul Chavard
10cdd2c77e
Apply suggestions from code review
...
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2021-06-16 09:38:47 +02:00
Paul Chavard
7f28c49887
expand commune searches with multiple post codes
2021-06-16 09:29:25 +02:00
Paul Chavard
7575f50d25
Fix autocomplete on blur
2021-06-15 10:13:31 +02:00
Paul Chavard
7f4e174871
Declare useCallback dependencies
2021-06-15 10:13:31 +02:00
simon lehericey
6be0bbaa9c
Change bottom champs editor button from enregistrer to continuer
2021-06-15 09:54:32 +02:00
Paul Chavard
1b0cc62fc2
Add cadastres to MapReader
2021-05-24 11:57:00 +02:00
Paul Chavard
2244263b49
Add cadastres to MapEditor
2021-05-24 11:57:00 +02:00
Paul Chavard
19440afebf
Improuve mapbox utilis and shared components
2021-05-24 11:57:00 +02:00
Paul Chavard
bf462380e6
MultiSelect: select values on blur
2021-05-20 17:21:13 +02:00
Paul Chavard
3313ea5885
MultiSelect: do not show empty results on free form inputs
2021-05-20 17:21:13 +02:00
Paul Chavard
e0d8d096f2
MultiSelect: improuve setters
2021-05-20 17:21:13 +02:00
Paul Chavard
868ec214ce
MultiSelect: enable adding multiple emails with , or space
2021-05-20 17:21:13 +02:00
Paul Chavard
bf9f29cc71
Fix messagerie scroll to last message
2021-05-20 11:58:54 +02:00
Paul Chavard
69ab7854c2
replace fontawesome with heroicons
2021-04-29 15:20:05 +02:00
Paul Chavard
6e1b4a2067
Update and pin mapbox-gl
2021-04-28 15:34:53 +02:00
Paul Chavard
85b907807a
Improuve ComboMultipleDropdownList style
2021-04-28 12:54:45 +02:00
Paul Chavard
6836191ca5
Improuve commune autocomplete results
2021-04-22 09:59:21 +01:00
Christophe Robillard
6026793c1d
focus to target after toggle
2021-03-17 11:31:51 +01:00
Christophe Robillard
df3bd3a1d2
handle focus during and after upload
2021-03-17 11:31:51 +01:00
Christophe Robillard
43039d1755
add aria-value min, max and now for progressbar upload
2021-03-17 11:31:51 +01:00
Paul Chavard
6f543d3770
Handle invalid GeoJSON in the editor
2021-03-11 15:51:09 +01:00
Paul Chavard
9f8c55969d
Add proper external data API errors handling
2021-03-04 10:16:06 +01:00
Paul Chavard
2c2b392d6c
Fix multiselect labels
...
only add values to new values if it is a new value
2021-02-19 12:08:54 +01:00
Paul Chavard
24f71ccc1a
Improuve multi select
...
In multi select with acceptNewValues option alway keep the new value as the first item in the list to make it easier to add it
2021-02-19 10:53:16 +01:00
Paul Chavard
6756db1013
Update react-query
2021-02-16 18:14:11 +01:00
Paul Chavard
bb49f6e151
replace react-use with use-debounce
...
this is a much lighter dependencie
2021-02-16 18:14:10 +01:00
Paul Chavard
3dae5b5c04
update react
2021-02-16 18:14:10 +01:00
Paul Chavard
df80f5681d
remove react-scroll-to-component
2021-02-16 18:14:10 +01:00
Paul Chavard
1c164c4376
Use jsx extension
2021-02-16 18:14:10 +01:00
Paul Chavard
881820888a
Use stable cache key for useMemo
2021-02-16 16:47:15 +01:00
Christophe Robillard
8b55f67964
accepte nouvelles valeurs pour ComboMultipleDropdownList
2021-02-16 16:47:15 +01:00
Paul Chavard
06e282b839
supprime select2
...
select2 n'est plus utilisé. Il est remplacé par
ComboMultipleDropdownList
2021-02-16 16:47:15 +01:00
Christophe Robillard
e048f48241
create ComboMultipleDropdownList component
2021-02-16 16:47:14 +01:00
Paul Chavard
a503417298
Remove old css and js
2021-02-02 15:26:11 +01:00
Paul Chavard
9f691dce4c
Set external_id from combo search inputs
2021-01-15 11:50:02 +01:00
Paul Chavard
91be115c70
Add annuaire_education champ ui
2021-01-14 17:57:48 +01:00
Paul Chavard
6ca9daab0f
Ensure a combo always autosave value on change
2021-01-14 17:31:37 +01:00
Paul Chavard
075ee9dcde
Fix cadastres layer
2020-12-11 14:47:50 +01:00
Paul Chavard
1af0d30d94
Use new optional layers in maps module
2020-12-10 11:26:16 +01:00
Paul Chavard
eaa9b1c071
Expose all optional layers in TypeDeChamp editor
2020-12-10 11:26:16 +01:00
Christophe Robillard
ddd50993a5
cache pays
2020-12-08 13:09:08 +00:00
Christophe Robillard
12d1a5bece
implement ComboPaysSearch
2020-12-08 13:09:08 +00:00
Paul Chavard
618c81b9a6
Mount react components on page updates
2020-10-15 18:46:12 +02:00
Paul Chavard
ca0ba4ba2d
replace deprecated react-loadable with suspense
2020-10-15 17:30:49 +02:00
Paul Chavard
752ee78c49
Use fetch instead of jQuery
2020-10-13 10:55:10 +02:00
Paul Chavard
70bf9ea92f
remove unused select2 code
2020-10-08 15:26:15 +02:00
Paul Chavard
8a2f079acb
Implement ComboAdresseSearch
2020-10-08 15:26:14 +02:00
Paul Chavard
b6c94a3758
Implement ComboCommunesSearch
2020-10-08 15:26:14 +02:00
Paul Chavard
4217dcd94b
Implement ComboDepartementsSearch
2020-10-08 15:26:14 +02:00
Paul Chavard
2c7ee82d31
Implement ComboRegionsSearch
2020-10-08 15:26:14 +02:00
Paul Chavard
1b57d94d93
Use @reach/combobox instead of select2
2020-10-08 15:26:14 +02:00
Paul Chavard
5df7a729e7
Add a wrapper to catch chart rendering before chartkick is loaded
2020-10-07 11:40:07 +02:00
Paul Chavard
d8852c7dc5
Lazily load trix
2020-10-07 11:40:07 +02:00
Paul Chavard
95eb907090
remove unused javascript
2020-10-07 11:39:57 +02:00
Christophe Robillard
6fd0134b6d
convert to es6 classes
2020-09-22 16:09:15 +02:00
Christophe Robillard
8baaee8810
load expanded buttons only for contact form
2020-09-22 16:09:15 +02:00
Christophe Robillard
5bd4644c2c
fix js lint errors
2020-09-22 16:09:15 +02:00
Christophe Robillard
9be015752a
set input value for question type of contact page
2020-09-22 16:09:15 +02:00
Christophe Robillard
df9a15a224
expand buttons for contact page
2020-09-22 16:09:15 +02:00
Paul Chavard
512cdeb6ff
normalize features on import
2020-09-22 09:12:55 +02:00
kara Diaby
5c68d75107
add titre_identite champ
2020-09-18 14:57:08 +02:00
Christophe Robillard
51c4001a1a
add aria-disclosure for Mon compte button
2020-09-15 18:12:26 +02:00
Paul Chavard
bbcdff0ccf
Use IGN plan v2 and add MNHN data sources
2020-09-15 14:39:02 +02:00
Pierre de La Morinerie
e033ec3404
js: ignore missing DOM element on ProgressBar
...
Currently ProgressBar is used to monitor upload progress of attachments.
But there's two cases where the associated DOM element may be removed:
- In the champs editor, when the list scrolls, DOM elements are removed
and added dynamically by React;
- In the user form, the user might start an upload on a repetition, and
then remove the associated row during the download.
In both those cases, we don't want the missing DOM element to trigger
an error.
2020-09-03 15:03:13 +02:00
kara Diaby
ae61c279af
migrate emails text editor to new interface
2020-09-03 14:42:22 +02:00
Paul Chavard
ec72fdd164
Remove migration service
2020-09-02 11:26:26 +02:00
kara Diaby
1788471664
carto hack : traduce edition buttons in french
2020-09-01 17:41:20 +02:00
Pierre de La Morinerie
ecc4f01c20
autosave: trigger an autosave after removing a row
2020-08-25 15:45:49 +02:00
Pierre de La Morinerie
96037069ff
autosave: remove the repetition row after deletion
...
Before, when autosaving a draft, removing a repetition row would
send `_destroy` inputs to the controller – but not remove the row
from the DOM. This led to the `_destroy` inputs being sent again
on the next autosave request, which made the controller raise
(because the row fields were already deleted before).
To fix this, we let the controller response remove the deleted
row(s) from the DOM.
Doing it using a controller response avoids the need to keep track
of operations on the Javascript side: the controller can easily
know which row was just deleted, and emit the relevant changes for
the DOM. This keeps the autosave requests robust: even if a request
is skipped (e.g. because of a network interruption), the next request
will still contain the relevant informations to succeed, and not let the
form in an unstable state.
Fix #5470
2020-08-25 14:39:34 +02:00
Pierre de La Morinerie
e157a289e1
autosave: factorize some javascript code
2020-08-25 14:39:34 +02:00
Paul Chavard
4c87e547b3
Put IGN map behind a feature flag
2020-07-30 17:22:28 +02:00
Paul Chavard
f1cbc9846e
Add carte ign
2020-07-30 16:58:20 +02:00
Paul Chavard
87a1661cdc
fix prop type error
2020-07-22 11:10:14 +02:00
Pierre de La Morinerie
5949266e89
javascript: silence Crisp warning in Javascript console
2020-06-26 15:57:14 +02:00
kara Diaby
3dacff19d5
[CARTO] fix the GPX and KML imports in order to manage multiples draw types in the same file
2020-06-18 16:28:46 +02:00
Paul Chavard
d9f7d10425
Refactor Map Reader|Editor to handle events from geo areas list
2020-06-09 18:45:45 +02:00
Paul Chavard
95d61c85e1
Dispatch events from geo areas list view
2020-06-09 18:45:45 +02:00
Paul Chavard
901b6e23a8
Remove legacy carto
2020-06-04 16:03:23 +02:00
kara Diaby
f104567619
Add 2 cards style for MapEditor + optim import gpx kml
2020-06-02 13:24:29 +02:00
kara Diaby
1e3a042a69
Add styles without cadastres in mapReader + tutorials pages in MapEditor
2020-05-28 17:50:14 +02:00
kara Diaby
d8ae089e93
[Carto] Improve files import UX + import KML files
2020-05-20 14:17:27 +02:00
kara Diaby
c37b32ac94
fix the search input addresses return box bug [Carto]
2020-05-19 15:34:48 +02:00
Pierre de La Morinerie
833d7a3b59
javascript: ignore most common upload errors also in standard uploads
...
In #5149 , we ignored most common upload errors, but only for
auto-uploads.
This PR ignores those errors also for standard uploads.
2020-05-18 11:50:29 +02:00
Paul Chavard
d44df9cc2a
Fix map apercu
2020-05-14 14:28:54 +02:00
Pierre de La Morinerie
bbc0aa5465
javascript: remove debug code for FileReader errors
2020-05-14 13:29:54 +02:00
Pierre de La Morinerie
86357b65f0
javascript: ignore most common upload errors
2020-05-14 13:29:54 +02:00
Pierre de La Morinerie
4b288038d3
javascript: human-readable message for reading errors during upload
2020-05-14 13:29:54 +02:00
Paul Chavard
03075afa5b
Update javascript dependencies
2020-05-14 13:21:42 +02:00
Pierre de La Morinerie
b5f1d97629
app: disable Turbolinks
...
Fix #5039
2020-05-13 11:04:16 +02:00
Paul Chavard
43a1ead1cb
fix new prettier defaults
2020-05-12 18:18:37 +02:00
kara Diaby
474521c841
Adapt style for Map reader (point, line)
2020-05-12 17:47:28 +02:00
kara Diaby
1cc04092f4
import GPX file in browser [Carto]
2020-05-11 11:36:36 +02:00
Paul Chavard
05e408225b
Implement atomic operations on MapEditor
2020-05-06 16:46:14 +02:00
kara Diaby
9aea1fffee
Migrate the map editor to mapbox-gl with react component
2020-04-27 11:30:32 +02:00
Pierre de La Morinerie
6f4075f38e
javascript: fix FileUploadError stacktraces
...
When subclassing a JS error, most browsers include the constructor
stacktrace :/
This is an issue, because:
- The stacktrace is deeper than it should be
- The stacktrace reaches into a polyfill for which there is not source
map, which causes Sentry to infer the issue grouping from the JS file
name. And the fingerprinted name changes on each release. So for each
release, the stacktrace is different ; and Sentry can't group issues
properly.
2020-04-23 12:27:26 +02:00
Pierre de La Morinerie
ef009f73e2
javascript: report upload FileReader errors to Sentry
...
We have quite a lot of `Error reading file` errors when uploading files.
These errors are generated by ActiveStorage `file_checksum.js` component
but it eats the actual reason of errors.
(See https://github.com/rails/rails/blob/5-2-stable/activestorage/app/javascript/activestorage/file_checksum.js#L38 )
We can't really override the class to generate better errors, as they
are deeply nested in ActiveStorage class hierarchy, and not exported to
external code.
Instead, we hook into the FileReader event handler, to insert a logger
when this error occur. The original event handler will also still be
called as usual.
This is intended to be temporary. The debug code will be removed once
we get a better idea of what is going on.
2020-04-22 11:26:16 +02:00
Paul Chavard
bc8217e030
Carte Editor sends FeatureCollection to the server
2020-04-16 18:29:19 +02:00
Pierre de La Morinerie
769e98f63e
javascript: fix the progress bar removal on success
...
When using auto-attach, the response HTML fragment replaces the progress
bar – so it doesn't need to be removed twice.
2020-04-16 17:02:23 +02:00
Pierre de La Morinerie
647ad3ba10
javascript: consider unknown upload errors as client errors
2020-04-16 12:59:14 +02:00
Pierre de La Morinerie
b006c33ebe
javascript: parse the upload status code correctly
...
Previously the status was "Status: 422" instead of just 422.
2020-04-16 12:54:18 +02:00
Pierre de La Morinerie
b2231e98d5
javascript: don't report connectivity issues to Sentry
2020-04-16 11:20:45 +02:00
Pierre de La Morinerie
55788990da
javascript: add a helpful message on connectivity error
2020-04-16 11:20:45 +02:00
Pierre de La Morinerie
432967bd76
javascript: make Uploader always throw the same kind of errors
...
A DirectUpload may fail for several reasons, and return many types of
errors (string, xhr response, Error objects, etc).
For convenience, wrap all these errors in a FileUploadError object.
- It makes easier for clients of the Uploader class to handle errors;
- It allows to propagate the error code and failure responsability.
2020-04-16 11:20:45 +02:00
Pierre de La Morinerie
d8f3b86b0e
javascript: move auto-upload attachment to the Uploader class
...
Rationale:
- It makes more sense to handle the progress bar updates in a single class;
- This will allow us to unify the error handling.
2020-04-16 11:20:45 +02:00
Paul Chavard
442a6a3cdd
Remove deprecated map reader
2020-04-15 18:07:09 +02:00
Paul Chavard
22604013d0
Expose multiple user selections on champ carte
2020-04-15 18:07:09 +02:00
Paul Chavard
52d2ace823
Remove quartiers prioritaires
2020-04-14 10:29:59 +02:00