Commit graph

17 commits

Author SHA1 Message Date
Pierre de La Morinerie
4cb747fdb6 specs: always require rails_helper
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Paul Chavard
86b271997b Invite experts to linked dossiers
closes #3669
2019-10-23 13:10:09 +02:00
simon lehericey
3fde2a6f70 Rename gestionnaire in code to instructeur 2019-08-12 13:47:01 +02:00
gregoirenovel
386fbce776 Enable the Layout/SpaceBeforeBlockBraces cop 2019-01-03 10:53:50 +01:00
Frederic Merizen
07b1c147d9 [Fix #1972] Always send mails asynchronously 2018-05-28 12:02:13 +02:00
Frederic Merizen
13d251d970 describe '#method' rather than describe '.method' for instance methods 2018-03-20 16:00:30 +01:00
Mathieu Magnin
69f8353b2f [Fix #1479] Sanitize Avis email before validation 2018-03-14 17:41:47 +01:00
gregoirenovel
897a30da0c Enable the Layout/SpaceInsideBlockBraces cop 2018-01-18 10:53:34 +01:00
Simon Lehericey
fc987a730d [Fix #925] strip avis email input 2017-10-30 14:19:20 +01:00
Mathieu Magnin
31995c270c [Fix #721] If an avis is created with uppercase email, downcase it before save 2017-09-13 10:59:59 +02:00
Simon Lehericey
7016bdc49a Avis: move assign_gestionnaire logic to avis model 2017-07-21 11:22:16 +02:00
Simon Lehericey
fe1b97b738 Avis: move notify_gestionnaire to private method 2017-07-21 11:19:18 +02:00
Simon Lehericey
64f7cab3cf Avis: add claimant gestionnaire to track who asks for an avis 2017-05-29 11:44:28 +02:00
Simon Lehericey
aaf155df72 Avis: add sign_up logic for new tps gestionnaire 2017-05-29 11:44:28 +02:00
Mathieu Magnin
4e064dbaed Add a method to link multiple avis to a gestionnaire by his email 2017-05-29 11:44:28 +02:00
Mathieu Magnin
d07943a55d Add by_latest scope in Avis 2017-05-29 11:44:28 +02:00
Mathieu Magnin
c3bf15d49f Create and list Avis on Dossier detail page 2017-05-29 11:44:28 +02:00