Paul Chavard
0146ba7b69
Merge pull request #6599 from betagouv/main
...
2021-10-28-01
2021-10-28 15:25:46 +02:00
Paul Chavard
199f128a49
Merge pull request #6594 from tchak/fix-repetition-add-row-button
...
Fix repetition add row button
2021-10-28 15:03:07 +02:00
Paul Chavard
da49a6447f
refactor(repetition): optimize and add a transaction around repetition add row
2021-10-28 14:54:33 +02:00
Paul Chavard
f9a8fb4ada
fix(repetition): prevent rage clicks on add row button
2021-10-28 14:54:32 +02:00
Paul Chavard
a8dcf934f8
Merge pull request #6589 from tchak/fix-remove-instructeur-from-group
...
fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur
2021-10-28 14:54:14 +02:00
Paul Chavard
c4b93f8d4a
fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur
2021-10-28 14:45:52 +02:00
LeSim
88c2bfed8e
Merge pull request #6585 from betagouv/merge_and_delete
...
Supprime le vieux compte lors d'un merge
2021-10-28 14:44:47 +02:00
simon lehericey
8fe1e2bf71
wrap merge in transaction
2021-10-28 14:39:13 +02:00
simon lehericey
7935e42109
Add merge log
2021-10-28 14:39:13 +02:00
simon lehericey
3328c9a132
merge move invite as well
2021-10-28 14:39:13 +02:00
simon lehericey
f2ccb39912
merge destroys the old role and account
2021-10-28 14:39:13 +02:00
simon lehericey
1401d163ba
add dependent_destroy to user instructeur / admin / expert roles
2021-10-28 14:39:13 +02:00
simon lehericey
c725999582
move merge method to user
2021-10-28 14:39:13 +02:00
simon lehericey
3d524e9488
Change factory user password to be compatible with admin pass constraint
2021-10-28 14:39:13 +02:00
Paul Chavard
aaf1498fff
Merge pull request #6598 from tchak/fix-rebase-champ-repetition
...
fix(rebase): fix repetition champ rebase
2021-10-28 13:39:11 +02:00
Paul Chavard
1393b7b07b
fix(rebase): fix repetition champ rebase
2021-10-28 13:27:53 +02:00
LeSim
a66257884d
Merge pull request #6597 from tchak/fix-typos
...
fix(typo): addresse -> adresse
2021-10-28 13:04:16 +02:00
Paul Chavard
d659595cde
fix(typo): addresse -> adresse
2021-10-27 18:59:18 +02:00
Paul Chavard
e7f7e4eb91
Merge pull request #6591 from tchak/fix-disable-pj-on-bulk-messages
...
fix(bulk_messages): disable pj on bulk messages
2021-10-27 15:47:32 +02:00
Paul Chavard
6599f9a992
fix(bulk_messages): disable pj on bulk messages
2021-10-27 15:41:53 +02:00
Kara Diaby
b49606bfb3
Merge pull request #6593 from betagouv/main
...
2021-10-27-01
2021-10-27 14:40:50 +02:00
Kara Diaby
1fee02e6e4
Merge pull request #6553 from betagouv/feat/6517
...
ETQ Administrateur je voudrai pouvoir ajouter une option autre aux menus déroulants
2021-10-27 12:52:37 +02:00
Paul Chavard
7ebc439630
refactor(drop_down_list_champ): other option
2021-10-27 12:01:15 +02:00
Paul Chavard
8154daf847
refactor(drop_down_list_champ): other option
2021-10-27 12:00:39 +02:00
kara Diaby
f1f2b76a3d
revisions
2021-10-27 12:00:39 +02:00
kara Diaby
71aa13f468
tests
2021-10-27 12:00:39 +02:00
kara Diaby
c2fcd3992d
add other option for dropdown select
2021-10-26 16:11:15 +02:00
kara Diaby
0e65916e44
add other option for dropdown radio
2021-10-26 16:11:15 +02:00
kara Diaby
dc35d9521f
add other option to liste deroulante champ
2021-10-26 16:11:15 +02:00
Pierre de La Morinerie
8bc925ae50
Merge pull request #6584 from betagouv/system-specs
...
Migration des tests d'intégration vers des "system specs" (#6584 )
2021-10-26 12:43:30 +02:00
Pierre de La Morinerie
9fd38cae5e
specs: migrate from features to system specs
...
System specs have been available since Rails 5.1, and are better
integrated with the Rails framework.
- Rename `spec/features` to `spec/system`
- Rename `feature do` to `describe do`
- Configure Capybara for system specs
Steps mostly taken from https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6
2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
df9fa258ae
specs: remove database_cleaner
...
This is not needed for integration tests since Rails 5.1.
See https://www.nicholasjacques.io/blog/you-probably-dont-need-databasecleaner/
2021-10-26 12:24:46 +02:00
Pierre de La Morinerie
b1eee27dd7
specs: remove outdated workaround for silencing puma logs
2021-10-26 12:24:46 +02:00
Paul Chavard
afe2f7453e
Merge pull request #6564 from tchak/feat-improuve-linked_drop_down_list
...
Ajouter la possibilité de spécifier le libellé et la description pour les menus déroulants secondaires
2021-10-26 12:24:33 +02:00
Paul Chavard
6e8e0c7b6b
feat(type_de_champ): reflect changes of secondary labels and descriptions
2021-10-26 12:18:01 +02:00
Paul Chavard
d308448f02
feat(type_de_champ): add secondary label and description do linked drop downs
2021-10-26 12:18:01 +02:00
Pierre de La Morinerie
21e0c41b5d
Merge pull request #6583 from betagouv/improve-some-factories
2021-10-26 12:12:11 +02:00
Pierre de La Morinerie
cedbd31d39
specs: only build an admin when building a procedure
...
This should slighly be faster than doing a create in the middle of the
build.
2021-10-26 12:03:30 +02:00
Pierre de La Morinerie
a2b91c8ec6
factories: cleanup Administrateur, Instructeur and Expert factories
...
This changes:
- avoids relying on application code to create mock objects,
- allows to build Administrateur or Instructeurs without saving them.
2021-10-26 12:03:30 +02:00
Pierre de La Morinerie
0ff95df221
specs: improve speed of phone_champ_spec
...
Re-use the same champ for each test. This is safe, and makes the test
go from 4s to 1s.
2021-10-26 12:03:30 +02:00
Pierre de La Morinerie
fccf75710a
specs: avoid creating uneeded champs on geo_area
...
It makes the test much faster.
2021-10-26 12:03:30 +02:00
Paul Chavard
05293ad849
Merge pull request #6574 from tchak/fix-discarded-dossiers-deletion
...
fix(dossier): fix dossier.avis cascade
2021-10-26 12:01:10 +02:00
Paul Chavard
579dce8eb6
refactor(user): wrap user destruction in a transaction
2021-10-26 11:16:29 +02:00
Paul Chavard
d5d3995dad
fix(dossier): fix dossier.avis cascade
2021-10-26 11:16:29 +02:00
Paul Chavard
6eae97944d
Merge pull request #6576 from tchak/fix-remove-discarded-dossiers-from-transfers
...
fix(transfer): remove discarded dossiers from transfers
2021-10-26 11:04:07 +02:00
Paul Chavard
4aa573a75d
fix(transfer): remove discarded dossiers from transfers
2021-10-26 10:41:01 +02:00
Pierre de La Morinerie
01b0d15f5a
Merge pull request #6566 from betagouv/cache-pasword-complexity
2021-10-25 15:48:32 +02:00
Pierre de La Morinerie
d0e87a08cf
services: cache zxcvbn dictionaries per-thread
...
Before, every time a password was tested, the dictionaries were parsed
again by zxcvbn.
Parsing dictionaries is slow: it may take up to ~1s. This doesn't matter
that much in production, but it makes tests very slow (because we tend
to create a lot of User records).
With this changes, the initializer tester is shared between calls, class
instances and threads. It is lazily loaded on first use, in order not to
slow down the application boot sequence.
This uses ~20 Mo of memory (only once for all threads), but makes tests
more that twice faster.
For instance, model tests go from **8m 21s** to **3m 26s**.
NB:
An additionnal optimization could be to preload the tester on
boot, before workers are forked, to take advantage of Puma copy-on-write
mechanism. In this way all forked workers would use the same cached
instance.
But:
- We're not actually sure this would work properly. What if Ruby updates
an interval ivar on the class, and this forces the OS to copy the
whole data structure in each fork?
- Puma phased restarts are not compatible with copy-on-write anyway.
So we're avoiding this optimisation for now, and take the extra 20 Mo
per worker.
2021-10-25 12:04:56 +02:00
Pierre de La Morinerie
5818841daa
Merge pull request #6581 from betagouv/remove-puma-boot-code
2021-10-25 11:48:03 +02:00
Pierre de La Morinerie
136d0bc341
config: remove pre and post boot code from puma config
...
This is no longer needed since Rails 5.1.
See https://github.com/rails/rails/pull/31241
2021-10-25 11:28:09 +02:00
