Pierre de La Morinerie
3b5617b123
mailers: remove dead AdministrationMailer code
2021-02-04 12:15:13 +01:00
kara Diaby
00b5ad7a10
EQT instructeur, je peux supprimer un dossier terminé
2020-12-16 15:00:26 +01:00
clemkeirua
de3118bc7b
force password reset on admin promotion or creation
2020-09-17 16:39:13 +02:00
Pierre de La Morinerie
e34f82a6fb
mailers: ignore more SMTP errors
...
Although we already ignore "invalid recipient" errors, a new type
of error recently popped: the mail service responds with
> Net::SMTPServerBusy '400 unexpected recipients: want atleast 1, got 0'
We want to also ignore this kind of errors.
2020-07-13 16:17:55 +02:00
Pierre de La Morinerie
43569f687e
specs: use fixture_file_upload
rather than Rack::Test::UploadedFile
...
This is mostly for consistency (both styles were used before).
Note: we still have to use `Rack::Test::UploadedFile.new` in factories,
because of https://github.com/thoughtbot/factory_bot/issues/385 .
2020-07-01 11:13:45 +02:00
Christophe Robillard
c565c9c87b
refactor sign_up_instructeur_avis_url
2020-06-30 09:17:27 +02:00
Christophe Robillard
4839506374
refactor instructeur_avis_url
2020-06-30 09:17:27 +02:00
Paul Chavard
210389d0f8
Remove admin creation notification email
2020-06-25 16:29:06 +02:00
Judith
6b65ee8d15
mailers: display auto-archive date in notifications
2020-05-28 13:22:02 +00:00
Judith
59346ee868
mailers: mention the auto_archive in notify_new_draft
2020-05-28 13:22:02 +00:00
clemkeirua
1ac7ec2dca
precision dans mail suppression dossier en construction
2020-04-28 12:42:00 +00:00
Paul Chavard
f1b531911b
Handle processed dossiers in deletion mailers
2020-04-22 15:39:10 +02:00
Paul Chavard
61eaca928f
remove WarnExpiringDossiersJob
2020-04-09 11:11:51 +02:00
Paul Chavard
7ba4c513e6
Refactor notify near deletion mailers
2020-04-01 17:40:52 +02:00
Pierre de La Morinerie
4cb747fdb6
specs: always require rails_helper
...
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.
The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.
This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.
Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).
Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.
To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.
Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Paul Chavard
a60b6b6776
Use ’ consistently instead of '
2020-03-26 17:27:48 +01:00
maatinito
1af32b29fd
#4807 Use now() instead of Date.time.today (better code homogeneity)
2020-03-24 17:09:14 -10:00
maatinito
f5c2dc03c5
#4807 better method/variable naming
2020-03-24 16:46:23 -10:00
Christian Lautier
e61c53f267
Fix #4807 48h before closing a procedure, notify users their draft is not submitted
2020-03-24 16:46:23 -10:00
Paul Chavard
5c2eba1dd1
Always add a reason to dossier deletion
2020-03-24 09:30:11 +01:00
Paul Chavard
cd0acb1344
Cleanup dossier mailers
2020-03-19 16:52:18 +01:00
simon lehericey
3e7cef63c6
add mailer preview
2020-03-18 15:25:02 +01:00
simon lehericey
043847ae6e
change notify_automatic_deletion_to_administration signature
2020-03-18 15:25:02 +01:00
Christophe Robillard
e0f4957dfd
notify instructeur after groupe_instructeur changed
2020-02-26 11:25:07 +01:00
Pierre de La Morinerie
6664965961
mailers: add procedure context to the confirmation link
...
This allows to redirect the user to the procedure they signed up for
even when the browser session is not available (like if they changed
of browser).
Fix #4738
2020-02-25 11:45:36 +00:00
clemkeirua
4343bb3918
Revert "openly fail when not delivering mail"
...
This reverts commit 415cc2c2f1
.
2020-02-20 15:31:43 +00:00
Paul Chavard
b7051da278
Remove old export code
2020-02-19 18:19:17 +01:00
Paul Chavard
e931c0800d
Remove notify_unhide_to_user and notify_undelete_to_user mailers
2020-02-18 17:56:52 +01:00
Paul Chavard
318baf316e
Add notify_en_construction_near_deletion mailer
2020-02-18 17:18:14 +01:00
Paul Chavard
8c77d91e9f
Add notify_automatic_deletion_to_administration mailer
2020-02-18 17:18:06 +01:00
Paul Chavard
4e116f06a6
Add notify_automatic_deletion_to_user mailer
2020-02-18 17:15:32 +01:00
Pierre de La Morinerie
e746d90016
mailers: add a link to the procedure when the account already exists
2020-02-12 13:24:52 +00:00
clemkeirua
415cc2c2f1
openly fail when not delivering mail
2020-02-05 10:46:01 +01:00
Christophe Robillard
ed970d3f3c
admin: create without providing email
2020-02-04 16:21:42 +01:00
Pierre de La Morinerie
724ff50363
factories: rename dossier for_individual
to with_individual
...
This clarifies the distinction between
```
create :procedure, :for_individual
```
and
```
create :dossier, :with_individual
```
2020-01-21 17:24:56 +01:00
simon lehericey
c02e8b9553
Routing: send emails to the right group
2019-12-16 17:47:08 +01:00
simon lehericey
006e426a11
Work on deletion mail
2019-12-03 17:18:53 +01:00
simon lehericey
6391f7ff9c
Work on notify_near_deletion mailer
2019-12-03 17:18:53 +01:00
simon lehericey
8a42b9f97a
Add groupe instructeur mailer preview
2019-11-18 17:08:51 +01:00
clemkeirua
7f76ab6671
disable retry sending a mail with an invalid email adress
2019-11-07 10:11:48 +01:00
simon lehericey
e3d7688e66
[ fix #4473 ] Invite_administrateur!: do not reset password if the user is active
2019-11-05 10:29:39 +01:00
Pierre de La Morinerie
38f994a151
instructeurs: fix mailer previews not to use Instructeur.email
...
Mailers previews now create mock Instructeurs without directly accessing
the email.
2019-11-04 10:44:24 +01:00
clemkeirua
ad785278af
add mailer test
2019-10-22 09:51:14 +02:00
Chaïb Martinez
dd6c6bfe7a
mailers: add a NO_REPLY address to transactional emails
2019-09-10 13:37:28 +02:00
Pierre de La Morinerie
aa1cf6788b
mailers: turn revert_to_instruction into a notification email
2019-09-10 13:29:06 +02:00
clemkeirua
4032fc61e3
move to only one pipedrive account
2019-08-28 12:16:25 +02:00
simon lehericey
3fde2a6f70
Rename gestionnaire in code to instructeur
2019-08-12 13:47:01 +02:00
simon lehericey
6902f84b85
Brutally rename gestionnaire filename to instructeur
2019-08-12 13:47:01 +02:00
Pierre de La Morinerie
1c837eb901
mailers: improve wording of transactional emails and default templates
2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
8313752663
mailers: add CTA to templated emails
2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
858b093314
mailers: use the standard view mechanism to render notifications
...
Instead of rendering a view as a template, consider the view as a normal
view.
2019-07-23 14:53:50 +02:00
Pierre de La Morinerie
f32357f527
specs: avoid weird hacks to test NotificationMailer private method
...
- testing private methods is a code smell
- this setup is especially brittle
- we test the equivalent public method right below
2019-07-22 16:22:20 +02:00
Pierre de La Morinerie
71dfb38787
emails: improve typography of titles
2019-07-17 15:01:19 +02:00
Pierre de La Morinerie
44574b2b93
mailer_preview: improve data used for generating previews
2019-07-17 14:55:55 +02:00
Pierre de La Morinerie
03fc555edf
profile: send an email when the account is already taken
2019-07-10 11:31:09 +02:00
Nicolas Bouilleaud
bd47bf2691
Disable Messagerie in archived Dossiers and procedures
...
* Use the existing Dossier#messagerie_available? method
* Raise when attempting to build a Commentaire if not messagerie_available?
* Disable the Messagerie form if not messagerie_available?
* Add tests :)
* Tweak the Horaires formatting while we’re here.
2019-07-01 09:39:39 +02:00
Christian Lautier
2393fa86be
Mailer preview correction: procedure has now multiple administrators
2019-06-20 10:17:55 +02:00
Mathieu Magnin
1a97cd42de
Fix missing helper in notification mailer
2019-04-11 12:25:55 +02:00
Mathieu Magnin
e91b412254
[ Fix #3064 ] Use a different layout for state notifications emails
2019-04-11 11:03:12 +02:00
Pierre de La Morinerie
8ca683c515
mailers: fix last_week_overview crash when the overview is missing
...
This is because procedures may be unpublished between the time where
the job is enqueued and the time the mailer is run
Fix #3745
2019-04-04 17:32:12 +02:00
pedong
0d7c30c9dd
[ fix #3476 ] add notify email for the dossier change state to instruction
2019-03-25 16:04:33 +01:00
simon lehericey
6607de4827
Notification: add service to send notifications
2019-03-18 16:37:51 +01:00
Mathieu Magnin
dd27167c5d
Enforce Timezone rule in Rubocop
2019-02-18 16:19:42 +01:00
maatinito
8304ce12e1
Make some email previews database-independent
2018-12-20 17:07:03 +01:00
maatinito
e1b97b3303
Make more emails previewable
2018-12-20 17:06:57 +01:00
maatinito
e37372d261
Fix a typo
2018-12-20 16:21:27 +01:00
maatinito
9842142a9a
Add InviteMailerPreview
2018-12-20 16:21:27 +01:00
maatinito
a1a11adb83
[ #325 ] Make the notification layout inherit from the general layout
2018-12-20 16:21:27 +01:00
gregoirenovel
121086eedd
Bump rails
2018-12-04 11:16:42 +01:00
gregoirenovel
478fb88618
Bump capybara (2.18.0 → 3.11.0)
2018-12-04 10:35:13 +01:00
Pierre de La Morinerie
ea8bc0c961
mailers: improve notification layout
2018-11-27 15:51:26 +01:00
Mathieu Magnin
718a30639f
[ Fix #2929 ] Improve readability of invitation for avis
2018-11-23 13:18:36 +01:00
Pierre de La Morinerie
f983bc68e2
mailers: fix dossier mailer spec
2018-11-20 17:45:50 +01:00
Pierre de La Morinerie
a5f9be00e0
mailers: add preview URL to all previewable mailers
2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
f2eaf66a9a
mailers: add missing previews for notification emails
2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
e5303fd986
mailers: streamline the NotificationMailer
...
Notifications are now only for demarche-templated emails.
2018-11-20 14:46:31 +01:00
simon lehericey
5690599289
Session: send a mail to confirm gestionnaire login
2018-11-13 10:41:45 +01:00
simon lehericey
13ffa61435
DateTime.now => Time.zone.now
2018-10-26 10:10:20 +00:00
Pierre de La Morinerie
40cf7ebdcb
mailers: update links to messagerie
2018-09-27 17:22:59 +02:00
Frederic Merizen
ac82a72dcc
[ #1946 ] Monthly expiring dossiers summary mail
2018-09-20 17:44:31 +02:00
gregoirenovel
00ecae5f93
Procédure → Démarche
2018-09-05 15:46:24 +02:00
lucien mollard
b2f2e75f43
mailer: add layout for notifications emails
2018-09-05 15:31:08 +02:00
Pierre de La Morinerie
2a5a8cf621
mailer: fix typo in spec
2018-09-05 15:25:46 +02:00
Pierre de La Morinerie
d7dd027cb8
mailer: improve naming in specs
2018-09-05 15:25:46 +02:00
gregoirenovel
3662b82039
accompagnateur → instructeur
2018-08-29 23:09:08 +02:00
simon lehericey
9c023095da
[ fix #2359 ] Fix link in avis mail for gestionnaire
2018-08-08 13:19:54 +02:00
Pierre de La Morinerie
40aae2e20b
mailers: mention the procedure when notifying about dossier deletion
2018-07-16 15:49:34 +02:00
Pierre de La Morinerie
d6624aeca7
mailers: add tests for dossier_mailer
2018-07-16 15:38:03 +02:00
gregoirenovel
24e37842ee
Fix a typo
2018-06-08 15:14:22 +02:00
Frederic Merizen
65e9025d5d
Add at least minimal test for AdministrationMailer
2018-06-06 16:08:18 +02:00
gregoirenovel
41e8350cbe
[ Fix #1735 ] Sign the admin account creation email
2018-06-01 20:48:50 +02:00
gregoirenovel
b82ed65568
[ Fix #885 ] Convert .text.erb to .html.haml
2018-06-01 17:14:48 +02:00
gregoirenovel
4f2509861b
Improve the wording of the avis email
2018-06-01 15:42:56 +02:00
gregoirenovel
b364b8bfb3
Improve many subjects
2018-06-01 11:35:40 +02:00
gregoirenovel
a57e2388f6
Unify NotificationMailer methods’ signatures
2018-05-31 12:10:06 +02:00
Mathieu Magnin
eb1fbb7dbc
Delete button, notify user and admin then delete dossier
2018-05-30 18:01:36 +02:00
Mathieu Magnin
0f32821b27
Add dossier state to deletion email
2018-05-29 12:16:22 +02:00
Frederic Merizen
cce00e19c6
[ #1972 ] Avoid passing unsaved templates to ActionMailer
...
So that all mail arguments can be serialized
2018-05-28 12:02:13 +02:00
simon lehericey
0b87944368
[ #1915 ] Devise: avoid leaking registered people
2018-05-23 15:55:52 +02:00
simon lehericey
7fed476e29
Welcome Mailer: remove obsolete mailer
2018-05-23 15:55:52 +02:00
simon lehericey
5bd589344e
Devise: confirm user email
2018-05-23 15:55:52 +02:00
Frederic Merizen
5ef129d960
[ #1563 ] Remove attestation mail attachment
2018-05-09 10:42:40 +02:00
Mathieu Magnin
f6d53be873
[ Fix #1799 ] Send automatic emails to improve administrateur activation
2018-04-09 11:08:13 +02:00
simon lehericey
289ddb5419
[ fix #1670 ] Manager send the refused admin email
2018-03-27 16:02:09 +02:00
gregoirenovel
1b8b6a3274
TPS -> demarches-simplifiees.fr
2018-02-28 18:14:06 +01:00
simon lehericey
26c9f28407
Gestionnaire Namespace: fix last_week_overview
2018-02-23 13:45:21 +01:00
simon lehericey
4189a2790d
MailPreview: fix last_week_overview
2018-02-23 13:45:21 +01:00
simon lehericey
377e4d689a
Gestionnaire Namespace: fix send_dossier
2018-02-23 13:45:21 +01:00
simon lehericey
c4cd113fbd
MailPreview: add send_dossier
2018-02-23 13:45:21 +01:00
gregoirenovel
142241dd16
Remove notifications
2018-02-06 14:07:20 +01:00
Mathieu Magnin
839c0e6aa9
Invite admin mail is previewable
2018-01-29 11:08:19 +01:00
gregoirenovel
897a30da0c
Enable the Layout/SpaceInsideBlockBraces cop
2018-01-18 10:53:34 +01:00
Frederic Merizen
56749769d6
[ Fix #1186 ] Rename object to subject for mail templates
2018-01-09 16:00:31 +01:00
simon lehericey
f1b7a03b63
[ fix #1097 ] Add job to monitor procedures
2018-01-09 10:29:54 +01:00
Mathieu Magnin
a8ec374252
[ Fix #813 ] When a brouillon is created, send an email to user
2017-10-20 12:13:55 +02:00
Mathieu Magnin
0f945e2fea
Simplify mailer parameters to be serializable (even if mail_template.id is nil)
2017-10-13 21:27:17 +02:00
Simon Lehericey
e60ce35ae8
[ Fix #196 ] Attestation: join the attestation to the closed mail
...
Add a upper limit to the attachment size as it could be a problem with Mailjet and receiver
(https://www.mailjet.com/support/what-is-the-size-limit-for-attachments-files-sent-via-mailjet,289.htm )
If the attestation cannot be sent, it is logged in sentry
2017-06-16 12:11:10 +02:00
gregoirenovel
24e7537c49
Enable the Layout/EmptyLinesAroundClassBody cop
2017-06-13 10:35:32 +02:00
gregoirenovel
f1907f4d0e
Enable the Layout/EmptyLinesAroundBlockBody cop
2017-06-13 10:35:23 +02:00
gregoirenovel
2a74207d15
you_are_invited_on_dossier -> avis_invitation
...
- shorter
- clearer
2017-06-12 10:53:59 +02:00
gregoirenovel
ec69086ebc
Don’t use alias_method_chain, use a proxy method
2017-06-08 12:22:48 +02:00
Simon Lehericey
64f7cab3cf
Avis: add claimant gestionnaire to track who asks for an avis
2017-05-29 11:44:28 +02:00
Mathieu Magnin
efdac753c6
When an Avis is created an email is sent to the Gestionnaire
2017-05-29 11:44:28 +02:00
Simon Lehericey
8dabdcc6c4
GestionnaireMailer: add a last week report
2017-05-23 17:12:18 +02:00
gregoirenovel
70f637f088
[ Fix #198 ] Add a Commentaire when we send a Notification email to a user
2017-05-12 14:03:48 +02:00
gregoirenovel
ddf02ccd6d
Use a non-breaking space after the “numéro” contraction
2017-04-19 11:19:53 +02:00
gregoirenovel
aa41349f0c
Lowercase the “n” of “numéro” contraction where needed
2017-04-19 11:19:53 +02:00
gregoirenovel
ba4ee68019
Use masculine ordinal indicator instead of the degree sign
...
It’s the right way to contract “numéro”
We should use the superscript lowercase o but
it’s hard to do in places where only raw text is
available
2017-04-19 11:19:53 +02:00
Mathieu Magnin
4ea7635dfc
Fix after review
2017-03-07 16:23:44 +01:00
Simon Lehericey
6c560e65eb
Notification Mailer: use send_notification for all the mails
2017-03-07 10:27:13 +01:00
Simon Lehericey
7b336922cc
Cleaning
2017-03-07 10:25:34 +01:00
Simon Lehericey
65d399b4b0
NotificationMailer: add send notification
2017-03-07 10:25:34 +01:00
Mathieu Magnin
4cc6aedfb9
Fix tests after workflow simplication
2017-02-27 11:56:26 +01:00
Mathieu Magnin
6444aa5be6
Use has_one instead of scope
2017-02-06 16:52:57 +01:00
Mathieu Magnin
b40193e7b5
New customizable mail : mail_validated, new balise --lien_dossier--
2017-01-26 12:12:52 +01:00
Mathieu Magnin
7e24adbca0
Add mail preview and small fix
2017-01-23 15:49:19 +01:00
Mathieu Magnin
29de9b0b55
Simplify mailers development with mailcatcher and previews
2017-01-23 15:41:09 +01:00
Xavier J
21f58c0725
Fix notification Mailer tests
2017-01-03 11:36:08 +01:00
Xavier J
14df85d16d
Change require for notification mailer spec
2016-12-15 17:59:01 +01:00
Xavier J
6f40424979
Change wording "Valider le dossier" to "Déclarer complet"
2016-10-19 11:23:34 +02:00
Xavier J
f03733f3ff
Mail for receive dossier is now send.
2016-09-01 10:27:22 +02:00
Xavier J
a69433e8de
User can be begin without SIRET
2016-08-30 11:18:43 +02:00
Xavier J
f6d3e2d780
Fix test welcome mailer
2016-07-26 15:05:24 +02:00
Xavier J
d7dbd28507
fix test cerfa flag
2016-02-04 14:08:35 +01:00
Xavier J
563e739958
Minor fix bug
2015-12-17 12:53:43 +01:00
Xavier J
ed8b4ff083
Add mailer submitted dossier.
2015-12-17 10:06:40 +01:00
Xavier J
a24ff681fc
- Send email when gestionnaire write a new commentaire
...
- Change url on mail => redirect on dossier recapitulative page
2015-12-15 15:33:21 +01:00
Xavier J
372011e4d6
NotificationMailer : dossier_validated
2015-12-15 11:41:50 +01:00
Xavier J
25937b2635
NotificationMailer : new answer
2015-12-15 11:02:07 +01:00
Xavier J
a65f271a60
Add mailer Welcome
2015-12-14 16:09:20 +01:00