Commit graph

8196 commits

Author SHA1 Message Date
simon lehericey
5cadb70d3a refactor(js): add 'debounced-empty' when there are no more debouncing call 2022-10-25 14:44:43 +02:00
simon lehericey
f4f40ded6c refactor(js): send 'autosave:end' when there are no more pending promises 2022-10-25 14:44:43 +02:00
Kara Diaby
476dd7e699 layout 2022-10-21 19:13:12 +02:00
Kara Diaby
cf8e6a9c67 controller 2022-10-21 19:13:12 +02:00
Kara Diaby
492c7f377f migration 2022-10-21 19:13:12 +02:00
Paul Chavard
f2e8dba8e4 fix(dossier): tag can contain non breaking space 2022-10-21 16:34:19 +02:00
Paul Chavard
d7c5dcf8bb fix(dossier): a tag can be preceded by a - 2022-10-21 16:06:32 +02:00
Paul Chavard
85581e72e9 refactor(turbo): simplify custom actions implementation now that turbo has support for it 2022-10-21 10:24:00 +02:00
Martin
527f416f52 amelioration(archives): documentation de la structure de l'archive
Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>

Update app/views/shared/archives/_notice.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>
2022-10-20 16:40:53 +02:00
simon lehericey
097082afc9 fix(dolist): reduce message name variability 2022-10-20 15:29:56 +02:00
Martin
2cd74d1010 amelioration(archives): positionne le fichier des reporting des erreurs en tête de l'arborescence 2022-10-20 15:14:57 +02:00
Martin
d46efeef85 amelioration(export): clarifier l'usage des exports pour les instructeurs pour eviter le téléchargement des export zip pour de l'archivage 2022-10-20 14:50:48 +02:00
Colin Darie
5b813a25d6 fix(dsfr/callout): don't nest p, it's already declared by component 2022-10-20 09:18:16 +02:00
Colin Darie
e96d307e56 style(admin): auto expiration styled with DSFR callout 2022-10-20 09:18:16 +02:00
Colin Darie
f5a0842c6e style(dsfr): callout component with support for a bottom section like buttons 2022-10-20 09:18:16 +02:00
Colin Darie
7f28f1fe4c fix(conjugaison): après que + indicatif 2022-10-20 09:18:16 +02:00
Colin Darie
45994ff567 fix(invitation): when dossier is not visible anymore
https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/
2022-10-20 09:08:36 +02:00
Paul Chavard
74aa01479b fix(revision): fix changes list style 2022-10-20 06:56:20 +02:00
Martin
576aa2c1e0 amelioration(export): augment la duree de conservation des exports en cours de generation passant de 12 a 16h. augment la duree de conservation des exports generés passant de 16 à 32h 2022-10-20 06:32:41 +02:00
simon lehericey
5fa5d46d8c fix(admin_merge): a case where 2 admins have the same service 2022-10-19 16:54:34 +02:00
Paul Chavard
5be8810da4 fix(dossier): nullify instructeur and expert id on messages when they are deleted
we keep email on the message so it will be used when instructeur or expert are not available
2022-10-19 11:53:10 +02:00
simon lehericey
c6e7db3622 fix(export): bug when combining revision and conditional 2022-10-18 11:53:13 +02:00
simon lehericey
fbf089d60e refactor(dossier): rename check_mandatory_champs -> check_mandatory_and_visible_champs 2022-10-18 11:13:41 +02:00
simon lehericey
9bba2093be refactor(champ): mandatory_blank_and_visible? -> mandatory_blank?
As the method does not check visibility
2022-10-18 11:13:41 +02:00
simon lehericey
6832b12bd4 clean(haml): remove commented code 2022-10-18 11:13:41 +02:00
simon lehericey
7114623285 fix(champ): rewire champ.mandatory? to type_de_champ.mandatory?
it fixes behaviour in drop_down_list_component which add option if not mandatory (!= not required)
2022-10-18 11:13:41 +02:00
simon lehericey
528b7ec3f8 refactor(champ): add required?
used for the `required` html attribute. It check visibility to avoid hidden required input which prevent the form from being sent.
2022-10-18 11:13:41 +02:00
simon lehericey
dc89ddb639 fix(translation): typo in footer 2022-10-17 22:47:42 +02:00
Martin
6000de2095 feat(manager/outdated_procedure): enhance procedure cleanup 2022-10-17 13:35:37 +02:00
Paul Chavard
736e0b0731 fix(routage): fill dossier groupe instructeur in some edge cases 2022-10-14 17:29:56 +02:00
Paul Chavard
c075a4e415 fix(dossier): we should never detroy user’s dossiers in cascade 2022-10-14 14:14:51 +02:00
Paul Chavard
c097f70543 fix(graphql): hide champs based on conditions 2022-10-14 11:33:25 +02:00
simon lehericey
d5d031e15d fix(export): do not export invisible champ 2022-10-14 10:30:27 +02:00
simon lehericey
40a3fff593 perf(dossiers_controller): do not load pj template in update, -10ms 2022-10-13 22:36:56 +02:00
simon lehericey
f8ee6386b9 perf(champ): check condition.present? without json deserializationl, -6ms 2022-10-13 22:36:56 +02:00
simon lehericey
73b4ee64e6 perf(champ_value): use champ_type instead of tdc.type_champ, -22ms 2022-10-13 22:36:56 +02:00
Eric Leroy-Terquem
c6082ded09 no select for usager if only one groupe_instructeur 2022-10-13 19:49:32 +02:00
Martin
d09c47f5ce correctif(usager.fusion): leve une erreur quand on essaie de fusionner un compte sur lui même 2022-10-13 17:00:20 +02:00
Paul Chavard
25c774b3a1 refactor(dossier): extract dossier edit footer into a component 2022-10-13 14:44:46 +02:00
Paul Chavard
d409b6f4ef feat(dossier): do not save dossier on submit 2022-10-13 14:44:46 +02:00
Paul Chavard
78a1323fc2 refactor(dossier): move dossier submit action in to a new form 2022-10-13 14:44:46 +02:00
Paul Chavard
dd38fa4458 refactor(spec): add wait_for_autosave helper 2022-10-13 14:44:46 +02:00
Colin Darie
e2e9ddd625 style(conditionnel): dsfr button styles 2022-10-13 10:17:21 +02:00
Colin Darie
8153f33896 style(repetition): fix button styles 2022-10-13 10:17:21 +02:00
Colin Darie
9571e9481d style(avis): fix font sizes & colors due to h2 strongly styled 2022-10-12 14:41:31 +02:00
Paul Chavard
1fd1878370 feat(jobs): add request_id to jobs payload 2022-10-12 14:32:23 +02:00
Paul Chavard
7f1dd49bdc chore(flipper): always use feature_enabled? helper 2022-10-12 14:14:30 +02:00
Paul Chavard
0f192fd752 chore(flipper): add feature_enabled? to components 2022-10-12 14:14:30 +02:00
Damien Le Thiec
29a97fac43
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-11 18:59:45 +02:00
Damien Le Thiec
0e995c8bcc
Update app/models/champs/rna_champ.rb
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2022-10-11 16:34:00 +02:00
simon lehericey
7672ad3fe9 fix(editor champ): do not raise on destroy replay 2022-10-11 16:27:49 +02:00
Damien Le Thiec
73f6063c87
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-11 15:36:46 +02:00
Damien Le Thiec
2e8c0512a5 Remove skip_cleanup option 2022-10-11 15:11:51 +02:00
Colin Darie
073656342e fix(api_address): support Adresse BAN without postcode
Des adresses n'ont pas de code postal (dans certains TOM par exemple).
On fallback sur un string vide plutôt que nil pour limiter les effets de bord.
2022-10-11 12:25:12 +02:00
Damien Le Thiec
bcdc9c18ae Remove skip_fetch_data mechanism 2022-10-11 11:52:59 +02:00
simon lehericey
97529ab6af refactor(user dossier): move ruby logic to controller 2022-10-11 11:39:05 +02:00
simon lehericey
32e01b13ef refactor(user dossier): mutualize update/update_brouillon 2022-10-11 11:39:05 +02:00
simon lehericey
437ac44143 perf(user dossier): batch hide/show element finding 2022-10-11 11:39:05 +02:00
Paul Chavard
a19bf050ef fix(iban): format iban after validation 2022-10-11 10:43:32 +02:00
Colin Darie
a9f2bec636 style(css): add deprecation rules and TODO
Co-authored-by: mfo <mfo@users.noreply.github.com>
2022-10-11 09:50:21 +02:00
Colin Darie
59b9ae5c46 TODO: deprecate CSS containers
Co-authored-by: mfo <mfo@users.noreply.github.com>
2022-10-11 09:50:21 +02:00
Colin Darie
03de58c7e2 fix: download link with empty value, otherwise it could be used to name the file 2022-10-11 09:50:21 +02:00
Colin Darie
df672fb493 fix(footer): etalab link with rel=noopener 2022-10-11 09:50:21 +02:00
Colin Darie
d821a3e40c style(new_session): fix buttons style 2022-10-11 09:50:21 +02:00
Colin Darie
9992ab9e09 style(admin): new procedure btn styles 2022-10-11 09:50:21 +02:00
Colin Darie
3e8f040d49 style(usager/dossier): fix summary actions style 2022-10-11 09:50:21 +02:00
Colin Darie
10802d15cc style(instructeur/procedure): re-style header procedure title & dossier number 2022-10-11 09:50:21 +02:00
Colin Darie
c5092fda12 style(expert): fix avis weight/font-size 2022-10-11 09:50:21 +02:00
Colin Darie
df1d7ae2bd style(procedures): dsfr compat instructeurs/expert procedures list 2022-10-11 09:50:21 +02:00
Colin Darie
0480a0336d fix(scss): lint errors 2022-10-11 09:50:21 +02:00
Colin Darie
fa9bc5d185 style(admin): multiple style improvements, essentially links & buttons 2022-10-11 09:50:21 +02:00
Colin Darie
0a2460ba71 style(admin): fix various links / buttons style 2022-10-11 09:50:21 +02:00
Colin Darie
fd3b30d8e6 style(messagerie): improve font-size & styles 2022-10-11 09:50:21 +02:00
Colin Darie
278b58ef78 style(instructeurs): restyle dossier actions 2022-10-11 09:50:21 +02:00
Colin Darie
0e1077487a style(autosave): better font-size & link style 2022-10-11 09:50:21 +02:00
Colin Darie
2ab5fbbb24 style(link): use DSFR underline style everywhere possible.
Par conséquent on commence à remplacer d'anciens "liens-boutons" (qui
auraient récupéré un souligné indésirable), par un vrai boutton dsfr.

Le hack fr-underlined n'est aussi plus nécessaire.
2022-10-11 09:50:21 +02:00
Colin Darie
555c796d19 style(forms): increase forms elements font-size to legacy value & fieldset style 2022-10-11 09:50:21 +02:00
Colin Darie
71996af65b style(avis): use fr-badge for count instead of broken css 2022-10-11 09:50:21 +02:00
Colin Darie
7dd3a42cd7 fix(style): tabs 2022-10-11 09:50:21 +02:00
Colin Darie
72e79eb2d3 fix(css): don't duplicate font declarations from DSFR.
This may cause issues in exact font height computation & underline effect.
2022-10-11 09:50:21 +02:00
Colin Darie
aea2733be1 refactor(css): more landing + new_footer cleanup 2022-10-11 09:50:21 +02:00
Colin Darie
be367503cf fix(footer): add missing title attribute on a 2022-10-11 09:50:21 +02:00
Colin Darie
8bd36921e0 style(footer): drop useless br since we now have a default margin-bottom on p 2022-10-11 09:50:21 +02:00
Colin Darie
10917af523 style: signin button styled accordingly to UX 2022-10-11 09:50:21 +02:00
Colin Darie
5c36c2e317 style(landing): update after reset CSS drop 2022-10-11 09:50:21 +02:00
Colin Darie
08c207e0e4 refactor(scss): remove legacy reset + generic rules, refactor imports 2022-10-11 09:50:21 +02:00
Colin Darie
5a50383a27 style: download links (notice & template) with expected DSFR design & details
Closes #7829
2022-10-11 09:50:21 +02:00
Colin Darie
1e9d5b753c refactor(footer): licence sentence in partial 2022-10-11 09:50:21 +02:00
Colin Darie
36589c186c style(colors): fix exact colors for some DSFR components like footer links 2022-10-11 09:50:21 +02:00
Colin Darie
cf4ac28735 style(stats): button with more space + dsfr 2022-10-11 09:50:21 +02:00
Colin Darie
2d7eca9dd2 feat(combo): debounce only with address / autocomplete binded on API 2022-10-10 21:09:30 +02:00
Paul Chavard
402d0dd3db
Revert "refactor(react): useDeferredValue"
This reverts commit cd4d7b5d36.
2022-10-10 17:36:33 +02:00
simon lehericey
157c3778df refactor(dossier_preloader): add option to laod pj_template 2022-10-10 12:31:40 +02:00
simon lehericey
7e03f0c825 refactor(dossier_preloader): add load_one api 2022-10-10 12:31:40 +02:00
simon lehericey
5920168077 refactor(dossier_preloader): preload piece_justificative_template 2022-10-10 12:31:40 +02:00
simon lehericey
1f95f68fcc refactor(dossier_preloader): assign champ.parent 2022-10-10 12:31:40 +02:00
simon lehericey
5df76d9fec refactor(dossier_preloader): remove weird set_inverse_instance 2022-10-10 12:31:40 +02:00
simon lehericey
f32b05e8b4 perf(dossier controller): use DossierPreloader 2022-10-10 12:31:40 +02:00
Martin
c921e6e1ee fix(ProcedureExportService): downloadable_sorted_batch is scoped by export, no need to re-filter them via downloadablable_sorted_batch otherwise export for supprimes_recemment does not includes dossier.supprimes_recemment 2022-10-10 11:11:21 +02:00
Eric Leroy-Terquem
1177d861f4 add validation on routing_criteria_name 2022-10-10 09:48:11 +02:00
Martin
1f8bf201a2 feat(procedure_serializer): just add an empty string for direction 2022-10-07 18:39:17 +02:00
Martin
6752da40a9 test(procedure.direction): can we drop this column ? 2022-10-07 18:39:17 +02:00
simon lehericey
ceaf8ebbe7 fix: orphan tdc due to reset_draft 2022-10-07 17:44:30 +02:00
krichtof
44018a86de a procedure without zone is finally valid 2022-10-07 16:59:12 +02:00
simon lehericey
f54407aa1e fix: last_week_overview 2022-10-07 13:56:05 +02:00
simon lehericey
e86375046b fix: label in linked_drop_down 2022-10-07 13:56:05 +02:00
simon lehericey
3dc0ed7695 fix: label in multiple_drop_down_list 2022-10-07 13:56:05 +02:00
simon lehericey
87d0334c1c fix: label in champ component 2022-10-07 13:56:05 +02:00
Christophe Robillard
272c8cae09 cannot publish a procedure if no zones 2022-10-07 10:48:35 +02:00
Christophe Robillard
bdcb451d3c procedure publiee must have one zone at least 2022-10-07 10:48:35 +02:00
Christophe Robillard
2985295a00 use normal font weight for checkbox labels 2022-10-07 10:48:35 +02:00
Christophe Robillard
a6928e7ca2 add ZonesComponent 2022-10-07 10:48:35 +02:00
Christophe Robillard
4d2c37ffdf extract checkboxes zones to dedicated page 2022-10-07 10:48:35 +02:00
Christophe Robillard
94ca93e130 can choose multiple zones 2022-10-07 10:48:35 +02:00
Christophe Robillard
bffd9d61a9 add habtm between procedures and zones 2022-10-07 10:48:34 +02:00
simon lehericey
0e75f9960b fix: send_dossier_decision preview 2022-10-06 17:43:09 +02:00
simon lehericey
9aeaddcb40 perf: remove one query on invite dropdown 2022-10-06 17:17:27 +02:00
Martin
a256dfbaa0 fix(spec): missed a failed spec previously. sorry 2022-10-06 15:34:29 +02:00
mfo
8a3550cda4
Merge pull request #7860 from mfo/US/procedure-duree-up-to-manager
feat(procedure.max_duree_conservation_dossiers_dans_ds): make it more flexible
2022-10-06 11:36:50 +02:00
mfo
e76b97fcb5
Merge pull request #7862 from mfo/US/cleanup-other-col
clean(procedure.columns): :durees_conservation_required, :cerfa_flag, :test_started_at
2022-10-06 11:36:00 +02:00
Martin
883ba8717f clean(procedure.columns): :durees_conservation_required, :cerfa_flag, :test_started_at 2022-10-05 18:03:49 +02:00
Martin
405a885160 feat(procedure.max_duree_conservation_dossiers_dans_ds): make it more flexible 2022-10-05 17:27:09 +02:00
Damien Le Thiec
abbbef1461 Fix tests 2022-10-05 13:07:39 +02:00
Damien Le Thiec
a3468fca27
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-05 12:54:31 +02:00
Damien Le Thiec
0131a41266
Merge branch 'main' into feature/add_rna_type_de_champs 2022-10-05 12:38:24 +02:00
krichtof
92807edd03 fix zone labels when building a new procedure 2022-10-05 12:37:08 +02:00
Damien Le Thiec
93e89c8968 Fix small bugs rna controller and add tests 2022-10-05 12:31:34 +02:00
Paul Chavard
432c4690b5 feat(tags): replace regexp based parser with a parser combinator 2022-10-05 11:25:37 +02:00
Damien Le Thiec
776736fe5a Fix rights view RNA champ data 2022-10-05 09:46:15 +02:00
Eric Leroy-Terquem
ff2e9f0816 add feature flag 2022-10-05 09:21:08 +02:00
Eric Leroy-Terquem
acd874ccdf reorder inside categories 2022-10-05 09:21:08 +02:00
Eric Leroy-Terquem
6925ca66e6 add grouped options for select 2022-10-05 09:21:08 +02:00
Damien Le Thiec
0d9f02c88d First draft autofetch data for RNA 2022-10-04 22:11:01 +02:00
Damien Le Thiec
ecd54de854 Extend RNA adapter while keeping depreciated version 2022-10-04 19:59:39 +02:00
Damien Le Thiec
e694ff1f60 Fix update external id after validation 2022-10-04 17:19:16 +02:00
Martin
54a47fadae fix(sentry/3422144920): old email using TargetUserLink creates confusing errors 2022-10-04 11:41:32 +02:00
Paul Chavard
78d4abfb3d chore(js): remove CheckConditionsController 2022-10-04 10:59:23 +02:00
Kara Diaby
057c951408 fixe une typo remontée par le support 2022-10-04 12:11:19 +04:00
Martin
7125e8538a clean(engagement): remove last pieces of engagement champs 2022-10-04 07:17:47 +02:00
simon lehericey
77289b7a80 perf(admin_procedure_controller): same with publication page 2022-10-03 20:49:38 +02:00
simon lehericey
7af248b4bf perf(admin_procedure_show): use partial with collection 2022-10-03 20:49:38 +02:00
simon lehericey
e043725d51 refactor(admin_procedure_controller): simplify AR include 2022-10-03 20:49:38 +02:00
simon lehericey
adbb655a4a perf(procedure edition): validate only once to avoid reload tdc with n+1 2022-10-03 20:49:38 +02:00
simon lehericey
122c8107a5 fix(web_graphql): fix graphql web playground authorization 2022-10-03 18:08:03 +02:00
simon lehericey
6a5a82ce06 fix(instructeur dashboard): dossiers filtered on multiple states 2022-10-03 15:18:46 +02:00
Martin
19bac6339c fix(multiple_drop_down_list): iterate over selected options not to_s 2022-09-30 12:24:00 +02:00
Martin
aceb8996c1 feat(instructeur/procedure#show): enhance sort by notifications as planned by UX
Update app/javascript/controllers/checkbox_controller.ts

Co-authored-by: Paul Chavard <github@paul.chavard.net>
2022-09-30 10:29:51 +02:00
Christophe Robillard
da0738c661 unschedule export demarches opendata 2022-09-30 07:26:48 +02:00
Paul Chavard
462cc41caa refactor(block): use block? instead of repetition? 2022-09-29 17:49:14 +02:00
simon lehericey
7a9c5e8d19 refactor(ujs): turbo use an id for turbo_stream.update id not a class 2022-09-29 17:04:15 +02:00