DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
22935 commits 2 branches 1166 tags 85 MiB
Commit graph

108 commits

Author SHA1 Message Date
Pierre de La Morinerie
4cb747fdb6 specs: always require rails_helper 
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
 2020-03-31 12:48:32 +02:00
Pierre de La Morinerie
7ba76c6658 dossier: add a notice when some attachments of the dossier were lost 
On the 22/01/2020, a technical error on the demarches-simplifees.fr
instance made us delete some files attached to some dossiers.

This PR adds a warning when browsing a dossier containing attachments
that were deleted.
 2020-02-12 11:49:33 +01:00
Pierre de La Morinerie
c7a307553c helpers: allow dossier_display_state to take a state as input 
This allow to use either:

- `dossier_display_state(dossier)`
- `dossier_display_state(:en_construction)`
 2019-12-19 13:22:40 +01:00
Paul Chavard
7b947feae4 Rename demarche archivée to demarche close 2019-11-28 15:07:16 +01:00
simon lehericey
90ae4181bf fix dossier_linked_path in routed procedure 2019-10-23 21:47:20 +02:00
simon lehericey
b541ef0b41 Procedure has many instructeurs with defaut_groupe_instructeur 2019-09-02 11:41:12 +02:00
Paul Chavard
cc35a04e26 Migrate procedure logo to active_storage 2019-08-21 11:15:00 +02:00
simon lehericey
3fde2a6f70 Rename gestionnaire in code to instructeur 2019-08-12 13:47:01 +02:00
Pierre de La Morinerie
0c4cb3b498 admin: remove UI for managing old pj 2019-07-30 16:11:16 +02:00
Nicolas Bouilleaud
fac20ed190 Fix Commentaire factory so that the default case creates a valid object 2019-07-08 16:13:43 +02:00
pedong
abcd58c35d [fix #3710] date with letter 
Co-Authored-By: simon lehericey <mail@simon.lehericey.net>
 2019-06-12 17:48:12 +02:00
Mathieu Magnin
8525761332 Revert english dates 2019-04-02 14:38:47 +02:00
pedong
fb29d30826 [fix #3342] show date with format letter 2019-03-27 15:27:20 +01:00
Frederic Merizen
a8ce11a4d2 Add rel=noopener to links with target=_blank 
http://support.detectify.com/customer/portal/articles/2792257-external-links-using-target-_blank-
 2019-03-05 18:25:26 +01:00
gregoirenovel
b4781f7440 Make dossier link clickable for users in the Demande tab 2019-01-08 12:32:27 +01:00
gregoirenovel
f5a31be36a Remove the now useless #formatted_value method 2019-01-08 12:32:26 +01:00
gregoirenovel
9466442aff Remove the TypeDeChamp decorators 2019-01-03 12:08:25 +01:00
gregoirenovel
9c130c41da Remove ProcedureDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
b41764ec03 Remove ChampDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
186e362701 Enable the Layout/SpaceInsideArrayLiteralBrackets 2019-01-03 10:53:50 +01:00
gregoirenovel
df7e0a9881 Remove dead code 2018-12-19 14:59:15 +01:00
Paul Chavard
0fe59a7c65 Add dossier_legacy_state helper 2018-11-08 14:56:45 +01:00
Paul Chavard
f09a7a01c8 Add dossier_display_state helper 2018-11-08 14:56:45 +01:00
Paul Chavard
1c87eda6e1 Move types_de_champ helper to service 2018-11-07 11:36:10 +01:00
simon lehericey
26ae29ea52 Time.local => Time.zone.local 2018-10-26 10:10:20 +00:00
simon lehericey
13ffa61435 DateTime.now => Time.zone.now 2018-10-26 10:10:20 +00:00
gregoirenovel
c8f872c566 InviteUser → Invite 2018-10-10 12:07:10 +02:00
gregoirenovel
98d348aab1 Remove the delete demarche feature for admins 2018-10-09 16:42:32 +02:00
Pierre de La Morinerie
f007eaa2ee dossier: enable new UI by default 2018-10-02 12:23:53 +02:00
Pierre de La Morinerie
926dc3e107 dossier: display latest message on summary page 2018-09-12 10:09:16 +02:00
Pierre de La Morinerie
968952ff46 Reorder a test to prepare for a future one 2018-09-12 10:09:16 +02:00
Pierre de La Morinerie
353ab812fc messagerie: fix 'Invité' label in message sender 2018-09-07 12:02:26 +02:00
Pierre de La Morinerie
211674435e messagerie: better format message dates 2018-09-07 12:02:26 +02:00
gregoirenovel
5ac8117c69 DossierController#modifier → #brouillon 2018-09-07 10:19:10 +02:00
gregoirenovel
00ecae5f93 Procédure → Démarche 2018-09-05 15:46:24 +02:00
gregoirenovel
75ee41b7fa [Fix #2494] Improve deletion warning text 2018-08-31 15:41:51 +02:00
Frederic Merizen
559d080ca6 [#1946] Show data retention time in footer 2018-08-30 18:03:01 +02:00
gregoirenovel
4b071ecf06 Use enum to the fullest with Dossier.states 2018-08-29 17:31:08 +02:00
gregoirenovel
2d3b553e4d Use enum to the fullest with TypeDeChamp.type_champs 2018-08-29 17:31:08 +02:00
Pierre de La Morinerie
33c743ab77 helper: simplify DossierHelper.url_for_dossier 
The argument is never an Invite
 2018-07-04 11:43:39 +02:00
Pierre de La Morinerie
148dc164f7 dossiers: generate the correct link to see the dossier details 2018-07-02 13:58:58 +02:00
Mathieu Magnin
e694e7f9b9 [Fix #2145] When procedure is archived, usager should see a message explaining dossier submission is closed 2018-07-02 11:10:34 +02:00
Frederic Merizen
52bb40ab20 [#1946] Show retention times in procedure administration summary 2018-06-01 17:35:04 +02:00
Mathieu Magnin
152cf03d72 [Fix #1801] rename and move html_formatted_description in a generic helper 2018-05-24 18:05:00 +02:00
Paul Chavard
3f249d6663 Remove unused decorators 2018-05-24 17:54:51 +02:00
Paul Chavard
45019ce75c Use Flipflop instead of Feature 2018-04-18 16:51:21 +02:00
Mathieu Magnin
8c1c2f32ca [Fix #1724] Ensure that printed json is safe 2018-04-04 14:00:50 +02:00
simon lehericey
28c4dde96d _explication: display champ.description instead of champ.value 2018-03-01 11:25:57 +01:00
simon lehericey
9db5e82b41 Gestionnaire: move avis_path to gestionnaire_avis_path 2018-02-22 17:02:20 +01:00
simon lehericey
0dc101e375 Gestionnaire: move dossier_path gestionnaire_dossier_path 2018-02-22 17:02:20 +01:00
gregoirenovel
93d8470321 Put the piece justificative champ behind a feature flag 2018-02-15 12:04:03 +01:00
Mathieu Magnin
d945001e0a [Fix #1302] sanitize_url can deal with nil values 2018-01-18 17:35:19 +01:00
gregoirenovel
d30ea70c08 Enable the Layout/SpaceInsideParens cop 2018-01-18 10:53:35 +01:00
Mathieu Magnin
5c46db3b3d Improve messagerie readability 2017-12-15 11:01:48 +01:00
Mathieu Magnin
8e67e5c057 [Fix #1016] display notifications for new messages 2017-12-14 13:57:19 +01:00
Frederic Merizen
21bb04d74e [fix #1066] Fix links to related dossier for experts 
- link to full dossier if gestionnaire is affected on procedure
- link to avis if avis expert requested on related dossier
 2017-12-13 10:28:16 +00:00
gregoirenovel
04d17a2ed0 [Fix #1078] Fix a crasher in HtmlToStringHelper 2017-12-12 10:06:50 +01:00
Simon Lehericey
a05217b364 [fix #1014] strip html tags in annotations_privees 2017-12-11 12:40:12 +01:00