Commit graph

3413 commits

Author SHA1 Message Date
gregoirenovel
1c295eafb6
Merge pull request #1246 from betagouv/unless
Unless
2018-01-15 09:53:24 +01:00
gregoirenovel
22e58a5346 Detect code that could use #present? with rubocop 2018-01-15 09:45:31 +01:00
gregoirenovel
3593adbe66 !foo.empty? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
aedafbaf2e !foo.blank? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
bbaebe0602 !foo.nil? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
3dd03a04cd Detect unless/else patterns with rubocop 2018-01-12 11:32:43 +01:00
gregoirenovel
7c34807f46 Don’t use unless 2018-01-12 11:32:43 +01:00
Frederic Merizen
8c73851cec
Merge pull request #1242 from betagouv/fix_1209-date_de_depot_in_received_mail
Fix 1209 date de depot in received mail
2018-01-11 16:51:44 +01:00
Frederic Merizen
fcb8fb5935 [Fix #1209] test that en_construction is set for initiated mail 2018-01-11 16:47:06 +01:00
Frederic Merizen
ca642abda8 [#1209] Actually put dossier in brouillon state 2018-01-11 16:47:06 +01:00
Frederic Merizen
8807763561 [#1209] Make submission side-effect more explicit 2018-01-11 16:47:06 +01:00
Frederic Merizen
f6986c4db3 [#1209] Clean up formatting 2018-01-11 16:47:06 +01:00
Frederic Merizen
b006db1402 [#1209] remove unused test code 2018-01-11 16:47:06 +01:00
gregoirenovel
f337d95b52
Merge pull request #1235 from betagouv/improve_procedure_champs_readability_in_manager
In manager display libelles with line breaks
2018-01-11 11:19:30 +01:00
Mathieu Magnin
e3ec8643db In manager display libelles with line breaks 2018-01-11 11:03:34 +01:00
LeSim
49d5f276ae
Merge pull request #1210 from betagouv/fix_1209-date_de_depot_in_received_mail
[#1209] Make sure date de dépôt is available before sending mail
2018-01-10 18:42:19 +01:00
Frederic Merizen
32be8213da [#1209] Make sure date de dépôt is available before sending mail 2018-01-10 18:31:55 +01:00
Mathieu Magnin
bcf3246e89
Merge pull request #1212 from betagouv/improve_whitelisting
Improve whitelisting
2018-01-10 18:28:15 +01:00
Mathieu Magnin
f772adc582 Add flash when procedure is whitelisted 2018-01-10 18:17:05 +01:00
Mathieu Magnin
1ebaab51de Show procedure.whitelisted_at in administrate 2018-01-10 18:17:05 +01:00
Mathieu Magnin
4c0592d631 Rails-ish route 2018-01-10 18:17:05 +01:00
LeSim
36d8f4e056
Merge pull request #1211 from betagouv/abstraction
Abstract the Procedure whitelisting
2018-01-10 18:11:41 +01:00
gregoirenovel
608a8eaf67 Abstract the Procedure whitelisting 2018-01-10 17:58:10 +01:00
gregoirenovel
4f2ac6ac2e
Merge pull request #1208 from betagouv/org-rename
Handle the GitHub org rename: sgmap -> betagouv
2018-01-10 17:46:12 +01:00
gregoirenovel
289461d708 Handle the GitHub org rename: sgmap -> betagouv 2018-01-10 17:26:25 +01:00
gregoirenovel
e2bcace4ff
Merge pull request #1207 from betagouv/easier_whitelist
Easier whitelist
2018-01-10 17:24:46 +01:00
Simon Lehericey
6f0c3ebc11 Whitelist: send the alert mail to equipe 2018-01-10 17:18:44 +01:00
simon lehericey
53687bf84a Whitelist: add whitelist button in admin 2018-01-10 17:18:44 +01:00
Simon Lehericey
202d0489a1 Whitelist: links from mail to admin 2018-01-10 17:18:44 +01:00
Mathieu Magnin
fa2613c682
Merge pull request #1206 from betagouv/fix_optional_assets_precompilation
[Fix #1205] Assets precompilation is forced during deployment
2018-01-10 15:41:49 +01:00
Mathieu Magnin
748b273496 [Fix #1205] Assets precompilation is forced during deployment 2018-01-10 15:32:52 +01:00
Mathieu Magnin
be386a3870
Merge pull request #1194 from sgmap/fix_1098
Administrate
2018-01-10 13:53:41 +01:00
Mathieu Magnin
440c2b5dd1 [Fix #1098] add administrate custom layout to add logout link 2018-01-10 13:44:02 +01:00
Mathieu Magnin
d8d2ecf515 [Fix #1098] Administrateur dashboard 2018-01-10 13:44:02 +01:00
Mathieu Magnin
c7b3bb0733 [Fix #1098] Custom TypesDePieceJustificativeField for Administrate 2018-01-10 13:44:01 +01:00
Mathieu Magnin
51b94e2f53 [Fix #1098] Custom TypesDeChampCollectionField for Administrate 2018-01-10 13:44:01 +01:00
Mathieu Magnin
65f0859357 [Fix #1098] Using custom views to remove edit and delete button from index
This can be reverted when Administrate gem will include this fix : https://github.com/thoughtbot/administrate/pull/597 (>=0.5.0)
2018-01-10 13:44:00 +01:00
Mathieu Magnin
d0de9b9ae2 [Fix #1098] Add procedures dashboard 2018-01-10 13:44:00 +01:00
Mathieu Magnin
b2b26b73ab [Fix #1098] Add administrate gem 2018-01-10 13:44:00 +01:00
LeSim
61d9bc2095
Merge pull request #1204 from sgmap/fix_1033_champ_position
Fix 1033 champ position
2018-01-10 13:36:05 +01:00
Simon Lehericey
1473577131 [fix #1033] Procedure Edition: add position field to order the champs 2018-01-10 13:27:22 +01:00
Simon Lehericey
78739ccc6f Spec: rename spec file to match code filename 2018-01-09 16:45:16 +01:00
gregoirenovel
c3f46f817d
Merge pull request #1202 from sgmap/simplify-mail-factory
Simplify factory girl configuration for mail templates
2018-01-09 16:31:14 +01:00
Frederic Merizen
9afdb4c2c4 Simplify factory girl configuration for mail templates 2018-01-09 16:24:00 +01:00
gregoirenovel
8d6d8026a6
Merge pull request #1201 from sgmap/fix_1186-rename_object_to_subject
[Fix #1186] Rename object to subject for mail templates
2018-01-09 16:14:15 +01:00
Frederic Merizen
56749769d6 [Fix #1186] Rename object to subject for mail templates 2018-01-09 16:00:31 +01:00
gregoirenovel
a6735c5acd
Merge pull request #1200 from sgmap/fix_typo_in_readme
Readme: fix typo
2018-01-09 15:55:10 +01:00
Simon Lehericey
81b3b3b0f9 Readme: fix typo 2018-01-09 15:51:07 +01:00
Frederic Merizen
4c0d8042d3
Merge pull request #1190 from sgmap/remove_mail_templates_table
Drop MAIL_TEMPLATES table
2018-01-09 15:32:46 +01:00
Frederic Merizen
39a138e48d Drop MAIL_TEMPLATES table
it’s not used since 695dc16b8 / 335caed65e anymore
2018-01-09 15:28:16 +01:00