Commit graph

8350 commits

Author SHA1 Message Date
LeSim
cf6c33b9b5
Merge pull request #4224 from betagouv/fix_flaky_spec
fix flaky spec in ip_service_spec
2019-08-20 16:48:09 +02:00
simon lehericey
eb2ebee16e fix flaky spec in ip_service_spec 2019-08-20 16:41:32 +02:00
LeSim
3330b9550f
Merge pull request #4220 from betagouv/update_nokogiri
Mise à jour de la Gem Nokogiri
2019-08-20 15:02:21 +02:00
LeSim
9f481e3a4d
Merge pull request #4218 from betagouv/fix_after_party_task
Corrige une tache after party
2019-08-20 14:44:02 +02:00
simon lehericey
69c1734b3e bump nokogiri 2019-08-20 14:40:14 +02:00
simon lehericey
bf3dd319c1 Task: catch various exception 2019-08-20 14:37:35 +02:00
LeSim
9ba3de65de
Merge pull request #4205 from betagouv/remove-old-after-parties
Remove nonworking after_party rake tasks
2019-08-20 14:06:15 +02:00
Nicolas Bouilleaud
e27fbf1a95 Remove nonworking after_party rake tasks
These tasks mention symbols that have been renamed or removed. (Gestionnaire, Procedure.administrateur (single), or VirusScan.)

They won’t be run again.

I guess some (most) of the other after_party and rake tasks could be removed too; it’s just that those prevent `rake after_party:run` to execute on a clean install.
2019-08-20 14:01:38 +02:00
LeSim
28656cbad7
Merge pull request #4212 from philemon95/patch-3
retrait d'un s
2019-08-20 14:00:15 +02:00
Philémon
0528026631 retrait d'un s
par souci de cohérence entre "satisfaction usagerø" et "contact usagerø" :) 
la bise!
2019-08-20 13:53:24 +02:00
Philémon
e6e0f5ed31 changement de wording
changement de wording "Connectez-vous pour donner votre avis" > "Cliquez ici pour donner votre avis", ça permet de clarifier (sinon les usagers peuvent penser que c'est le lien pour se connecter à ds (/sign_in).
c'est le fruit de discussion avec des admin :)
2019-08-20 13:53:24 +02:00
LeSim
3a1f17cce8
Merge pull request #4033 from pengfeidong/lock_account_by_brute_force_attack_use_rack_attack
add Gem rack_attack for prevent attack brute-force
2019-08-20 13:45:01 +02:00
simon lehericey
86d968bb8e Use rack_attack_enabled?
We cannot enable rack attack during the tests as it interferes with features spec.
So we add a flag to enable it during the runtime.
2019-08-20 13:29:29 +02:00
simon lehericey
0f0fecdb25 RackAttack: use remote ip and test it ! 2019-08-20 13:29:29 +02:00
simon lehericey
b7f8bb2fea Simplify ip_service 2019-08-20 13:29:29 +02:00
pedong
fc8cebd78d add Gem rack_attack for prevent attack brute-force 2019-08-20 13:29:29 +02:00
LeSim
cab5b5cd9b
Merge pull request #4211 from betagouv/simplify_role_creation
Simplifie la création de role instructeur ou administrateur
2019-08-20 12:25:06 +02:00
simon lehericey
e0e29d741f Simplify instructeur and administrateur factory 2019-08-20 12:20:12 +02:00
simon lehericey
c1a622efa1 Add User.create_or_promote_to_administrateur 2019-08-20 12:20:12 +02:00
simon lehericey
01a91e68ca Simply avis controller 2019-08-20 12:20:12 +02:00
simon lehericey
98a24bea51 Simplify invite_instructeur 2019-08-20 12:20:12 +02:00
simon lehericey
97d0855d47 add User.create_or_promote_to_instructeur 2019-08-20 12:20:12 +02:00
LeSim
132900cca2
Merge pull request #4213 from betagouv/fix_manager_reset_password
Corriger un bug dans le manager concernant le reset de password
2019-08-20 12:17:37 +02:00
simon lehericey
e913b01c52 fix_manager_reset_password 2019-08-20 12:12:20 +02:00
LeSim
a455836498
Merge pull request #4214 from betagouv/fix_manager_delete_admin
Corrige la suppression d'un administrateur par une administration
2019-08-20 12:07:50 +02:00
simon lehericey
ebe871819d Fix admin deletion by an administration 2019-08-20 12:01:36 +02:00
LeSim
6e83f3d524
Merge pull request #4215 from betagouv/fix_procedure_presentation
Corrige un bug dans le filtre de la vue instructeur
2019-08-20 11:33:33 +02:00
simon lehericey
77c11d8b79 fix_procedure_presentation 2019-08-20 11:28:18 +02:00
Paul Chavard
19bf1bebaf
Merge pull request #4203 from tchak/remove-commentaire-file-uploader
Remove commentaire file uploader
2019-08-20 10:29:42 +02:00
Paul Chavard
e9ba7700d4 Remove commentaire file uploader 2019-08-20 10:24:13 +02:00
Paul Chavard
522d45839b
Merge pull request #4209 from betagouv/cleaning
Cleaning
2019-08-20 10:23:50 +02:00
Paul Chavard
78b0650ef0
Merge pull request #4210 from betagouv/cleaning_user_session
Nettoyage du Controller de Session
2019-08-20 10:17:43 +02:00
simon lehericey
80cb8b87fe Keep only the FC logic and use devise for the rest 2019-08-16 16:48:22 +02:00
simon lehericey
54d7effe28 Spec: specify france_connect logic 2019-08-16 16:48:22 +02:00
simon lehericey
9c715b2969 SessionController: new User in view 2019-08-16 16:48:22 +02:00
simon lehericey
416a07d2dd SessionView: simplify 2019-08-16 16:48:22 +02:00
simon lehericey
27085af9b5 SessionController: remove remember_me
It is somehow taken care by warden
2019-08-16 16:48:22 +02:00
simon lehericey
002510d5cb SessionController: remove complicated try_to_authenticate 2019-08-16 16:48:22 +02:00
simon lehericey
4be9c79e03 Spec : specify remember me 2019-08-16 16:48:22 +02:00
simon lehericey
67cc2c1a87 SessionController: remove instructeur_signed_in? 2019-08-16 16:48:22 +02:00
simon lehericey
a3b9bf90d4 SessionController: remove useless code
- the redirection of a locked user is made by the sign_in method
- because of the paranoid mode it displays the devise.failure.invalid error message
2019-08-16 16:48:22 +02:00
simon lehericey
08bb393ced Spec: specify locked logic 2019-08-16 16:48:22 +02:00
simon lehericey
1b14d85c77 Rerender if wrong credentials 2019-08-16 16:48:22 +02:00
simon lehericey
9a6b3c3757 Spec: specify the redirections when logged in 2019-08-16 16:48:22 +02:00
simon lehericey
56d34173e6 Spec: remove multi devise account tests 2019-08-16 12:04:54 +02:00
simon lehericey
95cd301d0d Spec: remove superfluous code 2019-08-16 11:47:53 +02:00
simon lehericey
f87e316a5d Spec: remove outdated trusted_device logic
This is tested on the application controller
2019-08-16 11:45:40 +02:00
simon lehericey
dab1519b8c Remove credenticals synchronisation logic 2019-08-16 11:35:19 +02:00
simon lehericey
58ecf18390 ActivateController: add tests and clean a bit 2019-08-16 11:22:36 +02:00
simon lehericey
d5ddd182a7 remove useless session views 2019-08-14 18:04:26 +02:00