Commit graph

53 commits

Author SHA1 Message Date
Martin
b9d13df483 fix(spec): avoid flacky test. 15.days ago is not always on the previous month. eg: this spec failed on 16 of december, stats is still in december 2021-12-16 15:02:17 +01:00
maatinito
0a31c8bc79 refactor date_trunc queries using groupdate gem 2021-12-14 08:50:11 +01:00
Paul Chavard
46e2e34b89 fix(stats): remove super admin stats 2021-12-01 18:10:05 +01:00
Paul Chavard
2a068fb9b0 Remove user feedback buttons 2021-04-22 15:40:40 +01:00
Christophe Robillard
5562e65bf3 refacto: rename administration to super_admin 2020-11-05 16:03:55 +01:00
Paul Chavard
6a33a8e48b update controllers specs to use revisions 2020-09-02 11:26:26 +02:00
Christophe Robillard
cea170e4a6 update stats with traitement model 2020-07-08 18:15:15 +02:00
Pierre de La Morinerie
4cb747fdb6 specs: always require rails_helper
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Pierre de La Morinerie
031c40aa55 stats: display 12 weeks of feedbacks 2019-04-02 17:22:38 +02:00
Mathieu Magnin
6b9dbb22af Remove unused stats 2019-03-13 11:00:14 +01:00
Paul Chavard
0e4b6e1ba2 Remove “Nombre d'administrations ayant dématérialisé N démarches” graph 2019-03-12 11:59:01 +01:00
Pierre de La Morinerie
908771e172 stats: use group_by_week to compute the week range
Fix #3242
2019-01-10 16:17:00 +01:00
gregoirenovel
386fbce776 Enable the Layout/SpaceBeforeBlockBraces cop 2019-01-03 10:53:50 +01:00
Frederic Merizen
cf9024d36f Fix test that doesn't work just after daylight saving time changes
If I submit a request on Friday at 8am, and get a response on
Monday at 8am, the response time is 72h...

except if there was a daylight saving time change on Sunday, in
which case the response time is either 71h or 73h, making the test
fail
2018-10-30 10:58:20 +01:00
simon lehericey
3685c65fb7 [fix #2905] fix DATE_TRUNC usage
DATE_TRUNC is played on the db where the timestamp are stored in utc.
So if a user search for 12/12/2012 in Paris timezone and that we truncate it should do something similar to :

SELECT DATE_TRUNC('day', foo.timezone) from (SELECT timestamp '2012-12-12 00:00:00' AT TIME ZONE 'Europe/Paris') as foo;
=> 2012-12-11

To avoid such pb, I suggest avoiding DATE_TRUNC when exact results are needed
2018-10-26 10:10:20 +00:00
simon lehericey
3078b377c7 Time.new => Time.zone.local 2018-10-26 10:10:20 +00:00
simon lehericey
2238e5bd9f Time.now => Time.zone.now 2018-10-26 10:10:20 +00:00
gregoirenovel
ed240cb4d3 Enable Style/UnneededInterpolation 2018-10-03 12:03:21 +02:00
gregoirenovel
00ecae5f93 Procédure → Démarche 2018-09-05 15:46:24 +02:00
gregoirenovel
e60aa0c37b Use scopes when possible 2018-08-30 13:16:14 +02:00
gregoirenovel
4b071ecf06 Use enum to the fullest with Dossier.states 2018-08-29 17:31:08 +02:00
simon lehericey
28ce027025 [fix #1832] Procedure Stat: display procedure cloned ratio 2018-04-24 14:22:22 +02:00
gregoirenovel
0a9f442260 Enable some Rails cops 2018-03-06 17:18:44 +01:00
gregoirenovel
a2f4e8b283 factory_girl is now factory_bot 2018-01-23 17:15:42 +01:00
gregoirenovel
d30ea70c08 Enable the Layout/SpaceInsideParens cop 2018-01-18 10:53:35 +01:00
gregoirenovel
0be657c0d7 Enable the Layout/IndentHash cop 2018-01-15 22:33:12 +01:00
gregoirenovel
9e0e553f80 Enable the Layout/IndentArray cop 2018-01-15 22:33:12 +01:00
Frederic Merizen
ff2c4d7bfe Fix flaky test
1) StatsController#avis_average_answer_time should include [1512120443, 9.5]
     Failure/Error: it { is_expected.to include [3.week.ago.to_i, 9.5] }
       expected [[1512120442, 9.5], [1512725242, 7.33], [1513330042, 1.0]] to include [1512120443, 9.5]
     # ./spec/controllers/stats_controller_spec.rb:263:in `block (3 levels) in <top (required)>'
2017-12-22 10:58:48 +01:00
Simon Lehericey
a13256f73d [fix #504] Dossier: closed -> accepte 2017-12-15 12:10:54 +01:00
Simon Lehericey
72bae2c374 [fix #504] Dossier: draft -> brouillon 2017-12-15 11:52:09 +01:00
LeSim
56545933a9 [fix #504] Dossier: initiated -> en_construction
The change must not impact the api
2017-12-15 11:52:09 +01:00
Simon Lehericey
d90e22e332 Tests: add (or group) Timecop.return to resume time in specs 2017-11-29 16:07:39 +01:00
Mathieu Magnin
08f76f336c If not super admin do not display current month in cumul 2017-10-17 12:55:17 +02:00
Mathieu Magnin
dae700788f Fix test that fail when is run on the 1st day of the month following a 31 days month 2017-08-01 16:42:39 +02:00
gregoirenovel
6f2c63c094 Remove default values for some stat methods’ arguments 2017-07-17 16:00:16 +02:00
gregoirenovel
f55b7914cf [Ref #144] Don't use Procedure.published anymore 2017-07-11 14:51:43 +02:00
gregoirenovel
469f0aed4b [Fix #440] Show the current month only if logged in as superadmin 2017-06-26 10:50:31 +02:00
gregoirenovel
d0b927857a Add stats for encart motivation 2017-06-19 18:01:59 +02:00
gregoirenovel
bc16027ccc Enable the Layout/BlockEndNewline cop 2017-06-13 10:35:19 +02:00
Simon Lehericey
9e6098dc09 Add the weekly avis answer percentage to Stats 2017-05-31 14:24:33 +02:00
Mathieu Magnin
068b635b7c Add the weekly avis answer time average to Stats 2017-05-31 14:24:32 +02:00
Simon Lehericey
b5f1b898c7 Add the weekly avis usage to Stats 2017-05-31 13:31:19 +02:00
Mathieu Magnin
69a5857322 [Fix #264] Add pie chart to count administrations 2017-05-30 15:36:21 +02:00
gregoirenovel
3215411547 Delete the 30 days flows graphs 2017-05-30 12:05:28 +02:00
gregoirenovel
711f21c458 [Fix #264] Add the mean filling time graph to Stats 2017-05-30 12:05:27 +02:00
gregoirenovel
faa547e891 [Fix #264] Add the mean instruction time graph to Stats 2017-05-30 12:05:27 +02:00
gregoirenovel
ed7ba60cf0 [Fix #264] Add the last 4 months evolution graphs to Stats 2017-05-30 12:05:26 +02:00
gregoirenovel
b820f9d39c Move a test in the right describe section 2017-05-29 16:11:53 +02:00
gregoirenovel
06714b5fc3 Add a date_attribute argument to StatsController#cumulative_hash 2017-05-05 12:03:53 +02:00
gregoirenovel
c7999b9691 Add a date_attribute argument to StatsController#thirty_days_flow 2017-05-05 12:03:53 +02:00