Commit graph

3994 commits

Author SHA1 Message Date
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier 2024-09-06 11:23:12 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥 2024-09-06 08:37:08 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions 2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen 2024-09-04 15:00:03 +00:00
simon lehericey
eaef5c7e39
readapt name and logic 2024-09-04 08:08:01 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review 2024-09-04 08:05:54 +00:00
Kara Diaby
337f88575d
Modifications sur la méthode after_confirmation dans le modèle user 2024-09-04 08:05:53 +00:00
Kara Diaby
9c41c9a08f
Model FC : au lieu de valider le mail on envoie une demande de confirmation par mail 2024-09-04 08:05:52 +00:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
simon lehericey
e0daf1032d
rename virtual_dates by non_displayable_dates 2024-09-02 17:27:35 +02:00
simon lehericey
245f7bb975
remove column.virtual params 2024-09-02 17:25:46 +02:00
simon lehericey
3c7c58623f
replace virtual: true by displayable: false 2024-09-02 17:25:22 +02:00
Lisa Durand
b5051a25d9
it displays an alert if using test service before publishing a procedure 2024-09-02 16:52:21 +02:00
Colin Darie
4db4cf1513
fix(attestation): don't render block levels presentation elements into a p 2024-09-02 16:11:02 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs 2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list 2024-09-02 15:23:11 +02:00
Colin Darie
8e1cfd50dd
feat(procedure): improve dossier_for_preview with last dossier, excluding hidden by user 2024-09-02 15:23:10 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
mfo
f171727140
Merge pull request #10703 from mfo/US/dry-rna-rnf-siret-addresses-view
ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET
2024-09-02 12:25:54 +00:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring" 2024-08-30 16:43:30 +02:00
Eric Leroy-Terquem
37a018880b
chore: generate representations coming from ActionText in background 2024-08-30 16:37:19 +02:00
Eric Leroy-Terquem
00c905a615
chore: generate variant for procedure logo in background 2024-08-30 14:28:42 +02:00
simon lehericey
516205efd9
add path_rewrite model 2024-08-29 16:15:07 +02:00
Paul Chavard
79c9784d17
refactor(dossier loader): simplify all the things 2024-08-26 14:53:56 +02:00
Paul Chavard
bb288337bf
cleanup(prefill): remove unused validation 2024-08-26 14:53:56 +02:00
Paul Chavard
3ef6f450da
cleanup: more concistent methods usage 2024-08-26 14:53:56 +02:00
Paul Chavard
5edb8749c0
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ 2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage 2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision 2024-08-26 14:53:56 +02:00
Paul Chavard
701a28302e
refactor(dossier): remove unused scopes 2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods 2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc 2024-08-26 11:16:47 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ 2024-08-26 11:16:46 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers 2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
mfo
70983c50f9
spec(normalized_address): add simple spec 2024-08-22 10:37:31 +02:00
mfo
fdff699d51
feat(champ.rnf/rna/siret): render normalized address the same way 2024-08-22 09:45:27 +02:00
Colin Darie
992c61b51a
fix: as of parsby 1.1, IO can be mutated during parsing
See 534f8a95b4/lib/parsby.rb (L572C11-L572C17)

Trace:
IOError: not modifiable string
    # parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
    # parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
    # parsby-1.1.1/lib/parsby.rb:539:in `block in restore'
    # parsby-1.1.1/lib/parsby.rb:539:in `each'
2024-08-22 09:26:48 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Lisa Durand
3cf3dc4623
make email confirmation more generic 2024-08-21 16:23:56 +02:00
Lisa Durand
ea354d46c4
Create new invitation email if expert not confirm 2024-08-21 16:19:51 +02:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable 2024-08-20 18:46:19 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one 2024-08-20 15:26:09 +02:00
Colin Darie
e4d460965f
Merge pull request #10690 from mfo/US/normalize-addresses-for-rnf-rna-siret
ETQ Tech, les adresses des champs siret / rna / rnf sont normalisées pour une recherche homogène via les filtres
2024-08-20 10:11:48 +00:00
Colin Darie
1e53e3bfef
Merge pull request #10661 from demarches-simplifiees/feat/10460
ETQ admin, je veux que l'email du déposant ne puisse pas être similaire à l'email du mandataire
2024-08-20 09:34:03 +00:00
LeSim
befe74b801
Merge pull request #9758 from demarches-simplifiees/purge_supprimer_dol
Tech: quand un dossier est définitivement supprimé, on ne garde que le log (DOL) concernant sa suppression
2024-08-20 09:26:33 +00:00
simon lehericey
28b338452a
feat(dossier_purge): when the dols are purged, only keep supprimer dol but destroy its data
Note, the only remaining data are dossier_id, automatic_operation, digest and bill_id, created_at
2024-08-20 10:55:32 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json 2024-08-20 10:31:23 +02:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀 2024-08-19 15:46:14 +02:00
mfo
b910705353
move tdc facets builder to tdc 2024-08-19 15:30:08 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields 2024-08-19 15:30:08 +02:00
mfo
743ff8c8a9
extract Instructeurs::FacetTableHeaderComponent wrapping sort logic 2024-08-19 15:30:08 +02:00
simon lehericey
61051771a7
stay the old way for the moment ? 2024-08-19 15:30:07 +02:00
simon lehericey
ef63579e2e
clean facets_concern 2024-08-19 15:30:07 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select 2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options 2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets 2024-08-19 15:29:59 +02:00
simon lehericey
e19f1bd8c2
sortable? -> sorted_by 2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private 2024-08-19 15:29:59 +02:00
simon lehericey
7a1c25271d
small refactors 2024-08-19 15:29:56 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component 2024-08-19 15:28:36 +02:00
simon lehericey
73293b0d06
give facet object instead of field_id to instructeur_filter_component 2024-08-19 15:28:36 +02:00
simon lehericey
437e632f6a
move facet_find to Facet.find 2024-08-19 15:28:36 +02:00
simon lehericey
969282e453
remove last field_hash 2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
simon lehericey
2239172fac
move facets list to facets 2024-08-19 15:28:36 +02:00
simon lehericey
49eaf10bce
fields -> facets 2024-08-19 15:28:36 +02:00
simon lehericey
5c09581228
move id to facet and search_by facet_id 2024-08-19 15:28:34 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
Co-Authored-By: LeSim <mail@simon.lehericey.net>

clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
88cd4a94dd
Ajoute la validation sur le modèle Individual 2024-08-19 12:51:39 +00:00
Paul Chavard
065000cae3
Merge pull request #10674 from colinux/really-fix-rnf
ETQ usager, permet de saisir un champ RNF en ignorant les espaces/tabulations
2024-08-01 18:09:21 +00:00
Colin Darie
c2159ca0bf
fix(contact): allow deletion of contact form of users having dossiers 2024-08-01 19:44:44 +02:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces 2024-08-01 18:00:46 +02:00
Colin Darie
4b6d3ee16d
refactor(contact): support => contact 2024-07-31 17:08:02 +02:00
Colin Darie
5af32b46f4
refactor(contact): form is persisted in db before pushed to HS 2024-07-31 17:08:01 +02:00
Colin Darie
4bc0a04106
chore(schema): add contact_forms 2024-07-31 17:08:01 +02:00
Paul Chavard
9d7d7da85a
Merge pull request #10572 from demarches-simplifiees/add-pj-from-messagerie-to-gallery
ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes"
2024-07-30 09:35:14 +00:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
simon lehericey
057868a48e
small work on tiptap 2024-07-26 13:34:49 +02:00
simon lehericey
8906a59635
simplify export_template model and spec 2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type 2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern 2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename 2024-07-26 13:31:05 +02:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision 2024-07-25 18:29:01 +02:00
Lisa Durand
4f7b0c93d0
fix multiple errors from creation of dedicated method to restore and extend 2024-07-25 16:55:00 +02:00
Lisa Durand
7da3e05752
small refacto to simplify scope 2024-07-24 17:07:48 +02:00
Lisa Durand
b820577461
create a method to extend and restore 2024-07-24 17:07:48 +02:00
Lisa Durand
ae1a6e1b3d
improve hidden_by_expired scope 2024-07-24 17:07:47 +02:00
Lisa Durand
5c26073af7
small refacto with hidden_by_expired? method 2024-07-24 17:07:47 +02:00
Lisa Durand
df13e53815
small refactos from Sim review 2024-07-24 17:07:47 +02:00
Lisa Durand
94e1f048ce
fix tabs count 2024-07-24 17:07:47 +02:00
Lisa Durand
eb3b928cf2
change scope to include new column for expiring dossiers 2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at 2024-07-24 17:07:41 +02:00
Lisa Durand
1441855fe8
fix query for instructeur tabs count 2024-07-24 17:06:31 +02:00
Lisa Durand
2d66a67564
use automatic flag for dossier operation log 2024-07-24 17:06:31 +02:00
Lisa Durand
9346020889
dont use depreciated column hidden_at 2024-07-24 17:06:30 +02:00
Lisa Durand
8b88fafc25
add correct action for instructeur 2024-07-24 17:06:30 +02:00
Lisa Durand
c2abceaa72
hide expired dossiers instead of delete them 2024-07-24 17:06:30 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Eric Leroy-Terquem
3bbcda9c04
refactor(dossier): refactor pieces jointes 2024-07-22 10:07:39 +02:00
Eric Leroy-Terquem
3516bae008
feat(gallery): create representations for pjs sent by messagerie 2024-07-22 10:07:39 +02:00
Paul Chavard
be83f2c7d1
Merge pull request #10609 from tchak/champs-selection-multiple-combobox
Utiliser les nouvelles combobox pour les champs de sélection multiple
2024-07-16 13:17:41 +00:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes 2024-07-16 15:10:45 +02:00
Paul Chavard
42ed6d7c87
refactor(dossier): use each instead of filter with side effects 2024-07-16 09:03:56 +02:00
Lisa Durand
7630cc39fa
Merge pull request #10595 from demarches-simplifiees/email-mandant-need-confirmation-ldu
ETQ Mandant, je dois confirmer mon mail avant de recevoir des notifs
2024-07-15 14:00:38 +00:00
Lisa Durand
e9f5389f83
resent email if link too old and better style email 2024-07-15 12:00:03 +02:00
Lisa Durand
3eabcb0736
add tests 2024-07-15 11:56:18 +02:00
mfo
b55ed262ed
Merge pull request #10607 from mfo/US/fix-invisible-pj
Amélioration: ETQ usager, je souhaite que les PJs d'un champ qui n'est plus visible ne soient pas soumise a l'administration
2024-07-15 09:36:01 +00:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false] 2024-07-15 11:28:59 +02:00
mfo
d5c8b7464c
fix(users.update_email): optimistic 2024-07-12 15:42:50 +02:00
Eric Leroy-Terquem
ea8112b8b3
fix(routing): open routing wizard to all conditionable types 2024-07-11 14:55:03 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
Lisa Durand
7539d2ddea
fix specs 2024-07-10 16:11:38 +02:00
Lisa Durand
42633c0012
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into instructeur-invitation-include-typo-suggestion-ldu 2024-07-10 14:58:55 +02:00
Lisa Durand
3b138d5bb7
add confirmation for tiers email 2024-07-10 10:57:26 +02:00
mfo
f3690d8890
Merge pull request #10587 from tchak/refactor-no-validate-on-format
refactor(champ): remove call to validation from value formatting code
2024-07-09 14:31:10 +00:00
Colin Darie
142ed6f762
fix(cojo): fetch external data when "-01" suffix is typed, even if its deleted later by .to_i 2024-07-09 12:49:22 +02:00
Paul Chavard
133689b4d3
refactor(champ): remove call to validation from value formatting code 2024-07-08 15:39:28 +02:00
Colin Darie
3e9cb6f388
Merge pull request #10576 from colinux/secure-cookies
Tech: cookies avec flag `secure` et `httponly`
2024-07-08 09:33:30 +00:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
f0f88ef3f0
refactor(champ): update champ drop_down_list 2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune 2024-07-05 09:36:33 +02:00
Paul Chavard
f1f1af4e61
refactor(champ): update champ annuaire education 2024-07-05 09:36:33 +02:00
Paul Chavard
79a65a4847
refactor(champ): update champ address 2024-07-05 09:36:33 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces. 2024-07-04 09:56:23 +02:00
Lisa Durand
c8906d20b8
add reusable code in concern for typo detection email 2024-07-03 16:09:34 +02:00
Colin Darie
1eb0bdb4ae
chore: cookies with "secure" flag (only transmitted through https) 2024-07-03 11:18:16 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Eric Leroy-Terquem
2b0c53cd82
Merge pull request #10565 from demarches-simplifiees/add-demarches-publiees-page-in-manager
ETQ superadmin, je peux accéder aux informations essentielles des dernières démarches publiées
2024-07-02 07:46:30 +00:00
Eric Leroy-Terquem
0a70c6b90f
manager: add a page for demarches publiees 2024-06-28 18:20:05 +02:00
Colin Darie
48e5a237e3
chore(schema): change default types_de_champ#mandatory from false to true 2024-06-25 17:17:21 +02:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation 2024-06-25 15:14:26 +02:00
Colin Darie
ccf5b255ed
Merge pull request #10465 from colinux/attestations-v2-prod
ETQ admin je peux activer la délivrance des attestations v2 (sous feature flag)
2024-06-24 08:56:31 +00:00
mfo
2ee6f2350a
Merge pull request #10536 from mfo/US/summary-in-instructeur-demande
ETQ instructeur, je peux naviguer dans le formulaire de l'usager via un sommaire, idem pour les annotations privées.
2024-06-21 14:44:50 +00:00
mfo
4caeecadff
Merge pull request #10534 from mfo/US/fix-ineligibilite-rules-check-without-rules
Correctif: ETQ admin, je ne peux pas activer l'inéligibilité des dossiers sans règles d'inéligibilité
2024-06-21 09:47:43 +00:00
mfo
d46dc7055d
feat(instructeurs/dossiers): add summary to dossier.champs and dossier.champ_private views, also extract summary in
two component. one of type de champ editor. one for viewable champs
2024-06-21 11:06:45 +02:00
mfo
5a5ebfb235
Merge pull request #10531 from mfo/US/add-champ-summary-to-annotations
ETQ administrateur, je peux naviguer dans l'editeur des annotations en utilisant le sommaire façon editeur des champs du formulaire
2024-06-21 08:34:12 +00:00
mfo
6eaf870cbf
feat(administrateurs/procedure#annotations): add summary 2024-06-21 05:50:24 +02:00
mfo
24d7b0b014
fix(ineligibilite_rules): prevent admin to enable ineligibilite rules without rules 2024-06-20 15:35:36 +02:00
mfo
9adb1bcf49
fix(ineligibilite_rules): cache bust champs.visible after checking for ineligibilite rules
Update app/models/dossier.rb

Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-06-20 15:20:32 +02:00
Colin Darie
f2669fbca8
fix(attestation): fix unspecified_attestation_champs for v2 2024-06-20 14:15:06 +02:00
Colin Darie
a540f8dccb
feat(attestation): can render & attach attestations v2 2024-06-20 14:15:05 +02:00
Colin Darie
11d29f5574
chore(attestation): publish a v2 attestation 2024-06-20 11:08:15 +02:00
Colin Darie
4af6957237
fix(attestation): dup keep all attributes 2024-06-20 11:08:15 +02:00
Colin Darie
c5c24c01d8
chore(attestation): procedure#attestation_template always returns the published attestation 2024-06-20 11:08:15 +02:00
Colin Darie
ad3c5a7493
chore(schema): add attestation_templates#state 2024-06-20 11:08:15 +02:00