Pierre de La Morinerie
503c393a87
helpscout: use replies_sent to compute contact rate
...
The `conversations_count` we previously used counts replies, but also
all conversations that were tagged or re-tagged during the month – with
made counting the actual work spent on user support brittle.
Counting the replies is a better estimation of what we get.
Unfortunately this also removes the filtering-by-tag feature. To
mitigate this, the reports are now scoped to a specific mailbox. This
allows to create extra mailboxes for conversations that should't be
counted in the stats.
2019-09-11 17:26:10 +02:00
Paul Chavard
65e227c44b
Migrate to flipper
2019-09-10 16:10:14 +02:00
clemkeirua
4032fc61e3
move to only one pipedrive account
2019-08-28 12:16:25 +02:00
simon lehericey
3fde2a6f70
Rename gestionnaire in code to instructeur
2019-08-12 13:47:01 +02:00
Pierre de La Morinerie
02a5234bde
lib: remove FileSizeValidator
...
It was only used by the PieceJustificative model.
2019-07-30 16:11:17 +02:00
clemkeirua
25f81f1d3c
download a dossier as zip with all attachments
2019-07-16 09:11:25 +02:00
clemkeirua
d29be1fe41
suppression de redouane de Pipedrive
2019-07-09 17:29:25 +02:00
clemkeirua
1f3015e24f
suppression de camille de la liste pipedrive
2019-07-09 17:29:25 +02:00
Paul Chavard
7f8079b5bb
Download active_storage blobs through proxy
2019-06-26 15:32:57 +02:00
Paul Chavard
aad4025ce0
Revert "Download active_storage blobs through proxy"
...
This reverts commit 0b39da7080
2019-06-26 15:31:35 +02:00
Paul Chavard
0b39da7080
Download active_storage blobs through proxy
2019-06-26 15:07:40 +02:00
Nicolas Bouilleaud
dace9a53d3
Add Universign timestamp API query
2019-06-17 16:16:28 +02:00
Nicolas Bouilleaud
e16cb731c5
Add poor man’s ASN1 parsing
2019-06-17 16:16:28 +02:00
Pierre de La Morinerie
55c9dfc001
api_entreprise: display better error message when SIRET is private
...
Previously we blamed the network.
Now we say that the entreprise infos cannot be retrieved. Which is not
ideal, but better.
2019-06-12 11:58:04 +02:00
Chaïb Martinez
3b513af32a
Add nb_of_dossiers by years and deadline to PipeDrive Person
...
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-06-04 16:55:11 +02:00
Paul Chavard
42235e81b1
Use active storage load hook to extend blob
2019-05-16 20:43:01 +02:00
Pierre de La Morinerie
e66e78b4db
helpscout: remove integration of custom fields
...
Our new HelpScout plan doesn't allow custom fields
anymore.
2019-05-13 12:33:29 +02:00
clemkeirua
25bcd51fce
add log for virus_scanner
2019-05-13 12:22:19 +02:00
Paul Chavard
f113d108c9
Save virus scan status to blob metadata
2019-05-02 15:58:09 +02:00
Pierre de La Morinerie
ad4a89f0f6
api_entreprise: raise on network error
2019-05-02 11:24:22 +02:00
Pierre de La Morinerie
6c8280fba6
api_entreprise: add a feature flag for toggling API INSEE v3
2019-04-30 17:27:58 +02:00
Pierre de La Morinerie
b74fdd3cc8
Revert "Fix API Entreprise call"
...
This reverts commit 7deb228477
2019-04-30 17:19:46 +02:00
simon lehericey
7deb228477
Fix API Entreprise call
2019-04-30 10:27:35 +02:00
simon lehericey
14c3686969
ApiAdresse: add timeout
2019-04-23 14:31:01 +02:00
Pierre de La Morinerie
e90b1cdcc0
api_entreprise: use API v3 again
...
This reverts commit 10e1408a88
2019-04-04 17:14:58 +02:00
Pierre de La Morinerie
10e1408a88
api_entreprise: revert to API v2
...
Fix a production error
2019-04-03 12:19:28 +02:00
Mathieu Magnin
ff0356e698
Fix Sentry 165 : api crash when siret is unknown
2019-03-12 17:53:11 +01:00
Paul Chavard
48701e80bd
Enable flipflop for instructeurs
2019-03-12 12:14:34 +01:00
Frederic Merizen
98713b6a4d
Proxy for SendinBlue API
2019-03-08 16:33:28 +01:00
Pierre de La Morinerie
7413df81e0
Revert "file upload: proxy direct upload through the APP_HOST"
...
This reverts commit 2365efbdaa
2019-02-14 16:23:11 +01:00
Mathieu Magnin
2365efbdaa
file upload: proxy direct upload through the APP_HOST
...
Ref #3409
2019-02-14 14:28:03 +01:00
Mathieu Magnin
f445d95166
Fix Macedoine 🇲🇰
2019-02-13 13:56:51 +01:00
Pierre de La Morinerie
b8978d2196
carto: properly handle RestClient::ServiceUnavailable exceptions
2019-02-06 17:40:15 +01:00
Pierre de La Morinerie
00d3cbc182
carto: handle more "API unavailable" errors
2019-01-28 18:22:55 +01:00
Pierre de La Morinerie
803364490d
carto: present API InternalServerError to the user, instead of failing
2019-01-28 18:22:55 +01:00
Frederic Merizen
0846860748
Proxy for active storage service provider
2019-01-16 11:34:57 +01:00
Pierre de La Morinerie
86b9e2d092
stats: fix exception when HelpScout env vars are missing
...
This fixes the stats page, which used to raise an exception when
HelpScout env vars are not present.
2019-01-03 17:27:56 +01:00
Pierre de La Morinerie
da675bb47e
api: fix formatting error when a request fails
2019-01-03 17:27:56 +01:00
Chaïb Martinez
905d2f1635
Add phone number from pipedrive
2018-12-22 11:49:15 +01:00
Chaïb Martinez
0fe473b84e
Add 2 new categories in admin contact form
2018-12-20 15:29:49 +01:00
gregoirenovel
616e9305e9
Enable the Style/ClassCheck cop
2018-12-19 13:56:10 +01:00
gregoirenovel
026fd1aaa2
Use parentheses
2018-12-18 22:18:38 +01:00
Pierre de La Morinerie
d614ea6bd5
stats: display contact rate
2018-12-18 10:38:59 +01:00
Pierre de La Morinerie
30774aa189
api_geo: cache requests for one day
...
This should make the 500 errors that we get in production less frequent.
NB: Unfortunately we can't write a spec for the caching behavior, as the
VCR mocks are never cached.
2018-12-10 11:41:07 +01:00
Pierre de La Morinerie
a0ae1afb45
typhoeus: add a cache store for successful requests
2018-12-10 11:41:07 +01:00
gregoirenovel
3b0562949c
Ask API Entreprise for insee v3
2018-12-10 10:49:56 +01:00
gregoirenovel
31250b4642
Make more ApiEntreprise::API methods private
2018-12-10 10:48:57 +01:00
Paul Chavard
b9af07b845
Add admin support contact form
2018-11-28 16:50:37 +01:00
Paul Chavard
fcdc0114fd
Add id to geo areas
2018-10-30 12:16:09 +01:00
simon lehericey
ee0a6b1913
Time.at => Time.zone.at
2018-10-26 10:10:20 +00:00
Paul Chavard
7ffbe417f9
Add ApiGeo RPG adapter
2018-10-23 18:13:44 +02:00
Paul Chavard
ed46e2c3be
Use Typhoeus in ApiGeo adapter
2018-10-23 18:13:44 +02:00
gregoirenovel
a8af27105d
Remove ssl_verifypeer option in ApiEntreprise::API.call
...
SSL seems OK for https://entreprise.api.gouv.fr/
2018-10-16 10:23:30 +02:00
gregoirenovel
5a326db650
Simplify ApiCarto::API.call
...
SSL seems OK for https://apicarto.sgmap.fr
2018-10-16 10:16:44 +02:00
gregoirenovel
f66f0f9668
Remove two useless initialize methods
2018-10-16 09:33:16 +02:00
gregoirenovel
22088b167d
Remove ApiAdresse::Geocodeur
2018-10-16 09:33:16 +02:00
gregoirenovel
d68aca545a
Refactor ApiAddresse::PointAdapter
2018-10-16 09:33:16 +02:00
gregoirenovel
145880555e
ApiAdresse::PointAdapter#point → #geocode
2018-10-16 09:33:16 +02:00
gregoirenovel
af716fa3c6
ApiAdresse::PointRetriever → ApiAdresse::PointAdapter
2018-10-16 09:33:16 +02:00
gregoirenovel
81d2b27160
Refactor ApiAdresse::AddressAdapter
2018-10-16 09:33:16 +02:00
gregoirenovel
7af41b35a2
ApiAdresse::AddressAdapter#list → #get_suggestions
2018-10-16 09:33:16 +02:00
gregoirenovel
517c0ad3fc
ApiAdresse::AddressRetriever → ApiAdresse::AddressAdapter
2018-10-16 09:33:16 +02:00
gregoirenovel
32b27ba111
Add some spacing
2018-10-15 23:31:23 +02:00
gregoirenovel
76cf9ab746
ApiGeo::Driver → ApiGeo::API
2018-10-15 23:31:23 +02:00
gregoirenovel
c654122e90
Unify scoping in app/lib
2018-10-15 23:31:23 +02:00
gregoirenovel
831cd56b95
Remove comments in ApiAdresse
2018-10-15 23:31:23 +02:00
gregoirenovel
8b4ba42f15
Simplify ApiAdresse
2018-10-15 23:31:23 +02:00
gregoirenovel
a841a517df
ApiAdresse::Driver → ApiAdresse::API
2018-10-15 23:31:23 +02:00
gregoirenovel
5db4de6c53
QuartiersPrioritaires::Adapter → QuartiersPrioritairesAdapter
2018-10-15 23:31:23 +02:00
gregoirenovel
918a91a985
ApiCarto::Cadastre::Adapter → ApiCarto::CadastreAdapter
2018-10-15 23:31:23 +02:00
gregoirenovel
6be26af7db
Use parentheses
2018-10-15 20:55:46 +02:00
gregoirenovel
5e9e913dce
Carto::Geocodeur → ApiAdresse::Geocodeur
2018-10-15 20:55:46 +02:00
gregoirenovel
d726fbf698
CARTO::SGMAP → ApiCarto
2018-10-15 20:55:46 +02:00
gregoirenovel
442b4a241b
Make API_ADRRESSE_URL canonical
2018-10-15 20:55:46 +02:00
gregoirenovel
a7a6898ce3
Constantize the API Adresse URL
2018-10-15 20:55:46 +02:00
gregoirenovel
ca8af0e904
Use parentheses
2018-10-15 20:55:46 +02:00
gregoirenovel
dac2019675
Carto::Bano → ApiAdresse
2018-10-15 20:55:46 +02:00
gregoirenovel
d749d20bb3
api_url → url
2018-10-15 20:55:46 +02:00
gregoirenovel
a7019719c2
Use parentheses
2018-10-15 20:55:46 +02:00
gregoirenovel
4903a6b189
Carto::GeoAPI → ApiGeo
2018-10-15 20:55:46 +02:00
gregoirenovel
34ac68b27f
2018-10-15 17:12:34 +02:00
gregoirenovel
b162c68844
Use Hash#slice
2018-10-15 17:12:34 +02:00
gregoirenovel
889b9b9342
Make Cadastre::Adapter#to_params more like QuartiersPrioritaires::Adapter
2018-10-15 16:45:30 +02:00
gregoirenovel
22beb41240
Unify #generate_qp with #generate_cadastre
2018-10-15 16:45:30 +02:00
gregoirenovel
a18af4e616
Simplify CARTO::SGMAP::API.call
2018-10-15 16:45:30 +02:00
gregoirenovel
5df4e3305e
Simplify CARTO::SGMAP::API
2018-10-15 16:45:30 +02:00
gregoirenovel
2ed4c1da1c
Use round brackets
2018-10-15 16:45:30 +02:00
gregoirenovel
0196309822
Remove a useless default in CARTO::SGMAP::API.call
2018-10-15 16:16:16 +02:00
gregoirenovel
7fe3b43eab
Improve a comment in RNAAdapter
2018-10-04 21:03:49 +02:00
gregoirenovel
1ffd4a230b
Simplify RNAAdapter#process_params
...
Avoid catching an attribute only to remove it
a few lines later
2018-10-04 21:03:49 +02:00
gregoirenovel
b28607a3a6
Simplify an instruction in ExercicesAdapter#process_params
2018-10-04 21:03:49 +02:00
Paul Chavard
1302b68d91
Only reject api entreprise data if required fields are missing
2018-10-04 17:55:09 +02:00
gregoirenovel
7e4268db67
Enable Style/TrailingCommaInArguments
2018-10-03 12:03:21 +02:00
gregoirenovel
a171186dd8
Enable Style/TrailingCommaInHashLiteral
2018-10-03 12:03:21 +02:00
gregoirenovel
1f4ef0074f
Enable Style/ZeroLengthPredicate
2018-10-03 12:00:17 +02:00
gregoirenovel
b994fa4206
Do one thing per line
2018-10-01 16:15:46 +02:00
gregoirenovel
0c9628c180
Fix some files according the the .editorconfig rules
2018-09-20 16:23:09 +02:00
Paul Chavard
6453b53a41
Add helpscout API adapter
2018-08-29 10:43:00 +01:00
gregoirenovel
9284afc649
Use a constant for the API Entreprise URL
2018-08-28 10:44:16 +02:00
Paul Chavard
9abb3c7a5a
[ENV] Pipedrive key config
2018-08-23 15:55:32 +02:00
Mathieu Magnin
db8e750f1a
[ENV] Configure Api Entreprise token
2018-08-23 15:55:32 +02:00
simon lehericey
d9a9677d1d
[ fix #2397 ] Manager: update crm conf
2018-08-23 12:12:39 +02:00
simon lehericey
ee43650c32
Demande: add nb_of_procedure, deadline and nb_of_dossier fields
2018-08-23 12:12:39 +02:00
Pierre de La Morinerie
d1301762d4
pipedrive: fix deals when no deals are returned
2018-07-02 17:07:24 +02:00
gregoirenovel
346b32fbd4
[ Fix #1736 ] Assign the deal and person to the person who accepted them
2018-06-07 16:04:15 +02:00
Frederic Merizen
695f5b2705
Fix class methods on BizDev module
...
and add missing tests
2018-06-06 16:07:29 +02:00
gregoirenovel
6992bea141
Add the BizDev module
2018-06-01 20:48:50 +02:00
gregoirenovel
5d188c191d
Move transform_keys calls directly to #process_params methods
2018-05-24 17:54:51 +02:00
simon lehericey
aaebcd3494
[ fix #1701 ] Use DS form to enroll admin
2018-05-24 17:15:44 +02:00
gregoirenovel
44754418f8
Add parentheses
2018-05-22 19:01:46 +02:00
gregoirenovel
a246181afd
Add API_GEO_URL
2018-05-22 19:01:46 +02:00
gregoirenovel
1839269dd9
Add API_CARTO_URL
2018-05-22 18:53:34 +02:00
Paul Chavard
d9dbf7b7f9
Remove legacy features support
2018-04-26 16:28:45 +02:00
Paul Chavard
e76e17895a
Flipflop should check administrateur id not user id
2018-04-25 11:06:40 +02:00
Paul Chavard
3f3358db16
Add flipflop config
2018-04-18 16:51:21 +02:00
gregoirenovel
26b66aac96
Improve a method name
2018-04-09 09:54:11 +02:00
gregoirenovel
71e9a6056d
Structure the helpers methods the same way
2018-04-09 09:54:10 +02:00
gregoirenovel
c5953f8aef
Use .join to generate urls (unification)
2018-04-09 09:54:10 +02:00
gregoirenovel
298d7d050c
Mutualize some code in Pipedrive::API#put
2018-04-09 09:54:10 +02:00
gregoirenovel
e688fc4212
Mutualize some code in Pipedrive::API#get
2018-04-09 09:54:10 +02:00
gregoirenovel
d202e0173e
Mutualize some code in Pipedrive::API#get
2018-04-09 09:54:10 +02:00
gregoirenovel
d287eb0e5f
Create Pipedrive::API get helpers
2018-04-09 09:54:10 +02:00
gregoirenovel
4ff07f2b93
Mutualize a call Pipedrive::API.put
2018-04-09 09:54:10 +02:00
gregoirenovel
e31b839e0c
Create Pipedrive::API put helpers
2018-04-09 09:54:10 +02:00
gregoirenovel
e71d3a76fa
Refactor Pipedrive: create adapters and an API files
2018-04-09 09:54:10 +02:00
gregoirenovel
094ccecc01
Rename Adapter’s siret_or_siren to siret
2018-03-29 16:06:14 +02:00
gregoirenovel
8938a5b40d
Delete SiretService.siren, move its code to EntrepriseAdapter#get_resource
2018-03-29 16:06:14 +02:00
gregoirenovel
cc9e318210
Add a comment to explain why we reject 206 responses
2018-03-29 15:36:41 +02:00
gregoirenovel
67cf614879
Mutualize some code on ApiEntreprise::Adapter
2018-03-29 11:44:59 +02:00
gregoirenovel
5f1394cd7f
ExercicesAdapter#to_array -> ExercicesAdapter#to_params
2018-03-29 11:44:59 +02:00
gregoirenovel
68c9849977
Mutualize the adapters’ #data_source methods
2018-03-29 11:44:59 +02:00
gregoirenovel
a9360a8be2
Mutualize Adapter initialization in a class and method
2018-03-29 11:44:59 +02:00
gregoirenovel
681e33b850
Simplify RNAAdapter#to_params and unify the type of objects it returns
2018-03-28 10:55:15 +02:00
gregoirenovel
caf2e50954
Make #to_params return blank hashes if we have no data
2018-03-28 10:55:15 +02:00
gregoirenovel
de483ac0f6
Format all attr_to_fetch methods the same way
2018-03-28 10:55:14 +02:00
gregoirenovel
3dd76c3d68
Remove useless success? methods
2018-03-28 10:55:14 +02:00
gregoirenovel
a9c1c9f551
Improve #success? methods
2018-03-28 10:55:14 +02:00
gregoirenovel
19add3f534
Use if-flows instead of rescue-flows
2018-03-28 10:55:14 +02:00
gregoirenovel
182afee970
to_params -> to_array
2018-03-28 10:52:54 +02:00
gregoirenovel
3e16eff9a0
Unify data_source methods
2018-03-28 10:50:27 +02:00
Paul Chavard
2f68b7c4b3
Tweak timeout API Entreprises
2018-03-27 17:59:51 +02:00
Paul Chavard
5ae8eb3383
Lower timeout for API Entreprise
2018-03-27 17:16:56 +02:00
Paul Chavard
2505419b08
Treat partial success from api entreprises as errors
...
We might refine this later, but for now this will give an error instead of unspecified state
2018-03-26 17:44:37 +02:00
Paul Chavard
f35aef0eb6
Use Typhoeus and set agressive timeouts
2018-03-26 16:53:42 +02:00
Frederic Merizen
2fa88a432b
Add missing brackets around parameters in method definitions
2018-03-20 17:54:51 +01:00
gregoirenovel
4df2eb168d
Remove mandataires_sociaux
2018-03-20 16:09:00 +01:00
gregoirenovel
5658aae96b
SIADE -> ApiEntreprise
2018-03-19 11:39:46 +01:00
gregoirenovel
96f78b6213
data_source methods can be private
2018-03-19 11:39:46 +01:00
gregoirenovel
9a7e13f72f
Mutualise a JSON#parse call
2018-03-19 11:39:46 +01:00
gregoirenovel
57b42e24e5
SIADEURL -> API_ENTREPRISE_URL
2018-03-19 11:39:46 +01:00
gregoirenovel
658bd95f86
Add a constant to SIADEURL
2018-03-19 11:39:46 +01:00
gregoirenovel
a0a56d6f67
Add a variable for legibility
2018-03-19 11:39:46 +01:00
gregoirenovel
5628eba0a4
mandatory_params -> params
2018-03-19 11:39:46 +01:00
gregoirenovel
b71b8ea8e0
Refactor the url method
2018-03-19 11:39:46 +01:00
gregoirenovel
92e0e4c231
Remove the base_url method
2018-03-19 11:39:46 +01:00
gregoirenovel
51c030b945
Move the URL computation to a private method
2018-03-19 11:39:46 +01:00
gregoirenovel
94176f0b53
Pass a resource instead of a url to #call
2018-03-19 11:39:46 +01:00
gregoirenovel
330f99de8a
Mutualise part of the URL
2018-03-19 11:39:46 +01:00
gregoirenovel
2c18541256
Mutualise base_url call
2018-03-19 11:39:46 +01:00
gregoirenovel
6902f502d3
Mutualise mandatory_params call
2018-03-19 11:39:46 +01:00
gregoirenovel
9daf0ee608
Remove useless attribute default
2018-03-19 11:39:46 +01:00
Mathieu Magnin
ab368d44a1
[ Fix #1500 ] Add mandatory params to call api entreprise v2
2018-03-15 14:51:42 +01:00
gregoirenovel
7489b8d1aa
Avoid assignments in conditions
2018-03-06 17:18:44 +01:00
Paul Chavard
94a503a2c4
Fix create dossier with siret
2018-02-28 17:16:03 +01:00
Paul Chavard
896518f3d5
add SIRETService
2018-02-27 16:22:53 +01:00
Paul Chavard
da14cceadc
Refactor siade adapters
2018-02-27 16:22:53 +01:00
gregoirenovel
c9a79b4f08
Use map when possible
2018-01-30 15:50:52 +01:00
gregoirenovel
b138dcd876
Enable the Layout/SpaceInsideHashLiteralBraces cop
2018-01-18 10:53:35 +01:00
gregoirenovel
c3754a173f
Use map instead of inject
2018-01-16 11:08:56 +01:00
gregoirenovel
0be657c0d7
Enable the Layout/IndentHash cop
2018-01-15 22:33:12 +01:00
gregoirenovel
08ed400ec2
Enable the Layout/FirstArrayElementLineBreak cop
2018-01-15 22:14:38 +01:00
gregoirenovel
7c34807f46
Don’t use unless
2018-01-12 11:32:43 +01:00
Simon Lehericey
fe9ac727de
[ fix #872 ] apientrepise: use v2 endpoints
2017-12-01 11:26:40 +01:00
gregoirenovel
379e7b74d6
Enable all the rubicop perf cops
2017-11-21 10:31:16 +01:00
gregoirenovel
24e7537c49
Enable the Layout/EmptyLinesAroundClassBody cop
2017-06-13 10:35:32 +02:00
gregoirenovel
f1907f4d0e
Enable the Layout/EmptyLinesAroundBlockBody cop
2017-06-13 10:35:23 +02:00
gregoirenovel
9439e1abb1
Enable the Layout/AlignParameters cop
2017-06-13 10:35:16 +02:00
gregoirenovel
d5e7bbd80d
Files should end with a new line
2017-04-04 16:59:38 +02:00
Xavier J
42359eff15
Fix rake tasks
2017-01-11 17:36:28 +01:00
Xavier J
5eeb91ec60
Delete last GithubRelease
2017-01-03 10:43:04 +01:00
Xavier J
83444ab54c
Catch error 500 for quartier prioritaire
2016-12-20 12:27:53 +01:00
Xavier J
f21f151c9c
Add test for GeoAPI driver lib
2016-12-16 10:42:34 +01:00
Xavier J
1a3e23c6ef
Change place lib repository
2016-12-02 17:03:52 +01:00
