DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
9640 commits 250 branches 1166 tags 78 MiB
Commit graph

9640 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pierre de La Morinerie
55c9dfc001 api_entreprise: display better error message when SIRET is private 
Previously we blamed the network.

Now we say that the entreprise infos cannot be retrieved. Which is not
ideal, but better.
 2019-06-12 11:58:04 +02:00
Paul Chavard
8c7d7f2eed
Merge pull request #3930 from betagouv/fix-activestorage-events-on-ie11 
javascript: fix payload of ActiveStorage events missing on IE 11
 2019-06-06 15:20:13 +02:00
Pierre de La Morinerie
78f75744e3 javascript: fix payload of ActiveStorage events missing on IE 11 
Under some circumstances (like dispatching events just before a page
navigation), IE 11 events will be dispatched twice by the browser: once
with the payload, and a second time without.

To prevent these errors, ignore the events if the payload is missing.
 2019-06-06 15:00:57 +02:00
Pierre de La Morinerie
d9f7bad049
🚒 Corrige les notifications Instructeur sur les dossiers migrés avant-hier (#3931) 
🚒 Corrige les notifications Instructeur sur les dossiers migrés avant-hier
 2019-06-06 11:42:31 +02:00
Pierre de La Morinerie
0b49e61ec0 tasks: repair updated_at of dossiers wrongly touched by PJ migration 
When running the PJ migration task, migrated dossiers have their
updated_at attribute modified.

This means a yellow notification badge pops up on the Instructeurs
pages.

This PR repairs the affected dossiers, by restoring an approximative
updated_at from the latest workflow value (or the timestamp of the
migrated champ).
 2019-06-06 11:11:29 +02:00
Pierre de La Morinerie
e0d2a31880
Chat with admin (#3758) 
Intégration de l'API Crisp
 2019-06-05 17:51:27 +02:00
Chaïb Martinez
eccd456325 Add crisp 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-05 17:41:47 +02:00
Pierre de La Morinerie
edbfd4e2b5
Fix default button type (#3925) 
Usager : les bloc répétables ne disparaissent plus lorsqu'on appuie sur la touche Entrée dans un champ
 2019-06-04 18:08:24 +02:00
Paul Chavard
5a216b5583 Fix default button type 
fix #3924
 2019-06-04 17:59:02 +02:00
Pierre de La Morinerie
b8b88201fa
Merge pull request #3908 from betagouv/fix-3899-view-admin-vip 
- Manager : ajout de colonnes "nombre de dossiers par an" et "échéance souhaitée".
 2019-06-04 17:04:51 +02:00
Chaïb Martinez
9198f7f437 Remove useless select options 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-04 16:55:11 +02:00
Chaïb Martinez
3b513af32a Add nb_of_dossiers by years and deadline to PipeDrive Person 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-04 16:55:11 +02:00
Pierre de La Morinerie
3ae6b64994
Wait for ajax (#3920) 
Corrige certains tests automatisés qui échouaient aléatoirement
 2019-06-04 16:38:15 +02:00
Paul Chavard
6d312e1716 spec: refactor wait_for_ajax to work with out new ajax utils 
`wait_for_ajax` is not used anymore, but it may be in the future.
 2019-06-04 16:30:36 +02:00
Paul Chavard
f621bd63e5 spec: fix flaky test by using new wait_until helper 
Fix #3911
 2019-06-04 16:30:36 +02:00
Paul Chavard
cc80939a42 spec: remove tests for old pj (probably) dead code 2019-06-04 16:30:36 +02:00
Pierre de La Morinerie
c2fcc6057e spec: add a wait_until helper 2019-06-04 16:30:36 +02:00
Paul Chavard
e870ba186f spec: add a pause helper 2019-06-04 16:16:53 +02:00
Pierre de La Morinerie
d050b9dc07
Return dossiers on api with stable order (#3921) 
API : l'ordre des dossiers renvoyés dans les résultats paginés est maintenant stable
 2019-06-04 15:44:32 +02:00
Paul Chavard
d5911071f8 Return dossiers on api with stable order 2019-06-04 15:34:49 +02:00
Pierre de La Morinerie
5624b5a997
stylesheets: fix font of dropdown items on Firefox (#3917) 
Correction de l'affichage des menus déroulants dans Firefox
 2019-06-04 11:53:09 +02:00
Pierre de La Morinerie
1f69c6c6eb stylesheets: fix font of dropdown items on Firefox 
Styling `<select>` elements is notoriously hard. Here, it seems that
Firefox doesn't handle custom fonts on `<option>` elements. As we have
no fallback font, the browser uses its default font, Times.

Having fallback fonts is good practice anyway.
 2019-06-04 11:37:40 +02:00
Pierre de La Morinerie
9ec2e4edf6
Améliore la rapidité et la fiabilité des tests d'intégration (#3914) 
Améliore la rapidité et la fiabilité des tests d'intégration
 2019-06-04 11:23:16 +02:00
Pierre de La Morinerie
b829d105d9 brouillon_spec: fix the slow use of have_select(locator, selected: …) 
Capybara's `have_select` can be very slow for elemtns with many options
(see https://github.com/teamcapybara/capybara/issues/1527)

This is because Capybara asserts that no other elements than the
required ones are selected.

This faster version is not as complete, but helps when checking the
countries list or the years in a date picker.
 2019-06-04 11:03:09 +02:00
Pierre de La Morinerie
5419c130f4 brouillon_spec: make the login sequence faster 
Log the user with `login_as` (rather than the browser).
 2019-06-04 11:03:09 +02:00
Paul Chavard
d8ba8d72e0
Merge pull request #3915 from betagouv/disable-map-tiles-during-tests 
carte: disable tiles layer during tests
 2019-06-04 11:00:53 +02:00
Pierre de La Morinerie
f2f16e2580 carte: disable tiles layer during tests 
During integration tests, we don't want to load the tiles from OSM:

- It hits OSM servers during every test run;
- It it slow (Capybara waits for the tiles to be loaded to proceed);
- It makes test time out when tiles cannot be loaded for some reason.

Fix #3913
 2019-06-03 17:24:15 +02:00
Pierre de La Morinerie
c7cde75b53
Merge pull request #3912 from betagouv/improve-specs 
Amélioration de la fiabilité des tests d'acceptance
 2019-06-03 14:07:44 +02:00
Pierre de La Morinerie
a555b24675 specs: precompile Webpack assets before running the specs suite 
This avoids the first feature spec stalling for a few dozens of seconds
because Webpack assets are compiling (and thus reduce the risk of the
spec timing out).

Pre-compilation takes ~ 10s.
 2019-06-03 12:50:59 +02:00
Pierre de La Morinerie
2bd749a325 specs: clear the React champ before adding a new value 
This prevents the value from being
`Nouveau champ TexteLibellé de champ carte`.
 2019-06-03 12:47:03 +02:00
Pierre de La Morinerie
c05dc38b95 specs: remove 'disable-gpu' from chromedriver options 
This option as only ever needed on Windows [1] (which we don't use),
and it shouldn't be required anymore, as the underlying bug has been
fixed [2].

- [1] https://developers.google.com/web/updates/2017/04/headless-chrome
- [2] https://bugs.chromium.org/p/chromium/issues/detail?id=737678
 2019-06-03 12:46:12 +02:00
Pierre de La Morinerie
4feecb0833
Bump fstream from 1.0.11 to 1.0.12 (#3910) 
- Bump de la dépendance indirecte `fstream`
 2019-06-03 10:56:26 +02:00
dependabot[bot]
6393401f37
Bump fstream from 1.0.11 to 1.0.12 
Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12.
- [Release notes](https://github.com/npm/fstream/releases)
- [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12)
 2019-05-31 10:15:16 +00:00
Paul Chavard
db2b531656
Merge pull request #3903 from tchak/purge-pj 
Ajouter la possibilité de supprimer une pj sur les avis
 2019-05-29 16:03:46 +02:00
Paul Chavard
ff44b7a600 Refactor purge pj to be more generic 2019-05-29 15:54:51 +02:00
Pierre de La Morinerie
4013557cd7
Améliorations de robustesse à la tâche de migration des PR (#3904) 
Améliorations de robustesse à la tâche de migration des PR
 2019-05-29 14:56:04 +02:00
Pierre de La Morinerie
a8847e40ea pj migration: add comments and notices 2019-05-29 14:46:49 +02:00
Pierre de La Morinerie
6cb02f2927 pj migration: handle signal interrupts 2019-05-29 14:46:49 +02:00
Pierre de La Morinerie
1a256b37f8 pj migration: print a notice when migrating missing files 2019-05-29 12:20:10 +02:00
Pierre de La Morinerie
a168ae3a72 pj migration: reduce the number of queries by preloading champs 2019-05-29 12:20:10 +02:00
Pierre de La Morinerie
60121a1be6 task_helper: ensure that incrementing above 100% doesn’t raise an error 2019-05-29 12:06:32 +02:00
Pierre de La Morinerie
2bb103b8bd task_helper: mark private methods 2019-05-29 11:48:41 +02:00
Pierre de La Morinerie
4d9cb0bb7a task_helper: fix duration formatting 
If we don't convert the duration to utc, it starts at 01:00:00
 2019-05-29 11:48:21 +02:00
Pierre de La Morinerie
f1875e9c25
Corrections sur la tâche de migration des PJs (#3902) 
Corrections sur la tâche de migration des pièces justificatives
 2019-05-29 11:07:54 +02:00
Pierre de La Morinerie
10df7b70ee carrierwave: when migrating, create an empty blob if file is missing 2019-05-28 18:19:33 +02:00
Pierre de La Morinerie
44c410d40d piece_justificative_service: fix for missing order_place 
In production some pieces justificatives don't have an order place.

In this case, insert the champs after the ones that have an order place.
 2019-05-28 17:20:07 +02:00
Pierre de La Morinerie
c7f2113972 tasks: add a description to make :pieces_justificatives tasks valid 2019-05-28 15:29:59 +02:00
Paul Chavard
a65774b726 Fix job enqueue instruction in README 2019-05-28 12:24:44 +02:00
Pierre de La Morinerie
de22f09ea6
Merge pull request #3883 from betagouv/mark-migrated-pjs-as-scanned 
Migration des pièces-jointes : évite de faire tourner l'antivirus lors de la migration
 2019-05-28 11:58:37 +02:00
Pierre de La Morinerie
d410e31344 active_storage: document the virus scan hooks 2019-05-28 11:39:22 +02:00