Pierre de La Morinerie
4cb747fdb6
specs: always require rails_helper
...
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.
The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.
This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.
Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).
Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.
To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.
Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
Christophe Robillard
cef776ff9e
admin: fix add administrateur to a procedure
2020-02-04 16:21:42 +01:00
Christophe Robillard
055918aabc
admin: replace calls to Administrateur.find_by(email: ...)
2020-02-04 16:21:42 +01:00
Paul Chavard
2f060fc30a
Add depubliee state to procedures
2019-12-04 16:52:41 +01:00
Pierre de La Morinerie
a328e8d94a
features: refactor the editor specs
...
- Add an `add_champ` helper
- Stop relying on a default champ being created
- Wait for all champs to be created by watching the "Add champ" button
This should fix the flakiness of these tests.
Refs #4417
2019-11-27 11:58:46 +01:00
simon lehericey
5643e671a0
Code use user.active?
2019-11-05 14:10:39 +01:00
Pierre de La Morinerie
5be83bd01e
procedure: make the layout more similar to the mockup
2019-10-31 10:27:19 +01:00
simon lehericey
e290fc3674
No need to update column as the sign_up process activates the user
2019-10-24 18:32:48 +02:00
Nicolas Bouilleaud
78da268ded
Improve feature tests for procedure cloning and creation
2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud
fc416ee2ec
Fix procedure_locked_spec
...
`login_as administrateur, scope: :administrateur` doesn’t seem to actually do anything, but testing for the _absence_ of content can’t break.
- Make the test fail if login fails,
- Fix the login,
- Write the opposite test,
- Update the searched content to the actual text used in the partial
2019-09-17 14:50:37 +02:00
simon lehericey
c380d807ab
Spec: sign_in with administrateur.user
2019-08-14 15:08:14 +02:00
simon lehericey
a4b9eecded
Remove unused devise session controller
2019-08-13 14:13:48 +02:00
simon lehericey
f7528f70ac
add admin creation spec
2019-08-12 13:43:03 +02:00
Pierre de La Morinerie
0c4cb3b498
admin: remove UI for managing old pj
2019-07-30 16:11:16 +02:00
clemkeirua
314b0f5dc0
fix tests
2019-07-25 17:15:19 +02:00
Pierre de La Morinerie
7ca3d5fce2
procedure: select for_individual by default
2019-07-10 18:47:34 +02:00
simon lehericey
0f9fdf3f75
Activate device email change confirmation
2019-07-09 11:55:17 +02:00
Paul Chavard
cc80939a42
spec: remove tests for old pj (probably) dead code
2019-06-04 16:30:36 +02:00
Paul Chavard
9725f2a418
Enable new champs editor for all
2019-05-14 16:18:29 +02:00
Paul Chavard
3446782cd0
Remove deprecated editor
2019-05-14 16:18:29 +02:00
Paul Chavard
e2fc9e10b0
Update tests for new editor
2019-04-03 14:38:57 +02:00
Paul Chavard
48701e80bd
Enable flipflop for instructeurs
2019-03-12 12:14:34 +01:00
Mathieu Magnin
44f28ec565
Remove feature flag for publish draft
2019-03-12 11:26:07 +01:00
Paul Chavard
b7058947e1
Fix buttons on screen bottom
2019-02-12 16:22:12 +01:00
Paul Chavard
5da5f75c5f
[Types de Champ Editeur] Save on change and only edited model
2019-02-07 17:05:55 +01:00
Paul Chavard
1d75a32cac
Add a default text type de champ to editor
2019-02-05 16:48:26 +01:00
Paul Chavard
9b7b59f67e
Champs editor should handle repetition type
2019-02-04 11:58:26 +01:00
Mathieu Magnin
0e6b5678ad
Fix tests
2019-01-17 14:04:59 +01:00
Paul Chavard
41c9b21509
Use new editor
2019-01-17 11:20:31 +01:00
simon lehericey
f0139c5962
Spec Factory: an administrateur always has a gestionnaire
2019-01-09 13:49:47 +01:00
Pierre de La Morinerie
2c0108190c
spec: fix specs failing randomly
...
This is because creating a procedure attempts to create an admin from
scratch, and fails to do so.
Broken by 802f2086d6
2019-01-03 17:42:43 +01:00
Chaïb Martinez
802f2086d6
Redirect admins with no démarches to the new demarche page
2018-12-28 18:57:51 +01:00
Frederic Merizen
d1cfe4468d
Encourager la création de champs PJ plutôt que de vieilles PJS
2018-12-19 11:57:23 +01:00
simon lehericey
fb76197404
SessionController: flipflop trusted device
2018-11-13 10:41:45 +01:00
simon lehericey
5690599289
Session: send a mail to confirm gestionnaire login
2018-11-13 10:41:45 +01:00
simon lehericey
2613d05a4f
An admin has always a gestionnaire role
2018-11-13 10:41:45 +01:00
Paul Chavard
f1fd1b38ec
Refactor procedures_controller
2018-10-30 12:01:45 +01:00
simon lehericey
1af789b9a8
Profile: add breadcrumb
2018-09-27 10:14:32 +02:00
simon lehericey
bd04972f65
Profile: move to new design
2018-09-27 10:14:32 +02:00
Paul Chavard
f94a24d7ce
Add path field to procedure information form
2018-09-26 10:53:45 +02:00
gregoirenovel
00ecae5f93
Procédure → Démarche
2018-09-05 15:46:24 +02:00
gregoirenovel
3662b82039
accompagnateur → instructeur
2018-08-29 23:09:08 +02:00
gregoirenovel
2d3b553e4d
Use enum to the fullest with TypeDeChamp.type_champs
2018-08-29 17:31:08 +02:00
Paul Chavard
b57c22cafe
Refactor publish dialog
2018-08-14 16:39:11 +02:00
Pierre de La Morinerie
93ba063612
specs: improve reliability of procedure creation features
...
The 'etape_suivante' button is sometimes not activated, and it could
be because the event handler on the checkbox sometimes doesn't run.
2018-08-07 14:28:52 +02:00
Frederic Merizen
fd10310cbf
[ Fix #1568 ] Use new procedure preview
2018-06-19 12:42:46 +02:00
Frederic Merizen
648483ac76
[ #1946 ] Allow admins to edit data retention time
2018-06-01 16:46:39 +02:00
Frederic Merizen
5325830d62
[ #1946 ] Extract test helper method
2018-06-01 16:46:39 +02:00
simon lehericey
a96889310b
Procedure: add legal reference
2018-05-31 16:55:31 +02:00
simon lehericey
928227a610
Procedure: remove now duplicate organisation and direction
2018-05-18 16:21:27 +02:00
