DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
22892 commits 2 branches 1166 tags 85 MiB
Commit graph

51 commits

Author SHA1 Message Date
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Paul Chavard
9f9243499c
refactor(combobox): fix specs 2024-07-05 09:36:33 +02:00
mfo
d46dc7055d
feat(instructeurs/dossiers): add summary to dossier.champs and dossier.champ_private views, also extract summary in 
two component. one of type de champ editor. one for viewable champs
 2024-06-21 11:06:45 +02:00
Lisa Durand
c6e2e6445c add instructeur feedback on accuse de lecture agreement 2024-04-15 12:10:28 +02:00
mfo
3a895fbd4a
tech(review): add a guard clause to prevent missing pdf, enhance specs 2024-04-02 10:04:22 +02:00
Martin
2944a0c2c3
fix(expert.attestation.url): was pointing to attestation_instructeur_dossier_path, so did not worked when expert was not instructeur. use active_storage_link, secured enough because served to authenticated users as well as expiring link 2024-03-30 06:20:11 +01:00
Martin
9425f2cc58 fix(user.france_connect_informations): has_many, not has_one 2024-03-08 09:44:21 +01:00
Colin Darie
8e6a1c58b2 feat(correction): badge Corrigé when a correction has been resolved 
Closes #9928
 2024-01-24 17:26:34 +01:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction 
Closes #9731
 2023-12-12 15:05:44 +01:00
Colin Darie
fd4a9a6a2f
refactor(instruction): menu repasser en construction + demander une correction 2023-06-02 16:18:32 +02:00
Colin Darie
3c4ea6f8cf
refactor(instructeur): instruction menu as component 2023-06-02 16:18:31 +02:00
Colin Darie
734d88d80d
fix(pending-correction): wording alignement 2023-06-02 16:16:14 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections" 2023-06-02 16:16:12 +02:00
Nicolas Cavigneaux
e483bfbc76
fix: remove hardcoded .html.haml from render calls since it no longer works 2023-05-03 10:10:38 +02:00
Paul Chavard
05cfb4055d fix(dossier): improuve dossier state display 2023-04-19 12:27:16 +02:00
Paul Chavard
207ce21327 fix(dossier): instructeur actions should be buttons and not links 2023-04-07 12:12:15 +02:00
Lisa Durand
3aac56042e fix tests 2023-03-02 16:34:58 +01:00
Lisa Durand
7130ea7e99 fix specs 2023-03-02 16:34:58 +01:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs 
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
 2023-03-02 13:28:23 +00:00
Lisa Durand
07bb27a3af add repasser_en_instruction to dossiers expirants 2023-02-27 17:57:46 +01:00
Lisa Durand
b03748d3dd fix actions rules for archived and expirant dossiers 2023-02-23 17:03:55 +01:00
Lisa Durand
76947a5ccf add mention if user_deleted and move dossier info back to info_generales 2023-02-23 16:05:43 +01:00
Lisa Durand
90a7ecef52 rename state button to instruction button 2023-02-23 16:05:38 +01:00
Lisa Durand
fddcce8b7b fix specs 2023-02-22 18:17:06 +01:00
Colin Darie
8a3bb0c38e fix(instructeurs): combobox layout in "personnes impliquees" tab 
Closes #8527
 2023-02-21 18:20:30 +01:00
Paul Chavard
6e18090fb3 refactor(virus_scan_result): use column instead of metadata on blob 2023-01-04 12:12:11 +01:00
Colin Darie
9b929c86ea
Merge pull request #7760 from betagouv/dsfr-dossier-top-form 
DSFR: convert dossier top form elements
 2022-09-21 16:44:51 +02:00
Colin Darie
39322e6dff feat(instructeurs): warn about acceptation/reject unavailable due to incomplete etablissement 2022-09-21 16:00:59 +02:00
Colin Darie
fcb478eb53 refactor(fc_info): use Dsfr::Notice for france connect informations 2022-09-21 15:47:35 +02:00
Colin Darie
a5e1d8865b style(france_connect_account): convert notice about FC user to DSFR 2022-09-21 15:47:35 +02:00
Martin
f84b69276e fix(expiration_banner.message): miss match when procedure was not expirable ; always showing expiration message 2022-02-11 15:49:37 +01:00
Martin
d8a8d1fdab feat(instructeur/dossier/header/_expiration_banner): split trads and add dedicated expiration banner for instructeur. also enhance wording to include duree conservation + extension_conservation 
feat(expiration_banner): enhance wording of expiration

feat(dossiers/expiration_banner): enhance wording regarding expiration to include duree_conservation_dossiers_dans_ds + extension_conservation, also add spec on expiration_banner for instructeur
 2021-12-06 07:05:17 +01:00
maatinito
cc19453f68 views: fix warning message about incomplete fields for attestation 
The labels for the champs and private champs were inverted.
 2021-03-23 16:56:02 +01:00
Christophe Robillard
c855d13994 rend accessible l'envoi de dossier par un instructeur 
en remplaçant select2 par ComboMultipleDropdownList
 2021-02-16 16:47:14 +01:00
kara Diaby
00b5ad7a10 EQT instructeur, je peux supprimer un dossier terminé 2020-12-16 15:00:26 +01:00
kara Diaby
c033ef0910 Ajoute a l'information de connexion France Connect dans les informations du dossier ainsi que sur la demande usager 2020-11-05 19:30:13 +01:00
kara Diaby
4b2e3b5be7 Revert "Merge pull request #5710 from betagouv/revert-5705-feat/5701" 
This reverts commit aae77c77b0, reversing
changes made to 4c2c5c630c.
 2020-11-05 19:30:13 +01:00
Kara Diaby
f78e0ced3a
Revert "feat 5701 - Ajoute l'information lorsqu'un usager s'authentifie via France Connect" 2020-10-30 18:28:08 +01:00
kara Diaby
e6c1a20329 Ajoute l'information lorsqu'un usager s'authentifie via France Connect 2020-10-30 17:28:54 +01:00
Pierre de La Morinerie
4cb747fdb6 specs: always require rails_helper 
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
 2020-03-31 12:48:32 +02:00
Paul Chavard
c6326bfa77 Fix tests involving attachment urls 2020-01-08 14:46:18 +01:00
Pierre de La Morinerie
db0fede521 views: improve the state button 
- Turn the "accepted" infos into standard dropdown sections
- Display the justificatif even if there is no motivation
 2019-10-15 12:48:14 +02:00
Pierre de La Morinerie
dd57953b76 views: refactor the state button 
Now that all states have a dropdown, we can simplify the code.

This also brings the "Repasser en instruction" action for all states
(including when no attestation or motivation is present).
 2019-10-15 12:48:14 +02:00
Pierre de La Morinerie
07f75ff20e views: fix missing attestation link 
- Fix the missing link to see attestations (see #4400)
- Fix the "Repasser en instruction" wording being confusing for
  accepted state
- Add lot of tests
 2019-10-15 12:48:14 +02:00
Pierre de La Morinerie
0e5f66c5ba views: make the "Voir l'attestation" UI simpler 
Instead of adding a button, just turn the "attestation" text into a link
 2019-10-15 12:41:37 +02:00
Pierre de La Morinerie
0064c2c610 views: tell an attestation will be sent only if it is true 
Previously the message stating "an attestation will be sent" was
displayed even when the attestation was disabled.
 2019-10-15 12:41:37 +02:00
simon lehericey
ad31822a68 Spec: sign_in with instructeur.user 2019-08-13 15:15:16 +02:00
simon lehericey
0d71a820a8 Stub instructeur devise methods in spec 2019-08-13 15:15:16 +02:00
simon lehericey
3fde2a6f70 Rename gestionnaire in code to instructeur 2019-08-12 13:47:01 +02:00