Commit graph

23107 commits

Author SHA1 Message Date
mfo
8a42c6a7ad
Merge pull request #10708 from mfo/US/format-rna
ETQ tech je souhaite que les champs RNA ne puissent pas contenir d'espace sans quoi nos appels d'API remontent un URI::InvalidURIError
2024-08-22 08:36:38 +00:00
mfo
76f9373af5
fix(RNA.pattern): allows RNA with letters too, some territories can have letters too 2024-08-22 10:24:03 +02:00
mfo
53cbb1cace
fix(PopulateRnaJsonValue): some procedure had been deleted, can not find them 2024-08-22 10:24:03 +02:00
mfo
22e50d4c9e
fix(data): normalize invalid Champs::RNAChamp.values in db 2024-08-22 10:24:03 +02:00
mfo
abb2fa159c
feat(Champ.rna): avoid spaces that breaks API calls 2024-08-22 10:23:56 +02:00
Colin Darie
bd4c31684d
Merge pull request #10386 from colinux/frozen-strings
Tech(perf): frozen string literals partout
2024-08-22 07:51:39 +00:00
mfo
7182a4e8d0
feat(identite_entreprise): prefer champ.value_json in order to ensure good department 2024-08-22 09:45:27 +02:00
mfo
fdff699d51
feat(champ.rnf/rna/siret): render normalized address the same way 2024-08-22 09:45:27 +02:00
Colin Darie
ebdc91f7ed
test(coverage): group manager controllers 2024-08-22 09:26:49 +02:00
Colin Darie
2b9fe12079
test(dolist): add some specs and remove unsupported email sent with attachments 2024-08-22 09:26:49 +02:00
Colin Darie
3c3bc4a657
chore(coverage): ignore deployment rake tasks 2024-08-22 09:26:49 +02:00
Colin Darie
659d35e11f
test: fix for mutable string 2024-08-22 09:26:49 +02:00
Colin Darie
6d9a7648e2
fix(test): disable frozen string in siret concern because it's a literal string in spec 2024-08-22 09:26:49 +02:00
Colin Darie
992c61b51a
fix: as of parsby 1.1, IO can be mutated during parsing
See 534f8a95b4/lib/parsby.rb (L572C11-L572C17)

Trace:
IOError: not modifiable string
    # parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
    # parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
    # parsby-1.1.1/lib/parsby.rb:539:in `block in restore'
    # parsby-1.1.1/lib/parsby.rb:539:in `each'
2024-08-22 09:26:48 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Colin Darie
edeb9a46ec
fix(rubocop): better perf in local 2024-08-22 09:26:16 +02:00
Colin Darie
3796210928
Merge pull request #10707 from colinux/fix-unpublished-changes-button
ETQ admin: corrige le nouveau bouton de publication d'une démarche
2024-08-21 15:48:45 +00:00
Colin Darie
4c1e67bd65
Merge pull request #10704 from mfo/US/fix-populate-rna-maintenance-task
Correctif: tache de maintenance des données RNA pour permettre la recherche
2024-08-21 15:45:18 +00:00
Colin Darie
eccfde848f
feat(admin): disable publish button when there are errors 2024-08-21 17:38:07 +02:00
Colin Darie
d0837c58f5
fix(admin): publish modifications button must be PUT 2024-08-21 17:38:07 +02:00
Colin Darie
6efd9ae747
refactor(admin): rename procedures/_unpublished_changes_{navbar,sticky} partial 2024-08-21 17:38:04 +02:00
mfo
0ed5206d9f
fix(PopulateRNAJSONValueTask): edge case, one champ raises an URI::InvalidURIError 2024-08-21 16:36:22 +02:00
Lisa Durand
3cf3dc4623
make email confirmation more generic 2024-08-21 16:23:56 +02:00
Lisa Durand
ea354d46c4
Create new invitation email if expert not confirm 2024-08-21 16:19:51 +02:00
Kara Diaby
9ed2de9bb7
Merge pull request #10702 from demarches-simplifiees/feat/10208
ETQ Admin je suis prévenu que ma modification de formulaire aura besoin d'être publiée
2024-08-21 10:53:46 +00:00
Kara Diaby
4a93579e71
Ajoute une sticky navbar si il y a une modification de démarche déjà publiée 2024-08-21 10:23:02 +00:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
Paul Chavard
1d15689989
Merge pull request #10701 from tchak/refactor-virtual-displayable
refactor(columns): rename virtual to displayable
2024-08-21 09:37:51 +00:00
mfo
42b9ac1737
spec(filter): with rna enum 2024-08-21 10:23:56 +02:00
mfo
575c4cbdff
clean(spec): procedure_filters_spec.rb, less tdc by default 2024-08-21 10:23:56 +02:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Colin Darie
c1f4bd0ba3
Merge pull request #10700 from colinux/fix-persisting-pp-error
ETQ instructeur, n'affiche pas 2 fois le message de réinitialisation du tableau de dossiers
2024-08-21 07:23:15 +00:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable 2024-08-20 18:46:19 +02:00
Colin Darie
8c6a7a8528
fix(instructeur): don't display twice pp error on get requests 2024-08-20 18:30:20 +02:00
Colin Darie
8cdd7ef4df
Merge pull request #10699 from mfo/US/hotfix-pp
Correctif: rattrape les données inconsistantes pour la présentation des tableaux instructeurs qui se font detruire a la 1ere connection
2024-08-20 16:16:26 +00:00
Colin Darie
6b9af51e31
Merge pull request #10698 from colinux/fix-strftime-on-non-numeric-field
ETQ instructeur, ne plante pas en essayant de formater une date quand c'est pas une date
2024-08-20 15:59:02 +00:00
mfo
3662e38366
hotfix(ProcedurePresentation): backfill invalid procedure presentation private tabel name for type de champs private 2024-08-20 17:58:55 +02:00
Colin Darie
fe2e8ae793
fix(instructeur): never try to strftime on non date value 2024-08-20 17:33:04 +02:00
Colin Darie
6b6cf091e0
Merge pull request #10697 from colinux/fix-row-deleted-dossier
ETQ instructeur, corrige l'affichage expliquant la raison pour laquelle l'usager a supprimé (ou expiré) un dossier
2024-08-20 15:20:39 +00:00
Lisa Durand
49e9d4a683
Merge pull request #10627 from demarches-simplifiees/simplify-tabs-supprimes-ldu
[UX] Simplifier l'interface avec un onglet unique pour les dossiers supprimés
2024-08-20 14:50:42 +00:00
Colin Darie
b2931a9dde
fix(instructeur): dossier hidden by user reason interpolation 2024-08-20 16:15:13 +02:00
Colin Darie
f50d4948e4
Merge pull request #10696 from colinux/fix-xss-galery
Sécurité: évite une injection XSS par le nom des PJ qui trompait les navigateurs
2024-08-20 14:06:19 +00:00
Colin Darie
87cc8a7241
fix(dossier): render PJ champ respects profile context 2024-08-20 15:52:30 +02:00
Colin Darie
e6c2926426
fix(xss): injection from pj malicious filename would trick browser and lead to XSS injection 2024-08-20 15:51:54 +02:00
Lisa Durand
16864cc868
fix test 2024-08-20 15:47:09 +02:00
Paul Chavard
686000d6cb
fix spec 2024-08-20 15:26:15 +02:00
Lisa Durand
286758e933
create component to display deleted dossiers 2024-08-20 15:26:15 +02:00
Lisa Durand
5281ab966a
add deleted dossiers in menu for instructeurs 2024-08-20 15:26:15 +02:00
Lisa Durand
066a2bea85
use main navigation to display deleted dossier for user 2024-08-20 15:26:14 +02:00
Lisa Durand
95a8f1458b
fix specs 2024-08-20 15:26:14 +02:00