add feature flag
This commit is contained in:
parent
acd874ccdf
commit
ff2e9f0816
4 changed files with 45 additions and 16 deletions
|
@ -56,6 +56,7 @@ class TypesDeChampEditor::ChampComponent < ApplicationComponent
|
|||
end
|
||||
|
||||
def types_of_type_de_champ
|
||||
if Flipper.enabled?(:categories_type_de_champ, controller.current_user)
|
||||
cat_scope = "activerecord.attributes.type_de_champ.categorie"
|
||||
tdc_scope = "activerecord.attributes.type_de_champ.type_champs"
|
||||
|
||||
|
@ -72,6 +73,15 @@ class TypesDeChampEditor::ChampComponent < ApplicationComponent
|
|||
tdc.map { [t(_1, scope: tdc_scope), _1] }
|
||||
]
|
||||
end
|
||||
else
|
||||
TypeDeChamp.type_champs
|
||||
.keys
|
||||
.filter(&method(:filter_type_champ))
|
||||
.filter(&method(:filter_featured_type_champ))
|
||||
.filter(&method(:filter_block_type_champ))
|
||||
.map { |type_champ| [t("activerecord.attributes.type_de_champ.type_champs.#{type_champ}"), type_champ] }
|
||||
.sort_by(&:first)
|
||||
end
|
||||
end
|
||||
|
||||
def piece_justificative_options(form)
|
||||
|
|
|
@ -19,7 +19,10 @@
|
|||
%span.sr-only Déplacer le champ vers le bas
|
||||
.cell.flex.justify-start.column.flex-grow
|
||||
= form.label :type_champ, "Type de champ", for: dom_id(type_de_champ, :type_champ)
|
||||
- if Flipper.enabled?(:categories_type_de_champ, controller.current_user)
|
||||
= form.select :type_champ, grouped_options_for_select(types_of_type_de_champ, type_de_champ.type_champ), {}, class: 'small-margin small inline width-100', id: dom_id(type_de_champ, :type_champ)
|
||||
- else
|
||||
= form.select :type_champ, types_of_type_de_champ, {}, class: 'small-margin small inline width-100', id: dom_id(type_de_champ, :type_champ)
|
||||
.flex.column.justify-start.flex-grow
|
||||
.cell
|
||||
.flex.align-center
|
||||
|
|
|
@ -21,6 +21,7 @@ end
|
|||
features = [
|
||||
:administrateur_web_hook,
|
||||
:api_particulier,
|
||||
:categories_type_de_champ,
|
||||
:dossier_pdf_vide,
|
||||
:expert_not_allowed_to_invite,
|
||||
:hide_instructeur_email,
|
||||
|
|
|
@ -69,4 +69,19 @@ describe 'Creating a new procedure', js: true do
|
|||
expect(champs_card).to have_content('À modifier')
|
||||
end
|
||||
end
|
||||
|
||||
context 'with feature activated' do
|
||||
let(:procedure) { create(:procedure, :with_service, administrateur: administrateur) }
|
||||
before { Flipper.enable(:categories_type_de_champ, administrateur.user) }
|
||||
after { Flipper.disable(:categories_type_de_champ, administrateur.user) }
|
||||
|
||||
it 'types de champ are grouped by categories ' do
|
||||
visit champs_admin_procedure_path(procedure)
|
||||
|
||||
add_champ(remove_flash_message: true)
|
||||
select('Bloc répétable', from: 'Type de champ')
|
||||
|
||||
expect(page).to have_selector('select > optgroup', count: 7)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue